Fokko merged PR #130:
URL: https://github.com/apache/iceberg-rust/pull/130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
Xuanwo commented on PR #130:
URL: https://github.com/apache/iceberg-rust/pull/130#issuecomment-1868673496
Thanks a lot, @bitsondatadev!
---
@Fokko, what else needs to be done for this PR to be merged?
--
This is an automated message from the Apache Git Service.
To respond to
bitsondatadev commented on PR #130:
URL: https://github.com/apache/iceberg-rust/pull/130#issuecomment-1867938398
Thank you all for being so considerate and willing to move outside of Rust.
When I first replied yesterday I only saw not using our unified framework as a
hindrence to update doc
Xuanwo commented on PR #130:
URL: https://github.com/apache/iceberg-rust/pull/130#issuecomment-1867378787
> You have to publish to the `gh-pages` branch and add a [`CNAME`
file](https://github.com/apache/iceberg-python/blob/gh-pages/CNAME) to let the
Apache DNS know what the domain name is.
Fokko commented on PR #130:
URL: https://github.com/apache/iceberg-rust/pull/130#issuecomment-1867375634
Thinking more of it, and looking at other projects, both
[Avro](https://docs.rs/apache-avro/latest/apache_avro/) and
[Arrow](https://docs.rs/arrow/latest/arrow/) use the `docs.rs` websit
liurenjie1024 commented on PR #130:
URL: https://github.com/apache/iceberg-rust/pull/130#issuecomment-1867168892
> I'm open to switching to MkDocs or any other framework that Iceberg uses.
I agree that using the same tools makes it easier to maintain the docs,
especially since Iceberg has s
Xuanwo commented on PR #130:
URL: https://github.com/apache/iceberg-rust/pull/130#issuecomment-1867122015
Hi, @bitsondatadev, thanks a lot for your effort of maintaining docs. I can
imagine that coordinating such a huge amount of work is challenging.
I'm open to switching to MkDocs or
bitsondatadev commented on PR #130:
URL: https://github.com/apache/iceberg-rust/pull/130#issuecomment-1866709687
Okay, so to avoid any delays or concern here, I don't want you all to stop
with writing documentation because you're not sure how this will fall inline
with the other docs.
bitsondatadev commented on PR #130:
URL: https://github.com/apache/iceberg-rust/pull/130#issuecomment-1866632260
Update
After having a meeting with Fokko and him showing me the [Arrow site
documentation](https://arrow.apache.org/docs/) I am not totally opposed to the
idea despite my
bitsondatadev commented on PR #130:
URL: https://github.com/apache/iceberg-rust/pull/130#issuecomment-1866527007
> mdbook is widely used in rust community to build a docs site
While I can respect this, it is larger than just a Rust project, and we've
had [ongoing](https://lists.apache
Fokko commented on PR #130:
URL: https://github.com/apache/iceberg-rust/pull/130#issuecomment-1866188024
@bitsondatadev WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Xuanwo commented on PR #130:
URL: https://github.com/apache/iceberg-rust/pull/130#issuecomment-1866067912
> This is why I mentioned mkdocs earlier in the issue. Is there a specific
reason to go with `mdbook`?
mdbook is widely used in rust community to build a docs site. It's easy to
Fokko commented on PR #130:
URL: https://github.com/apache/iceberg-rust/pull/130#issuecomment-1866062987
There is an effort going on to centralize everything at some point:
https://github.com/apache/iceberg/pull/8919 We noticed in practice that many
people don't find PyIceberg because it is
Xuanwo commented on code in PR #130:
URL: https://github.com/apache/iceberg-rust/pull/130#discussion_r1433758237
##
website/book.toml:
##
Review Comment:
added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
liurenjie1024 commented on code in PR #130:
URL: https://github.com/apache/iceberg-rust/pull/130#discussion_r1433366580
##
website/book.toml:
##
Review Comment:
It would be better to have a `README.md` so that we can know how to generate
the book in local environment for p
Xuanwo commented on PR #130:
URL: https://github.com/apache/iceberg-rust/pull/130#issuecomment-1864176028
JIRA ticket to enable the action has been submitted:
https://issues.apache.org/jira/browse/INFRA-25298
--
This is an automated message from the Apache Git Service.
To respond to the m
Xuanwo opened a new pull request, #130:
URL: https://github.com/apache/iceberg-rust/pull/130
This PR will add mdbook as a start for our website.
Our workflow will commit the built content to `gh-pages`, and `asf.yml` will
deploy to `rust.i.a.o`.
# Show Time
