Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-26 Thread via GitHub
Fokko merged PR #132: URL: https://github.com/apache/iceberg-rust/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-26 Thread via GitHub
Fokko commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1436335985 ## crates/iceberg/src/expr/mod.rs: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-25 Thread via GitHub
amogh-jahagirdar commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1436109732 ## crates/iceberg/src/expr/mod.rs: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreem

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-25 Thread via GitHub
liurenjie1024 commented on PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#issuecomment-1868978725 I did a refactoring to make it more similar models used in java/python. cc @ZENOTME @Fokko @Xuanwo @amogh-jahagirdar PTAL -- This is an automated message from the Apache Git S

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-24 Thread via GitHub
liurenjie1024 commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1435986885 ## crates/iceberg/src/expr/unbound.rs: ## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-24 Thread via GitHub
liurenjie1024 commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1435986733 ## crates/iceberg/src/expr/mod.rs: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreement

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-24 Thread via GitHub
liurenjie1024 commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1435986624 ## crates/iceberg/src/expr/mod.rs: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreement

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-24 Thread via GitHub
liurenjie1024 commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1435983199 ## crates/iceberg/src/expr/bound.rs: ## @@ -0,0 +1,41 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreeme

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-24 Thread via GitHub
liurenjie1024 commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1435982647 ## crates/iceberg/src/expr/mod.rs: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreement

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-24 Thread via GitHub
amogh-jahagirdar commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1435850488 ## crates/iceberg/src/expr/mod.rs: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreem

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-22 Thread via GitHub
Fokko commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1434871605 ## crates/iceberg/src/expr/mod.rs: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-21 Thread via GitHub
liurenjie1024 commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1434689405 ## crates/iceberg/src/expr/bound.rs: ## @@ -0,0 +1,41 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreeme

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-21 Thread via GitHub
liurenjie1024 commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1434689231 ## crates/iceberg/src/expr/mod.rs: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreement

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-21 Thread via GitHub
liurenjie1024 commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1434685440 ## crates/iceberg/src/expr/bound.rs: ## @@ -0,0 +1,41 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreeme

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-21 Thread via GitHub
liurenjie1024 commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1434685237 ## crates/iceberg/src/expr/mod.rs: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreement

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-21 Thread via GitHub
liurenjie1024 commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1434681128 ## crates/iceberg/src/expr/bound.rs: ## @@ -0,0 +1,41 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreeme

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-21 Thread via GitHub
Fokko commented on code in PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#discussion_r1434045494 ## crates/iceberg/src/expr/bound.rs: ## @@ -0,0 +1,41 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. Se

Re: [PR] feat: Expression system. [iceberg-rust]

2023-12-21 Thread via GitHub
liurenjie1024 commented on PR #132: URL: https://github.com/apache/iceberg-rust/pull/132#issuecomment-1865842080 cc @Xuanwo @Fokko @ZENOTME PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] feat: Expression system. [iceberg-rust]

2023-12-21 Thread via GitHub
liurenjie1024 opened a new pull request, #132: URL: https://github.com/apache/iceberg-rust/pull/132 Close #22. This pr introduce definition of expression used in iceberg. Expression operations such as binding, evaluation will come in following pr. -- This is an automated message fr