callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1740065220
##
crates/catalog/sql/src/catalog.rs:
##
@@ -141,21 +142,30 @@ impl SqlCatalog {
}
/// SQLX Any does not implement PostgresSQL bindings, so we have t
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1740062315
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,312 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
liurenjie1024 commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1731193964
##
crates/catalog/sql/src/catalog.rs:
##
@@ -141,21 +142,30 @@ impl SqlCatalog {
}
/// SQLX Any does not implement PostgresSQL bindings, so we have
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1731169469
##
crates/catalog/sql/src/catalog.rs:
##
@@ -141,21 +142,30 @@ impl SqlCatalog {
}
/// SQLX Any does not implement PostgresSQL bindings, so we have t
liurenjie1024 commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1730525891
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,312 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+///
liurenjie1024 commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1730514726
##
crates/catalog/sql/src/catalog.rs:
##
@@ -141,21 +142,30 @@ impl SqlCatalog {
}
/// SQLX Any does not implement PostgresSQL bindings, so we have
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1730004295
##
crates/catalog/sql/src/catalog.rs:
##
@@ -276,4 +579,385 @@ mod tests {
new_sql_catalog(warehouse_loc.clone()).await;
new_sql_catalog(wareho
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1730004206
##
crates/catalog/sql/src/catalog.rs:
##
@@ -141,21 +142,30 @@ impl SqlCatalog {
}
/// SQLX Any does not implement PostgresSQL bindings, so we have t
sdd commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1725609116
##
crates/catalog/sql/src/catalog.rs:
##
@@ -276,4 +579,385 @@ mod tests {
new_sql_catalog(warehouse_loc.clone()).await;
new_sql_catalog(warehouse_loc.
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1725559714
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,312 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1725539258
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,312 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1725537409
##
crates/catalog/sql/src/catalog.rs:
##
@@ -276,4 +579,385 @@ mod tests {
new_sql_catalog(warehouse_loc.clone()).await;
new_sql_catalog(wareho
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1725535153
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,312 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1725533714
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,312 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1725530833
##
crates/catalog/sql/src/catalog.rs:
##
@@ -141,21 +142,30 @@ impl SqlCatalog {
}
/// SQLX Any does not implement PostgresSQL bindings, so we have t
liurenjie1024 commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1725114189
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,312 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+///
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1722260283
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,335 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1722175695
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,335 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1722173257
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,335 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1722169292
##
crates/catalog/sql/src/catalog.rs:
##
@@ -141,21 +142,30 @@ impl SqlCatalog {
}
/// SQLX Any does not implement PostgresSQL bindings, so we have t
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1722170737
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,335 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1722169865
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,335 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1720765041
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,335 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1720764099
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,335 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1720764034
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,335 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
liurenjie1024 commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1720598113
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,335 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+///
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1715744495
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,344 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1715743769
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,344 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
sdd commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1714292148
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,344 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Execute st
sdd commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1714279852
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,344 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Execute st
sdd commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1714277890
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,344 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Execute st
sdd commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1714265481
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,344 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Execute st
sdd commented on PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#issuecomment-2284722772
I'm also ok with this being SQL rather than Diesel. Diesel feels like a
large dependency to bring in for a small number of quite straightforward
queries.
--
This is an automated message
callum-ryan commented on PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#issuecomment-2284572219
> Hi, I need more time to review the SQL individually. Here are some
additional comments that I believe should take priority.
>
> By the way, have you considered using `diese
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1714153827
##
crates/catalog/sql/src/catalog.rs:
##
@@ -141,21 +142,24 @@ impl SqlCatalog {
}
/// SQLX Any does not implement PostgresSQL bindings, so we have t
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1714153256
##
crates/catalog/sql/src/catalog.rs:
##
@@ -141,21 +142,24 @@ impl SqlCatalog {
}
/// SQLX Any does not implement PostgresSQL bindings, so we have t
Xuanwo commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1713021439
##
crates/catalog/sql/src/catalog.rs:
##
@@ -141,21 +142,24 @@ impl SqlCatalog {
}
/// SQLX Any does not implement PostgresSQL bindings, so we have to do
callum-ryan opened a new pull request, #534:
URL: https://github.com/apache/iceberg-rust/pull/534
Carrying on from [PR #524
](https://github.com/apache/iceberg-rust/pull/524), this is the implementation
of the namespace functionality
--
This is an automated message from the Apache Git Se
38 matches
Mail list logo
