liurenjie1024 merged PR #233:
URL: https://github.com/apache/iceberg-rust/pull/233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
liurenjie1024 commented on code in PR #233:
URL: https://github.com/apache/iceberg-rust/pull/233#discussion_r1665146620
##
crates/iceberg/Cargo.toml:
##
@@ -82,3 +86,4 @@ iceberg_test_utils = { path = "../test_utils", features =
["tests"] }
pretty_assertions = { workspace = tr
Xuanwo commented on PR #233:
URL: https://github.com/apache/iceberg-rust/pull/233#issuecomment-2197860098
> Thanks @odysa , generally it LGTM. But I think we should resolve #418
first to unblock this.
Got it. I will work on #418 first.
--
This is an automated message from the Apach
liurenjie1024 commented on code in PR #233:
URL: https://github.com/apache/iceberg-rust/pull/233#discussion_r1650082866
##
Cargo.toml:
##
@@ -16,7 +16,6 @@
# under the License.
[workspace]
-resolver = "2"
Review Comment:
Why remove this?
##
crates/iceberg/src/
liurenjie1024 commented on PR #233:
URL: https://github.com/apache/iceberg-rust/pull/233#issuecomment-2184992611
> Made code change. Now tokio is always a dependency since traits like
`AsyncWrite` are used. Do you have any plan for them? I made `tokio` a default
feature to avoid breaking ch
