liurenjie1024 commented on code in PR #577:
URL: https://github.com/apache/iceberg-rust/pull/577#discussion_r1743392719
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -301,12 +302,7 @@ impl TableMetadataBuilder {
} = table_creation;
let partition_specs =
liurenjie1024 commented on PR #577:
URL: https://github.com/apache/iceberg-rust/pull/577#issuecomment-2328362065
> > Thanks @FANNG1 for this pr. However I think there are some prepartion
work before we can actually finished this pr. If we can narrow down the goal of
this pr to change type f
FANNG1 commented on PR #577:
URL: https://github.com/apache/iceberg-rust/pull/577#issuecomment-2324436354
> Thanks @FANNG1 for this pr. However I think there are some prepartion work
before we can actually finished this pr. If we can narrow down the goal of this
pr to change type for `Unbou
FANNG1 commented on code in PR #577:
URL: https://github.com/apache/iceberg-rust/pull/577#discussion_r1740693686
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -301,12 +302,7 @@ impl TableMetadataBuilder {
} = table_creation;
let partition_specs = match
FANNG1 commented on code in PR #577:
URL: https://github.com/apache/iceberg-rust/pull/577#discussion_r1740691810
##
crates/iceberg/tests/partition_table_test.rs:
##
@@ -0,0 +1,97 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag
liurenjie1024 commented on code in PR #577:
URL: https://github.com/apache/iceberg-rust/pull/577#discussion_r1740498084
##
crates/iceberg/tests/partition_table_test.rs:
##
@@ -0,0 +1,97 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
liurenjie1024 commented on PR #577:
URL: https://github.com/apache/iceberg-rust/pull/577#issuecomment-2323659302
The reason we use `PartitionSpec` was that some fields, such as spec id,
partition field id should not be passed by user when creating a table. But I
think you are right when a
FANNG1 commented on PR #577:
URL: https://github.com/apache/iceberg-rust/pull/577#issuecomment-2320796097
> Hi, @FANNG1 Thanks for your contribution. The reason why we use
`UnboundPartitionSpec` rather `PartitionSpec` is to simplify the usage of this
method. `PartitionSpec` is bound to a sc
liurenjie1024 commented on PR #577:
URL: https://github.com/apache/iceberg-rust/pull/577#issuecomment-2319725641
Hi, @FANNG1 Thanks for your contribution. The reason why we use
`UnboundPartitionSpec` rather `PartitionSpec` is to simplify the usage of this
method. `PartitionSpec` is bound to
