xxchan commented on code in PR #383:
URL: https://github.com/apache/iceberg-rust/pull/383#discussion_r1751316492
##
crates/iceberg/src/arrow/schema.rs:
##
@@ -35,6 +35,9 @@ use rust_decimal::prelude::ToPrimitive;
use std::collections::HashMap;
use std::sync::Arc;
+/// When i
ZENOTME commented on code in PR #383:
URL: https://github.com/apache/iceberg-rust/pull/383#discussion_r1650093045
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -188,10 +496,10 @@ impl ParquetWriter {
.column_sizes(column_sizes)
.valu
ZENOTME commented on code in PR #383:
URL: https://github.com/apache/iceberg-rust/pull/383#discussion_r1650093045
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -188,10 +496,10 @@ impl ParquetWriter {
.column_sizes(column_sizes)
.valu
ZENOTME commented on code in PR #383:
URL: https://github.com/apache/iceberg-rust/pull/383#discussion_r1650086826
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -78,106 +89,403 @@ impl
FileWriterBuilder for ParquetWr
type R = ParquetWriter;
async
ZENOTME commented on code in PR #383:
URL: https://github.com/apache/iceberg-rust/pull/383#discussion_r1650086826
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -78,106 +89,403 @@ impl
FileWriterBuilder for ParquetWr
type R = ParquetWriter;
async
ZENOTME commented on PR #383:
URL: https://github.com/apache/iceberg-rust/pull/383#issuecomment-2157957733
Thanks for your review! I have refined the code, please let me know if there
is something that still can be improved. @sdd
--
This is an automated message from the Apache Git Servic
ZENOTME commented on code in PR #383:
URL: https://github.com/apache/iceberg-rust/pull/383#discussion_r1633012703
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -78,106 +89,407 @@ impl
FileWriterBuilder for ParquetWr
type R = ParquetWriter;
async
sdd commented on code in PR #383:
URL: https://github.com/apache/iceberg-rust/pull/383#discussion_r1630753095
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -78,106 +89,407 @@ impl
FileWriterBuilder for ParquetWr
type R = ParquetWriter;
async fn b
sdd commented on code in PR #383:
URL: https://github.com/apache/iceberg-rust/pull/383#discussion_r1630738655
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -78,106 +89,407 @@ impl
FileWriterBuilder for ParquetWr
type R = ParquetWriter;
async fn b
sdd commented on code in PR #383:
URL: https://github.com/apache/iceberg-rust/pull/383#discussion_r1630721046
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -78,106 +89,407 @@ impl
FileWriterBuilder for ParquetWr
type R = ParquetWriter;
async fn b
sdd commented on code in PR #383:
URL: https://github.com/apache/iceberg-rust/pull/383#discussion_r1630709857
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -78,106 +89,407 @@ impl
FileWriterBuilder for ParquetWr
type R = ParquetWriter;
async fn b
sdd commented on code in PR #383:
URL: https://github.com/apache/iceberg-rust/pull/383#discussion_r1630700456
##
crates/iceberg/src/writer/base_writer/data_file_writer.rs:
##
@@ -123,195 +126,35 @@ mod test {
location_generator::{test::MockLocationGenerator,
De
ZENOTME commented on PR #383:
URL: https://github.com/apache/iceberg-rust/pull/383#issuecomment-2137745265
This PR is blocked by #386 now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
ZENOTME commented on PR #383:
URL: https://github.com/apache/iceberg-rust/pull/383#issuecomment-2134271741
cc @Fokko @liurenjie1024 @Xuanwo @sdd @marvinlanhenke
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
14 matches
Mail list logo
