Re: [PR] feat: support projection pushdown for datafusion iceberg [iceberg-rust]

2024-09-12 Thread via GitHub
liurenjie1024 merged PR #594: URL: https://github.com/apache/iceberg-rust/pull/594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] feat: support projection pushdown for datafusion iceberg [iceberg-rust]

2024-09-05 Thread via GitHub
FANNG1 commented on PR #594: URL: https://github.com/apache/iceberg-rust/pull/594#issuecomment-2331731075 @liurenjie1024 , all comments are addressed, please help to review again, thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] feat: support projection pushdown for datafusion iceberg [iceberg-rust]

2024-09-05 Thread via GitHub
FANNG1 commented on code in PR #594: URL: https://github.com/apache/iceberg-rust/pull/594#discussion_r1745529020 ## crates/integrations/datafusion/src/physical_plan/scan.rs: ## @@ -138,3 +156,18 @@ async fn get_batch_stream( Ok(Box::pin(stream)) } + +fn get_column_names(

Re: [PR] feat: support projection pushdown for datafusion iceberg [iceberg-rust]

2024-09-04 Thread via GitHub
liurenjie1024 commented on code in PR #594: URL: https://github.com/apache/iceberg-rust/pull/594#discussion_r1743337943 ## crates/integrations/datafusion/src/physical_plan/scan.rs: ## @@ -138,3 +156,18 @@ async fn get_batch_stream( Ok(Box::pin(stream)) } + +fn get_column

Re: [PR] feat: support projection pushdown for datafusion iceberg [iceberg-rust]

2024-09-01 Thread via GitHub
FANNG1 commented on code in PR #594: URL: https://github.com/apache/iceberg-rust/pull/594#discussion_r1740085143 ## crates/examples/src/datafusion_read_data.rs: ## @@ -0,0 +1,37 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agr