ZENOTME commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-2071290816
close by https://github.com/apache/iceberg-rust/pull/275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
ZENOTME closed pull request #135: init writer framework
URL: https://github.com/apache/iceberg-rust/pull/135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
ZENOTME commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1905338963
> > This may make this interface easier to make sense.
>
> The real code could be like:
>
> ```rust
> let writer = FileWriterHelper::new(builder_a)
> .lay
Xuanwo commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1905335724
> This may make this interface easier to make sense.
The real code could be like:
```rust
let writer = FileWriterHelper::new(builder_a)
.layer(builder_b)
ZENOTME commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1905325893
I found a new way to make this API can be used like the following:
```
let writer = FileWriterHelper::new(MockFileWriterBuilder)
// build the file writer first
liurenjie1024 commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1898308549
Let's mark this pr as draft? cc @ZENOTME
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
liurenjie1024 commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1895352135
> And we can work on the FileWriter part first if it looks good. How do you
think? @Xuanwo @Fokko
+1
--
This is an automated message from the Apache Git Service.
To resp
Xuanwo commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1895313954
> And we can work on the `FileWriter` part first if it looks good. How do
you think? @Xuanwo @Fokko
LGTM! It's good to merge things in small chunks and polish them during the
rea
ZENOTME commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1895304460
I feel that for this writer framework, we may need more discussion, so I can
separate this framework as `IcebergWriter` and `FileWriter` parts.
The `IcebergWriter` part is about how
Xuanwo commented on code in PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#discussion_r1454796676
##
crates/iceberg/src/writer/file_writer/mod.rs:
##
@@ -0,0 +1,41 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license ag
liurenjie1024 commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1895000380
cc @Fokko @Xuanwo PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
ZENOTME commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1894915527
> > > This design is kind of too complicated for me. I still prefer the
approach we used in icelake, and don't overuse too much traits for just saving
code.
> >
> >
> > Actu
liurenjie1024 commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1894895024
> > This design is kind of too complicated for me. I still prefer the
approach we used in icelake, and don't overuse too much traits for just saving
code.
>
> Actually, th
ZENOTME commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1894877728
> This design is kind of too complicated for me. I still prefer the approach
we used in icelake, and don't overuse too much traits for just saving code.
Actually, this design is
liurenjie1024 commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1894871318
This design is kind of too complicated for me. I still prefer the approach
we used in icelake, and don't overuse too much traits for just saving code.
--
This is an automated m
ZENOTME commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1894811712
> Trait is usually used to abstract things and hide concrete implementation.
I don't quite understand the goal of this trait CurrentStatus and when it will
be useful?
Sorry, Let
liurenjie1024 commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1894775565
> Hi, I find that we can modify
>
> ```
> /// The current file status of iceberg writer. It implement for the writer
which write a single
> /// file.
> pub trait C
ZENOTME commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1893177443
Hi, I find that we can modify
```
/// The current file status of iceberg writer. It implement for the writer
which write a single
/// file.
pub trait CurrentFileStatus {
liurenjie1024 commented on code in PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#discussion_r1449911450
##
crates/iceberg/src/writer/mod.rs:
##
@@ -0,0 +1,109 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
liurenjie1024 commented on code in PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#discussion_r1449890234
##
crates/iceberg/src/writer/file_writer/mod.rs:
##
@@ -0,0 +1,41 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
ZENOTME commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1888422180
To make the design more simple, I have removed the **WriteResult trait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
liurenjie1024 commented on code in PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#discussion_r1448357734
##
crates/iceberg/src/writer/file_writer/mod.rs:
##
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
ZENOTME commented on code in PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#discussion_r1445904375
##
crates/iceberg/src/writer/mod.rs:
##
@@ -0,0 +1,120 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
ZENOTME commented on code in PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#discussion_r1445893518
##
crates/iceberg/src/writer/mod.rs:
##
@@ -0,0 +1,120 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
ZENOTME commented on code in PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#discussion_r1445893518
##
crates/iceberg/src/writer/mod.rs:
##
@@ -0,0 +1,120 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
ZENOTME commented on code in PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#discussion_r1445872438
##
crates/iceberg/src/writer/file_writer/mod.rs:
##
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license a
ZENOTME commented on code in PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#discussion_r1445854906
##
crates/iceberg/src/writer/file_writer/mod.rs:
##
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license a
Xuanwo commented on code in PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#discussion_r1445761472
##
crates/iceberg/src/writer/mod.rs:
##
@@ -0,0 +1,120 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
liurenjie1024 commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1882539731
> Sorry for being late. I drew a UML diagram, hope it can make the design
clearer. Please let me know if there is something confused.
, so I'm familiar with this. I
feel that maybe a UML d
ZENOTME commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1869402828
https://github.com/apache/iceberg-rust/assets/43447882/7b830b61-e898-49e6-85f4-eb11a47455b0";>
I draw a diagram to demonstrate the design of writer. Please let me know if
it stil
liurenjie1024 commented on PR #135:
URL: https://github.com/apache/iceberg-rust/pull/135#issuecomment-1869321881
I would suggest to have a class hierarchy to demonstrate the whole picture
of this design.
--
This is an automated message from the Apache Git Service.
To respond to the messag
ZENOTME opened a new pull request, #135:
URL: https://github.com/apache/iceberg-rust/pull/135
related issue: #34
I drafted a writer framework which has been implemented in icelake
https://github.com/icelake-io/icelake/issues/243 and proved that it's
extensible and flexible. The followin
35 matches
Mail list logo
