[ 
https://issues.apache.org/jira/browse/IGNITE-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946096#comment-15946096
 ] 

Valentin Kulichenko edited comment on IGNITE-4141 at 3/28/17 10:38 PM:
-----------------------------------------------------------------------

[~ezhuravl], fix itself is OK, but there are two modes for JDBC driver:
* Current one - https://apacheignite.readme.io/docs/jdbc-driver
* Legacy one (deprecated) - https://apacheignite.readme.io/v1.3/docs/jdbc-driver

The fix should be applied to both, while you applied it only to the legacy 
version. Please add corresponding tests and fix 
{{org.apache.ignite.internal.jdbc2.JdbcQueryTaskV2}} accordingly.

In tests you should check that correct data is returned. If you use 
{{rs.getObject}} method, you should get correct {{BinaryObject}} instances. 
Please improve test coverage.


was (Author: vkulichenko):
[~ezhuravl], there are two modes for JDBC driver:
* Current one - https://apacheignite.readme.io/docs/jdbc-driver
* Legacy one (deprecated) - https://apacheignite.readme.io/v1.3/docs/jdbc-driver

The fix should be applied to both, while you applied it only to the legacy 
version. Please add corresponding tests and fix 
{{org.apache.ignite.internal.jdbc2.JdbcQueryTaskV2}} accordingly.

In tests you should check that correct data is returned. If you use 
{{rs.getObject}} method, you should get correct {{BinaryObject}} instances. 
Please improve test coverage.

> JDBC driver should always set withKeepBinary flag when querying cache
> ---------------------------------------------------------------------
>
>                 Key: IGNITE-4141
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4141
>             Project: Ignite
>          Issue Type: Improvement
>          Components: jdbc-driver, SQL
>    Affects Versions: 1.7
>            Reporter: Valentin Kulichenko
>            Assignee: Evgenii Zhuravlev
>
> Generally there are no model classes on the client which uses JDBC driver. 
> This means that an attempt to query {{_key}} and {{_val}} fields (which are 
> included in {{select *}}) will fail with "Failed resolve class for ID" error. 
> To avoid this we should always set {{withKeepBinary()}} flag when executing 
> query on server side.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to