[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108162#comment-17108162
]
Alexey Scherbakov commented on IGNITE-11147:
[~v.pyatkov]
LGTM, merged to master
[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107086#comment-17107086
]
Ignite TC Bot commented on IGNITE-11147:
{panel:title=Branch: [pull/7428/head] Base: [master] :
[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080462#comment-17080462
]
Ignite TC Bot commented on IGNITE-11147:
{panel:title=Branch: [pull/7428/head] Base: [master] :
[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063809#comment-17063809
]
Vladislav Pyatkov commented on IGNITE-11147:
[~ascherbakov] I added several changes,
[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063807#comment-17063807
]
Ignite TC Bot commented on IGNITE-11147:
{panel:title=Branch: [pull/7428/head] Base: [master] :
[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039008#comment-17039008
]
Alexey Scherbakov commented on IGNITE-11147:
[~v.pyatkov]
I think we should add a test for
[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039000#comment-17039000
]
Maxim Muzafarov commented on IGNITE-11147:
--
[~ascherbakov]
Yes, I've mentioned the same in
[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038999#comment-17038999
]
Alexey Scherbakov commented on IGNITE-11147:
Guys,
Looks like the patch has an issue.
It's
[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038932#comment-17038932
]
Alexey Scherbakov commented on IGNITE-11147:
Looks like all comments are addressed. No more
[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038925#comment-17038925
]
Vladislav Pyatkov commented on IGNITE-11147:
[~ascherbakov] [~xtern] [~NSAmelchev][~mmuzaf]
[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038356#comment-17038356
]
Alexey Scherbakov commented on IGNITE-11147:
[~v.pyatkov]
Check my comments under the PR.
[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038329#comment-17038329
]
Maxim Muzafarov commented on IGNITE-11147:
--
Folks,
I'll take a look at these changes soon.
[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037888#comment-17037888
]
Vladislav Pyatkov commented on IGNITE-11147:
[~ascherbakov] Please review my changes.
>
[
https://issues.apache.org/jira/browse/IGNITE-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037886#comment-17037886
]
Ignite TC Bot commented on IGNITE-11147:
{panel:title=Branch: [pull/7428/head] Base: [master] :
14 matches
Mail list logo