[
https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029930#comment-17029930
]
Andrey N. Gura commented on IGNITE-12568:
-
Merged to master branch.
> MessageFactory
[
https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029918#comment-17029918
]
Alexey Goncharuk commented on IGNITE-12568:
---
Looks good to me as well!
> MessageFactory
[
https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029851#comment-17029851
]
Ivan Bessonov commented on IGNITE-12568:
[~agura] looks good to me, do we need another approval
[
https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029723#comment-17029723
]
Andrey N. Gura commented on IGNITE-12568:
-
[~ibessonov] Thanks for your comments. I fixed most
[
https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027436#comment-17027436
]
Ignite TC Bot commented on IGNITE-12568:
{panel:title=Branch: [pull/7302/head] Base: [master] :
[
https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026033#comment-17026033
]
Andrey N. Gura commented on IGNITE-12568:
-
Added new test. Waiting for TC.
> MessageFactory
[
https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025141#comment-17025141
]
Andrey N. Gura commented on IGNITE-12568:
-
[~ibessonov] [~agoncharuk] Could you please review
[
https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025139#comment-17025139
]
Ignite TC Bot commented on IGNITE-12568:
{panel:title=Branch: [pull/7302/head] Base: [master] :
[
https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023037#comment-17023037
]
Alexey Goncharuk commented on IGNITE-12568:
---
Agree, the second approach looks clean.
>
[
https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022058#comment-17022058
]
Ivan Bessonov commented on IGNITE-12568:
[~agura] second solution looks nicer, I like it, thank
[
https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022048#comment-17022048
]
Andrey N. Gura commented on IGNITE-12568:
-
[~ibessonov] [~agoncharuk] It seems that
[
https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021255#comment-17021255
]
Andrey N. Gura commented on IGNITE-12568:
-
[~ibessonov] Good point about extensions. I need
[
https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021208#comment-17021208
]
Ivan Bessonov commented on IGNITE-12568:
[~agura] I believe that we'll face an issue with
13 matches
Mail list logo