[jira] [Commented] (IGNITE-12568) MessageFactory implementations refactoring

2020-02-04 Thread Andrey N. Gura (Jira)
[ https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029930#comment-17029930 ] Andrey N. Gura commented on IGNITE-12568: - Merged to master branch. > MessageFactory

[jira] [Commented] (IGNITE-12568) MessageFactory implementations refactoring

2020-02-04 Thread Alexey Goncharuk (Jira)
[ https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029918#comment-17029918 ] Alexey Goncharuk commented on IGNITE-12568: --- Looks good to me as well! > MessageFactory

[jira] [Commented] (IGNITE-12568) MessageFactory implementations refactoring

2020-02-04 Thread Ivan Bessonov (Jira)
[ https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029851#comment-17029851 ] Ivan Bessonov commented on IGNITE-12568: [~agura] looks good to me, do we need another approval

[jira] [Commented] (IGNITE-12568) MessageFactory implementations refactoring

2020-02-04 Thread Andrey N. Gura (Jira)
[ https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029723#comment-17029723 ] Andrey N. Gura commented on IGNITE-12568: - [~ibessonov] Thanks for your comments. I fixed most

[jira] [Commented] (IGNITE-12568) MessageFactory implementations refactoring

2020-01-31 Thread Ignite TC Bot (Jira)
[ https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027436#comment-17027436 ] Ignite TC Bot commented on IGNITE-12568: {panel:title=Branch: [pull/7302/head] Base: [master] :

[jira] [Commented] (IGNITE-12568) MessageFactory implementations refactoring

2020-01-29 Thread Andrey N. Gura (Jira)
[ https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026033#comment-17026033 ] Andrey N. Gura commented on IGNITE-12568: - Added new test. Waiting for TC. > MessageFactory

[jira] [Commented] (IGNITE-12568) MessageFactory implementations refactoring

2020-01-28 Thread Andrey N. Gura (Jira)
[ https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025141#comment-17025141 ] Andrey N. Gura commented on IGNITE-12568: - [~ibessonov] [~agoncharuk] Could you please review

[jira] [Commented] (IGNITE-12568) MessageFactory implementations refactoring

2020-01-28 Thread Ignite TC Bot (Jira)
[ https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025139#comment-17025139 ] Ignite TC Bot commented on IGNITE-12568: {panel:title=Branch: [pull/7302/head] Base: [master] :

[jira] [Commented] (IGNITE-12568) MessageFactory implementations refactoring

2020-01-24 Thread Alexey Goncharuk (Jira)
[ https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023037#comment-17023037 ] Alexey Goncharuk commented on IGNITE-12568: --- Agree, the second approach looks clean. >

[jira] [Commented] (IGNITE-12568) MessageFactory implementations refactoring

2020-01-23 Thread Ivan Bessonov (Jira)
[ https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022058#comment-17022058 ] Ivan Bessonov commented on IGNITE-12568: [~agura] second solution looks nicer, I like it, thank

[jira] [Commented] (IGNITE-12568) MessageFactory implementations refactoring

2020-01-23 Thread Andrey N. Gura (Jira)
[ https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022048#comment-17022048 ] Andrey N. Gura commented on IGNITE-12568: - [~ibessonov] [~agoncharuk] It seems that

[jira] [Commented] (IGNITE-12568) MessageFactory implementations refactoring

2020-01-22 Thread Andrey N. Gura (Jira)
[ https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021255#comment-17021255 ] Andrey N. Gura commented on IGNITE-12568: - [~ibessonov] Good point about extensions. I need

[jira] [Commented] (IGNITE-12568) MessageFactory implementations refactoring

2020-01-22 Thread Ivan Bessonov (Jira)
[ https://issues.apache.org/jira/browse/IGNITE-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021208#comment-17021208 ] Ivan Bessonov commented on IGNITE-12568: [~agura] I believe that we'll face an issue with