[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-08-29 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447273#comment-15447273 ] Andrey Gura commented on IGNITE-2969: - Fixed as part of IGNITE-2968. > Optimistic transactions

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-08-29 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447272#comment-15447272 ] Andrey Gura commented on IGNITE-2969: - Fixed as part of IGNITE-2968. > Optimistic transactions

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-07-12 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373391#comment-15373391 ] Andrey Gura commented on IGNITE-2969: - Also added fix for {{GridDhtLockFuture}} that affect

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-07-06 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364731#comment-15364731 ] Andrey Gura commented on IGNITE-2969: - Race found in {{IgniteTxManager.txLockInfo}} method. When

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-07-05 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362922#comment-15362922 ] Andrey Gura commented on IGNITE-2969: - Found bug in {{TxDeadlockDetection.findCycle}} method that

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-06-17 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336192#comment-15336192 ] Andrey Gura commented on IGNITE-2969: - {{GridDhtTxPrepareFuture}} also changed accordingly to review

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-06-16 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334272#comment-15334272 ] Andrey Gura commented on IGNITE-2969: - Items 1-3, 5-7 are fixed.

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-06-15 Thread Semen Boikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331747#comment-15331747 ] Semen Boikov commented on IGNITE-2969: -- Reviewed, my comments: - need change

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-06-10 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324141#comment-15324141 ] Andrey Gura commented on IGNITE-2969: - Tests fixed. Please review. > Optimistic transactions support

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-06-08 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320510#comment-15320510 ] Andrey Gura commented on IGNITE-2969: - In {{GridNearOptimisticTxPrepareFuture}} some code blocks are

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-06-07 Thread Dmitriy Setrakyan (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319458#comment-15319458 ] Dmitriy Setrakyan commented on IGNITE-2969: --- Yakov, you are right, I didn't notice that some

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-06-07 Thread Yakov Zhdanov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319396#comment-15319396 ] Yakov Zhdanov commented on IGNITE-2969: --- I don't see any drop here. [~agura], [~sboikov], can you

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-06-07 Thread Dmitriy Setrakyan (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319342#comment-15319342 ] Dmitriy Setrakyan commented on IGNITE-2969: --- The performance drop does not make sense to me. If

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-06-07 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319153#comment-15319153 ] Andrey Gura commented on IGNITE-2969: - Rerun benchmarks more accurate. Results below: {noformat}

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-06-07 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319138#comment-15319138 ] Andrey Gura commented on IGNITE-2969: - I ran tests for deadlock detection with pessimistic and

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-06-06 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316905#comment-15316905 ] Andrey Gura commented on IGNITE-2969: - I ran tests for deadlock detection with pessimistic and

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-05-31 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308868#comment-15308868 ] Andrey Gura commented on IGNITE-2969: - Nested synchronization is removed. Transactions classes don't

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-05-27 Thread Semen Boikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304325#comment-15304325 ] Semen Boikov commented on IGNITE-2969: -- Did quick review, have some comments: - you added additional

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-05-26 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302747#comment-15302747 ] Andrey Gura commented on IGNITE-2969: - Implemented. Waiting for TC. Also additional testing needed.

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-05-23 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297423#comment-15297423 ] Andrey Gura commented on IGNITE-2969: - I was wrong about {{checkValid}} method behavior. Actually

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-05-22 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295725#comment-15295725 ] Andrey Gura commented on IGNITE-2969: - One more problem found. In cases when some transaction wasn't

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-05-18 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290057#comment-15290057 ] Andrey Gura commented on IGNITE-2969: - [~sboikov], I see only one reliable way to provide proper

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-05-10 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279202#comment-15279202 ] Andrey Gura commented on IGNITE-2969: - Changes in {{GridDhtTxPrepareFuture}} affects pessimistic

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-04-29 Thread Semen Boikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15264016#comment-15264016 ] Semen Boikov commented on IGNITE-2969: -- Andrey, Looked at your changes, I think you need implement

[jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection

2016-04-28 Thread Andrey Gura (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262663#comment-15262663 ] Andrey Gura commented on IGNITE-2969: - Implemented using timeout objects in