[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594630#comment-16594630 ] ASF GitHub Bot commented on IGNITE-6055: Github user asfgit closed the pull request at:

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-28 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594591#comment-16594591 ] Nikolay Izhikov commented on IGNITE-6055: - Run All -

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-27 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593486#comment-16593486 ] Vladimir Ozerov commented on IGNITE-6055: - [~NIzhikov], I would only ensure that all tests are

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-24 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591391#comment-16591391 ] Nikolay Izhikov commented on IGNITE-6055: - [~isapego] Thank you, very much! [~vozerov] Is there

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-24 Thread Igor Sapego (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591382#comment-16591382 ] Igor Sapego commented on IGNITE-6055: - [~NIzhikov], looks good to me. > SQL: Add String length

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-23 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590858#comment-16590858 ] Nikolay Izhikov commented on IGNITE-6055: - [~isapego] I've fixed your comments and added a new

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-23 Thread Igor Sapego (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590365#comment-16590365 ] Igor Sapego commented on IGNITE-6055: - [~NIzhikov], left several comments in Upsource. Overall good,

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-22 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589353#comment-16589353 ] Nikolay Izhikov commented on IGNITE-6055: - [~isapego] [~vozerov] I've added support of length

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-20 Thread Igor Sapego (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586095#comment-16586095 ] Igor Sapego commented on IGNITE-6055: - [~NIzhikov], Well, basically, there is

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-20 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586045#comment-16586045 ] Nikolay Izhikov commented on IGNITE-6055: - > What was done for other clients? Only configuration

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-20 Thread Igor Sapego (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586038#comment-16586038 ] Igor Sapego commented on IGNITE-6055: - [~NIzhikov]  # I confirm, there is no yet SQL support or

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-20 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585876#comment-16585876 ] Nikolay Izhikov commented on IGNITE-6055: - Hello, [~isapego]. 1. Can you confirm, that,

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-18 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584674#comment-16584674 ] Nikolay Izhikov commented on IGNITE-6055: - NodeJS tests looks fine now -

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-18 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584666#comment-16584666 ] Nikolay Izhikov commented on IGNITE-6055: - [~vozerov], [~isapego] Guys, I crawl through CPP

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-17 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584653#comment-16584653 ] Nikolay Izhikov commented on IGNITE-6055: - Hello, [~vozerov], [~isapego], As I can see, nodejs

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-17 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584045#comment-16584045 ] Nikolay Izhikov commented on IGNITE-6055: - [~vozerov] Thank you for the review! [~isapego] Do

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-17 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584023#comment-16584023 ] Vladimir Ozerov commented on IGNITE-6055: - [~NIzhikov], patch looks good to me, thank you for

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-14 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580004#comment-16580004 ] Nikolay Izhikov commented on IGNITE-6055: - [~vozerov] All comments are fixed. New tests added.

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-14 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579609#comment-16579609 ] Vladimir Ozerov commented on IGNITE-6055: - [~NIzhikov], my comments: 1)

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-02 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567806#comment-16567806 ] Nikolay Izhikov commented on IGNITE-6055: - RunAll -

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-08-01 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566035#comment-16566035 ] Nikolay Izhikov commented on IGNITE-6055: - [~vozerov] > 5) I do not see how compatibility is

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-06-28 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526290#comment-16526290 ] Nikolay Izhikov commented on IGNITE-6055: - Latest Run All -

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-06-26 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523251#comment-16523251 ] Nikolay Izhikov commented on IGNITE-6055: - I've checked out "Review checklist" [1] Here are

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-06-25 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522719#comment-16522719 ] Nikolay Izhikov commented on IGNITE-6055: - > 1) >

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-06-13 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510892#comment-16510892 ] Vladimir Ozerov commented on IGNITE-6055: - [~NIzhikov], my comments: 1)

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-06-09 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507005#comment-16507005 ] Nikolay Izhikov commented on IGNITE-6055: - [~vozerov] I don't get it. Can you name the ticket I

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-06-09 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506995#comment-16506995 ] Nikolay Izhikov commented on IGNITE-6055: - [~vozerov] > it is illegal to replace 2.5.0 version

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-06-05 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501630#comment-16501630 ] Vladimir Ozerov commented on IGNITE-6055: - Let me perform some cleanup of older JDBC versions to

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-06-05 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501629#comment-16501629 ] Vladimir Ozerov commented on IGNITE-6055: - [~NIzhikov], first comment - it is illegal to replace

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-05-29 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493349#comment-16493349 ] Nikolay Izhikov commented on IGNITE-6055: - Run All results -

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-05-28 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492799#comment-16492799 ] Nikolay Izhikov commented on IGNITE-6055: - [~vozerov] Please, review PR. I've created a project

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-05-28 Thread Anton Vinogradov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492792#comment-16492792 ] Anton Vinogradov commented on IGNITE-6055: -- [~NIzhikov],  Looks good to me, but I'm not an

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-05-18 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480357#comment-16480357 ] Vladimir Ozerov commented on IGNITE-6055: - [~NIzhikov], please find my answers below: 1) Please

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-05-17 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478845#comment-16478845 ] Nikolay Izhikov commented on IGNITE-6055: - Hello, [~vozerov]. I've done a basic implementation.

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470386#comment-16470386 ] ASF GitHub Bot commented on IGNITE-6055: GitHub user nizhikov opened a pull request:

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-05-10 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470012#comment-16470012 ] Vladimir Ozerov commented on IGNITE-6055: - [~NIzhikov], my comments: 1) I do not see a case when

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-05-08 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467545#comment-16467545 ] Nikolay Izhikov commented on IGNITE-6055: - [~vozerov] I think we should add an ability to setup

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-05-08 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467189#comment-16467189 ] Nikolay Izhikov commented on IGNITE-6055: - [~vozerov] > why do we need to truncate anything on

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-05-08 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467185#comment-16467185 ] Vladimir Ozerov commented on IGNITE-6055: - [~NIzhikov], in general looks good, but if we truncate

[jira] [Commented] (IGNITE-6055) SQL: Add String length constraint

2018-05-08 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467115#comment-16467115 ] Nikolay Izhikov commented on IGNITE-6055: - [~vozerov] I propose following design for this issue