[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594630#comment-16594630
]
ASF GitHub Bot commented on IGNITE-6055:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594591#comment-16594591
]
Nikolay Izhikov commented on IGNITE-6055:
-
Run All -
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593486#comment-16593486
]
Vladimir Ozerov commented on IGNITE-6055:
-
[~NIzhikov], I would only ensure that all tests are
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591391#comment-16591391
]
Nikolay Izhikov commented on IGNITE-6055:
-
[~isapego] Thank you, very much!
[~vozerov] Is there
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591382#comment-16591382
]
Igor Sapego commented on IGNITE-6055:
-
[~NIzhikov], looks good to me.
> SQL: Add String length
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590858#comment-16590858
]
Nikolay Izhikov commented on IGNITE-6055:
-
[~isapego] I've fixed your comments and added a new
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590365#comment-16590365
]
Igor Sapego commented on IGNITE-6055:
-
[~NIzhikov], left several comments in Upsource. Overall good,
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589353#comment-16589353
]
Nikolay Izhikov commented on IGNITE-6055:
-
[~isapego] [~vozerov]
I've added support of length
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586095#comment-16586095
]
Igor Sapego commented on IGNITE-6055:
-
[~NIzhikov],
Well, basically, there is
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586045#comment-16586045
]
Nikolay Izhikov commented on IGNITE-6055:
-
> What was done for other clients? Only configuration
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586038#comment-16586038
]
Igor Sapego commented on IGNITE-6055:
-
[~NIzhikov]
# I confirm, there is no yet SQL support or
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585876#comment-16585876
]
Nikolay Izhikov commented on IGNITE-6055:
-
Hello, [~isapego].
1. Can you confirm, that,
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584674#comment-16584674
]
Nikolay Izhikov commented on IGNITE-6055:
-
NodeJS tests looks fine now -
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584666#comment-16584666
]
Nikolay Izhikov commented on IGNITE-6055:
-
[~vozerov], [~isapego]
Guys, I crawl through CPP
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584653#comment-16584653
]
Nikolay Izhikov commented on IGNITE-6055:
-
Hello, [~vozerov], [~isapego],
As I can see, nodejs
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584045#comment-16584045
]
Nikolay Izhikov commented on IGNITE-6055:
-
[~vozerov] Thank you for the review!
[~isapego] Do
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584023#comment-16584023
]
Vladimir Ozerov commented on IGNITE-6055:
-
[~NIzhikov], patch looks good to me, thank you for
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580004#comment-16580004
]
Nikolay Izhikov commented on IGNITE-6055:
-
[~vozerov]
All comments are fixed.
New tests added.
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579609#comment-16579609
]
Vladimir Ozerov commented on IGNITE-6055:
-
[~NIzhikov], my comments:
1)
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567806#comment-16567806
]
Nikolay Izhikov commented on IGNITE-6055:
-
RunAll -
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566035#comment-16566035
]
Nikolay Izhikov commented on IGNITE-6055:
-
[~vozerov]
> 5) I do not see how compatibility is
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526290#comment-16526290
]
Nikolay Izhikov commented on IGNITE-6055:
-
Latest Run All -
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523251#comment-16523251
]
Nikolay Izhikov commented on IGNITE-6055:
-
I've checked out "Review checklist" [1]
Here are
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522719#comment-16522719
]
Nikolay Izhikov commented on IGNITE-6055:
-
> 1)
>
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510892#comment-16510892
]
Vladimir Ozerov commented on IGNITE-6055:
-
[~NIzhikov], my comments:
1)
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507005#comment-16507005
]
Nikolay Izhikov commented on IGNITE-6055:
-
[~vozerov] I don't get it.
Can you name the ticket I
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506995#comment-16506995
]
Nikolay Izhikov commented on IGNITE-6055:
-
[~vozerov]
> it is illegal to replace 2.5.0 version
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501630#comment-16501630
]
Vladimir Ozerov commented on IGNITE-6055:
-
Let me perform some cleanup of older JDBC versions to
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501629#comment-16501629
]
Vladimir Ozerov commented on IGNITE-6055:
-
[~NIzhikov], first comment - it is illegal to replace
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493349#comment-16493349
]
Nikolay Izhikov commented on IGNITE-6055:
-
Run All results -
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492799#comment-16492799
]
Nikolay Izhikov commented on IGNITE-6055:
-
[~vozerov]
Please, review PR.
I've created a project
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492792#comment-16492792
]
Anton Vinogradov commented on IGNITE-6055:
--
[~NIzhikov],
Looks good to me, but I'm not an
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480357#comment-16480357
]
Vladimir Ozerov commented on IGNITE-6055:
-
[~NIzhikov], please find my answers below:
1) Please
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478845#comment-16478845
]
Nikolay Izhikov commented on IGNITE-6055:
-
Hello, [~vozerov]. I've done a basic implementation.
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470386#comment-16470386
]
ASF GitHub Bot commented on IGNITE-6055:
GitHub user nizhikov opened a pull request:
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470012#comment-16470012
]
Vladimir Ozerov commented on IGNITE-6055:
-
[~NIzhikov], my comments:
1) I do not see a case when
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467545#comment-16467545
]
Nikolay Izhikov commented on IGNITE-6055:
-
[~vozerov]
I think we should add an ability to setup
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467189#comment-16467189
]
Nikolay Izhikov commented on IGNITE-6055:
-
[~vozerov]
> why do we need to truncate anything on
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467185#comment-16467185
]
Vladimir Ozerov commented on IGNITE-6055:
-
[~NIzhikov], in general looks good, but if we truncate
[
https://issues.apache.org/jira/browse/IGNITE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467115#comment-16467115
]
Nikolay Izhikov commented on IGNITE-6055:
-
[~vozerov]
I propose following design for this issue
40 matches
Mail list logo