[
https://issues.apache.org/jira/browse/IMPALA-5390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe McDonnell resolved IMPALA-5390.
-----------------------------------
Resolution: Fixed
Fix Version/s: Impala 2.10.0
commit 53287df0a11ba43ff12067267cf2e3b0ffad075c
Author: Joe McDonnell <joemcdonn...@cloudera.com>
Date: Wed Jun 14 11:29:38 2017 -0700
IMPALA-5488: Fix handling of exclusive HDFS file handles
This change fixes three issues:
1. File handle caching is expected to be disabled for
remote files (using exclusive HDFS file handles),
however the file handles are still being cached.
2. The retry logic for exclusive file handles is broken,
leading the number of open files to be incorrect.
3. There is no test coverage for disabling the file
handle cache.
To fix issue #1, when a scan range is requesting an
exclusive file handle from the cache, it will always
request a newly opened file handle. It also will destroy
the file handle when the scan range is closed.
To fix issue #2, exclusive file handles will no longer
retry IOs. Since the exclusive file handle is always
a fresh file handle, it will never have a bad file
handle from the cache. This returns the logic to
its state before IMPALA-4623 in these cases. If a
file handle is borrowed from the cache, then the
code will continue to retry once with a fresh handle.
To fix issue #3, custom_cluster/test_hdfs_fd_caching.py
now does both positive and negative tests for the file
handle cache. It verifies that setting
max_cached_file_handles to zero disables caching. It
also verifies that caching is disabled on remote
files. (This change will resolve IMPALA-5390.)
Change-Id: I4c03696984285cc9ce463edd969c5149cd83a861
Reviewed-on: http://gerrit.cloudera.org:8080/7181
Reviewed-by: Dan Hecht <dhe...@cloudera.com>
Tested-by: Impala Public Jenkins
> Add test that file handle cache is disabled for S3,ADLS,Isilon
> --------------------------------------------------------------
>
> Key: IMPALA-5390
> URL: https://issues.apache.org/jira/browse/IMPALA-5390
> Project: IMPALA
> Issue Type: Test
> Components: Backend
> Affects Versions: Impala 2.10.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Fix For: Impala 2.10.0
>
>
> There are positive checks for file handle cache functionality on local HDFS
> files. There needs to be a unit test on S3, ADLS, and Isilon that verifies
> that the file handle cache is not used on those platforms.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
