[ https://issues.apache.org/jira/browse/IMPALA-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Armstrong resolved IMPALA-5957. ----------------------------------- Resolution: Fixed Fix Version/s: Impala 2.11.0 commit 98f8b19c3bd0debfe25055aaecaf86e38b23c748 Author: Tim Armstrong <tarmstr...@cloudera.com> Date: Tue Oct 24 11:04:55 2017 -0700 IMPALA-5957: print memory address, not memory The bug is that the pointer was a uint8_t*, which C++ iostreams print as a C-style string. The intent was to instead print the memory address, which happens for void*. To avoid the subtlety, instead convert to uintptr_t and print as hex. Change-Id: I89250646bf683dd2d636dcb37a66ceb0428af8b2 Reviewed-on: http://gerrit.cloudera.org:8080/8371 Reviewed-by: anujphadke <apha...@cloudera.com> Reviewed-by: Dan Hecht <dhe...@cloudera.com> Tested-by: Impala Public Jenkins > DCHECK attempts to print non-string as a c-style string > ------------------------------------------------------- > > Key: IMPALA-5957 > URL: https://issues.apache.org/jira/browse/IMPALA-5957 > Project: IMPALA > Issue Type: Bug > Components: Backend > Affects Versions: Impala 2.11.0 > Reporter: Tim Armstrong > Assignee: Tim Armstrong > Priority: Minor > Labels: newbie > Fix For: Impala 2.11.0 > > > The intention of the below code is to print the memory address, but the type > is uint8_t* instead of void*. > {code} > DCHECK_EQ(reinterpret_cast<uintptr_t>(mem) % HUGE_PAGE_SIZE, 0) << mem; > {code} > Severity/risk is low because this is only printed if the process is in the > process of crashing. -- This message was sent by Atlassian JIRA (v6.4.14#64029)