[GitHub] [kylin] nichunen edited a comment on issue #625: Added Unit Tests

nichunen edited a comment on issue #625: Added Unit Tests URL: https://github.com/apache/kylin/pull/625#issuecomment-488186974 Hi @TheRealHaui The pr is not passed by style check, for "Using the '.*' form of import should be avoided" You can set your dev env with reference h

[GitHub] [kylin] nichunen commented on issue #625: Added Unit Tests

nichunen commented on issue #625: Added Unit Tests URL: https://github.com/apache/kylin/pull/625#issuecomment-488186974 Hi @TheRealHaui The pr is not passed by style check, for "Using the '.*' form of import should be avoided" ---

[jira] [Commented] (KYLIN-3965) When using DriverManager - No suitable driver found for jdbc:kylin://

[ https://issues.apache.org/jira/browse/KYLIN-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830839#comment-16830839 ] ASF GitHub Bot commented on KYLIN-3965: --- nichunen commented on pull request #616: K

[jira] [Commented] (KYLIN-3965) When using DriverManager - No suitable driver found for jdbc:kylin://

[ https://issues.apache.org/jira/browse/KYLIN-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830840#comment-16830840 ] ASF subversion and git services commented on KYLIN-3965: Commit 2

[GitHub] [kylin] nichunen merged pull request #616: KYLIN-3965 JDBC fix.

nichunen merged pull request #616: KYLIN-3965 JDBC fix. URL: https://github.com/apache/kylin/pull/616 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [kylin] TheRealHaui opened a new pull request #625: Added Unit Tests

TheRealHaui opened a new pull request #625: Added Unit Tests URL: https://github.com/apache/kylin/pull/625 Added Unit Tests to increase code coverage. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kylin] asfgit commented on issue #625: Added Unit Tests

asfgit commented on issue #625: Added Unit Tests URL: https://github.com/apache/kylin/pull/625#issuecomment-488059450 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respon

[GitHub] [kylin] codecov-io commented on issue #616: KYLIN-3965 JDBC fix.

codecov-io commented on issue #616: KYLIN-3965 JDBC fix. URL: https://github.com/apache/kylin/pull/616#issuecomment-488022349 # [Codecov](https://codecov.io/gh/apache/kylin/pull/616?src=pr&el=h1) Report > Merging [#616](https://codecov.io/gh/apache/kylin/pull/616?src=pr&el=desc) into [m

[GitHub] [kylin] coveralls edited a comment on issue #616: KYLIN-3965 JDBC fix.

coveralls edited a comment on issue #616: KYLIN-3965 JDBC fix. URL: https://github.com/apache/kylin/pull/616#issuecomment-485441186 ## Pull Request Test Coverage Report for [Build 4437](https://coveralls.io/builds/23110843) * **0** of **0** changed or added relevant lines in **0**

[GitHub] [kylin] nichunen commented on issue #616: KYLIN-3965 JDBC fix.

nichunen commented on issue #616: KYLIN-3965 JDBC fix. URL: https://github.com/apache/kylin/pull/616#issuecomment-487994340 Hi @Sidonet I think you should add this file to the apache-rat-plugin's exclude list on pom.xml --

[GitHub] [kylin] Sidonet edited a comment on issue #616: KYLIN-3965 JDBC fix.

Sidonet edited a comment on issue #616: KYLIN-3965 JDBC fix. URL: https://github.com/apache/kylin/pull/616#issuecomment-487966474 Hello Ni Chunen, Ok, i didn't know about this feature. I think that the rat plugin expect license on jdbc/src/main/resources/META-INF/services/java

[GitHub] [kylin] Sidonet edited a comment on issue #616: KYLIN-3965 JDBC fix.

Sidonet edited a comment on issue #616: KYLIN-3965 JDBC fix. URL: https://github.com/apache/kylin/pull/616#issuecomment-487966474 Hello Ni Chunen, Ok, i didn't know about this feature. I think that the rat plugin expect license on jdbc/src/main/resources/META-INF/services/java

[GitHub] [kylin] Sidonet commented on issue #616: KYLIN-3965 JDBC fix.

Sidonet commented on issue #616: KYLIN-3965 JDBC fix. URL: https://github.com/apache/kylin/pull/616#issuecomment-487966474 Hello Ni Chunen, Ok, i don't know about this feature. I think that the rat plugin expect license on jdbc/src/main/resources/META-INF/services/java.sql.Dri

[GitHub] [kylin] coveralls edited a comment on issue #616: KYLIN-3965 JDBC fix.

coveralls edited a comment on issue #616: KYLIN-3965 JDBC fix. URL: https://github.com/apache/kylin/pull/616#issuecomment-485441186 ## Pull Request Test Coverage Report for [Build 4436](https://coveralls.io/builds/23107154) * **0** of **0** changed or added relevant lines in **0**

[GitHub] [kylin] nichunen commented on issue #616: KYLIN-3965 JDBC fix.

nichunen commented on issue #616: KYLIN-3965 JDBC fix. URL: https://github.com/apache/kylin/pull/616#issuecomment-487951198 > > retest this please > > Hello, in my project i use build from this branch, due to DriverManager used in my project. > How will i need to retest it?

[GitHub] [kylin] Sidonet commented on issue #616: KYLIN-3965 JDBC fix.

Sidonet commented on issue #616: KYLIN-3965 JDBC fix. URL: https://github.com/apache/kylin/pull/616#issuecomment-487890922 > retest this please Hello, in my project i use build from this branch, due to DriverManager used in my project. How will i need to retest it? --

[jira] [Comment Edited] (KYLIN-3967) sum along with case expression does not work in query

[ https://issues.apache.org/jira/browse/KYLIN-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830123#comment-16830123 ] hejian edited comment on KYLIN-3967 at 4/30/19 9:41 AM: thanks [~

[jira] [Comment Edited] (KYLIN-3967) sum along with case expression does not work in query

[ https://issues.apache.org/jira/browse/KYLIN-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830123#comment-16830123 ] hejian edited comment on KYLIN-3967 at 4/30/19 9:40 AM: thanks [~

[jira] [Commented] (KYLIN-3967) sum along with case expression does not work in query

[ https://issues.apache.org/jira/browse/KYLIN-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830123#comment-16830123 ] hejian commented on KYLIN-3967: --- yes, i set the column from the look up table as a normal d

[GitHub] [kylin] adoroszlai removed a comment on issue #616: KYLIN-3965 JDBC fix.

adoroszlai removed a comment on issue #616: KYLIN-3965 JDBC fix. URL: https://github.com/apache/kylin/pull/616#issuecomment-487863541 retest This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kylin] codecov-io commented on issue #624: Allow user-specified time format using real-time

codecov-io commented on issue #624: Allow user-specified time format using real-time URL: https://github.com/apache/kylin/pull/624#issuecomment-487864284 # [Codecov](https://codecov.io/gh/apache/kylin/pull/624?src=pr&el=h1) Report > Merging [#624](https://codecov.io/gh/apache/kylin/pull/

[GitHub] [kylin] adoroszlai commented on issue #616: KYLIN-3965 JDBC fix.

adoroszlai commented on issue #616: KYLIN-3965 JDBC fix. URL: https://github.com/apache/kylin/pull/616#issuecomment-487863541 retest This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kylin] coveralls commented on issue #624: Allow user-specified time format using real-time

coveralls commented on issue #624: Allow user-specified time format using real-time URL: https://github.com/apache/kylin/pull/624#issuecomment-487863142 ## Pull Request Test Coverage Report for [Build 4435](https://coveralls.io/builds/23101740) * **20** of **49** **(40.82%)** cha

[GitHub] [kylin] lidongsjtu removed a comment on issue #622: KYLIN-3893 Add validation for the encoding length and the type of encoding

lidongsjtu removed a comment on issue #622: KYLIN-3893 Add validation for the encoding length and the type of encoding URL: https://github.com/apache/kylin/pull/622#issuecomment-487853714 retest this please This is an automat

[GitHub] [kylin] nichunen removed a comment on issue #616: KYLIN-3965 JDBC fix.

nichunen removed a comment on issue #616: KYLIN-3965 JDBC fix. URL: https://github.com/apache/kylin/pull/616#issuecomment-487849786 retest This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kylin] nichunen commented on issue #616: KYLIN-3965 JDBC fix.

nichunen commented on issue #616: KYLIN-3965 JDBC fix. URL: https://github.com/apache/kylin/pull/616#issuecomment-487853759 retest this please This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kylin] lidongsjtu commented on issue #622: KYLIN-3893 Add validation for the encoding length and the type of encoding

lidongsjtu commented on issue #622: KYLIN-3893 Add validation for the encoding length and the type of encoding URL: https://github.com/apache/kylin/pull/622#issuecomment-487853714 retest this please This is an automated messa

[GitHub] [kylin] lidongsjtu removed a comment on issue #622: KYLIN-3893 Add validation for the encoding length and the type of encoding

lidongsjtu removed a comment on issue #622: KYLIN-3893 Add validation for the encoding length and the type of encoding URL: https://github.com/apache/kylin/pull/622#issuecomment-487851029 retest This is an automated message f

[GitHub] [kylin] lidongsjtu commented on issue #622: KYLIN-3893 Add validation for the encoding length and the type of encoding

lidongsjtu commented on issue #622: KYLIN-3893 Add validation for the encoding length and the type of encoding URL: https://github.com/apache/kylin/pull/622#issuecomment-487851029 retest This is an automated message from the

[GitHub] [kylin] nichunen commented on issue #616: KYLIN-3965 JDBC fix.

nichunen commented on issue #616: KYLIN-3965 JDBC fix. URL: https://github.com/apache/kylin/pull/616#issuecomment-487849786 retest This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Resolved] (KYLIN-3873) Fix inappropriate use of memory in SparkFactDistinct.java

[ https://issues.apache.org/jira/browse/KYLIN-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nichunen resolved KYLIN-3873. - Resolution: Fixed > Fix inappropriate use of memory in SparkFactDistinct.java >

[jira] [Commented] (KYLIN-3873) Fix inappropriate use of memory in SparkFactDistinct.java

[ https://issues.apache.org/jira/browse/KYLIN-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830029#comment-16830029 ] ASF subversion and git services commented on KYLIN-3873: Commit 0

[jira] [Commented] (KYLIN-3873) Fix inappropriate use of memory in SparkFactDistinct.java

[ https://issues.apache.org/jira/browse/KYLIN-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830028#comment-16830028 ] nichunen commented on KYLIN-3873: - Cherry-picked to 2.6.x branch > Fix inappropriate us

[jira] [Commented] (KYLIN-3885) Build dimension dictionary job costs too long when using Spark fact distinct

[ https://issues.apache.org/jira/browse/KYLIN-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830018#comment-16830018 ] ASF subversion and git services commented on KYLIN-3885: Commit a