[GitHub] [kylin] nichunen commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/…

2019-05-12 Thread GitBox
nichunen commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/… URL: https://github.com/apache/kylin/pull/629#discussion_r283126065 ## File path: core-cube/src/main/java/org/apache/kylin/measure/MeasureManager.java ###

[GitHub] [kylin] nichunen merged pull request #631: Add additional unit tests

2019-05-12 Thread GitBox
nichunen merged pull request #631: Add additional unit tests URL: https://github.com/apache/kylin/pull/631 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [kylin] Qsimple commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/…

2019-05-12 Thread GitBox
Qsimple commented on a change in pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/… URL: https://github.com/apache/kylin/pull/629#discussion_r283127561 ## File path: core-cube/src/main/java/org/apache/kylin/measure/MeasureManager.java

[GitHub] [kylin] Qsimple commented on issue #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/…

2019-05-12 Thread GitBox
Qsimple commented on issue #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/… URL: https://github.com/apache/kylin/pull/629#issuecomment-491672176 new pr https://github.com/apache/kylin/pull/638 This

[GitHub] [kylin] Qsimple closed pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/…

2019-05-12 Thread GitBox
Qsimple closed pull request #629: KYLIN-3983 Add extra metadata for measure. Add test case and example/… URL: https://github.com/apache/kylin/pull/629 This is an automated message from the Apache Git Service. To respond to t

[jira] [Commented] (KYLIN-3983) Add extra metadata for measure

2019-05-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838258#comment-16838258 ] ASF GitHub Bot commented on KYLIN-3983: --- Qsimple commented on pull request #638: KY

[jira] [Commented] (KYLIN-3983) Add extra metadata for measure

2019-05-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838259#comment-16838259 ] ASF GitHub Bot commented on KYLIN-3983: --- Qsimple commented on pull request #629: KY

[GitHub] [kylin] Qsimple opened a new pull request #638: KYLIN-3983 Add extra metadata for measure. Add test case and example/…

2019-05-12 Thread GitBox
Qsimple opened a new pull request #638: KYLIN-3983 Add extra metadata for measure. Add test case and example/… URL: https://github.com/apache/kylin/pull/638 …test_case_data for MeasureManager. Add measure metadata in sample cube UT passed IT passed rewrite some logi

[GitHub] [kylin] asfgit commented on issue #638: KYLIN-3983 Add extra metadata for measure. Add test case and example/…

2019-05-12 Thread GitBox
asfgit commented on issue #638: KYLIN-3983 Add extra metadata for measure. Add test case and example/… URL: https://github.com/apache/kylin/pull/638#issuecomment-491671973 Can one of the admins verify this patch? This is an a

[GitHub] [kylin] codecov-io commented on issue #638: KYLIN-3983 Add extra metadata for measure. Add test case and example/…

2019-05-12 Thread GitBox
codecov-io commented on issue #638: KYLIN-3983 Add extra metadata for measure. Add test case and example/… URL: https://github.com/apache/kylin/pull/638#issuecomment-491676181 # [Codecov](https://codecov.io/gh/apache/kylin/pull/638?src=pr&el=h1) Report > Merging [#638](https://codecov.io