[GitHub] [kylin] hit-lacus commented on pull request #1252: KYLIN-4552 Add a switch to enable/disable flink cubing step: convert …

2020-06-10 Thread GitBox
hit-lacus commented on pull request #1252: URL: https://github.com/apache/kylin/pull/1252#issuecomment-641774774 LGTM, let's merge it. This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kylin] hit-lacus merged pull request #1252: KYLIN-4552 Add a switch to enable/disable flink cubing step: convert …

2020-06-10 Thread GitBox
hit-lacus merged pull request #1252: URL: https://github.com/apache/kylin/pull/1252 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KYLIN-4552) Add a switch to enable/disable flink cubing step: convert to HFile

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130303#comment-17130303 ] ASF GitHub Bot commented on KYLIN-4552: --- hit-lacus commented on pull request #1252:

[jira] [Commented] (KYLIN-4552) Add a switch to enable/disable flink cubing step: convert to HFile

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130305#comment-17130305 ] ASF GitHub Bot commented on KYLIN-4552: --- hit-lacus merged pull request #1252: URL:

[jira] [Commented] (KYLIN-4552) Add a switch to enable/disable flink cubing step: convert to HFile

2020-06-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130304#comment-17130304 ] ASF subversion and git services commented on KYLIN-4552: Commit c

[jira] [Resolved] (KYLIN-4391) Bump Flink version from 1.9.0 to 1.9.2

2020-06-10 Thread Xiaoxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoxiang Yu resolved KYLIN-4391. - Resolution: Fixed > Bump Flink version from 1.9.0 to 1.9.2 >

[jira] [Resolved] (KYLIN-4552) Add a switch to enable/disable flink cubing step: convert to HFile

2020-06-10 Thread Xiaoxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoxiang Yu resolved KYLIN-4552. - Resolution: Fixed > Add a switch to enable/disable flink cubing step: convert to HFile >

[GitHub] [kylin] zhangayqian commented on pull request #1102: KYLIN-4371 Integrate System Cube with Real-time OLAP

2020-06-10 Thread GitBox
zhangayqian commented on pull request #1102: URL: https://github.com/apache/kylin/pull/1102#issuecomment-641779601 ## Verify test case - System cube ![image](https://user-images.githubusercontent.com/31064237/84237447-f1639480-ab2b-11ea-92b2-b6fdb0e42e8c.png) - Dashboard ![

[jira] [Commented] (KYLIN-4371) Integrate System Cube with Real-time OLAP

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130312#comment-17130312 ] ASF GitHub Bot commented on KYLIN-4371: --- zhangayqian commented on pull request #110

[jira] [Created] (KYLIN-4554) Validate "filter condition" on model saving

2020-06-10 Thread Shao Feng Shi (Jira)
Shao Feng Shi created KYLIN-4554: Summary: Validate "filter condition" on model saving Key: KYLIN-4554 URL: https://issues.apache.org/jira/browse/KYLIN-4554 Project: Kylin Issue Type: Improve

[GitHub] [kylin] zhangayqian commented on pull request #1102: KYLIN-4371 Integrate System Cube with Real-time OLAP

2020-06-10 Thread GitBox
zhangayqian commented on pull request #1102: URL: https://github.com/apache/kylin/pull/1102#issuecomment-641786479 ### Summary - System cube with Real-time OLAP works well. This is an automated message from the

[jira] [Commented] (KYLIN-4371) Integrate System Cube with Real-time OLAP

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130328#comment-17130328 ] ASF GitHub Bot commented on KYLIN-4371: --- zhangayqian commented on pull request #110

[jira] [Updated] (KYLIN-4554) Validate "filter condition" on model saving

2020-06-10 Thread Shao Feng Shi (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shao Feng Shi updated KYLIN-4554: - Description: When define a model, user can enter a filter condition (using to do data filtering o

[jira] [Updated] (KYLIN-4554) Validate "filter condition" on model saving

2020-06-10 Thread Shao Feng Shi (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shao Feng Shi updated KYLIN-4554: - Attachment: WechatIMG397.png > Validate "filter condition" on model saving >

[jira] [Updated] (KYLIN-4554) Validate "filter condition" on model saving

2020-06-10 Thread Shao Feng Shi (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shao Feng Shi updated KYLIN-4554: - Description: When define a model, user can enter a filter condition (using to do data filtering

[GitHub] [kylin] zhangayqian commented on pull request #1003: Add flink engine to master

2020-06-10 Thread GitBox
zhangayqian commented on pull request #1003: URL: https://github.com/apache/kylin/pull/1003#issuecomment-641788416 ## Verify test case ### Case-1 (Build failed) - Build failed in `Convert to hfile` step. - Error log ![image](https://user-images.githubusercontent.com/31064237

[jira] [Updated] (KYLIN-4554) Validate "filter condition" on model saving

2020-06-10 Thread Shao Feng Shi (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shao Feng Shi updated KYLIN-4554: - Component/s: Metadata > Validate "filter condition" on model saving > ---

[jira] [Created] (KYLIN-4555) kylin 在 fliter 过滤数据的时候构建异常

2020-06-10 Thread Jira
邱小德 created KYLIN-4555: -- Summary: kylin 在 fliter 过滤数据的时候构建异常 Key: KYLIN-4555 URL: https://issues.apache.org/jira/browse/KYLIN-4555 Project: Kylin Issue Type: Bug Components: Job Engine Aff

[GitHub] [kylin] coveralls commented on pull request #1252: KYLIN-4552 Add a switch to enable/disable flink cubing step: convert …

2020-06-10 Thread GitBox
coveralls commented on pull request #1252: URL: https://github.com/apache/kylin/pull/1252#issuecomment-641791865 ## Pull Request Test Coverage Report for [Build 5995](https://coveralls.io/builds/31357163) * **0** of **6** **(0.0%)** changed or added relevant lines in **2** files

[jira] [Commented] (KYLIN-4552) Add a switch to enable/disable flink cubing step: convert to HFile

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130339#comment-17130339 ] ASF GitHub Bot commented on KYLIN-4552: --- coveralls commented on pull request #1252:

[GitHub] [kylin] codecov-commenter edited a comment on pull request #1218: KYLIN-4485 Create a self service interface for cube migration

2020-06-10 Thread GitBox
codecov-commenter edited a comment on pull request #1218: URL: https://github.com/apache/kylin/pull/1218#issuecomment-631513549 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1218?src=pr&el=h1) Report > Merging [#1218](https://codecov.io/gh/apache/kylin/pull/1218?src=pr&el=desc) int

[jira] [Commented] (KYLIN-4485) Create a self service interface for cube migration

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130366#comment-17130366 ] ASF GitHub Bot commented on KYLIN-4485: --- codecov-commenter edited a comment on pull

[GitHub] [kylin] lgtm-com[bot] commented on pull request #1218: KYLIN-4485 Create a self service interface for cube migration

2020-06-10 Thread GitBox
lgtm-com[bot] commented on pull request #1218: URL: https://github.com/apache/kylin/pull/1218#issuecomment-641838633 This pull request **introduces 2 alerts** when merging aa42d8c7fc590c8f68d35225eddcf0f7172310f8 into c1705947dc2c04d084a4bf3f4ad15877e1c50b2c - [view on LGTM.com](https://l

[jira] [Commented] (KYLIN-4485) Create a self service interface for cube migration

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130403#comment-17130403 ] ASF GitHub Bot commented on KYLIN-4485: --- lgtm-com[bot] commented on pull request #1

[GitHub] [kylin] zhangayqian commented on pull request #1003: Add flink engine to master

2020-06-10 Thread GitBox
zhangayqian commented on pull request #1003: URL: https://github.com/apache/kylin/pull/1003#issuecomment-641862333 ## Summary - Happy path test success with FLINK engine. This is an automated message from the Apache Git Se

[GitHub] [kylin] zhangayqian commented on pull request #1003: Add flink engine to master

2020-06-10 Thread GitBox
zhangayqian commented on pull request #1003: URL: https://github.com/apache/kylin/pull/1003#issuecomment-641861811 ## Verify test case after fixed ### Case-1 (success) ![image](https://user-images.githubusercontent.com/31064237/84247557-db110500-ab3a-11ea-9853-149e1c07d0e9.png)

[jira] [Commented] (KYLIN-3694) Kylin On Druid Storage

2020-06-10 Thread jjhuang (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130639#comment-17130639 ] jjhuang commented on KYLIN-3694: Hi, I saw the "kylin-on-druid" branch still not merge to

[jira] [Created] (KYLIN-4556) improve job service

2020-06-10 Thread Guangxu Cheng (Jira)
Guangxu Cheng created KYLIN-4556: Summary: improve job service Key: KYLIN-4556 URL: https://issues.apache.org/jira/browse/KYLIN-4556 Project: Kylin Issue Type: Task Reporter: Guan

[jira] [Created] (KYLIN-4557) Refactor JobService to improve code readability

2020-06-10 Thread Guangxu Cheng (Jira)
Guangxu Cheng created KYLIN-4557: Summary: Refactor JobService to improve code readability Key: KYLIN-4557 URL: https://issues.apache.org/jira/browse/KYLIN-4557 Project: Kylin Issue Type: Sub

[jira] [Created] (KYLIN-4558) get all chained executable jobs through job API

2020-06-10 Thread Guangxu Cheng (Jira)
Guangxu Cheng created KYLIN-4558: Summary: get all chained executable jobs through job API Key: KYLIN-4558 URL: https://issues.apache.org/jira/browse/KYLIN-4558 Project: Kylin Issue Type: Sub

[jira] [Created] (KYLIN-4559) show cardinality and lookup snapshot job on job page

2020-06-10 Thread Guangxu Cheng (Jira)
Guangxu Cheng created KYLIN-4559: Summary: show cardinality and lookup snapshot job on job page Key: KYLIN-4559 URL: https://issues.apache.org/jira/browse/KYLIN-4559 Project: Kylin Issue Type

[jira] [Created] (KYLIN-4560) support to re-run/delete cardinality and lookup snapshot job

2020-06-10 Thread Guangxu Cheng (Jira)
Guangxu Cheng created KYLIN-4560: Summary: support to re-run/delete cardinality and lookup snapshot job Key: KYLIN-4560 URL: https://issues.apache.org/jira/browse/KYLIN-4560 Project: Kylin I

[GitHub] [kylin] codecov-commenter edited a comment on pull request #1218: KYLIN-4485 Create a self service interface for cube migration

2020-06-10 Thread GitBox
codecov-commenter edited a comment on pull request #1218: URL: https://github.com/apache/kylin/pull/1218#issuecomment-631513549 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1218?src=pr&el=h1) Report > Merging [#1218](https://codecov.io/gh/apache/kylin/pull/1218?src=pr&el=desc) int

[jira] [Commented] (KYLIN-4485) Create a self service interface for cube migration

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130780#comment-17130780 ] ASF GitHub Bot commented on KYLIN-4485: --- codecov-commenter edited a comment on pull

[GitHub] [kylin] zzcclp commented on a change in pull request #1218: KYLIN-4485 Create a self service interface for cube migration

2020-06-10 Thread GitBox
zzcclp commented on a change in pull request #1218: URL: https://github.com/apache/kylin/pull/1218#discussion_r438231577 ## File path: core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java ## @@ -2125,14 +2154,15 @@ public boolean isWebDashboardEnabled() {

[jira] [Commented] (KYLIN-4485) Create a self service interface for cube migration

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130824#comment-17130824 ] ASF GitHub Bot commented on KYLIN-4485: --- zzcclp commented on a change in pull reque

[GitHub] [kylin] zzcclp commented on a change in pull request #1218: KYLIN-4485 Create a self service interface for cube migration

2020-06-10 Thread GitBox
zzcclp commented on a change in pull request #1218: URL: https://github.com/apache/kylin/pull/1218#discussion_r438231577 ## File path: core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java ## @@ -2125,14 +2154,15 @@ public boolean isWebDashboardEnabled() {

[jira] [Commented] (KYLIN-4485) Create a self service interface for cube migration

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130825#comment-17130825 ] ASF GitHub Bot commented on KYLIN-4485: --- zzcclp commented on a change in pull reque

[GitHub] [kylin] zhangayqian opened a new pull request #1253: KYLIN-4394 Fix NoSuchMethod in spark build job after update guava

2020-06-10 Thread GitBox
zhangayqian opened a new pull request #1253: URL: https://github.com/apache/kylin/pull/1253 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be

[jira] [Commented] (KYLIN-4394) Upgrade dependency version for several CVEs

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132831#comment-17132831 ] ASF GitHub Bot commented on KYLIN-4394: --- zhangayqian opened a new pull request #125

[jira] [Commented] (KYLIN-4394) Upgrade dependency version for several CVEs

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132838#comment-17132838 ] ASF GitHub Bot commented on KYLIN-4394: --- hit-lacus commented on pull request #1253:

[GitHub] [kylin] hit-lacus commented on pull request #1253: KYLIN-4394 Fix NoSuchMethod in spark build job after update guava

2020-06-10 Thread GitBox
hit-lacus commented on pull request #1253: URL: https://github.com/apache/kylin/pull/1253#issuecomment-642359236 ### Reproduce in EMR ``` 20/06/10 10:21:20 INFO MemoryStore: Block broadcast_2 stored as values in memory (estimated size 216.5 KB, free 1028.3 MB) 20/06/10 10:21:20 ERR

[GitHub] [kylin] codecov-commenter commented on pull request #1253: KYLIN-4394 Fix NoSuchMethod in spark build job after update guava

2020-06-10 Thread GitBox
codecov-commenter commented on pull request #1253: URL: https://github.com/apache/kylin/pull/1253#issuecomment-642363767 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1253?src=pr&el=h1) Report > Merging [#1253](https://codecov.io/gh/apache/kylin/pull/1253?src=pr&el=desc) into [mas

[jira] [Commented] (KYLIN-4394) Upgrade dependency version for several CVEs

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132843#comment-17132843 ] ASF GitHub Bot commented on KYLIN-4394: --- codecov-commenter commented on pull reques

[GitHub] [kylin] coveralls commented on pull request #1253: KYLIN-4394 Fix NoSuchMethod in spark build job after update guava

2020-06-10 Thread GitBox
coveralls commented on pull request #1253: URL: https://github.com/apache/kylin/pull/1253#issuecomment-642366144 ## Pull Request Test Coverage Report for [Build 6001](https://coveralls.io/builds/31380040) * **0** of **0** changed or added relevant lines in **0** files are covered.

[jira] [Commented] (KYLIN-4394) Upgrade dependency version for several CVEs

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132848#comment-17132848 ] ASF GitHub Bot commented on KYLIN-4394: --- coveralls commented on pull request #1253:

[jira] [Commented] (KYLIN-4556) improve job service

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132849#comment-17132849 ] ASF GitHub Bot commented on KYLIN-4556: --- guangxuCheng opened a new pull request #12

[GitHub] [kylin] guangxuCheng opened a new pull request #1254: KYLIN-4556 improve job service

2020-06-10 Thread GitBox
guangxuCheng opened a new pull request #1254: URL: https://github.com/apache/kylin/pull/1254 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, b

[GitHub] [kylin] coveralls edited a comment on pull request #1218: KYLIN-4485 Create a self service interface for cube migration

2020-06-10 Thread GitBox
coveralls edited a comment on pull request #1218: URL: https://github.com/apache/kylin/pull/1218#issuecomment-631287497 ## Pull Request Test Coverage Report for [Build 6003](https://coveralls.io/builds/31380511) * **357** of **2239** **(15.94%)** changed or added relevant lines in

[jira] [Commented] (KYLIN-4556) improve job service

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132863#comment-17132863 ] ASF GitHub Bot commented on KYLIN-4556: --- codecov-commenter commented on pull reques

[GitHub] [kylin] codecov-commenter commented on pull request #1254: KYLIN-4556 improve job service

2020-06-10 Thread GitBox
codecov-commenter commented on pull request #1254: URL: https://github.com/apache/kylin/pull/1254#issuecomment-642377061 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1254?src=pr&el=h1) Report > Merging [#1254](https://codecov.io/gh/apache/kylin/pull/1254?src=pr&el=desc) into [mas

[jira] [Commented] (KYLIN-4485) Create a self service interface for cube migration

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132865#comment-17132865 ] ASF GitHub Bot commented on KYLIN-4485: --- coveralls edited a comment on pull request

[GitHub] [kylin] coveralls commented on pull request #1254: KYLIN-4556 improve job service

2020-06-10 Thread GitBox
coveralls commented on pull request #1254: URL: https://github.com/apache/kylin/pull/1254#issuecomment-642378044 ## Pull Request Test Coverage Report for [Build 6002](https://coveralls.io/builds/31380549) * **0** of **123** **(0.0%)** changed or added relevant lines in **4** file

[jira] [Commented] (KYLIN-4556) improve job service

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132868#comment-17132868 ] ASF GitHub Bot commented on KYLIN-4556: --- coveralls commented on pull request #1254:

[GitHub] [kylin] lgtm-com[bot] commented on pull request #1218: KYLIN-4485 Create a self service interface for cube migration

2020-06-10 Thread GitBox
lgtm-com[bot] commented on pull request #1218: URL: https://github.com/apache/kylin/pull/1218#issuecomment-642378756 This pull request **introduces 2 alerts** when merging aa2b4811955fbf3278bf2fb8cd8b68e6b3ef2dbd into c1705947dc2c04d084a4bf3f4ad15877e1c50b2c - [view on LGTM.com](https://l

[jira] [Commented] (KYLIN-4485) Create a self service interface for cube migration

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132869#comment-17132869 ] ASF GitHub Bot commented on KYLIN-4485: --- lgtm-com[bot] commented on pull request #1

[GitHub] [kylin] codecov-commenter edited a comment on pull request #1218: KYLIN-4485 Create a self service interface for cube migration

2020-06-10 Thread GitBox
codecov-commenter edited a comment on pull request #1218: URL: https://github.com/apache/kylin/pull/1218#issuecomment-631513549 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1218?src=pr&el=h1) Report > Merging [#1218](https://codecov.io/gh/apache/kylin/pull/1218?src=pr&el=desc) int

[jira] [Commented] (KYLIN-4485) Create a self service interface for cube migration

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132896#comment-17132896 ] ASF GitHub Bot commented on KYLIN-4485: --- codecov-commenter edited a comment on pull

[GitHub] [kylin] RupengWang commented on a change in pull request #1244: Minor, refactor

2020-06-10 Thread GitBox
RupengWang commented on a change in pull request #1244: URL: https://github.com/apache/kylin/pull/1244#discussion_r438562273 ## File path: server-base/src/main/java/org/apache/kylin/rest/controller/AdminController.java ## @@ -118,11 +116,6 @@ public void cleanupStorage() {

[GitHub] [kylin] codecov-commenter edited a comment on pull request #1244: Minor, refactor

2020-06-10 Thread GitBox
codecov-commenter edited a comment on pull request #1244: URL: https://github.com/apache/kylin/pull/1244#issuecomment-640421214 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1244?src=pr&el=h1) Report > Merging [#1244](https://codecov.io/gh/apache/kylin/pull/1244?src=pr&el=desc) int

[GitHub] [kylin] RupengWang commented on a change in pull request #1244: Minor, refactor

2020-06-10 Thread GitBox
RupengWang commented on a change in pull request #1244: URL: https://github.com/apache/kylin/pull/1244#discussion_r438562273 ## File path: server-base/src/main/java/org/apache/kylin/rest/controller/AdminController.java ## @@ -118,11 +116,6 @@ public void cleanupStorage() {

[GitHub] [kylin] coveralls edited a comment on pull request #1244: Minor, refactor

2020-06-10 Thread GitBox
coveralls edited a comment on pull request #1244: URL: https://github.com/apache/kylin/pull/1244#issuecomment-641042468 ## Pull Request Test Coverage Report for [Build 6004](https://coveralls.io/builds/31382819) * **3** of **10** **(30.0%)** changed or added relevant lines in **5*

[GitHub] [kylin] codecov-commenter edited a comment on pull request #1244: Minor, refactor

2020-06-10 Thread GitBox
codecov-commenter edited a comment on pull request #1244: URL: https://github.com/apache/kylin/pull/1244#issuecomment-640421214 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1244?src=pr&el=h1) Report > Merging [#1244](https://codecov.io/gh/apache/kylin/pull/1244?src=pr&el=desc) int

[GitHub] [kylin] coveralls edited a comment on pull request #1244: Minor, refactor

2020-06-10 Thread GitBox
coveralls edited a comment on pull request #1244: URL: https://github.com/apache/kylin/pull/1244#issuecomment-641042468 ## Pull Request Test Coverage Report for [Build 6005](https://coveralls.io/builds/31383147) * **3** of **10** **(30.0%)** changed or added relevant lines in **5*

[GitHub] [kylin] coveralls edited a comment on pull request #1254: KYLIN-4556 improve job service

2020-06-10 Thread GitBox
coveralls edited a comment on pull request #1254: URL: https://github.com/apache/kylin/pull/1254#issuecomment-642378044 ## Pull Request Test Coverage Report for [Build 6006](https://coveralls.io/builds/31383209) * **0** of **124** **(0.0%)** changed or added relevant lines in **4*

[jira] [Commented] (KYLIN-4556) improve job service

2020-06-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KYLIN-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132973#comment-17132973 ] ASF GitHub Bot commented on KYLIN-4556: --- coveralls edited a comment on pull request