[GitHub] [kylin] hit-lacus commented on a change in pull request #1376: KYLIN-4698 Delete segment storage path after merging segment, deleting segment and droping cube

hit-lacus commented on a change in pull request #1376: URL: https://github.com/apache/kylin/pull/1376#discussion_r477951578 ## File path: server/src/main/resources/applicationContext.xml ## @@ -38,6 +38,7 @@ + Review comment: Please update here. --

[GitHub] [kylin] hit-lacus commented on a change in pull request #1376: KYLIN-4698 Delete segment storage path after merging segment, deleting segment and droping cube

hit-lacus commented on a change in pull request #1376: URL: https://github.com/apache/kylin/pull/1376#discussion_r477945116 ## File path: kylin-spark-project/kylin-spark-engine/src/test/java/org/apache/kylin/engine/spark/LocalWithSparkSessionTest.java ## @@ -191,7 +201,15 @@ p

[GitHub] [kylin] hit-lacus commented on a change in pull request #1376: KYLIN-4698 Delete segment storage path after merging segment, deleting segment and droping cube

hit-lacus commented on a change in pull request #1376: URL: https://github.com/apache/kylin/pull/1376#discussion_r477937494 ## File path: core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java ## @@ -307,6 +307,7 @@ public String getHdfsWorkingDirectory() {

[GitHub] [kylin] hit-lacus commented on a change in pull request #1376: KYLIN-4698 Delete segment storage path after merging segment, deleting segment and droping cube

hit-lacus commented on a change in pull request #1376: URL: https://github.com/apache/kylin/pull/1376#discussion_r477948867 ## File path: server-base/src/main/java/org/apache/kylin/rest/init/InitialSparkerContext.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software

[GitHub] [kylin] hit-lacus commented on a change in pull request #1376: KYLIN-4698 Delete segment storage path after merging segment, deleting segment and droping cube

hit-lacus commented on a change in pull request #1376: URL: https://github.com/apache/kylin/pull/1376#discussion_r477946492 ## File path: server-base/src/main/java/org/apache/kylin/rest/init/InitialSparkerContext.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software

[GitHub] [kylin] hit-lacus commented on a change in pull request #1376: KYLIN-4698 Delete segment storage path after merging segment, deleting segment and droping cube

hit-lacus commented on a change in pull request #1376: URL: https://github.com/apache/kylin/pull/1376#discussion_r477947020 ## File path: server-base/src/main/java/org/apache/kylin/rest/init/InitialSparkerContext.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software

[GitHub] [kylin] hit-lacus commented on a change in pull request #1376: KYLIN-4698 Delete segment storage path after merging segment, deleting segment and droping cube

hit-lacus commented on a change in pull request #1376: URL: https://github.com/apache/kylin/pull/1376#discussion_r477945116 ## File path: kylin-spark-project/kylin-spark-engine/src/test/java/org/apache/kylin/engine/spark/LocalWithSparkSessionTest.java ## @@ -191,7 +201,15 @@ p

[GitHub] [kylin] hit-lacus commented on a change in pull request #1376: KYLIN-4698 Delete segment storage path after merging segment, deleting segment and droping cube

hit-lacus commented on a change in pull request #1376: URL: https://github.com/apache/kylin/pull/1376#discussion_r477937494 ## File path: core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java ## @@ -307,6 +307,7 @@ public String getHdfsWorkingDirectory() {