[GitHub] Aaaaaaron commented on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex…

2018-11-04 Thread GitBox
Aaron commented on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-435768040 When "totalWeight" is 0, means there are no nodes, so "thisWeight" is 0 too. --

[GitHub] Aaaaaaron commented on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex…

2018-11-02 Thread GitBox
Aaron commented on issue #326: KYLIN-3597, fix the critical bug reported by sonar: Make sure this ex… URL: https://github.com/apache/kylin/pull/326#issuecomment-43496 Hi @shaofengshi, I do a simple modify just change the init value, could you assess if this change is correct?