[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2016-10-27 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612068#comment-15612068 ] Shaofeng SHI commented on KYLIN-2135: - hi kaisen, what's the cardinality of the larges

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2016-10-30 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621315#comment-15621315 ] Shaofeng SHI commented on KYLIN-2135: - thanks Kaisen, I'm reviewing this, will update

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2016-10-31 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15624018#comment-15624018 ] Shaofeng SHI commented on KYLIN-2135: - which is the base version that making the patch

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2016-10-31 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15624044#comment-15624044 ] Shaofeng SHI commented on KYLIN-2135: - I have couple of comments for the patch: 1. th

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2016-10-31 Thread kangkaisen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15624112#comment-15624112 ] kangkaisen commented on KYLIN-2135: --- This patch is created from master branch. I use {{g

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2016-10-31 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15624163#comment-15624163 ] Shaofeng SHI commented on KYLIN-2135: - Thanks, I retried and this time it got success

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2016-10-31 Thread kangkaisen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15624568#comment-15624568 ] kangkaisen commented on KYLIN-2135: --- Hi, Shaofeng, thanks very much for your review and

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2016-11-01 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15624616#comment-15624616 ] Shaofeng SHI commented on KYLIN-2135: - Hi Kaisen, 1. The UHC column is very common; t

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2016-11-01 Thread kangkaisen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15624655#comment-15624655 ] kangkaisen commented on KYLIN-2135: --- OK, I see it. Thanks you. > Enlarge FactDistinctCo

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2016-11-03 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632361#comment-15632361 ] Shaofeng SHI commented on KYLIN-2135: - Looks good; will run a full regression test for

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2016-11-08 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15647584#comment-15647584 ] Shaofeng SHI commented on KYLIN-2135: - CI passed, merged into master (after resovling

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2016-11-08 Thread kangkaisen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15647678#comment-15647678 ] kangkaisen commented on KYLIN-2135: --- OK，thanks you. I will add test case later. > Enlar

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2016-11-15 Thread XIE FAN (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669277#comment-15669277 ] XIE FAN commented on KYLIN-2135: Can we specify different reducers number for different co

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2016-11-16 Thread kangkaisen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672686#comment-15672686 ] kangkaisen commented on KYLIN-2135: --- Hi, [~xiefan46]. We only enlarge the reducer number

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2016-11-17 Thread XIE FAN (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15673396#comment-15673396 ] XIE FAN commented on KYLIN-2135: Oh,I see. Thank you. > Enlarge FactDistinctColumns reduc

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2016-12-08 Thread kangkaisen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15731733#comment-15731733 ] kangkaisen commented on KYLIN-2135: --- Hi，Shaofeng. I am sorry to delay to add the test.

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2017-01-12 Thread kangkaisen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15820909#comment-15820909 ] kangkaisen commented on KYLIN-2135: --- Hi, Shaofeng. I think It is maybe unlikely add UT

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2017-01-12 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821080#comment-15821080 ] Shaofeng SHI commented on KYLIN-2135: - Thanks for investigating this; we want to contr

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2017-01-19 Thread Shaofeng SHI (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829672#comment-15829672 ] Shaofeng SHI commented on KYLIN-2135: - I discussed this with xiefan, when multiple red

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2017-01-19 Thread kangkaisen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829685#comment-15829685 ] kangkaisen commented on KYLIN-2135: --- I see. KYLIN-2135 and KYLIN-2217 don't conflict it

[jira] [Commented] (KYLIN-2135) Enlarge FactDistinctColumns reducer number

2017-02-10 Thread kangkaisen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861001#comment-15861001 ] kangkaisen commented on KYLIN-2135: --- The IT has covered KYLIN-2135. > Enlarge FactDist