[jira] [Commented] (KYLIN-2192) More Robust Global Dictionary

[ https://issues.apache.org/jira/browse/KYLIN-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735518#comment-15735518 ] Dayue Gao commented on KYLIN-2192: -- Found a bug in AppendTrieDictionary, which cause Kylin to load all

[jira] [Commented] (KYLIN-2192) More Robust Global Dictionary

[ https://issues.apache.org/jira/browse/KYLIN-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15688986#comment-15688986 ] Shaofeng SHI commented on KYLIN-2192: - Thanks Yerui; The community has been waiting 1.6.0 for some

[jira] [Commented] (KYLIN-2192) More Robust Global Dictionary

[ https://issues.apache.org/jira/browse/KYLIN-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15688549#comment-15688549 ] Shaofeng SHI commented on KYLIN-2192: - The IT is failed last night at "ITInMemCubeBuilderTest", the

[jira] [Commented] (KYLIN-2192) More Robust Global Dictionary

[ https://issues.apache.org/jira/browse/KYLIN-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15686370#comment-15686370 ] Shaofeng SHI commented on KYLIN-2192: - change "if (id < 0)" to "if (id == -1)" should be better; -1

[jira] [Commented] (KYLIN-2192) More Robust Global Dictionary

[ https://issues.apache.org/jira/browse/KYLIN-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15686289#comment-15686289 ] Shaofeng SHI commented on KYLIN-2192: - For backward compitable, we couldn't change the decoding logic

[jira] [Commented] (KYLIN-2192) More Robust Global Dictionary

[ https://issues.apache.org/jira/browse/KYLIN-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15686128#comment-15686128 ] Yerui Sun commented on KYLIN-2192: -- Shaofeng, the reason to change "if (id < 0)" to "if (isNullId(id))"

[jira] [Commented] (KYLIN-2192) More Robust Global Dictionary

[ https://issues.apache.org/jira/browse/KYLIN-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15685931#comment-15685931 ] Shaofeng SHI commented on KYLIN-2192: - Applied the patch in KYLIN-2192 branch; "mvn test" failed with

[jira] [Commented] (KYLIN-2192) More Robust Global Dictionary

[ https://issues.apache.org/jira/browse/KYLIN-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15685821#comment-15685821 ] Shaofeng SHI commented on KYLIN-2192: - Hi Yerui [~sunyerui], in the Dictionary.java, line 161, I see

[jira] [Commented] (KYLIN-2192) More Robust Global Dictionary

[ https://issues.apache.org/jira/browse/KYLIN-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15678916#comment-15678916 ] Shaofeng SHI commented on KYLIN-2192: - [~sunyerui] no patch uploaded, could you please upload again?