[jira] [Commented] (KYLIN-2237) Ensure dimensions and measures of model don't have null column

2016-12-08 Thread kangkaisen (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15731611#comment-15731611 ] kangkaisen commented on KYLIN-2237: --- I agree with you. we need coding convention , codin

[jira] [Commented] (KYLIN-2237) Ensure dimensions and measures of model don't have null column

2016-12-08 Thread liyang (JIRA)
[ https://issues.apache.org/jira/browse/KYLIN-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15731559#comment-15731559 ] liyang commented on KYLIN-2237: --- [~zhongjian], you want to double check the JS part? Java p