[
https://issues.apache.org/jira/browse/KYLIN-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407736#comment-16407736
]
ASF subversion and git services commented on KYLIN-3270:
Commit
[
https://issues.apache.org/jira/browse/KYLIN-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407472#comment-16407472
]
Zhong Yanghong commented on KYLIN-3270:
---
This patch is conflicted with commitÂ
[
https://issues.apache.org/jira/browse/KYLIN-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407467#comment-16407467
]
Dong Li commented on KYLIN-3270:
I did a "git am" on master branch, but not tried on 2.3.x branch.
> Add
[
https://issues.apache.org/jira/browse/KYLIN-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407417#comment-16407417
]
Shaofeng SHI commented on KYLIN-3270:
-
The patch has been successfully applied in the 2.3.x branch.
[
https://issues.apache.org/jira/browse/KYLIN-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407412#comment-16407412
]
Shaofeng SHI commented on KYLIN-3270:
-
I can apply the patch without any issue. Dong, what commands
[
https://issues.apache.org/jira/browse/KYLIN-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407413#comment-16407413
]
ASF subversion and git services commented on KYLIN-3270:
Commit
[
https://issues.apache.org/jira/browse/KYLIN-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398177#comment-16398177
]
Dong Li commented on KYLIN-3270:
+1 LGTM
But the patch cannot be applied because a rebase is needed...
[
https://issues.apache.org/jira/browse/KYLIN-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396389#comment-16396389
]
Shaofeng SHI commented on KYLIN-3270:
-
+1 LGTM
> Add integration test for Optimize Job
>
[
https://issues.apache.org/jira/browse/KYLIN-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385533#comment-16385533
]
Zhong Yanghong commented on KYLIN-3270:
---
The bugs caused by the refactor will block cube