[GitHub] [kylin] guangxuCheng commented on pull request #1254: KYLIN-4556 improve job service

2020-08-11 Thread GitBox
guangxuCheng commented on pull request #1254: URL: https://github.com/apache/kylin/pull/1254#issuecomment-672557732 @zhangayqian @shaofengshi I had fixed conflicts, can you take a look again? Thanks This is an automated mess

[GitHub] [kylin] hit-lacus commented on pull request #1353: KYLIN-4692: Receiver segment name error

2020-08-11 Thread GitBox
hit-lacus commented on pull request #1353: URL: https://github.com/apache/kylin/pull/1353#issuecomment-672565050 Actually, as far as I know, use UTC other than local time zone is not a mistake, it is by design. This is an au

[GitHub] [kylin] hit-lacus edited a comment on pull request #1353: KYLIN-4692: Receiver segment name error

2020-08-11 Thread GitBox
hit-lacus edited a comment on pull request #1353: URL: https://github.com/apache/kylin/pull/1353#issuecomment-672565050 Actually, as far as I know, use UTC other than local time zone is not a mistake, it is by design. I don't want to annoy you, but, honestly, if you didn't have fullly u

[GitHub] [kylin] hit-lacus commented on pull request #1254: KYLIN-4556 improve job service

2020-08-11 Thread GitBox
hit-lacus commented on pull request #1254: URL: https://github.com/apache/kylin/pull/1254#issuecomment-672568377 A nice feature! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kylin] coveralls commented on pull request #1353: KYLIN-4692: Receiver segment name error

2020-08-11 Thread GitBox
coveralls commented on pull request #1353: URL: https://github.com/apache/kylin/pull/1353#issuecomment-672570182 ## Pull Request Test Coverage Report for [Build 6241](https://coveralls.io/builds/32694579) * **1** of **2** **(50.0%)** changed or added relevant lines in **2** files

[GitHub] [kylin] coveralls edited a comment on pull request #1254: KYLIN-4556 improve job service

2020-08-11 Thread GitBox
coveralls edited a comment on pull request #1254: URL: https://github.com/apache/kylin/pull/1254#issuecomment-642378044 ## Pull Request Test Coverage Report for [Build 6242](https://coveralls.io/builds/32694621) * **5** of **121** **(4.13%)** changed or added relevant lines in **4

[GitHub] [kylin] zzcclp opened a new pull request #1354: KYLIN-4662 Migrate from third-party Spark to offical Apache Spark

2020-08-11 Thread GitBox
zzcclp opened a new pull request #1354: URL: https://github.com/apache/kylin/pull/1354 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure

[GitHub] [kylin] zzcclp commented on pull request #1354: KYLIN-4662 Migrate from third-party Spark to offical Apache Spark

2020-08-11 Thread GitBox
zzcclp commented on pull request #1354: URL: https://github.com/apache/kylin/pull/1354#issuecomment-672574139 manually run test cases successfully , command: `mvn clean -Dpre-commit apache-rat:check test -Dlicense.skip=false ` ---

[GitHub] [kylin] tianhui5 commented on pull request #1353: KYLIN-4692: Receiver segment name error

2020-08-11 Thread GitBox
tianhui5 commented on pull request #1353: URL: https://github.com/apache/kylin/pull/1353#issuecomment-672590325 > Actually, as far as I know, use UTC other than local time zone is not a mistake, it is by design. > I don't want to annoy you, but, honestly, if you didn't have fullly under

[GitHub] [kylin] hit-lacus commented on pull request #1353: KYLIN-4692: Receiver segment name error

2020-08-11 Thread GitBox
hit-lacus commented on pull request #1353: URL: https://github.com/apache/kylin/pull/1353#issuecomment-672622630 OK, thank you for your kindness, here is what I can find, please take a look: - https://issues.apache.org/jira/browse/KYLIN-4672 - https://issues.apache.org/jira/browse/KYLI

[GitHub] [kylin] Lujiusi opened a new pull request #1355: Update README.md

2020-08-11 Thread GitBox
Lujiusi opened a new pull request #1355: URL: https://github.com/apache/kylin/pull/1355 asdfasfasf ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a featu

[GitHub] [kylin] Lujiusi commented on pull request #1355: Update README.md

2020-08-11 Thread GitBox
Lujiusi commented on pull request #1355: URL: https://github.com/apache/kylin/pull/1355#issuecomment-672634708 dsfasdfasdfasdfaf This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kylin] coveralls commented on pull request #1355: Update README.md

2020-08-12 Thread GitBox
coveralls commented on pull request #1355: URL: https://github.com/apache/kylin/pull/1355#issuecomment-672677612 ## Pull Request Test Coverage Report for [Build 6244](https://coveralls.io/builds/32696874) * **0** of **0** changed or added relevant lines in **0** files are covered.

[GitHub] [kylin] guangxuCheng opened a new pull request #1356: KYLIN-4687 addendum - add apache license header

2020-08-12 Thread GitBox
guangxuCheng opened a new pull request #1356: URL: https://github.com/apache/kylin/pull/1356 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, b

[GitHub] [kylin] guangxuCheng commented on pull request #1349: KYLIN-4687 add unify clean sh to excute some clean shells

2020-08-12 Thread GitBox
guangxuCheng commented on pull request #1349: URL: https://github.com/apache/kylin/pull/1349#issuecomment-672688877 @hit-lacus The new file is missing the apache license, which causes the rat check to fail. I create a new pr to fix it. https://github.com/apache/kylin/pull/1356

[GitHub] [kylin] guangxuCheng commented on pull request #1254: KYLIN-4556 improve job service

2020-08-12 Thread GitBox
guangxuCheng commented on pull request #1254: URL: https://github.com/apache/kylin/pull/1254#issuecomment-672690026 The failed check is caused by #1349, I have open a new pr #1356 to fix it This is an automated message from t

[GitHub] [kylin] hit-lacus commented on pull request #1254: KYLIN-4556 improve job service

2020-08-12 Thread GitBox
hit-lacus commented on pull request #1254: URL: https://github.com/apache/kylin/pull/1254#issuecomment-672711464 Oh, my mistake. I apprecaite it, I forget to check the license header. This is an automated message from the Apa

[GitHub] [kylin] hit-lacus commented on pull request #1356: KYLIN-4687 addendum - add apache license header

2020-08-12 Thread GitBox
hit-lacus commented on pull request #1356: URL: https://github.com/apache/kylin/pull/1356#issuecomment-672712162 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kylin] hit-lacus merged pull request #1356: KYLIN-4687 addendum - add apache license header

2020-08-12 Thread GitBox
hit-lacus merged pull request #1356: URL: https://github.com/apache/kylin/pull/1356 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1356: KYLIN-4687 addendum - add apache license header

2020-08-12 Thread GitBox
hit-lacus commented on pull request #1356: URL: https://github.com/apache/kylin/pull/1356#issuecomment-672712042 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kylin] hit-lacus removed a comment on pull request #1356: KYLIN-4687 addendum - add apache license header

2020-08-12 Thread GitBox
hit-lacus removed a comment on pull request #1356: URL: https://github.com/apache/kylin/pull/1356#issuecomment-672712162 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kylin] coveralls commented on pull request #1356: KYLIN-4687 addendum - add apache license header

2020-08-12 Thread GitBox
coveralls commented on pull request #1356: URL: https://github.com/apache/kylin/pull/1356#issuecomment-672743442 ## Pull Request Test Coverage Report for [Build 6245](https://coveralls.io/builds/32698479) * **0** of **0** changed or added relevant lines in **0** files are covered.

[GitHub] [kylin] hit-lacus commented on pull request #1354: KYLIN-4662 Migrate from third-party Spark to offical Apache Spark

2020-08-12 Thread GitBox
hit-lacus commented on pull request #1354: URL: https://github.com/apache/kylin/pull/1354#issuecomment-672888369 This patch has some unpredictable performance lose impact on both build engine and query engine. But I think we can merge it and do a benchmark to analyse the difference . So

[GitHub] [kylin] hit-lacus commented on pull request #1354: KYLIN-4662 Migrate from third-party Spark to offical Apache Spark

2020-08-12 Thread GitBox
hit-lacus commented on pull request #1354: URL: https://github.com/apache/kylin/pull/1354#issuecomment-672890438 In general, this look good to me. This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [kylin] hit-lacus merged pull request #1354: KYLIN-4662 Migrate from third-party Spark to offical Apache Spark

2020-08-12 Thread GitBox
hit-lacus merged pull request #1354: URL: https://github.com/apache/kylin/pull/1354 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] zzcclp opened a new pull request #1357: KYLIN-4694 Fix 'NoClassDefFoundError: Lcom/esotericsoftware/kryo/io/Output' when query with sparder on yarn

2020-08-13 Thread GitBox
zzcclp opened a new pull request #1357: URL: https://github.com/apache/kylin/pull/1357 Fix 'NoClassDefFoundError: Lcom/esotericsoftware/kryo/io/Output' when query with sparder on yarn. Root cause: Class 'com/esotericsoftware/kryo/io/Output' is loaded by SparkClassLoader, but ther

[GitHub] [kylin] hit-lacus commented on pull request #1357: KYLIN-4694 Fix 'NoClassDefFoundError: Lcom/esotericsoftware/kryo/io/Output' when query with sparder on yarn

2020-08-13 Thread GitBox
hit-lacus commented on pull request #1357: URL: https://github.com/apache/kylin/pull/1357#issuecomment-673861650 LGTM Thank you @zzcclp . This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kylin] hit-lacus merged pull request #1357: KYLIN-4694 Fix 'NoClassDefFoundError: Lcom/esotericsoftware/kryo/io/Output' when query with sparder on yarn

2020-08-13 Thread GitBox
hit-lacus merged pull request #1357: URL: https://github.com/apache/kylin/pull/1357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] coveralls edited a comment on pull request #1311: KYLIN-4626 add set kylin home shell

2020-08-13 Thread GitBox
coveralls edited a comment on pull request #1311: URL: https://github.com/apache/kylin/pull/1311#issuecomment-655848303 ## Pull Request Test Coverage Report for [Build 6249](https://coveralls.io/builds/32749993) * **0** of **0** changed or added relevant lines in **0** files are c

[GitHub] [kylin] ITzhangqiang opened a new pull request #1358: KYLIN-4688 Too many tmp files in HDFS tmp dictionary

2020-08-14 Thread GitBox
ITzhangqiang opened a new pull request #1358: URL: https://github.com/apache/kylin/pull/1358 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, b

[GitHub] [kylin] ITzhangqiang closed pull request #1358: KYLIN-4688 Too many tmp files in HDFS tmp dictionary

2020-08-14 Thread GitBox
ITzhangqiang closed pull request #1358: URL: https://github.com/apache/kylin/pull/1358 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kylin] ITzhangqiang opened a new pull request #1359: KYLIN-4688 Too many tmp files in HDFS tmp dictionary

2020-08-14 Thread GitBox
ITzhangqiang opened a new pull request #1359: URL: https://github.com/apache/kylin/pull/1359 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, b

[GitHub] [kylin] ITzhangqiang closed pull request #1359: KYLIN-4688 Too many tmp files in HDFS tmp dictionary

2020-08-14 Thread GitBox
ITzhangqiang closed pull request #1359: URL: https://github.com/apache/kylin/pull/1359 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kylin] ITzhangqiang opened a new pull request #1360: KYLIN-4688 Too many tmp files in HDFS tmp dictionary

2020-08-14 Thread GitBox
ITzhangqiang opened a new pull request #1360: URL: https://github.com/apache/kylin/pull/1360 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, b

[GitHub] [kylin] coveralls commented on pull request #1360: KYLIN-4688 Too many tmp files in HDFS tmp dictionary

2020-08-14 Thread GitBox
coveralls commented on pull request #1360: URL: https://github.com/apache/kylin/pull/1360#issuecomment-674018555 ## Pull Request Test Coverage Report for [Build 6252](https://coveralls.io/builds/32756950) * **0** of **4** **(0.0%)** changed or added relevant lines in **1** file a

[GitHub] [kylin] RupengWang opened a new pull request #1361: KYLIN-4700 Wrong engine type for realtime streaming

2020-08-14 Thread GitBox
RupengWang opened a new pull request #1361: URL: https://github.com/apache/kylin/pull/1361 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be

[GitHub] [kylin] coveralls commented on pull request #1361: KYLIN-4700 Wrong engine type for realtime streaming

2020-08-14 Thread GitBox
coveralls commented on pull request #1361: URL: https://github.com/apache/kylin/pull/1361#issuecomment-674095242 ## Pull Request Test Coverage Report for [Build 6253](https://coveralls.io/builds/32760241) * **0** of **0** changed or added relevant lines in **0** files are covered.

[GitHub] [kylin] shaofengshi opened a new pull request #1362: minor, fix sonar reported bugs

2020-08-15 Thread GitBox
shaofengshi opened a new pull request #1362: URL: https://github.com/apache/kylin/pull/1362 ## Proposed changes fix several sonar reported bugs or issues: https://sonarcloud.io/project/issues?id=org.apache.kylin%3Akylin&resolved=false&severities=BLOCKER&types=BUG ## Types of c

[GitHub] [kylin] coveralls commented on pull request #1362: minor, fix sonar reported bugs

2020-08-15 Thread GitBox
coveralls commented on pull request #1362: URL: https://github.com/apache/kylin/pull/1362#issuecomment-674414449 ## Pull Request Test Coverage Report for [Build 6256](https://coveralls.io/builds/32777698) * **16** of **65** **(24.62%)** changed or added relevant lines in **12** f

[GitHub] [kylin] lgtm-com[bot] commented on pull request #1362: minor, fix sonar reported bugs

2020-08-15 Thread GitBox
lgtm-com[bot] commented on pull request #1362: URL: https://github.com/apache/kylin/pull/1362#issuecomment-674415595 This pull request **introduces 1 alert** and **fixes 4** when merging 3a05a5d72d3d3022d60a0ea362c5e254e1078da3 into 28c21ef6127a72d960a66ac44b46ea57df62dbb8 - [view on LGTM

[GitHub] [kylin] shaofengshi commented on pull request #1362: minor, fix sonar reported bugs

2020-08-15 Thread GitBox
shaofengshi commented on pull request #1362: URL: https://github.com/apache/kylin/pull/1362#issuecomment-674460258 Has passed integration test. This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [kylin] shaofengshi opened a new pull request #1363: Fix sonar vulunerability issues

2020-08-16 Thread GitBox
shaofengshi opened a new pull request #1363: URL: https://github.com/apache/kylin/pull/1363 ## Proposed changes Another batch of fix for static code issues reported by sonar. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in t

[GitHub] [kylin] coveralls commented on pull request #1363: Fix sonar vulunerability issues

2020-08-16 Thread GitBox
coveralls commented on pull request #1363: URL: https://github.com/apache/kylin/pull/1363#issuecomment-674500526 ## Pull Request Test Coverage Report for [Build 6257](https://coveralls.io/builds/32783199) * **5** of **75** **(6.67%)** changed or added relevant lines in **25** fil

[GitHub] [kylin] coveralls edited a comment on pull request #1363: Fix sonar vulunerability issues

2020-08-16 Thread GitBox
coveralls edited a comment on pull request #1363: URL: https://github.com/apache/kylin/pull/1363#issuecomment-674500526 ## Pull Request Test Coverage Report for [Build 6259](https://coveralls.io/builds/32785063) * **11** of **87** **(12.64%)** changed or added relevant lines in **

[GitHub] [kylin] coveralls edited a comment on pull request #1363: Fix sonar vulunerability issues

2020-08-16 Thread GitBox
coveralls edited a comment on pull request #1363: URL: https://github.com/apache/kylin/pull/1363#issuecomment-674500526 ## Pull Request Test Coverage Report for [Build 6260](https://coveralls.io/builds/32789109) * **13** of **89** **(14.61%)** changed or added relevant lines in **

[GitHub] [kylin] hit-lacus opened a new pull request #1364: KYLIN-4701 Front end change for Parquet Storage

2020-08-16 Thread GitBox
hit-lacus opened a new pull request #1364: URL: https://github.com/apache/kylin/pull/1364 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be s

[GitHub] [kylin] zhangayqian opened a new pull request #1365: Optimize pushdown document

2020-08-16 Thread GitBox
zhangayqian opened a new pull request #1365: URL: https://github.com/apache/kylin/pull/1365 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be

[GitHub] [kylin] shaofengshi closed pull request #1355: Update README.md

2020-08-17 Thread GitBox
shaofengshi closed pull request #1355: URL: https://github.com/apache/kylin/pull/1355 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kylin] hit-lacus commented on pull request #1364: KYLIN-4701 Front end change for Parquet Storage

2020-08-17 Thread GitBox
hit-lacus commented on pull request #1364: URL: https://github.com/apache/kylin/pull/1364#issuecomment-674719574 Here is what I change. ### Remove Encoding and Length in CubeDesc Advanced Setting https://user-images.githubusercontent.com/14030549/90370540-221df800-e0a0-11ea-882

[GitHub] [kylin] hit-lacus edited a comment on pull request #1364: KYLIN-4701 Front end change for Parquet Storage

2020-08-17 Thread GitBox
hit-lacus edited a comment on pull request #1364: URL: https://github.com/apache/kylin/pull/1364#issuecomment-674719574 Here is what I change. ### Remove Encoding and Length in CubeDesc Advanced Setting https://user-images.githubusercontent.com/14030549/90370540-221df800-e0a0-1

[GitHub] [kylin] hit-lacus edited a comment on pull request #1364: KYLIN-4701 Front end change for Parquet Storage

2020-08-17 Thread GitBox
hit-lacus edited a comment on pull request #1364: URL: https://github.com/apache/kylin/pull/1364#issuecomment-674719574 Here is what I change. ### Remove Encoding and Length in CubeDesc Advanced Setting https://user-images.githubusercontent.com/14030549/90370540-221df800-e0a0-1

[GitHub] [kylin] lgtm-com[bot] commented on pull request #1364: KYLIN-4701 Front end change for Parquet Storage

2020-08-17 Thread GitBox
lgtm-com[bot] commented on pull request #1364: URL: https://github.com/apache/kylin/pull/1364#issuecomment-674730559 This pull request **fixes 1 alert** when merging 75c392ac4ee3cc8ef06704f12912785212849465 into 1b4e4c245e620f1c2ccfc1267c5f7bd9a382aa83 - [view on LGTM.com](https://lgtm.co

[GitHub] [kylin] xuekaiqi opened a new pull request #1366: update how to doc

2020-08-17 Thread GitBox
xuekaiqi opened a new pull request #1366: URL: https://github.com/apache/kylin/pull/1366 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be su

[GitHub] [kylin] lgtm-com[bot] commented on pull request #1364: KYLIN-4701 Front end change for Parquet Storage

2020-08-17 Thread GitBox
lgtm-com[bot] commented on pull request #1364: URL: https://github.com/apache/kylin/pull/1364#issuecomment-674814485 This pull request **fixes 1 alert** when merging b795f6e2029d1513ba3c43b8a45fb828ed3f2cb0 into 1b4e4c245e620f1c2ccfc1267c5f7bd9a382aa83 - [view on LGTM.com](https://lgtm.co

[GitHub] [kylin] hit-lacus merged pull request #1366: update how to doc

2020-08-17 Thread GitBox
hit-lacus merged pull request #1366: URL: https://github.com/apache/kylin/pull/1366 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1366: update how to doc

2020-08-17 Thread GitBox
hit-lacus commented on pull request #1366: URL: https://github.com/apache/kylin/pull/1366#issuecomment-675204006 Thank you @kaiqi. This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kylin] hit-lacus commented on a change in pull request #1365: Optimize pushdown document

2020-08-17 Thread GitBox
hit-lacus commented on a change in pull request #1365: URL: https://github.com/apache/kylin/pull/1365#discussion_r471869377 ## File path: website/_docs/tutorial/query_pushdown.md ## @@ -14,8 +14,10 @@ If a query can not be answered by any cube, Kylin supports pushing down such

[GitHub] [kylin] hit-lacus commented on a change in pull request #1365: Optimize pushdown document

2020-08-17 Thread GitBox
hit-lacus commented on a change in pull request #1365: URL: https://github.com/apache/kylin/pull/1365#discussion_r471880696 ## File path: website/_docs/tutorial/query_pushdown.md ## @@ -14,8 +14,10 @@ If a query can not be answered by any cube, Kylin supports pushing down such

[GitHub] [kylin] xuekaiqi commented on pull request #1366: update how to doc

2020-08-17 Thread GitBox
xuekaiqi commented on pull request #1366: URL: https://github.com/apache/kylin/pull/1366#issuecomment-675224996 Issue Link: https://issues.apache.org/jira/browse/KYLIN-4703 This is an automated message from the Apache Git

[GitHub] [kylin] hit-lacus commented on a change in pull request #1362: minor, fix sonar reported bugs

2020-08-17 Thread GitBox
hit-lacus commented on a change in pull request #1362: URL: https://github.com/apache/kylin/pull/1362#discussion_r471917346 ## File path: core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java ## @@ -109,6 +109,7 @@ public static Dictionary mergeDictionar

[GitHub] [kylin] hit-lacus commented on pull request #1361: KYLIN-4700 Wrong engine type for realtime streaming

2020-08-17 Thread GitBox
hit-lacus commented on pull request #1361: URL: https://github.com/apache/kylin/pull/1361#issuecomment-675265069 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kylin] hit-lacus merged pull request #1361: KYLIN-4700 Wrong engine type for realtime streaming

2020-08-17 Thread GitBox
hit-lacus merged pull request #1361: URL: https://github.com/apache/kylin/pull/1361 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1365: Optimize pushdown document

2020-08-17 Thread GitBox
hit-lacus commented on pull request #1365: URL: https://github.com/apache/kylin/pull/1365#issuecomment-675266242 Thank you @zhangayqian , this patch look fine to me. This is an automated message from the Apache Git

[GitHub] [kylin] hit-lacus merged pull request #1365: Optimize pushdown document

2020-08-17 Thread GitBox
hit-lacus merged pull request #1365: URL: https://github.com/apache/kylin/pull/1365 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] lgtm-com[bot] commented on pull request #1364: KYLIN-4701 Front end change for Parquet Storage

2020-08-18 Thread GitBox
lgtm-com[bot] commented on pull request #1364: URL: https://github.com/apache/kylin/pull/1364#issuecomment-675298087 This pull request **fixes 1 alert** when merging 07d90aaed128b6cb306825fae45270abcac060ce into 1b4e4c245e620f1c2ccfc1267c5f7bd9a382aa83 - [view on LGTM.com](https://lgtm.co

[GitHub] [kylin] hit-lacus commented on pull request #1363: Fix sonar vulunerability issues

2020-08-18 Thread GitBox
hit-lacus commented on pull request #1363: URL: https://github.com/apache/kylin/pull/1363#issuecomment-675515654 LGTM , thank you. This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kylin] hit-lacus merged pull request #1363: Fix sonar vulunerability issues

2020-08-18 Thread GitBox
hit-lacus merged pull request #1363: URL: https://github.com/apache/kylin/pull/1363 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1362: minor, fix sonar reported bugs

2020-08-18 Thread GitBox
hit-lacus commented on pull request #1362: URL: https://github.com/apache/kylin/pull/1362#issuecomment-675522417 This looks good to me. This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kylin] hit-lacus merged pull request #1362: minor, fix sonar reported bugs

2020-08-18 Thread GitBox
hit-lacus merged pull request #1362: URL: https://github.com/apache/kylin/pull/1362 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] zzcclp commented on a change in pull request #1360: KYLIN-4688 Too many tmp files in HDFS tmp dictionary

2020-08-18 Thread GitBox
zzcclp commented on a change in pull request #1360: URL: https://github.com/apache/kylin/pull/1360#discussion_r472589173 ## File path: storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CubeHFileJob.java ## @@ -101,6 +102,7 @@ public int run(String[] args) throws

[GitHub] [kylin] zzcclp commented on a change in pull request #1360: KYLIN-4688 Too many tmp files in HDFS tmp dictionary

2020-08-18 Thread GitBox
zzcclp commented on a change in pull request #1360: URL: https://github.com/apache/kylin/pull/1360#discussion_r472589799 ## File path: core-common/src/main/java/org/apache/kylin/common/util/HadoopUtil.java ## @@ -69,13 +68,6 @@ public static Configuration getCurrentConfigurati

[GitHub] [kylin] ITzhangqiang commented on a change in pull request #1360: KYLIN-4688 Too many tmp files in HDFS tmp dictionary

2020-08-18 Thread GitBox
ITzhangqiang commented on a change in pull request #1360: URL: https://github.com/apache/kylin/pull/1360#discussion_r472617186 ## File path: storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CubeHFileJob.java ## @@ -101,6 +102,7 @@ public int run(String[] args)

[GitHub] [kylin] xuekaiqi opened a new pull request #1367: Improve Development part in the website

2020-08-18 Thread GitBox
xuekaiqi opened a new pull request #1367: URL: https://github.com/apache/kylin/pull/1367 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be su

[GitHub] [kylin] zzcclp commented on a change in pull request #1360: KYLIN-4688 Too many tmp files in HDFS tmp dictionary

2020-08-18 Thread GitBox
zzcclp commented on a change in pull request #1360: URL: https://github.com/apache/kylin/pull/1360#discussion_r472731647 ## File path: storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CubeHFileJob.java ## @@ -101,6 +102,7 @@ public int run(String[] args) throws

[GitHub] [kylin] shaofengshi opened a new pull request #1368: minor, fix sonar reported bugs

2020-08-19 Thread GitBox
shaofengshi opened a new pull request #1368: URL: https://github.com/apache/kylin/pull/1368 ## Proposed changes Another batch of fix for sonar reported code bugs ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that

[GitHub] [kylin] codecov-commenter commented on pull request #1368: minor, fix sonar reported bugs

2020-08-19 Thread GitBox
codecov-commenter commented on pull request #1368: URL: https://github.com/apache/kylin/pull/1368#issuecomment-676002906 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1368?src=pr&el=h1) Report > Merging [#1368](https://codecov.io/gh/apache/kylin/pull/1368?src=pr&el=desc) into [mas

[GitHub] [kylin] coveralls commented on pull request #1368: minor, fix sonar reported bugs

2020-08-19 Thread GitBox
coveralls commented on pull request #1368: URL: https://github.com/apache/kylin/pull/1368#issuecomment-676970835 ## Pull Request Test Coverage Report for [Build 6270](https://coveralls.io/builds/32875545) * **38** of **108** **(35.19%)** changed or added relevant lines in **22**

[GitHub] [kylin] guangxuCheng opened a new pull request #1369: KYLIN-4711 Change default value to 3 for kylin.metadata.hbase-client-…

2020-08-20 Thread GitBox
guangxuCheng opened a new pull request #1369: URL: https://github.com/apache/kylin/pull/1369 …retries-number ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolv

[GitHub] [kylin] coveralls commented on pull request #1369: KYLIN-4711 Change default value to 3 for kylin.metadata.hbase-client-…

2020-08-20 Thread GitBox
coveralls commented on pull request #1369: URL: https://github.com/apache/kylin/pull/1369#issuecomment-678019215 ## Pull Request Test Coverage Report for [Build 6272](https://coveralls.io/builds/32903292) * **0** of **1** **(0.0%)** changed or added relevant line in **1** file ar

[GitHub] [kylin] tianhui5 commented on pull request #1351: KYLIN-4683 Fail to consume kafka when partition number get larger

2020-08-20 Thread GitBox
tianhui5 commented on pull request #1351: URL: https://github.com/apache/kylin/pull/1351#issuecomment-678068937 > > > Thank you for you effort that you spend on this issue, here is my suggestion, what do you think? > > > If `offset` is null, please just set it to zero. > > > >

[GitHub] [kylin] coveralls edited a comment on pull request #1368: minor, fix sonar reported bugs

2020-08-21 Thread GitBox
coveralls edited a comment on pull request #1368: URL: https://github.com/apache/kylin/pull/1368#issuecomment-676970835 ## Pull Request Test Coverage Report for [Build 6273](https://coveralls.io/builds/32914460) * **38** of **119** **(31.93%)** changed or added relevant lines in

[GitHub] [kylin] shaofengshi merged pull request #1214: KYLIN-4515 fix error with sending mail on ssl

2020-08-21 Thread GitBox
shaofengshi merged pull request #1214: URL: https://github.com/apache/kylin/pull/1214 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kylin] shaofengshi merged pull request #1285: KYLIN-4549 Show column cardinality in rowkeys area of advanced settings

2020-08-21 Thread GitBox
shaofengshi merged pull request #1285: URL: https://github.com/apache/kylin/pull/1285 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kylin] shaofengshi merged pull request #1277: Add cube count column for project table

2020-08-21 Thread GitBox
shaofengshi merged pull request #1277: URL: https://github.com/apache/kylin/pull/1277 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kylin] shaofengshi commented on pull request #1277: Add cube count column for project table

2020-08-21 Thread GitBox
shaofengshi commented on pull request #1277: URL: https://github.com/apache/kylin/pull/1277#issuecomment-678578933 Hi Tianhui, the code looks good; Next time, please provide the JIRA ID in the PR description, and the GIT commit message; I searched it in JIRA for a while, and then manually

[GitHub] [kylin] shaofengshi merged pull request #1287: KYLIN-4550 Provide advanced refresh interface inside the refresh panel

2020-08-21 Thread GitBox
shaofengshi merged pull request #1287: URL: https://github.com/apache/kylin/pull/1287 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kylin] shaofengshi merged pull request #1217: Add considerations for hbase-shad-client -*.jar

2020-08-21 Thread GitBox
shaofengshi merged pull request #1217: URL: https://github.com/apache/kylin/pull/1217 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kylin] hit-lacus commented on pull request #1368: minor, fix sonar reported bugs

2020-08-23 Thread GitBox
hit-lacus commented on pull request #1368: URL: https://github.com/apache/kylin/pull/1368#issuecomment-678746101 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kylin] hit-lacus merged pull request #1368: minor, fix sonar reported bugs

2020-08-23 Thread GitBox
hit-lacus merged pull request #1368: URL: https://github.com/apache/kylin/pull/1368 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1367: Improve Development part in the website

2020-08-23 Thread GitBox
hit-lacus commented on pull request #1367: URL: https://github.com/apache/kylin/pull/1367#issuecomment-678749343 This LGTM, I will have to preview your compiled webpage and merge this , thank you @xuekaiqi . This is an autom

[GitHub] [kylin] hit-lacus commented on pull request #1351: KYLIN-4683 Fail to consume kafka when partition number get larger

2020-08-23 Thread GitBox
hit-lacus commented on pull request #1351: URL: https://github.com/apache/kylin/pull/1351#issuecomment-678754154 Maybe you are right. Let me have a test and see if it is wroks. This is an automated message from the Apache Git

[GitHub] [kylin] hit-lacus commented on pull request #1335: KYLIN-4671 update log level for ignore too many logs

2020-08-23 Thread GitBox
hit-lacus commented on pull request #1335: URL: https://github.com/apache/kylin/pull/1335#issuecomment-678754255 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kylin] hit-lacus merged pull request #1335: KYLIN-4671 update log level for ignore too many logs

2020-08-23 Thread GitBox
hit-lacus merged pull request #1335: URL: https://github.com/apache/kylin/pull/1335 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1314: KYLIN-4628: Fail to use custom measure when specifying cube to query

2020-08-23 Thread GitBox
hit-lacus commented on pull request #1314: URL: https://github.com/apache/kylin/pull/1314#issuecomment-678758714 This looks good to me. This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kylin] hit-lacus merged pull request #1314: KYLIN-4628: Fail to use custom measure when specifying cube to query

2020-08-23 Thread GitBox
hit-lacus merged pull request #1314: URL: https://github.com/apache/kylin/pull/1314 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus merged pull request #1254: KYLIN-4556 improve job service

2020-08-23 Thread GitBox
hit-lacus merged pull request #1254: URL: https://github.com/apache/kylin/pull/1254 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1254: KYLIN-4556 improve job service

2020-08-23 Thread GitBox
hit-lacus commented on pull request #1254: URL: https://github.com/apache/kylin/pull/1254#issuecomment-678768733 Thank you very much, @guangxuCheng , this patch LGTM. This is an automated message from the Apache Git Service.

[GitHub] [kylin] hit-lacus merged pull request #1364: KYLIN-4701 Front end change for Parquet Storage

2020-08-23 Thread GitBox
hit-lacus merged pull request #1364: URL: https://github.com/apache/kylin/pull/1364 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] lgtm-com[bot] commented on pull request #1364: KYLIN-4701 Front end change for Parquet Storage

2020-08-23 Thread GitBox
lgtm-com[bot] commented on pull request #1364: URL: https://github.com/apache/kylin/pull/1364#issuecomment-678812460 This pull request **fixes 1 alert** when merging b09ea06d7af355ef8d8b7d9c1bc0af5a4878689d into 1b4e4c245e620f1c2ccfc1267c5f7bd9a382aa83 - [view on LGTM.com](https://lgtm.co

[GitHub] [kylin] guangxuCheng commented on pull request #1254: KYLIN-4556 improve job service

2020-08-23 Thread GitBox
guangxuCheng commented on pull request #1254: URL: https://github.com/apache/kylin/pull/1254#issuecomment-678889759 @hit-lacus Thanks for commiting. This is an automated message from the Apache Git Service. To respond to the

<    13   14   15   16   17   18   19   20   21   22   >