zzcclp opened a new pull request #1396:
URL: https://github.com/apache/kylin/pull/1396
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be sure
hit-lacus commented on pull request #1396:
URL: https://github.com/apache/kylin/pull/1396#issuecomment-686875934
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
hit-lacus merged pull request #1396:
URL: https://github.com/apache/kylin/pull/1396
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zzcclp opened a new pull request #1397:
URL: https://github.com/apache/kylin/pull/1397
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be sure
hit-lacus merged pull request #1397:
URL: https://github.com/apache/kylin/pull/1397
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
coveralls edited a comment on pull request #1392:
URL: https://github.com/apache/kylin/pull/1392#issuecomment-686450407
## Pull Request Test Coverage Report for [Build
6337](https://coveralls.io/builds/33230516)
* **0** of **6** **(0.0%)** changed or added relevant lines in **1**
RupengWang opened a new pull request #1398:
URL: https://github.com/apache/kylin/pull/1398
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be
hit-lacus opened a new pull request #1399:
URL: https://github.com/apache/kylin/pull/1399
- QueryMetricsTest will not start a sparder context.
- Skip some module because I want to make sure UT pass at 30 mins.
## Proposed changes
Describe the big picture of your changes here
hit-lacus commented on pull request #1399:
URL: https://github.com/apache/kylin/pull/1399#issuecomment-687810547
I will merge this.
This is an automated message from the Apache Git Service.
To respond to the message, please l
hit-lacus closed pull request #1399:
URL: https://github.com/apache/kylin/pull/1399
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hit-lacus opened a new pull request #1400:
URL: https://github.com/apache/kylin/pull/1400
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be s
flyaos opened a new pull request #1401:
URL: https://github.com/apache/kylin/pull/1401
## Proposed changes
Delete duplicate code in AbstractHadoopJob.java that add project resource
twice.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put a
coveralls commented on pull request #1401:
URL: https://github.com/apache/kylin/pull/1401#issuecomment-688131738
## Pull Request Test Coverage Report for [Build
6345](https://coveralls.io/builds/33273673)
* **0** of **0** changed or added relevant lines in **0** files are
covered.
hit-lacus commented on pull request #1373:
URL: https://github.com/apache/kylin/pull/1373#issuecomment-689260518
This LGTM, thank you @guangxuCheng .
This is an automated message from the Apache Git Service.
To respond to the
hit-lacus merged pull request #1373:
URL: https://github.com/apache/kylin/pull/1373
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jshmchenxi opened a new pull request #1402:
URL: https://github.com/apache/kylin/pull/1402
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be
zzcclp opened a new pull request #1403:
URL: https://github.com/apache/kylin/pull/1403
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be sure
zzcclp opened a new pull request #1404:
URL: https://github.com/apache/kylin/pull/1404
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be
lgtm-com[bot] commented on pull request #1404:
URL: https://github.com/apache/kylin/pull/1404#issuecomment-689951663
This pull request **introduces 1 alert** when merging
fe8bc3ab6bde31e93ae63480ef6ea84e245523af into
f7c4ede01c6b9b46c1b007d94500038789a94fc6 - [view on
LGTM.com](https://lg
zzcclp commented on pull request #1404:
URL: https://github.com/apache/kylin/pull/1404#issuecomment-689959610
> This pull request **introduces 1 alert** when merging
[fe8bc3a](https://github.com/apache/kylin/commit/fe8bc3ab6bde31e93ae63480ef6ea84e245523af)
into
[f7c4ede](https://github.co
jshmchenxi commented on pull request #1402:
URL: https://github.com/apache/kylin/pull/1402#issuecomment-690015060
@shaofengshi Hi, this is a simple patch and the failed test seems to be
irrelevant. Would you please take a look?
hit-lacus merged pull request #1400:
URL: https://github.com/apache/kylin/pull/1400
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
guangxuCheng opened a new pull request #1405:
URL: https://github.com/apache/kylin/pull/1405
… UDF in "case when"
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
r
coveralls commented on pull request #1405:
URL: https://github.com/apache/kylin/pull/1405#issuecomment-690108973
## Pull Request Test Coverage Report for [Build
6356](https://coveralls.io/builds/33357071)
* **0** of **0** changed or added relevant lines in **0** files are
covered.
hit-lacus merged pull request #1404:
URL: https://github.com/apache/kylin/pull/1404
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hit-lacus commented on pull request #1404:
URL: https://github.com/apache/kylin/pull/1404#issuecomment-690143036
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
hit-lacus commented on pull request #1403:
URL: https://github.com/apache/kylin/pull/1403#issuecomment-690153827
This looks good to me.
This is an automated message from the Apache Git Service.
To respond to the message, plea
hit-lacus merged pull request #1403:
URL: https://github.com/apache/kylin/pull/1403
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
guangxuCheng opened a new pull request #1406:
URL: https://github.com/apache/kylin/pull/1406
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, b
coveralls commented on pull request #1406:
URL: https://github.com/apache/kylin/pull/1406#issuecomment-690273518
## Pull Request Test Coverage Report for [Build
6357](https://coveralls.io/builds/33361716)
* **0** of **0** changed or added relevant lines in **0** files are
covered.
hit-lacus opened a new pull request #1407:
URL: https://github.com/apache/kylin/pull/1407
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be s
hit-lacus merged pull request #1407:
URL: https://github.com/apache/kylin/pull/1407
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
yanghua opened a new pull request #1408:
URL: https://github.com/apache/kylin/pull/1408
## Proposed changes
Update the documentation to specify a given container name for `docker
run/exec` commands
## Types of changes
What types of changes does your code introduce t
coveralls commented on pull request #1408:
URL: https://github.com/apache/kylin/pull/1408#issuecomment-691965066
## Pull Request Test Coverage Report for [Build
6362](https://coveralls.io/builds/33437586)
* **0** of **0** changed or added relevant lines in **0** files are
covered.
hit-lacus merged pull request #1408:
URL: https://github.com/apache/kylin/pull/1408
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hit-lacus commented on pull request #1406:
URL: https://github.com/apache/kylin/pull/1406#issuecomment-692070955
@zzcclp could please help to review this patch ?
This is an automated message from the Apache Git Service.
To r
hit-lacus commented on pull request #1405:
URL: https://github.com/apache/kylin/pull/1405#issuecomment-692079514
I can reproduce this, I think I will merge this in the future.
This is an automated message from the Apache Git
hit-lacus commented on pull request #1401:
URL: https://github.com/apache/kylin/pull/1401#issuecomment-692081097
OK, this looks fine to me.
This is an automated message from the Apache Git Service.
To respond to the message,
hit-lacus merged pull request #1401:
URL: https://github.com/apache/kylin/pull/1401
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zzcclp commented on pull request #1406:
URL: https://github.com/apache/kylin/pull/1406#issuecomment-692396002
LGTM.
BTW, there are some places missing ';' after function, could you add them?
This is an automated message fr
guangxuCheng commented on pull request #1406:
URL: https://github.com/apache/kylin/pull/1406#issuecomment-692414107
> LGTM.
> BTW, there are some places missing ';' after function, could you add them?
Thanks for review. I will add them.
---
guangxuCheng commented on pull request #1406:
URL: https://github.com/apache/kylin/pull/1406#issuecomment-692419840
@zzcclp Add some missing ";" , the main change is in line 78. Thanks
This is an automated message fro
hit-lacus commented on pull request #1402:
URL: https://github.com/apache/kylin/pull/1402#issuecomment-692424311
@jshmchenxi Thank you for this patch, it looks good to me.
This is an automated message from the Apache Git Ser
codecov-commenter commented on pull request #1406:
URL: https://github.com/apache/kylin/pull/1406#issuecomment-692425263
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1406?src=pr&el=h1) Report
> Merging
[#1406](https://codecov.io/gh/apache/kylin/pull/1406?src=pr&el=desc) into
[mas
coveralls edited a comment on pull request #1406:
URL: https://github.com/apache/kylin/pull/1406#issuecomment-690273518
## Pull Request Test Coverage Report for [Build
6364](https://coveralls.io/builds/33460284)
* **0** of **0** changed or added relevant lines in **0** files are
c
hit-lacus merged pull request #1402:
URL: https://github.com/apache/kylin/pull/1402
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hit-lacus commented on pull request #1374:
URL: https://github.com/apache/kylin/pull/1374#issuecomment-692429066
@zzcclp Please help to review this.
This is an automated message from the Apache Git Service.
To respond to the
hit-lacus commented on pull request #1406:
URL: https://github.com/apache/kylin/pull/1406#issuecomment-692429861
Thank you, @guangxuCheng . I will merge this.
This is an automated message from the Apache Git Service.
To respo
hit-lacus merged pull request #1406:
URL: https://github.com/apache/kylin/pull/1406
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hit-lacus commented on pull request #1392:
URL: https://github.com/apache/kylin/pull/1392#issuecomment-692433519
Thank you @ggKe , looks like this patch has been fixed by
https://github.com/apache/kylin/pull/1351 , so thank you for your contribution.
--
hit-lacus closed pull request #1392:
URL: https://github.com/apache/kylin/pull/1392
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zzcclp commented on pull request #1374:
URL: https://github.com/apache/kylin/pull/1374#issuecomment-692448899
The root cause of this issue you met is that the version of node and npm is
higher than required, the required version is below:
node: lower than v10.20.X
npm: lower than 6
zhangayqian opened a new pull request #1409:
URL: https://github.com/apache/kylin/pull/1409
…deleted cube and project
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug o
zzcclp opened a new pull request #1410:
URL: https://github.com/apache/kylin/pull/1410
Docker image for Apache Kylin 4 Alpha
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes
hit-lacus commented on pull request #1370:
URL: https://github.com/apache/kylin/pull/1370#issuecomment-692493878
@zhangayqian , please help to check this .
This is an automated message from the Apache Git Service.
To respond
hit-lacus merged pull request #1340:
URL: https://github.com/apache/kylin/pull/1340
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hit-lacus commented on pull request #1340:
URL: https://github.com/apache/kylin/pull/1340#issuecomment-692624279
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
guangxuCheng commented on pull request #1374:
URL: https://github.com/apache/kylin/pull/1374#issuecomment-693152663
`✖ 4 of 3 tests failed:
1) jpegtran should return path to jpegtran binary:
AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy
value:
RupengWang opened a new pull request #1411:
URL: https://github.com/apache/kylin/pull/1411
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be
zhangayqian opened a new pull request #1412:
URL: https://github.com/apache/kylin/pull/1412
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be
zhangayqian opened a new pull request #1413:
URL: https://github.com/apache/kylin/pull/1413
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be
zzcclp commented on a change in pull request #1411:
URL: https://github.com/apache/kylin/pull/1411#discussion_r489238725
##
File path:
kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/kylin/engine/spark/builder/CubeDictionaryBuilder.scala
##
@@ -65,6 +65,7 @@ c
zzcclp commented on a change in pull request #1411:
URL: https://github.com/apache/kylin/pull/1411#discussion_r489240984
##
File path:
kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/kylin/engine/spark/job/CuboidAggregator.scala
##
@@ -98,9 +98,22 @@ object Cu
coveralls commented on pull request #1413:
URL: https://github.com/apache/kylin/pull/1413#issuecomment-693260502
## Pull Request Test Coverage Report for [Build
6370](https://coveralls.io/builds/33496149)
* **0** of **11** **(0.0%)** changed or added relevant lines in **1**
file
RupengWang commented on a change in pull request #1411:
URL: https://github.com/apache/kylin/pull/1411#discussion_r489305886
##
File path:
kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/kylin/engine/spark/job/CuboidAggregator.scala
##
@@ -98,9 +98,22 @@ objec
lijianfeng526 opened a new pull request #1414:
URL: https://github.com/apache/kylin/pull/1414
INFO : Compiling
command(queryId=hive_20200916191433_8b35b096-3c07-4b2f-b17a-fd4347c38aef): USE
default
INFO : Semantic Analysis Completed (retrial = false)
INFO : Returning Hive sche
hit-lacus commented on pull request #1411:
URL: https://github.com/apache/kylin/pull/1411#issuecomment-693387007
Thank you @RupengWang @zzcclp , you are doing great job.
This is an automated message from the Apache Git Servi
hit-lacus merged pull request #1411:
URL: https://github.com/apache/kylin/pull/1411
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hit-lacus merged pull request #1410:
URL: https://github.com/apache/kylin/pull/1410
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hit-lacus commented on pull request #1410:
URL: https://github.com/apache/kylin/pull/1410#issuecomment-693389878
This looks good to me.
This is an automated message from the Apache Git Service.
To respond to the message, plea
hit-lacus merged pull request #1405:
URL: https://github.com/apache/kylin/pull/1405
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hit-lacus commented on pull request #1414:
URL: https://github.com/apache/kylin/pull/1414#issuecomment-693393510
What do you want to fix ? Is it a patch to Hadoop3.X branch ?
This is an automated message from the Apache Git S
lijianfeng526 opened a new pull request #1415:
URL: https://github.com/apache/kylin/pull/1415
The version is :
kylin2.6.3 + hadoop3.1
**when the job cube , an error has occurred . the error is as follows**
**:**
![image](https://user-images.githubusercontent.com/
RupengWang opened a new pull request #1416:
URL: https://github.com/apache/kylin/pull/1416
…ith the same name
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resol
zhangayqian commented on pull request #1370:
URL: https://github.com/apache/kylin/pull/1370#issuecomment-694035692
I have verify this PR. It does fixed KYLIN-4712.
- Fistly, I grant two user `test` and `test_user` the project query
permission.
https://user-images.githubusercontent.co
zhangayqian edited a comment on pull request #1370:
URL: https://github.com/apache/kylin/pull/1370#issuecomment-694035692
I have verify this PR. It does fixed KYLIN-4712.
- Fistly, I grant two user `test` and `test_user` the project query
permission.
https://user-images.githubusercon
hit-lacus commented on pull request #1409:
URL: https://github.com/apache/kylin/pull/1409#issuecomment-694076501
This LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
hit-lacus commented on pull request #1409:
URL: https://github.com/apache/kylin/pull/1409#issuecomment-694076347
Looks like the CI check failed for network reason.
"Caused by: java.net.UnknownHostException: repository.kyligence.io:
Temporary failure in name resolution"
---
hit-lacus merged pull request #1409:
URL: https://github.com/apache/kylin/pull/1409
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hit-lacus commented on pull request #1370:
URL: https://github.com/apache/kylin/pull/1370#issuecomment-694077405
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
hit-lacus merged pull request #1370:
URL: https://github.com/apache/kylin/pull/1370
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hit-lacus closed pull request #1370:
URL: https://github.com/apache/kylin/pull/1370
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hit-lacus merged pull request #1398:
URL: https://github.com/apache/kylin/pull/1398
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hit-lacus commented on pull request #1398:
URL: https://github.com/apache/kylin/pull/1398#issuecomment-694078264
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
hit-lacus merged pull request #1351:
URL: https://github.com/apache/kylin/pull/1351
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hit-lacus commented on pull request #1351:
URL: https://github.com/apache/kylin/pull/1351#issuecomment-694084949
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
hit-lacus merged pull request #1416:
URL: https://github.com/apache/kylin/pull/1416
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hit-lacus commented on pull request #1416:
URL: https://github.com/apache/kylin/pull/1416#issuecomment-695755504
LGTM , thank you @RupengWang .
This is an automated message from the Apache Git Service.
To respond to the messa
hit-lacus merged pull request #1413:
URL: https://github.com/apache/kylin/pull/1413
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hit-lacus commented on pull request #1413:
URL: https://github.com/apache/kylin/pull/1413#issuecomment-695755749
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
hit-lacus commented on pull request #1412:
URL: https://github.com/apache/kylin/pull/1412#issuecomment-695996183
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
hit-lacus merged pull request #1412:
URL: https://github.com/apache/kylin/pull/1412
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zhangayqian opened a new pull request #1417:
URL: https://github.com/apache/kylin/pull/1417
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be
hit-lacus merged pull request #1412:
URL: https://github.com/apache/kylin/pull/1412
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hit-lacus commented on pull request #1412:
URL: https://github.com/apache/kylin/pull/1412#issuecomment-695996183
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
zhangayqian opened a new pull request #1418:
URL: https://github.com/apache/kylin/pull/1418
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be
coveralls commented on pull request #1418:
URL: https://github.com/apache/kylin/pull/1418#issuecomment-696620575
## Pull Request Test Coverage Report for [Build
6385](https://coveralls.io/builds/33630461)
* **0** of **0** changed or added relevant lines in **0** files are
covered.
tianhui5 opened a new pull request #1419:
URL: https://github.com/apache/kylin/pull/1419
## Proposed changes
JIRA: https://issues.apache.org/jira/browse/KYLIN-4770
## Types of changes
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-break
coveralls commented on pull request #1419:
URL: https://github.com/apache/kylin/pull/1419#issuecomment-696676711
## Pull Request Test Coverage Report for [Build
6386](https://coveralls.io/builds/33633402)
* **0** of **0** changed or added relevant lines in **0** files are
covered.
hit-lacus merged pull request #1418:
URL: https://github.com/apache/kylin/pull/1418
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
1901 - 2000 of 9871 matches
Mail list logo