[GitHub] [kylin] hit-lacus opened a new pull request #1440: KYLIN-4689 BuildJibSubmitter should obey MaxJobLimit

2020-10-09 Thread GitBox
hit-lacus opened a new pull request #1440: URL: https://github.com/apache/kylin/pull/1440 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be s

[GitHub] [kylin] hit-lacus commented on pull request #1440: KYLIN-4689 BuildJobSubmitter should obey MaxJobLimit

2020-10-09 Thread GitBox
hit-lacus commented on pull request #1440: URL: https://github.com/apache/kylin/pull/1440#issuecomment-706232339 I need some time to test this patch. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kylin] coveralls commented on pull request #1440: KYLIN-4689 BuildJobSubmitter should obey MaxJobLimit

2020-10-09 Thread GitBox
coveralls commented on pull request #1440: URL: https://github.com/apache/kylin/pull/1440#issuecomment-706269030 ## Pull Request Test Coverage Report for [Build 6436](https://coveralls.io/builds/34062525) * **0** of **8** **(0.0%)** changed or added relevant lines in **1** file a

[GitHub] [kylin] AndrewLane opened a new pull request #1441: Correct grammar of message when there are no cubes

2020-10-09 Thread GitBox
AndrewLane opened a new pull request #1441: URL: https://github.com/apache/kylin/pull/1441 ## Proposed changes Grammar fix on message when there are no cubes. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that ap

[GitHub] [kylin] coveralls commented on pull request #1441: Correct grammar of message when there are no cubes

2020-10-09 Thread GitBox
coveralls commented on pull request #1441: URL: https://github.com/apache/kylin/pull/1441#issuecomment-706338136 ## Pull Request Test Coverage Report for [Build 6437](https://coveralls.io/builds/34065974) * **0** of **0** changed or added relevant lines in **0** files are covered.

[GitHub] [kylin] coveralls edited a comment on pull request #1311: KYLIN-4626 add set kylin home shell

2020-10-09 Thread GitBox
coveralls edited a comment on pull request #1311: URL: https://github.com/apache/kylin/pull/1311#issuecomment-655848303 ## Pull Request Test Coverage Report for [Build 6438](https://coveralls.io/builds/34072911) * **0** of **0** changed or added relevant lines in **0** files are c

[GitHub] [kylin] hit-lacus merged pull request #1433: KYLIN-4697: Fix User info update logic use copyForWrite

2020-10-09 Thread GitBox
hit-lacus merged pull request #1433: URL: https://github.com/apache/kylin/pull/1433 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus merged pull request #1437: KYLIN-4752 Refine server mode checking

2020-10-09 Thread GitBox
hit-lacus merged pull request #1437: URL: https://github.com/apache/kylin/pull/1437 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus merged pull request #1441: Correct grammar of message when there are no cubes

2020-10-09 Thread GitBox
hit-lacus merged pull request #1441: URL: https://github.com/apache/kylin/pull/1441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus merged pull request #1439: KYLIN-4581 Modify the REST API url of update cube build engine

2020-10-09 Thread GitBox
hit-lacus merged pull request #1439: URL: https://github.com/apache/kylin/pull/1439 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1441: Correct grammar of message when there are no cubes

2020-10-09 Thread GitBox
hit-lacus commented on pull request #1441: URL: https://github.com/apache/kylin/pull/1441#issuecomment-706482161 Thank you @AndrewLane This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kylin] hit-lacus merged pull request #1419: KYLIN-4770: Move Kylin service on k8s from background to foreground

2020-10-09 Thread GitBox
hit-lacus merged pull request #1419: URL: https://github.com/apache/kylin/pull/1419 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on a change in pull request #1299: KYLIN-4613 add build cubev2 and JobRestClient

2020-10-09 Thread GitBox
hit-lacus commented on a change in pull request #1299: URL: https://github.com/apache/kylin/pull/1299#discussion_r502742763 ## File path: core-common/src/main/java/org/apache/kylin/common/KylinConfig.java ## @@ -134,7 +134,7 @@ private static void buildDefaultOrderedProperties(

[GitHub] [kylin] zzcclp commented on a change in pull request #1440: KYLIN-4689 BuildJobSubmitter should obey MaxJobLimit

2020-10-09 Thread GitBox
zzcclp commented on a change in pull request #1440: URL: https://github.com/apache/kylin/pull/1440#discussion_r502750727 ## File path: stream-coordinator/src/main/java/org/apache/kylin/stream/coordinator/coordinate/BuildJobSubmitter.java ## @@ -165,6 +166,11 @@ void doRun() {

[GitHub] [kylin] hit-lacus commented on a change in pull request #1440: KYLIN-4689 BuildJobSubmitter should obey MaxJobLimit

2020-10-09 Thread GitBox
hit-lacus commented on a change in pull request #1440: URL: https://github.com/apache/kylin/pull/1440#discussion_r502754031 ## File path: stream-coordinator/src/main/java/org/apache/kylin/stream/coordinator/coordinate/BuildJobSubmitter.java ## @@ -165,6 +166,11 @@ void doRun()

[GitHub] [kylin] hit-lacus commented on pull request #1438: KYLIN-4771 Clear the recordCachePool when the deadline has reached

2020-10-10 Thread GitBox
hit-lacus commented on pull request #1438: URL: https://github.com/apache/kylin/pull/1438#issuecomment-706512995 Hello @ggKe , I have checked your patch, your patch look good to me. But there are some UT failure, could you please help to fix them? Following is part of log:

[GitHub] [kylin] hit-lacus merged pull request #1436: KYLIN-4782 Verify if the query hit the true cuboid in IT

2020-10-10 Thread GitBox
hit-lacus merged pull request #1436: URL: https://github.com/apache/kylin/pull/1436 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] coveralls commented on pull request #1438: KYLIN-4771 Clear the recordCachePool when the deadline has reached

2020-10-10 Thread GitBox
coveralls commented on pull request #1438: URL: https://github.com/apache/kylin/pull/1438#issuecomment-706548304 ## Pull Request Test Coverage Report for [Build 6440](https://coveralls.io/builds/34077445) * **3** of **7** **(42.86%)** changed or added relevant lines in **1** file

[GitHub] [kylin] ggKe commented on pull request #1438: KYLIN-4771 Clear the recordCachePool when the deadline has reached

2020-10-10 Thread GitBox
ggKe commented on pull request #1438: URL: https://github.com/apache/kylin/pull/1438#issuecomment-706552143 > Hello @ggKe , I have checked your patch, your patch look good to me. But there are some UT failure, could you please help to fix them? > > Following is part of log: >

[GitHub] [kylin] hit-lacus commented on pull request #1438: KYLIN-4771 Clear the recordCachePool when the deadline has reached

2020-10-10 Thread GitBox
hit-lacus commented on pull request #1438: URL: https://github.com/apache/kylin/pull/1438#issuecomment-706552419 Thank you, that's great. This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kylin] coveralls edited a comment on pull request #1424: KYLIN-4775 Use docker-compose to deploy Hadoop and Kylin

2020-10-10 Thread GitBox
coveralls edited a comment on pull request #1424: URL: https://github.com/apache/kylin/pull/1424#issuecomment-698783979 ## Pull Request Test Coverage Report for [Build 6441](https://coveralls.io/builds/34077881) * **0** of **0** changed or added relevant lines in **0** files are c

[GitHub] [kylin] fengpod commented on pull request #1442: support segment data stored in ssd

2020-10-12 Thread GitBox
fengpod commented on pull request #1442: URL: https://github.com/apache/kylin/pull/1442#issuecomment-707029537 For better query performance,we put important data on ssd for core business use。 This is an automated message fro

[GitHub] [kylin] fengpod opened a new pull request #1442: support segment data stored in ssd

2020-10-12 Thread GitBox
fengpod opened a new pull request #1442: URL: https://github.com/apache/kylin/pull/1442 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sur

[GitHub] [kylin] fengpod edited a comment on pull request #1442: KYLIN-4786 support segment data stored in ssd

2020-10-12 Thread GitBox
fengpod edited a comment on pull request #1442: URL: https://github.com/apache/kylin/pull/1442#issuecomment-707029537 For better query performance,we put important data on ssd for core business use。We test the query performance of the same data on HDD and SSD,the performance of SSD for mor

[GitHub] [kylin] coveralls commented on pull request #1442: KYLIN-4786 support segment data stored in ssd

2020-10-12 Thread GitBox
coveralls commented on pull request #1442: URL: https://github.com/apache/kylin/pull/1442#issuecomment-707068205 ## Pull Request Test Coverage Report for [Build 6445](https://coveralls.io/builds/34104858) * **0** of **11** **(0.0%)** changed or added relevant lines in **3** files

[GitHub] [kylin] coveralls edited a comment on pull request #1440: KYLIN-4689 BuildJobSubmitter should obey MaxJobLimit

2020-10-12 Thread GitBox
coveralls edited a comment on pull request #1440: URL: https://github.com/apache/kylin/pull/1440#issuecomment-706269030 ## Pull Request Test Coverage Report for [Build 6446](https://coveralls.io/builds/34105823) * **1** of **7** **(14.29%)** changed or added relevant lines in **1*

[GitHub] [kylin] hit-lacus closed pull request #1440: KYLIN-4689 BuildJobSubmitter should obey MaxJobLimit

2020-10-12 Thread GitBox
hit-lacus closed pull request #1440: URL: https://github.com/apache/kylin/pull/1440 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus merged pull request #1434: 3.1.1 hadoop3 Patch List

2020-10-12 Thread GitBox
hit-lacus merged pull request #1434: URL: https://github.com/apache/kylin/pull/1434 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] zzcclp opened a new pull request #1443: HOTFIX modify the version of shaded-guava module to 3.1.2-SNAPSHOT

2020-10-12 Thread GitBox
zzcclp opened a new pull request #1443: URL: https://github.com/apache/kylin/pull/1443 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure

[GitHub] [kylin] hit-lacus merged pull request #1443: HOTFIX modify the version of shaded-guava module to 3.1.2-SNAPSHOT

2020-10-12 Thread GitBox
hit-lacus merged pull request #1443: URL: https://github.com/apache/kylin/pull/1443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] Ted-Jiang opened a new pull request #1444: KYLIN-4636 Make /api/admin/public_config callable for profile saml

2020-10-12 Thread GitBox
Ted-Jiang opened a new pull request #1444: URL: https://github.com/apache/kylin/pull/1444 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be s

[GitHub] [kylin] hit-lacus opened a new pull request #1445: 3.1.1 hadoop3 patch

2020-10-12 Thread GitBox
hit-lacus opened a new pull request #1445: URL: https://github.com/apache/kylin/pull/1445 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be s

[GitHub] [kylin] hit-lacus opened a new pull request #1446: Revert "KYLIN-4508 Add unit test for core-metrics module & reporters"

2020-10-12 Thread GitBox
hit-lacus opened a new pull request #1446: URL: https://github.com/apache/kylin/pull/1446 This reverts commit 8d894e2c8098a41d3778933cc93484a2c5f582e3. ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this

[GitHub] [kylin] hit-lacus commented on pull request #1446: Revert "KYLIN-4508 Add unit test for core-metrics module & reporters"

2020-10-12 Thread GitBox
hit-lacus commented on pull request #1446: URL: https://github.com/apache/kylin/pull/1446#issuecomment-707501290 Can not resolve `org.apache.hadoop.hdfs.DistributedFileSystem` . This is an automated message from the Apache Gi

[GitHub] [kylin] hit-lacus merged pull request #1446: Revert "KYLIN-4508 Add unit test for core-metrics module & reporters"

2020-10-12 Thread GitBox
hit-lacus merged pull request #1446: URL: https://github.com/apache/kylin/pull/1446 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus closed pull request #1445: 3.1.1 hadoop3 patch

2020-10-13 Thread GitBox
hit-lacus closed pull request #1445: URL: https://github.com/apache/kylin/pull/1445 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] zhangayqian opened a new pull request #1447: Add some missing tutorial

2020-10-13 Thread GitBox
zhangayqian opened a new pull request #1447: URL: https://github.com/apache/kylin/pull/1447 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be

[GitHub] [kylin] zhangayqian opened a new pull request #1448: Auto add USE $DATABASE; to the beginning of create_sample_tables.sql

2020-10-14 Thread GitBox
zhangayqian opened a new pull request #1448: URL: https://github.com/apache/kylin/pull/1448 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be

[GitHub] [kylin] coveralls commented on pull request #1448: Auto add USE $DATABASE; to the beginning of create_sample_tables.sql

2020-10-14 Thread GitBox
coveralls commented on pull request #1448: URL: https://github.com/apache/kylin/pull/1448#issuecomment-708347841 ## Pull Request Test Coverage Report for [Build 6454](https://coveralls.io/builds/34165485) * **0** of **0** changed or added relevant lines in **0** files are covered.

[GitHub] [kylin] zzcclp commented on pull request #1448: Auto add USE $DATABASE; to the beginning of create_sample_tables.sql

2020-10-14 Thread GitBox
zzcclp commented on pull request #1448: URL: https://github.com/apache/kylin/pull/1448#issuecomment-708851074 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kylin] fengpod opened a new pull request #1449: add segmentName and regionName in Coprocessor deadline info

2020-10-14 Thread GitBox
fengpod opened a new pull request #1449: URL: https://github.com/apache/kylin/pull/1449 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sur

[GitHub] [kylin] fengpod commented on pull request #1449: add segmentName and regionName in Coprocessor deadline info

2020-10-14 Thread GitBox
fengpod commented on pull request #1449: URL: https://github.com/apache/kylin/pull/1449#issuecomment-708862735 Add segmentName and regionName to Coprocessor deadline exception info,for locating the cube and region exactly。 When Coprocessor throws dealline expcetion,the info will looks li

[GitHub] [kylin] coveralls commented on pull request #1449: KYLIN-4788 add segmentName and regionName in Coprocessor deadline info

2020-10-14 Thread GitBox
coveralls commented on pull request #1449: URL: https://github.com/apache/kylin/pull/1449#issuecomment-708869790 ## Pull Request Test Coverage Report for [Build 6456](https://coveralls.io/builds/34186266) * **13** of **152** **(8.55%)** changed or added relevant lines in **3** fi

[GitHub] [kylin] coveralls edited a comment on pull request #1448: Auto add USE $DATABASE; to the beginning of create_sample_tables.sql

2020-10-14 Thread GitBox
coveralls edited a comment on pull request #1448: URL: https://github.com/apache/kylin/pull/1448#issuecomment-708347841 ## Pull Request Test Coverage Report for [Build 6458](https://coveralls.io/builds/34186813) * **0** of **0** changed or added relevant lines in **0** files are c

[GitHub] [kylin] coveralls edited a comment on pull request #1448: Auto add USE $DATABASE; to the beginning of create_sample_tables.sql

2020-10-14 Thread GitBox
coveralls edited a comment on pull request #1448: URL: https://github.com/apache/kylin/pull/1448#issuecomment-708347841 ## Pull Request Test Coverage Report for [Build 6457](https://coveralls.io/builds/34186811) * **0** of **0** changed or added relevant lines in **0** files are c

[GitHub] [kylin] chenjie-sau opened a new pull request #1450: KYLIN-4736 Update Flink version to 1.11.1

2020-10-14 Thread GitBox
chenjie-sau opened a new pull request #1450: URL: https://github.com/apache/kylin/pull/1450 ## Proposed changes Update flink calculation engine from 1.9.2 to 1.11.1 ## Types of changes - [ ] Update flink download file - [ ] Modify flink configuration parameters - [

[GitHub] [kylin] chenjie-sau opened a new pull request #1451: [KYLIN-4736]Upgrade Flink version to 1.11.1

2020-10-15 Thread GitBox
chenjie-sau opened a new pull request #1451: URL: https://github.com/apache/kylin/pull/1451 ## Proposed changes Upgrade Flink version to 1.11.1. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ -

[GitHub] [kylin] chenjie-sau closed pull request #1450: KYLIN-4736 Update Flink version to 1.11.1

2020-10-15 Thread GitBox
chenjie-sau closed pull request #1450: URL: https://github.com/apache/kylin/pull/1450 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kylin] chenjie-sau commented on pull request #1451: [KYLIN-4736]Upgrade Flink version to 1.11.1

2020-10-15 Thread GitBox
chenjie-sau commented on pull request #1451: URL: https://github.com/apache/kylin/pull/1451#issuecomment-709023361 Hi @yanghua could you please take a look when free This is an automated message from the Apache Git Service.

[GitHub] [kylin] coveralls commented on pull request #1451: [KYLIN-4736]Upgrade Flink version to 1.11.1

2020-10-15 Thread GitBox
coveralls commented on pull request #1451: URL: https://github.com/apache/kylin/pull/1451#issuecomment-709053644 ## Pull Request Test Coverage Report for [Build 6459](https://coveralls.io/builds/34193505) * **2** of **2** **(100.0%)** changed or added relevant lines in **1** file

[GitHub] [kylin] yanghua commented on pull request #1451: [KYLIN-4736]Upgrade Flink version to 1.11.1

2020-10-15 Thread GitBox
yanghua commented on pull request #1451: URL: https://github.com/apache/kylin/pull/1451#issuecomment-709084972 > Hi @yanghua could you please take a look when free OK, thanks for your contribution. Will review soon. Th

[GitHub] [kylin] bigxiaochu commented on a change in pull request #1299: KYLIN-4613 add build cubev2 and JobRestClient

2020-10-15 Thread GitBox
bigxiaochu commented on a change in pull request #1299: URL: https://github.com/apache/kylin/pull/1299#discussion_r505999634 ## File path: core-common/src/main/java/org/apache/kylin/common/KylinConfig.java ## @@ -134,7 +134,7 @@ private static void buildDefaultOrderedProperties

[GitHub] [kylin] zhangayqian commented on pull request #1451: KYLIN-4736 Upgrade Flink version to 1.11.1

2020-10-15 Thread GitBox
zhangayqian commented on pull request #1451: URL: https://github.com/apache/kylin/pull/1451#issuecomment-709696291 > @chenjie-sau Thanks for your contribution. @zhangayqian Do you have any concerns? Or do you want to verify it? @chenjie-sau has verified in his local env. Thank you @

[GitHub] [kylin] zhangayqian commented on pull request #1451: KYLIN-4736 Upgrade Flink version to 1.11.1

2020-10-16 Thread GitBox
zhangayqian commented on pull request #1451: URL: https://github.com/apache/kylin/pull/1451#issuecomment-709952465 I test this branch in my local env. I use the $KYLIN_HOME/bin/download-flink.sh download Flink 1.11.1. Then I start kylin and submit a Flink build job. But there is a error in

[GitHub] [kylin] zhangayqian edited a comment on pull request #1451: KYLIN-4736 Upgrade Flink version to 1.11.1

2020-10-16 Thread GitBox
zhangayqian edited a comment on pull request #1451: URL: https://github.com/apache/kylin/pull/1451#issuecomment-709952465 I tested this branch in my local env. I use the $KYLIN_HOME/bin/download-flink.sh download Flink 1.11.1. Then I start kylin and submit a Flink build job. But there is a

[GitHub] [kylin] zhangayqian opened a new pull request #1452: KYLIN-4790 Automaticly copy required jars to SPARK_HOME/jars for HDI3.6

2020-10-16 Thread GitBox
zhangayqian opened a new pull request #1452: URL: https://github.com/apache/kylin/pull/1452 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be

[GitHub] [kylin] hit-lacus merged pull request #1447: Add some missing tutorial

2020-10-18 Thread GitBox
hit-lacus merged pull request #1447: URL: https://github.com/apache/kylin/pull/1447 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1452: KYLIN-4790 Automaticly copy required jars to SPARK_HOME/jars for HDI3.6

2020-10-18 Thread GitBox
hit-lacus commented on pull request #1452: URL: https://github.com/apache/kylin/pull/1452#issuecomment-711138990 Hi @zhangayqian, this looks good to me. You might add one small change, once copy success, execute "sh bin/kylin.sh start" do not need copy again.

[GitHub] [kylin] hit-lacus commented on pull request #1448: Auto add USE $DATABASE; to the beginning of create_sample_tables.sql

2020-10-18 Thread GitBox
hit-lacus commented on pull request #1448: URL: https://github.com/apache/kylin/pull/1448#issuecomment-711139193 Thank you @zhangayqian . This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kylin] hit-lacus merged pull request #1448: Auto add USE $DATABASE; to the beginning of create_sample_tables.sql

2020-10-18 Thread GitBox
hit-lacus merged pull request #1448: URL: https://github.com/apache/kylin/pull/1448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1452: KYLIN-4790 Automaticly copy required jars to SPARK_HOME/jars for HDI3.6

2020-10-18 Thread GitBox
hit-lacus commented on pull request #1452: URL: https://github.com/apache/kylin/pull/1452#issuecomment-711139650 So, after all files are copied, you can add one empty file, to indicate copy job is done and no need to be repeated next time. -

[GitHub] [kylin] hit-lacus merged pull request #1444: KYLIN-4636 Make /api/admin/public_config callable for profile saml

2020-10-18 Thread GitBox
hit-lacus merged pull request #1444: URL: https://github.com/apache/kylin/pull/1444 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1444: KYLIN-4636 Make /api/admin/public_config callable for profile saml

2020-10-18 Thread GitBox
hit-lacus commented on pull request #1444: URL: https://github.com/apache/kylin/pull/1444#issuecomment-711139943 Thank you @Ted-Jiang . This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kylin] hit-lacus merged pull request #1438: KYLIN-4771 Clear the recordCachePool when the deadline has reached

2020-10-18 Thread GitBox
hit-lacus merged pull request #1438: URL: https://github.com/apache/kylin/pull/1438 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus merged pull request #1427: Kylin-4712 Update document

2020-10-18 Thread GitBox
hit-lacus merged pull request #1427: URL: https://github.com/apache/kylin/pull/1427 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus merged pull request #1311: KYLIN-4626 add set kylin home shell

2020-10-18 Thread GitBox
hit-lacus merged pull request #1311: URL: https://github.com/apache/kylin/pull/1311 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus opened a new pull request #1453: Prepare release for Kylin 3.1.1

2020-10-18 Thread GitBox
hit-lacus opened a new pull request #1453: URL: https://github.com/apache/kylin/pull/1453 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be s

[GitHub] [kylin] hit-lacus commented on pull request #1453: Prepare release for Kylin 3.1.1

2020-10-18 Thread GitBox
hit-lacus commented on pull request #1453: URL: https://github.com/apache/kylin/pull/1453#issuecomment-711160904 For 3.1.1 release This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kylin] hit-lacus merged pull request #1453: Prepare release for Kylin 3.1.1

2020-10-18 Thread GitBox
hit-lacus merged pull request #1453: URL: https://github.com/apache/kylin/pull/1453 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] zhangayqian commented on pull request #1452: KYLIN-4790 Automaticly copy required jars to SPARK_HOME/jars for HDI3.6

2020-10-18 Thread GitBox
zhangayqian commented on pull request #1452: URL: https://github.com/apache/kylin/pull/1452#issuecomment-711464675 > So, after all files are copied, you can add one empty file, to indicate copy job is done and no need to be repeated next time. Thank you for your review @hit-lacus. I wil

[GitHub] [kylin] zhangayqian edited a comment on pull request #1452: KYLIN-4790 Automaticly copy required jars to SPARK_HOME/jars for HDI3.6

2020-10-18 Thread GitBox
zhangayqian edited a comment on pull request #1452: URL: https://github.com/apache/kylin/pull/1452#issuecomment-711464675 Thank you for your review @hit-lacus. I will modify this commit. This is an automated message from

[GitHub] [kylin] hit-lacus merged pull request #1452: KYLIN-4790 Automaticly copy required jars to SPARK_HOME/jars for HDI3.6

2020-10-19 Thread GitBox
hit-lacus merged pull request #1452: URL: https://github.com/apache/kylin/pull/1452 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] zzcclp opened a new pull request #1454: KYLIN-4791 Fix exception 'UnsupportedOperationException: empty.reduceLeft' when there are cast expressions in the filters of FilePruner

2020-10-19 Thread GitBox
zzcclp opened a new pull request #1454: URL: https://github.com/apache/kylin/pull/1454 When execute function 'pruneSegments' of FilePruner, if there are some cast expressions in filter, it will throw exception 'UnsupportedOperationException: empty.reduceLeft'. Solution: Convert c

[GitHub] [kylin] chenjie-sau commented on pull request #1451: KYLIN-4736 Upgrade Flink version to 1.11.1

2020-10-19 Thread GitBox
chenjie-sau commented on pull request #1451: URL: https://github.com/apache/kylin/pull/1451#issuecomment-712248999 > I tested this branch in my local env. I use the $KYLIN_HOME/bin/download-flink.sh download Flink 1.11.1. Then I start kylin and submit a Flink build job. But there is a erro

[GitHub] [kylin] chenjie-sau commented on pull request #1451: KYLIN-4736 Upgrade Flink version to 1.11.1

2020-10-19 Thread GitBox
chenjie-sau commented on pull request #1451: URL: https://github.com/apache/kylin/pull/1451#issuecomment-712538067 > I tested this branch in my local env. I use the $KYLIN_HOME/bin/download-flink.sh download Flink 1.11.1. Then I start kylin and submit a Flink build job. But there is a erro

[GitHub] [kylin] chenjie-sau closed pull request #1451: KYLIN-4736 Upgrade Flink version to 1.11.1

2020-10-19 Thread GitBox
chenjie-sau closed pull request #1451: URL: https://github.com/apache/kylin/pull/1451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kylin] chenjie-sau removed a comment on pull request #1451: KYLIN-4736 Upgrade Flink version to 1.11.1

2020-10-19 Thread GitBox
chenjie-sau removed a comment on pull request #1451: URL: https://github.com/apache/kylin/pull/1451#issuecomment-712538067 > I tested this branch in my local env. I use the $KYLIN_HOME/bin/download-flink.sh download Flink 1.11.1. Then I start kylin and submit a Flink build job. But there i

[GitHub] [kylin] bigxiaochu commented on pull request #1378: KYLIN-4720 support htable read quota

2020-10-19 Thread GitBox
bigxiaochu commented on pull request #1378: URL: https://github.com/apache/kylin/pull/1378#issuecomment-712539712 有个疑问,表级别设置quota的业务意义何在。 因为查询是跨segment的,也就是跨表,单张表限制quota了,但一次查询可能跨多张表。如果是防止查挂机器,那在ns级别或用户级别设置quota就可以了。 这么设置有些粗暴,一旦查询失败,如果单个sql超过quota,几乎就不可能成功了,如果要控制查询并发量,应该用其他方式。 -

[GitHub] [kylin] zhangayqian edited a comment on pull request #1451: KYLIN-4736 Upgrade Flink version to 1.11.1

2020-10-19 Thread GitBox
zhangayqian edited a comment on pull request #1451: URL: https://github.com/apache/kylin/pull/1451#issuecomment-712539924 @chenjie-sau. My cdh version is cdh57. Maybe there are some differences between them. This is an autom

[GitHub] [kylin] zhangayqian commented on pull request #1451: KYLIN-4736 Upgrade Flink version to 1.11.1

2020-10-19 Thread GitBox
zhangayqian commented on pull request #1451: URL: https://github.com/apache/kylin/pull/1451#issuecomment-712539924 My cdh version is cdh57. Maybe there are some differences between them. This is an automated message from the

[GitHub] [kylin] zhangayqian edited a comment on pull request #1451: KYLIN-4736 Upgrade Flink version to 1.11.1

2020-10-19 Thread GitBox
zhangayqian edited a comment on pull request #1451: URL: https://github.com/apache/kylin/pull/1451#issuecomment-712539924 @chenjie-sau. My cdh version is cdh57. Maybe there are some differences between hadoop2 and hadoop3.

[GitHub] [kylin] zzcclp commented on pull request #1454: KYLIN-4791 Fix exception 'UnsupportedOperationException: empty.reduceLeft' when there are cast expressions in the filters of FilePruner

2020-10-19 Thread GitBox
zzcclp commented on pull request #1454: URL: https://github.com/apache/kylin/pull/1454#issuecomment-712540484 Raise another pr This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kylin] zzcclp closed pull request #1454: KYLIN-4791 Fix exception 'UnsupportedOperationException: empty.reduceLeft' when there are cast expressions in the filters of FilePruner

2020-10-19 Thread GitBox
zzcclp closed pull request #1454: URL: https://github.com/apache/kylin/pull/1454 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kylin] chenjie-sau commented on pull request #1451: KYLIN-4736 Upgrade Flink version to 1.11.1

2020-10-19 Thread GitBox
chenjie-sau commented on pull request #1451: URL: https://github.com/apache/kylin/pull/1451#issuecomment-712552968 > @chenjie-sau. My cdh version is cdh57. Maybe there are some differences between hadoop2 and hadoop3. @zhangayqian You can replace flink-shaded-hadoop-3-uber-3.1.1.7.1

[GitHub] [kylin] zzcclp opened a new pull request #1455: KYLIN-4791 Fix exception 'UnsupportedOperationException: empty.reduceLeft' when there are cast expressions in the filters of FilePruner

2020-10-19 Thread GitBox
zzcclp opened a new pull request #1455: URL: https://github.com/apache/kylin/pull/1455 When execute function 'pruneSegments' of FilePruner, if there are some cast expressions in filter, it will throw exception 'UnsupportedOperationException: empty.reduceLeft'. Solution: Convert c

[GitHub] [kylin] coveralls edited a comment on pull request #1451: KYLIN-4736 Upgrade Flink version to 1.11.1

2020-10-19 Thread GitBox
coveralls edited a comment on pull request #1451: URL: https://github.com/apache/kylin/pull/1451#issuecomment-709053644 ## Pull Request Test Coverage Report for [Build 6469](https://coveralls.io/builds/34302139) * **2** of **2** **(100.0%)** changed or added relevant lines in **1*

[GitHub] [kylin] bigxiaochu commented on pull request #1442: KYLIN-4786 support segment data stored in ssd

2020-10-19 Thread GitBox
bigxiaochu commented on pull request #1442: URL: https://github.com/apache/kylin/pull/1442#issuecomment-712604019 这个依赖文件系统打标签吧,依赖一个集群有ssd机型有sata盘机型,打上不同的标签。 一个集群混部的情况,比较出名的是ssd盘和sata盘混搭,如阿里的hdfs pr,写的时候一个副本ssd,2个sata,读的时候优先读ssd。 而更常见的,是ssd和sata分两个集群,表要么写在ssd要么sata盘集群。如果要一套kylin集群同时用两个

[GitHub] [kylin] bigxiaochu commented on pull request #1449: KYLIN-4788 add segmentName and regionName in Coprocessor deadline info

2020-10-19 Thread GitBox
bigxiaochu commented on pull request #1449: URL: https://github.com/apache/kylin/pull/1449#issuecomment-712605441 good job,+1 @xiaowangyu This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kylin] hit-lacus merged pull request #1455: KYLIN-4791 Fix exception 'UnsupportedOperationException: empty.reduceLeft' when there are cast expressions in the filters of FilePruner

2020-10-20 Thread GitBox
hit-lacus merged pull request #1455: URL: https://github.com/apache/kylin/pull/1455 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] zhangayqian commented on pull request #1451: KYLIN-4736 Upgrade Flink version to 1.11.1

2020-10-20 Thread GitBox
zhangayqian commented on pull request #1451: URL: https://github.com/apache/kylin/pull/1451#issuecomment-713238350 @chenjie-sau Hi, I replaced flink-shaded-hadoop-3-uber-3.1.1.7.1.1.0-565-9.0.jar in the flink/lib directory with flink-shaded-hadoop-2-uber-2.7.5-10.0.jar and restart kylin,

[GitHub] [kylin] chenjie-sau commented on pull request #1451: KYLIN-4736 Upgrade Flink version to 1.11.1

2020-10-20 Thread GitBox
chenjie-sau commented on pull request #1451: URL: https://github.com/apache/kylin/pull/1451#issuecomment-713249083 > @chenjie-sau Hi, I replaced flink-shaded-hadoop-3-uber-3.1.1.7.1.1.0-565-9.0.jar in the flink/lib directory with flink-shaded-hadoop-2-uber-2.7.5-10.0.jar and restart kylin,

[GitHub] [kylin] chenjie-sau edited a comment on pull request #1451: KYLIN-4736 Upgrade Flink version to 1.11.1

2020-10-20 Thread GitBox
chenjie-sau edited a comment on pull request #1451: URL: https://github.com/apache/kylin/pull/1451#issuecomment-713249083 > @chenjie-sau Hi, I replaced flink-shaded-hadoop-3-uber-3.1.1.7.1.1.0-565-9.0.jar in the flink/lib directory with flink-shaded-hadoop-2-uber-2.7.5-10.0.jar and restart

[GitHub] [kylin] zzcclp opened a new pull request #1456: KYLIN-4782 Verify if the query hit the true cuboid in IT - Part 2

2020-10-20 Thread GitBox
zzcclp opened a new pull request #1456: URL: https://github.com/apache/kylin/pull/1456 1. fix the concurrent issues 2. avoid to run test case 'verifySqlStandard' in NBuildAndQueryTest twice ## Proposed changes Describe the big picture of your changes here to communicate to t

[GitHub] [kylin] zzcclp commented on pull request #1456: KYLIN-4782 Verify if the query hit the true cuboid in IT - Part 2

2020-10-20 Thread GitBox
zzcclp commented on pull request #1456: URL: https://github.com/apache/kylin/pull/1456#issuecomment-713266800 Ran IT successfully. This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kylin] hit-lacus merged pull request #1456: KYLIN-4782 Verify if the query hit the true cuboid in IT - Part 2

2020-10-20 Thread GitBox
hit-lacus merged pull request #1456: URL: https://github.com/apache/kylin/pull/1456 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] chenjie-sau edited a comment on pull request #1451: KYLIN-4736 Upgrade Flink version to 1.11.1

2020-10-20 Thread GitBox
chenjie-sau edited a comment on pull request #1451: URL: https://github.com/apache/kylin/pull/1451#issuecomment-713249083 > @chenjie-sau Hi, I replaced flink-shaded-hadoop-3-uber-3.1.1.7.1.1.0-565-9.0.jar in the flink/lib directory with flink-shaded-hadoop-2-uber-2.7.5-10.0.jar and restart

[GitHub] [kylin] fengpod removed a comment on pull request #1378: KYLIN-4720 support htable read quota

2020-10-20 Thread GitBox
fengpod removed a comment on pull request #1378: URL: https://github.com/apache/kylin/pull/1378#issuecomment-713304491 > 有个疑问,表级别设置quota的业务意义何在。 > 因为查询是跨segment的,也就是跨表,单张表限制quota了,但一次查询可能跨多张表。如果是防止查挂机器,那在ns级别或用户quota就可以了。 > 这么设置有些粗暴,一旦查询失败,如果单个sql超过quota,几乎就不可能成功了,如果要控制查询并发量,应该用其他方式。

[GitHub] [kylin] fengpod commented on pull request #1378: KYLIN-4720 support htable read quota

2020-10-20 Thread GitBox
fengpod commented on pull request #1378: URL: https://github.com/apache/kylin/pull/1378#issuecomment-713304491 > 有个疑问,表级别设置quota的业务意义何在。 > 因为查询是跨segment的,也就是跨表,单张表限制quota了,但一次查询可能跨多张表。如果是防止查挂机器,那在ns级别或用户quota就可以了。 > 这么设置有些粗暴,一旦查询失败,如果单个sql超过quota,几乎就不可能成功了,如果要控制查询并发量,应该用其他方式。 这项配置支

[GitHub] [kylin] fengpod commented on pull request #1378: KYLIN-4720 support htable read quota

2020-10-20 Thread GitBox
fengpod commented on pull request #1378: URL: https://github.com/apache/kylin/pull/1378#issuecomment-713305274 @bigxiaochu 这项配置支持项目级别和cube级别,对项目下的所有cube的所有segment或者某个cube的所有segment生效。是针对业务方高并发查询某个cube的数据占用大量regionserver资源从而影响核心业务查询。这种场景下超过quota限制是允许失败的。 ---

[GitHub] [kylin] fengpod commented on pull request #1442: KYLIN-4786 support segment data stored in ssd

2020-10-20 Thread GitBox
fengpod commented on pull request #1442: URL: https://github.com/apache/kylin/pull/1442#issuecomment-713311145 一般情况下核心数据量只占全部数据的一小部分,可能几块ssd的容量就够用了。考虑到ssd成本及kylin和hbase的维护成本,我们选择了在一个hbase集群中混部ssd和hdd。 This is an automated me

<    17   18   19   20   21   22   23   24   25   26   >