[GitHub] [kylin] zhangayqian opened a new pull request #1457: KYLIN-4792 Verify several attribute values of segment in the build/me…

2020-10-21 Thread GitBox
zhangayqian opened a new pull request #1457: URL: https://github.com/apache/kylin/pull/1457 …rge test ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a fe

[GitHub] [kylin] zhangayqian commented on pull request #1457: KYLIN-4792 Verify several attribute values of segment in the build/me…

2020-10-21 Thread GitBox
zhangayqian commented on pull request #1457: URL: https://github.com/apache/kylin/pull/1457#issuecomment-714173894 IT Passed. ![image](https://user-images.githubusercontent.com/31064237/96809400-5e2d5a80-144d-11eb-8df9-7b4140e742ee.png)

[GitHub] [kylin] zzcclp commented on pull request #1457: KYLIN-4792 Verify several attribute values of segment in the build/me…

2020-10-21 Thread GitBox
zzcclp commented on pull request #1457: URL: https://github.com/apache/kylin/pull/1457#issuecomment-714179020 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kylin] hit-lacus commented on a change in pull request #1457: KYLIN-4792 Verify several attribute values of segment in the build/me…

2020-10-21 Thread GitBox
hit-lacus commented on a change in pull request #1457: URL: https://github.com/apache/kylin/pull/1457#discussion_r509844056 ## File path: kylin-spark-project/kylin-spark-engine/src/test/java/org/apache/kylin/engine/spark/LocalWithSparkSessionTest.java ## @@ -328,4 +337,27 @@ p

[GitHub] [kylin] hit-lacus commented on a change in pull request #1457: KYLIN-4792 Verify several attribute values of segment in the build/me…

2020-10-21 Thread GitBox
hit-lacus commented on a change in pull request #1457: URL: https://github.com/apache/kylin/pull/1457#discussion_r509844056 ## File path: kylin-spark-project/kylin-spark-engine/src/test/java/org/apache/kylin/engine/spark/LocalWithSparkSessionTest.java ## @@ -328,4 +337,27 @@ p

[GitHub] [kylin] hit-lacus merged pull request #1457: KYLIN-4792 Verify several attribute values of segment in the build/me…

2020-10-21 Thread GitBox
hit-lacus merged pull request #1457: URL: https://github.com/apache/kylin/pull/1457 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] zhangayqian opened a new pull request #1458: KYLIN-4793 In some Hadoop versions, kylin calcite reported error beca…

2020-10-21 Thread GitBox
zhangayqian opened a new pull request #1458: URL: https://github.com/apache/kylin/pull/1458 …use there is no guava14 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or

[GitHub] [kylin] zhangayqian commented on pull request #1458: KYLIN-4793 In some Hadoop versions, kylin calcite reported error beca…

2020-10-21 Thread GitBox
zhangayqian commented on pull request #1458: URL: https://github.com/apache/kylin/pull/1458#issuecomment-714273721 Commit https://github.com/apache/kylin/commit/e1fd472d00eea438d26c26f032e819db56e33486 remove guava14 from Kylin.war,which will causes calcite reported error because there is

[GitHub] [kylin] hit-lacus commented on pull request #1449: KYLIN-4788 add segmentName and regionName in Coprocessor deadline info

2020-10-22 Thread GitBox
hit-lacus commented on pull request #1449: URL: https://github.com/apache/kylin/pull/1449#issuecomment-714320328 Thank you for @fengpod 's patch and @bigxiaochu 's comment, I will verify and merge this patch. This is an auto

[GitHub] [kylin] zhangayqian opened a new pull request #1459: KYLIN-4782 Verify if the query hit the true cuboid in IT - Part 3

2020-10-22 Thread GitBox
zhangayqian opened a new pull request #1459: URL: https://github.com/apache/kylin/pull/1459 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be

[GitHub] [kylin] zhangayqian commented on pull request #1459: KYLIN-4782 Verify if the query hit the true cuboid in IT - Part 3

2020-10-22 Thread GitBox
zhangayqian commented on pull request #1459: URL: https://github.com/apache/kylin/pull/1459#issuecomment-714432496 IT passed. https://user-images.githubusercontent.com/31064237/96866311-b8eea280-149d-11eb-8edf-1ad3928e8d55.png";> -

[GitHub] [kylin] zzcclp commented on pull request #1459: KYLIN-4782 Verify if the query hit the true cuboid in IT - Part 3

2020-10-22 Thread GitBox
zzcclp commented on pull request #1459: URL: https://github.com/apache/kylin/pull/1459#issuecomment-714536637 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kylin] hit-lacus opened a new pull request #1460: System testing by docker-compose

2020-10-22 Thread GitBox
hit-lacus opened a new pull request #1460: URL: https://github.com/apache/kylin/pull/1460 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be s

[GitHub] [kylin] coveralls commented on pull request #1460: System testing by docker-compose

2020-10-22 Thread GitBox
coveralls commented on pull request #1460: URL: https://github.com/apache/kylin/pull/1460#issuecomment-714872540 ## Pull Request Test Coverage Report for [Build 6478](https://coveralls.io/builds/34399611) * **3** of **5** **(60.0%)** changed or added relevant lines in **1** file

[GitHub] [kylin] zzcclp commented on a change in pull request #1458: KYLIN-4793 In some Hadoop versions, kylin calcite reported error beca…

2020-10-22 Thread GitBox
zzcclp commented on a change in pull request #1458: URL: https://github.com/apache/kylin/pull/1458#discussion_r510567480 ## File path: build/bin/kylin.sh ## @@ -72,7 +72,14 @@ function retrieveDependency() { KYLIN_SPARK_JARS_HOME="${KYLIN_HOME}/spark/jars" if [[ -d "/

[GitHub] [kylin] zzcclp commented on a change in pull request #1458: KYLIN-4793 In some Hadoop versions, kylin calcite reported error beca…

2020-10-22 Thread GitBox
zzcclp commented on a change in pull request #1458: URL: https://github.com/apache/kylin/pull/1458#discussion_r510567639 ## File path: build/bin/kylin.sh ## @@ -72,7 +72,14 @@ function retrieveDependency() { KYLIN_SPARK_JARS_HOME="${KYLIN_HOME}/spark/jars" if [[ -d "/

[GitHub] [kylin] zhangayqian commented on a change in pull request #1458: KYLIN-4793 In some Hadoop versions, kylin calcite reported error beca…

2020-10-22 Thread GitBox
zhangayqian commented on a change in pull request #1458: URL: https://github.com/apache/kylin/pull/1458#discussion_r510569197 ## File path: build/bin/kylin.sh ## @@ -72,7 +72,14 @@ function retrieveDependency() { KYLIN_SPARK_JARS_HOME="${KYLIN_HOME}/spark/jars" if [[

[GitHub] [kylin] hit-lacus merged pull request #1459: KYLIN-4782 Verify if the query hit the true cuboid in IT - Part 3

2020-10-22 Thread GitBox
hit-lacus merged pull request #1459: URL: https://github.com/apache/kylin/pull/1459 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] zzcclp opened a new pull request #1461: KYLIN-4797 Correct inputRecordSizes of segment when there is no data in this segment

2020-10-22 Thread GitBox
zzcclp opened a new pull request #1461: URL: https://github.com/apache/kylin/pull/1461 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure

[GitHub] [kylin] hit-lacus merged pull request #1461: KYLIN-4797 Correct inputRecordSizes of segment when there is no data in this segment

2020-10-22 Thread GitBox
hit-lacus merged pull request #1461: URL: https://github.com/apache/kylin/pull/1461 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] zhangayqian commented on a change in pull request #1458: KYLIN-4793 In some Hadoop versions, kylin calcite reported error beca…

2020-10-22 Thread GitBox
zhangayqian commented on a change in pull request #1458: URL: https://github.com/apache/kylin/pull/1458#discussion_r510668060 ## File path: build/bin/kylin.sh ## @@ -72,7 +72,14 @@ function retrieveDependency() { KYLIN_SPARK_JARS_HOME="${KYLIN_HOME}/spark/jars" if [[

[GitHub] [kylin] zzcclp commented on pull request #1458: KYLIN-4793 In some Hadoop versions, kylin calcite reported error beca…

2020-10-23 Thread GitBox
zzcclp commented on pull request #1458: URL: https://github.com/apache/kylin/pull/1458#issuecomment-715094123 LGTM, @hit-lacus please review. This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kylin] hit-lacus merged pull request #1458: KYLIN-4793 In some Hadoop versions, kylin calcite reported error beca…

2020-10-23 Thread GitBox
hit-lacus merged pull request #1458: URL: https://github.com/apache/kylin/pull/1458 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] chenjie-sau closed pull request #1451: KYLIN-4736 Upgrade Flink version to 1.11.1

2020-10-24 Thread GitBox
chenjie-sau closed pull request #1451: URL: https://github.com/apache/kylin/pull/1451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kylin] chenjie-sau opened a new pull request #1462: [Kylin-4736] flink upgrade to 1.11.1 and Solve the problem of file closing early in cdh5

2020-10-24 Thread GitBox
chenjie-sau opened a new pull request #1462: URL: https://github.com/apache/kylin/pull/1462 ## Proposed changes flink upgrade to 1.11.1 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kylin] chenjie-sau commented on pull request #1462: [Kylin-4736] flink upgrade to 1.11.1 and Solve the problem of file closing early in cdh5

2020-10-24 Thread GitBox
chenjie-sau commented on pull request #1462: URL: https://github.com/apache/kylin/pull/1462#issuecomment-715891466 @yanghua could you please take a look when free, thank you This is an automated message from the Apache Git Se

[GitHub] [kylin] coveralls commented on pull request #1462: [Kylin-4736] flink upgrade to 1.11.1 and Solve the problem of file closing early in cdh5

2020-10-24 Thread GitBox
coveralls commented on pull request #1462: URL: https://github.com/apache/kylin/pull/1462#issuecomment-715894067 ## Pull Request Test Coverage Report for [Build 6483](https://coveralls.io/builds/34430039) * **3** of **4** **(75.0%)** changed or added relevant lines in **2** files

[GitHub] [kylin] zhangayqian commented on pull request #1462: [Kylin-4736] flink upgrade to 1.11.1

2020-10-26 Thread GitBox
zhangayqian commented on pull request #1462: URL: https://github.com/apache/kylin/pull/1462#issuecomment-716369936 @chenjie-sau @yanghua Thanks!LGTM,works well in my local env (cdh57). This is an automated message from the Ap

[GitHub] [kylin] coveralls edited a comment on pull request #1460: System testing by docker-compose

2020-10-26 Thread GitBox
coveralls edited a comment on pull request #1460: URL: https://github.com/apache/kylin/pull/1460#issuecomment-714872540 ## Pull Request Test Coverage Report for [Build 6490](https://coveralls.io/builds/34472443) * **3** of **5** **(60.0%)** changed or added relevant lines in **1**

[GitHub] [kylin] coveralls edited a comment on pull request #1460: System testing by docker-compose

2020-10-26 Thread GitBox
coveralls edited a comment on pull request #1460: URL: https://github.com/apache/kylin/pull/1460#issuecomment-714872540 ## Pull Request Test Coverage Report for [Build 6492](https://coveralls.io/builds/34473720) * **3** of **5** **(60.0%)** changed or added relevant lines in **1**

[GitHub] [kylin] coveralls edited a comment on pull request #1460: System testing by docker-compose

2020-10-26 Thread GitBox
coveralls edited a comment on pull request #1460: URL: https://github.com/apache/kylin/pull/1460#issuecomment-714872540 ## Pull Request Test Coverage Report for [Build 6493](https://coveralls.io/builds/34474510) * **3** of **5** **(60.0%)** changed or added relevant lines in **1**

[GitHub] [kylin] coveralls edited a comment on pull request #1460: System testing by docker-compose

2020-10-26 Thread GitBox
coveralls edited a comment on pull request #1460: URL: https://github.com/apache/kylin/pull/1460#issuecomment-714872540 ## Pull Request Test Coverage Report for [Build 6494](https://coveralls.io/builds/34475699) * **3** of **5** **(60.0%)** changed or added relevant lines in **1**

[GitHub] [kylin] coveralls edited a comment on pull request #1460: System testing by docker-compose

2020-10-26 Thread GitBox
coveralls edited a comment on pull request #1460: URL: https://github.com/apache/kylin/pull/1460#issuecomment-714872540 ## Pull Request Test Coverage Report for [Build 6495](https://coveralls.io/builds/34475987) * **3** of **5** **(60.0%)** changed or added relevant lines in **1**

[GitHub] [kylin] coveralls edited a comment on pull request #1460: System testing by docker-compose

2020-10-26 Thread GitBox
coveralls edited a comment on pull request #1460: URL: https://github.com/apache/kylin/pull/1460#issuecomment-714872540 ## Pull Request Test Coverage Report for [Build 6496](https://coveralls.io/builds/34476198) * **3** of **5** **(60.0%)** changed or added relevant lines in **1**

[GitHub] [kylin] coveralls edited a comment on pull request #1460: System testing by docker-compose

2020-10-26 Thread GitBox
coveralls edited a comment on pull request #1460: URL: https://github.com/apache/kylin/pull/1460#issuecomment-714872540 ## Pull Request Test Coverage Report for [Build 6497](https://coveralls.io/builds/34476320) * **3** of **5** **(60.0%)** changed or added relevant lines in **1**

[GitHub] [kylin] yanghua merged pull request #1462: KYLIN-4736 flink upgrade to 1.11.1

2020-10-26 Thread GitBox
yanghua merged pull request #1462: URL: https://github.com/apache/kylin/pull/1462 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kylin] coveralls edited a comment on pull request #1460: System testing by docker-compose

2020-10-26 Thread GitBox
coveralls edited a comment on pull request #1460: URL: https://github.com/apache/kylin/pull/1460#issuecomment-714872540 ## Pull Request Test Coverage Report for [Build 6498](https://coveralls.io/builds/34479763) * **3** of **5** **(60.0%)** changed or added relevant lines in **1**

[GitHub] [kylin] zzcclp commented on a change in pull request #1462: KYLIN-4736 flink upgrade to 1.11.1

2020-10-27 Thread GitBox
zzcclp commented on a change in pull request #1462: URL: https://github.com/apache/kylin/pull/1462#discussion_r512462114 ## File path: core-common/src/main/java/org/apache/kylin/common/util/HadoopUtil.java ## @@ -64,12 +64,14 @@ public static Configuration getCurrentConfigurat

[GitHub] [kylin] chenjie-sau commented on a change in pull request #1462: KYLIN-4736 flink upgrade to 1.11.1

2020-10-27 Thread GitBox
chenjie-sau commented on a change in pull request #1462: URL: https://github.com/apache/kylin/pull/1462#discussion_r512478705 ## File path: core-common/src/main/java/org/apache/kylin/common/util/HadoopUtil.java ## @@ -64,12 +64,14 @@ public static Configuration getCurrentConfi

[GitHub] [kylin] zzcclp opened a new pull request #1463: KYLIN-4762 Optimize join where there is the same shardby partition num on join key -- Part I Implement on kylin side

2020-10-27 Thread GitBox
zzcclp opened a new pull request #1463: URL: https://github.com/apache/kylin/pull/1463 ## Proposed changes Optimize join where there is the same shardby partition num on join key. Part I : Implement on kylin side ## Types of changes What types of changes does y

[GitHub] [kylin] zhangayqian opened a new pull request #1464: KYLIN-4800 Add canary tool for sparder-context

2020-10-27 Thread GitBox
zhangayqian opened a new pull request #1464: URL: https://github.com/apache/kylin/pull/1464 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be

[GitHub] [kylin] coveralls edited a comment on pull request #1460: System testing by docker-compose

2020-10-27 Thread GitBox
coveralls edited a comment on pull request #1460: URL: https://github.com/apache/kylin/pull/1460#issuecomment-714872540 ## Pull Request Test Coverage Report for [Build 6504](https://coveralls.io/builds/34514438) * **3** of **5** **(60.0%)** changed or added relevant lines in **1**

[GitHub] [kylin] coveralls edited a comment on pull request #1460: System testing by docker-compose

2020-10-27 Thread GitBox
coveralls edited a comment on pull request #1460: URL: https://github.com/apache/kylin/pull/1460#issuecomment-714872540 ## Pull Request Test Coverage Report for [Build 6505](https://coveralls.io/builds/34515680) * **3** of **5** **(60.0%)** changed or added relevant lines in **1**

[GitHub] [kylin] hit-lacus merged pull request #1463: KYLIN-4762 Optimize join where there is the same shardby partition num on join key -- Part I Implement on kylin side

2020-10-27 Thread GitBox
hit-lacus merged pull request #1463: URL: https://github.com/apache/kylin/pull/1463 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on a change in pull request #1464: KYLIN-4800 Add canary tool for sparder-context

2020-10-27 Thread GitBox
hit-lacus commented on a change in pull request #1464: URL: https://github.com/apache/kylin/pull/1464#discussion_r513215189 ## File path: kylin-spark-project/kylin-spark-query/src/main/scala/org/apache/spark/sql/SparderContext.scala ## @@ -194,6 +195,10 @@ object SparderContex

[GitHub] [kylin] zhangayqian opened a new pull request #1465: KYLIN-4774 Provide a System Testing Framwork for Kylin Cluster

2020-10-27 Thread GitBox
zhangayqian opened a new pull request #1465: URL: https://github.com/apache/kylin/pull/1465 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be

[GitHub] [kylin] hit-lacus commented on a change in pull request #1464: KYLIN-4800 Add canary tool for sparder-context

2020-10-27 Thread GitBox
hit-lacus commented on a change in pull request #1464: URL: https://github.com/apache/kylin/pull/1464#discussion_r513216412 ## File path: kylin-spark-project/kylin-spark-query/src/main/java/org/apache/kylin/query/monitor/SparderContextCanary.java ## @@ -0,0 +1,143 @@ +/* + * L

[GitHub] [kylin] hit-lacus commented on a change in pull request #1464: KYLIN-4800 Add canary tool for sparder-context

2020-10-28 Thread GitBox
hit-lacus commented on a change in pull request #1464: URL: https://github.com/apache/kylin/pull/1464#discussion_r513218360 ## File path: kylin-spark-project/kylin-spark-query/src/main/java/org/apache/kylin/query/monitor/SparderContextCanary.java ## @@ -0,0 +1,143 @@ +/* + * L

[GitHub] [kylin] hit-lacus commented on a change in pull request #1464: KYLIN-4800 Add canary tool for sparder-context

2020-10-28 Thread GitBox
hit-lacus commented on a change in pull request #1464: URL: https://github.com/apache/kylin/pull/1464#discussion_r513218472 ## File path: kylin-spark-project/kylin-spark-query/src/main/java/org/apache/kylin/query/monitor/SparderContextCanary.java ## @@ -0,0 +1,143 @@ +/* + * L

[GitHub] [kylin] hit-lacus commented on a change in pull request #1464: KYLIN-4800 Add canary tool for sparder-context

2020-10-28 Thread GitBox
hit-lacus commented on a change in pull request #1464: URL: https://github.com/apache/kylin/pull/1464#discussion_r513218905 ## File path: kylin-spark-project/kylin-spark-query/src/main/java/org/apache/kylin/query/monitor/SparderContextCanary.java ## @@ -0,0 +1,143 @@ +/* + * L

[GitHub] [kylin] hit-lacus commented on a change in pull request #1464: KYLIN-4800 Add canary tool for sparder-context

2020-10-28 Thread GitBox
hit-lacus commented on a change in pull request #1464: URL: https://github.com/apache/kylin/pull/1464#discussion_r513219639 ## File path: core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java ## @@ -2879,6 +2879,18 @@ public boolean isAutoStartSparder() {

[GitHub] [kylin] hit-lacus closed pull request #1460: System testing by docker-compose

2020-10-28 Thread GitBox
hit-lacus closed pull request #1460: URL: https://github.com/apache/kylin/pull/1460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1460: System testing by docker-compose

2020-10-28 Thread GitBox
hit-lacus commented on pull request #1460: URL: https://github.com/apache/kylin/pull/1460#issuecomment-717764098 No need This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kylin] hit-lacus closed pull request #1435: KYLIN-4778 package and release in docker container

2020-10-28 Thread GitBox
hit-lacus closed pull request #1435: URL: https://github.com/apache/kylin/pull/1435 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus closed pull request #1424: KYLIN-4775 Use docker-compose to deploy Hadoop and Kylin

2020-10-28 Thread GitBox
hit-lacus closed pull request #1424: URL: https://github.com/apache/kylin/pull/1424 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1424: KYLIN-4775 Use docker-compose to deploy Hadoop and Kylin

2020-10-28 Thread GitBox
hit-lacus commented on pull request #1424: URL: https://github.com/apache/kylin/pull/1424#issuecomment-717765271 @liuyonghengheng Really appreacite your contribution! @zhangayqian will add your patchs in her PR( https://github.com/apache/kylin/pull/1465) with some modification, so I will

[GitHub] [kylin] coveralls commented on pull request #1465: KYLIN-4774 Provide a System Testing Framwork for Kylin Cluster

2020-10-28 Thread GitBox
coveralls commented on pull request #1465: URL: https://github.com/apache/kylin/pull/1465#issuecomment-717773146 ## Pull Request Test Coverage Report for [Build 6506](https://coveralls.io/builds/34520148) * **3** of **5** **(60.0%)** changed or added relevant lines in **1** file

[GitHub] [kylin] lgtm-com[bot] commented on pull request #1465: KYLIN-4774 Provide a System Testing Framwork for Kylin Cluster

2020-10-28 Thread GitBox
lgtm-com[bot] commented on pull request #1465: URL: https://github.com/apache/kylin/pull/1465#issuecomment-717814132 This pull request **introduces 6 alerts** when merging 68cc133088d6478a325adffcf36c49d727840ef5 into 2353abe84b2a60fe2dec0485d638a98e20244004 - [view on LGTM.com](https://l

[GitHub] [kylin] coveralls edited a comment on pull request #1465: KYLIN-4774 Provide a System Testing Framwork for Kylin Cluster

2020-10-28 Thread GitBox
coveralls edited a comment on pull request #1465: URL: https://github.com/apache/kylin/pull/1465#issuecomment-717773146 ## Pull Request Test Coverage Report for [Build 6509](https://coveralls.io/builds/34523711) * **3** of **5** **(60.0%)** changed or added relevant lines in **1**

[GitHub] [kylin] lgtm-com[bot] commented on pull request #1465: KYLIN-4774 Provide a System Testing Framwork for Kylin Cluster

2020-10-28 Thread GitBox
lgtm-com[bot] commented on pull request #1465: URL: https://github.com/apache/kylin/pull/1465#issuecomment-717861869 This pull request **introduces 6 alerts** when merging 983dfeab4e0355c661dfc96ee1668c13ac9844e4 into 2353abe84b2a60fe2dec0485d638a98e20244004 - [view on LGTM.com](https://l

[GitHub] [kylin] lgtm-com[bot] commented on pull request #1465: KYLIN-4774 Provide a System Testing Framwork for Kylin Cluster

2020-10-28 Thread GitBox
lgtm-com[bot] commented on pull request #1465: URL: https://github.com/apache/kylin/pull/1465#issuecomment-717903005 This pull request **introduces 6 alerts** when merging 72aaf2b6ea246ea4264c2e775ffdd50650084f15 into 2353abe84b2a60fe2dec0485d638a98e20244004 - [view on LGTM.com](https://l

[GitHub] [kylin] coveralls edited a comment on pull request #1465: KYLIN-4774 Provide a System Testing Framwork for Kylin Cluster

2020-10-28 Thread GitBox
coveralls edited a comment on pull request #1465: URL: https://github.com/apache/kylin/pull/1465#issuecomment-717773146 ## Pull Request Test Coverage Report for [Build 6511](https://coveralls.io/builds/34530048) * **3** of **5** **(60.0%)** changed or added relevant lines in **1**

[GitHub] [kylin] hit-lacus merged pull request #1464: KYLIN-4800 Add canary tool for sparder-context

2020-10-28 Thread GitBox
hit-lacus merged pull request #1464: URL: https://github.com/apache/kylin/pull/1464 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] joey-yoonsung opened a new pull request #1466: KYLIN-4799 Create CONTRIBUTING.md

2020-10-28 Thread GitBox
joey-yoonsung opened a new pull request #1466: URL: https://github.com/apache/kylin/pull/1466 ## Proposed changes There are documents for developers on the website. Placing CONTRIBUTING.md in the root of the GitHub repository is defacto-standard but this project doesn't. I create a

[GitHub] [kylin] coveralls commented on pull request #1466: KYLIN-4799 Create CONTRIBUTING.md

2020-10-28 Thread GitBox
coveralls commented on pull request #1466: URL: https://github.com/apache/kylin/pull/1466#issuecomment-718355411 ## Pull Request Test Coverage Report for [Build 6513](https://coveralls.io/builds/34548357) * **0** of **0** changed or added relevant lines in **0** files are covered.

[GitHub] [kylin] lgtm-com[bot] commented on pull request #1465: KYLIN-4774 Provide a System Testing Framwork for Kylin Cluster

2020-10-28 Thread GitBox
lgtm-com[bot] commented on pull request #1465: URL: https://github.com/apache/kylin/pull/1465#issuecomment-718402366 This pull request **introduces 6 alerts** when merging d95bceb20daa57c6c8df47ab5908eea7f42e3c9d into 2353abe84b2a60fe2dec0485d638a98e20244004 - [view on LGTM.com](https://l

[GitHub] [kylin] coveralls edited a comment on pull request #1465: KYLIN-4774 Provide a System Testing Framwork for Kylin Cluster

2020-10-29 Thread GitBox
coveralls edited a comment on pull request #1465: URL: https://github.com/apache/kylin/pull/1465#issuecomment-717773146 ## Pull Request Test Coverage Report for [Build 6514](https://coveralls.io/builds/34551437) * **3** of **5** **(60.0%)** changed or added relevant lines in **1**

[GitHub] [kylin] shaofengshi commented on pull request #1466: KYLIN-4799 Create CONTRIBUTING.md

2020-10-29 Thread GitBox
shaofengshi commented on pull request #1466: URL: https://github.com/apache/kylin/pull/1466#issuecomment-719123933 LGTM, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kylin] shaofengshi merged pull request #1466: KYLIN-4799 Create CONTRIBUTING.md

2020-10-29 Thread GitBox
shaofengshi merged pull request #1466: URL: https://github.com/apache/kylin/pull/1466 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kylin] guangxuCheng commented on pull request #1369: KYLIN-4711 Change default value to 3 for kylin.metadata.hbase-client-…

2020-11-04 Thread GitBox
guangxuCheng commented on pull request #1369: URL: https://github.com/apache/kylin/pull/1369#issuecomment-721589488 @hit-lacus can you take a look again? This PR will be very effective when hbase encounters an exception This

[GitHub] [kylin] zhangayqian opened a new pull request #1468: KYLIN-4808 Auto copy hive-site.xml to hadoop_conf_dir in kylin4

2020-11-05 Thread GitBox
zhangayqian opened a new pull request #1468: URL: https://github.com/apache/kylin/pull/1468 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be

[GitHub] [kylin] Ted-Jiang opened a new pull request #1469: [KYLIN-4639] Make batch account without any authorities to be able to…

2020-11-06 Thread GitBox
Ted-Jiang opened a new pull request #1469: URL: https://github.com/apache/kylin/pull/1469 … see web pages ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves

[GitHub] [kylin] coveralls commented on pull request #1469: [KYLIN-4639] Make batch account without any authorities to be able to…

2020-11-06 Thread GitBox
coveralls commented on pull request #1469: URL: https://github.com/apache/kylin/pull/1469#issuecomment-722976801 ## Pull Request Test Coverage Report for [Build 6527](https://coveralls.io/builds/34768610) * **0** of **0** changed or added relevant lines in **0** files are covered.

[GitHub] [kylin] Ted-Jiang opened a new pull request #1470: [KYLIN-4702] Fix missing cube-level lookup table snapshot when doing …

2020-11-06 Thread GitBox
Ted-Jiang opened a new pull request #1470: URL: https://github.com/apache/kylin/pull/1470 …cube migration ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves

[GitHub] [kylin] zhangayqian opened a new pull request #1471: System testing framework

2020-11-06 Thread GitBox
zhangayqian opened a new pull request #1471: URL: https://github.com/apache/kylin/pull/1471 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be

[GitHub] [kylin] lgtm-com[bot] commented on pull request #1471: KYLIN-4774 System testing framework

2020-11-06 Thread GitBox
lgtm-com[bot] commented on pull request #1471: URL: https://github.com/apache/kylin/pull/1471#issuecomment-722997385 This pull request **introduces 7 alerts** when merging e31f11df9c8dda217838f948245d1b5569438087 into 1d43e0a4ac81648f89666365e06e2519ae53271b - [view on LGTM.com](https://l

[GitHub] [kylin] coveralls commented on pull request #1470: [KYLIN-4702] Fix missing cube-level lookup table snapshot when doing …

2020-11-06 Thread GitBox
coveralls commented on pull request #1470: URL: https://github.com/apache/kylin/pull/1470#issuecomment-723011594 ## Pull Request Test Coverage Report for [Build 6528](https://coveralls.io/builds/34770796) * **0** of **14** **(0.0%)** changed or added relevant lines in **2** files

[GitHub] [kylin] lgtm-com[bot] commented on pull request #1471: KYLIN-4774 System testing framework

2020-11-06 Thread GitBox
lgtm-com[bot] commented on pull request #1471: URL: https://github.com/apache/kylin/pull/1471#issuecomment-723058779 This pull request **introduces 7 alerts** when merging 8b66e2da28940d6c811adec6803e6489054ca985 into 1d43e0a4ac81648f89666365e06e2519ae53271b - [view on LGTM.com](https://l

[GitHub] [kylin] hit-lacus merged pull request #1471: KYLIN-4774 System testing framework

2020-11-08 Thread GitBox
hit-lacus merged pull request #1471: URL: https://github.com/apache/kylin/pull/1471 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus merged pull request #1468: KYLIN-4808 Auto copy hive-site.xml to hadoop_conf_dir in kylin4

2020-11-08 Thread GitBox
hit-lacus merged pull request #1468: URL: https://github.com/apache/kylin/pull/1468 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] hit-lacus commented on pull request #1369: KYLIN-4711 Change default value to 3 for kylin.metadata.hbase-client-…

2020-11-08 Thread GitBox
hit-lacus commented on pull request #1369: URL: https://github.com/apache/kylin/pull/1369#issuecomment-723549225 > @hit-lacus can you take a look again? This PR will be very effective when hbase encounters an exception I am sorry, I and my teammate understand your purpose. But I am j

[GitHub] [kylin] hit-lacus opened a new pull request #1472: KYLIN-4811 Support cube level configuration for BuildingJob

2020-11-08 Thread GitBox
hit-lacus opened a new pull request #1472: URL: https://github.com/apache/kylin/pull/1472 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be s

[GitHub] [kylin] hit-lacus commented on pull request #1472: KYLIN-4811 Support cube level configuration for BuildingJob

2020-11-08 Thread GitBox
hit-lacus commented on pull request #1472: URL: https://github.com/apache/kylin/pull/1472#issuecomment-723579513 1. Add spark-conf https://user-images.githubusercontent.com/14030549/98466656-d2b51700-220b-11eb-8721-b3b84f4c2527.png";> 2. Build a segment https://user-

[GitHub] [kylin] hit-lacus edited a comment on pull request #1472: KYLIN-4811 Support cube level configuration for BuildingJob

2020-11-08 Thread GitBox
hit-lacus edited a comment on pull request #1472: URL: https://github.com/apache/kylin/pull/1472#issuecomment-723579513 ## Test Plan 1. Add spark-conf https://user-images.githubusercontent.com/14030549/98466656-d2b51700-220b-11eb-8721-b3b84f4c2527.png";> 2. Build a s

[GitHub] [kylin] codecov-io commented on pull request #1472: KYLIN-4811 Support cube level configuration for BuildingJob

2020-11-08 Thread GitBox
codecov-io commented on pull request #1472: URL: https://github.com/apache/kylin/pull/1472#issuecomment-723580672 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1472?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`kylin-on-parquet-v2@2db2800`). [Cli

[GitHub] [kylin] zzcclp commented on pull request #1472: KYLIN-4811 Support cube level configuration for BuildingJob

2020-11-08 Thread GitBox
zzcclp commented on pull request #1472: URL: https://github.com/apache/kylin/pull/1472#issuecomment-723709107 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kylin] hit-lacus commented on pull request #1472: KYLIN-4811 Support cube level configuration for BuildingJob

2020-11-08 Thread GitBox
hit-lacus commented on pull request #1472: URL: https://github.com/apache/kylin/pull/1472#issuecomment-723714208 I will merge this patch. This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kylin] hit-lacus merged pull request #1472: KYLIN-4811 Support cube level configuration for BuildingJob

2020-11-08 Thread GitBox
hit-lacus merged pull request #1472: URL: https://github.com/apache/kylin/pull/1472 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] zhangayqian opened a new pull request #1473: KYLIN-4808 Return after finding the correct hadoop_conf to avoid cont…

2020-11-09 Thread GitBox
zhangayqian opened a new pull request #1473: URL: https://github.com/apache/kylin/pull/1473 …inue scanning other directories ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes

[GitHub] [kylin] zzcclp commented on pull request #1473: KYLIN-4808 Return after finding the correct hadoop_conf to avoid cont…

2020-11-09 Thread GitBox
zzcclp commented on pull request #1473: URL: https://github.com/apache/kylin/pull/1473#issuecomment-724378753 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kylin] hit-lacus merged pull request #1473: KYLIN-4808 Return after finding the correct hadoop_conf to avoid cont…

2020-11-09 Thread GitBox
hit-lacus merged pull request #1473: URL: https://github.com/apache/kylin/pull/1473 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kylin] xuekaiqi opened a new pull request #1474: update system cube

2020-11-09 Thread GitBox
xuekaiqi opened a new pull request #1474: URL: https://github.com/apache/kylin/pull/1474 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be su

[GitHub] [kylin] hit-lacus commented on a change in pull request #1474: update system cube

2020-11-09 Thread GitBox
hit-lacus commented on a change in pull request #1474: URL: https://github.com/apache/kylin/pull/1474#discussion_r520266098 ## File path: website/_docs/tutorial/setup_systemcube.cn.md ## @@ -356,17 +376,25 @@ sh ${KYLIN_HOME}/bin/kylin.sh org.apache.kylin.tool.job.CubeBuilding

[GitHub] [kylin] hit-lacus commented on a change in pull request #1474: update system cube

2020-11-09 Thread GitBox
hit-lacus commented on a change in pull request #1474: URL: https://github.com/apache/kylin/pull/1474#discussion_r520268140 ## File path: website/_docs/tutorial/setup_systemcube.cn.md ## @@ -7,16 +7,24 @@ permalink: /cn/docs/tutorial/setup_systemcube.html > 自 Apache Kylin v2

[GitHub] [kylin] xuekaiqi commented on a change in pull request #1474: update system cube

2020-11-09 Thread GitBox
xuekaiqi commented on a change in pull request #1474: URL: https://github.com/apache/kylin/pull/1474#discussion_r520268485 ## File path: website/_docs/tutorial/setup_systemcube.cn.md ## @@ -7,16 +7,24 @@ permalink: /cn/docs/tutorial/setup_systemcube.html > 自 Apache Kylin v2.

[GitHub] [kylin] hit-lacus commented on a change in pull request #1474: update system cube

2020-11-09 Thread GitBox
hit-lacus commented on a change in pull request #1474: URL: https://github.com/apache/kylin/pull/1474#discussion_r520268419 ## File path: website/_docs/tutorial/setup_systemcube.md ## @@ -383,56 +414,82 @@ This Cube is for collecting job metrics. The details are as follows:

[GitHub] [kylin] hit-lacus commented on a change in pull request #1474: update system cube

2020-11-09 Thread GitBox
hit-lacus commented on a change in pull request #1474: URL: https://github.com/apache/kylin/pull/1474#discussion_r520268520 ## File path: website/_docs/tutorial/setup_systemcube.md ## @@ -383,56 +414,82 @@ This Cube is for collecting job metrics. The details are as follows:

[GitHub] [kylin] hit-lacus commented on a change in pull request #1474: update system cube

2020-11-09 Thread GitBox
hit-lacus commented on a change in pull request #1474: URL: https://github.com/apache/kylin/pull/1474#discussion_r520268672 ## File path: website/_docs/tutorial/setup_systemcube.md ## @@ -383,56 +414,82 @@ This Cube is for collecting job metrics. The details are as follows:

[GitHub] [kylin] hit-lacus commented on a change in pull request #1474: update system cube

2020-11-09 Thread GitBox
hit-lacus commented on a change in pull request #1474: URL: https://github.com/apache/kylin/pull/1474#discussion_r520329656 ## File path: website/_docs/tutorial/setup_systemcube.md ## @@ -189,19 +202,19 @@ This Cube is for collecting query metrics at the highest level. The det

[GitHub] [kylin] hit-lacus commented on a change in pull request #1474: update system cube

2020-11-09 Thread GitBox
hit-lacus commented on a change in pull request #1474: URL: https://github.com/apache/kylin/pull/1474#discussion_r520329963 ## File path: website/_docs/tutorial/setup_systemcube.md ## @@ -189,19 +202,19 @@ This Cube is for collecting query metrics at the highest level. The det

<    18   19   20   21   22   23   24   25   26   27   >