[GitHub] [lucene-solr] gunasekhardora opened a new pull request #1048: SOLR-13806: change type of QueryResponse._explainMap

2019-11-30 Thread GitBox
gunasekhardora opened a new pull request #1048: SOLR-13806: change type of QueryResponse._explainMap URL: https://github.com/apache/lucene-solr/pull/1048 # Description Please provide a short description of the changes you're making with this pull request. # Soluti

[jira] [Commented] (SOLR-13986) remove "execute" permission from solr-tests.policy

2019-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985481#comment-16985481 ] Robert Muir commented on SOLR-13986: With the attached patch (containing numerous ugl

[jira] [Updated] (SOLR-13986) remove "execute" permission from solr-tests.policy

2019-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated SOLR-13986: --- Attachment: SOLR-13986.patch > remove "execute" permission from solr-tests.policy > -

[GitHub] [lucene-solr] praste commented on a change in pull request #153: Fix issues reported by findbugs

2019-11-30 Thread GitBox
praste commented on a change in pull request #153: Fix issues reported by findbugs URL: https://github.com/apache/lucene-solr/pull/153#discussion_r352319352 ## File path: solr/contrib/extraction/src/java/org/apache/solr/handler/extraction/XLSXResponseWriter.java ## @@ -35

[jira] [Assigned] (SOLR-13897) Unsafe publication of Terms object in ZkShardTerms

2019-11-30 Thread Shalin Shekhar Mangar (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar reassigned SOLR-13897: Assignee: Shalin Shekhar Mangar > Unsafe publication of Terms object in Zk

[jira] [Commented] (SOLR-13897) Unsafe publication of Terms object in ZkShardTerms

2019-11-30 Thread Shalin Shekhar Mangar (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985479#comment-16985479 ] Shalin Shekhar Mangar commented on SOLR-13897: -- This patch adds registerTerm

[jira] [Updated] (SOLR-13897) Unsafe publication of Terms object in ZkShardTerms

2019-11-30 Thread Shalin Shekhar Mangar (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar updated SOLR-13897: - Status: Patch Available (was: Open) > Unsafe publication of Terms object in ZkSh

[jira] [Updated] (SOLR-13897) Unsafe publication of Terms object in ZkShardTerms

2019-11-30 Thread Shalin Shekhar Mangar (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar updated SOLR-13897: - Attachment: SOLR-13897.patch > Unsafe publication of Terms object in ZkShardTerms

[jira] [Created] (SOLR-13989) Move all hadoop related code to a contrib module

2019-11-30 Thread Shalin Shekhar Mangar (Jira)
Shalin Shekhar Mangar created SOLR-13989: Summary: Move all hadoop related code to a contrib module Key: SOLR-13989 URL: https://issues.apache.org/jira/browse/SOLR-13989 Project: Solr

[jira] [Commented] (SOLR-13986) remove "execute" permission from solr-tests.policy

2019-11-30 Thread Shalin Shekhar Mangar (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985477#comment-16985477 ] Shalin Shekhar Mangar commented on SOLR-13986: -- bq. Unrelated to these speci

[jira] [Commented] (SOLR-13986) remove "execute" permission from solr-tests.policy

2019-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985475#comment-16985475 ] Robert Muir commented on SOLR-13986: I can't hack around all the broken hadoop code h

[jira] [Updated] (SOLR-13986) remove "execute" permission from solr-tests.policy

2019-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated SOLR-13986: --- Attachment: SOLR-13986.patch Status: Open (was: Open) I added a hack for their equally broke

[jira] [Commented] (SOLR-13986) remove "execute" permission from solr-tests.policy

2019-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985471#comment-16985471 ] Robert Muir commented on SOLR-13986: These problems are already present in tests toda

[jira] [Commented] (SOLR-13986) remove "execute" permission from solr-tests.policy

2019-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985468#comment-16985468 ] Robert Muir commented on SOLR-13986: I implemented patch with my workaround from befo

[jira] [Updated] (SOLR-13986) remove "execute" permission from solr-tests.policy

2019-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated SOLR-13986: --- Attachment: SOLR-13986.patch > remove "execute" permission from solr-tests.policy > -

[jira] [Updated] (SOLR-13897) Unsafe publication of Terms object in ZkShardTerms

2019-11-30 Thread Shalin Shekhar Mangar (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar updated SOLR-13897: - Attachment: SOLR-13897.patch > Unsafe publication of Terms object in ZkShardTerms

[jira] [Commented] (SOLR-13897) Unsafe publication of Terms object in ZkShardTerms

2019-11-30 Thread Shalin Shekhar Mangar (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985459#comment-16985459 ] Shalin Shekhar Mangar commented on SOLR-13897: -- The onTermUpdates might rece

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1043: LUCENE-9071: Speed up BM25 scores.

2019-11-30 Thread GitBox
bruno-roustant commented on a change in pull request #1043: LUCENE-9071: Speed up BM25 scores. URL: https://github.com/apache/lucene-solr/pull/1043#discussion_r352307646 ## File path: lucene/core/src/java/org/apache/lucene/search/similarities/BM25Similarity.java ## @@ -22

[GitHub] [lucene-solr] original-brownbear opened a new pull request #1047: MINOR: Fix Incorrect Constant Name in Codec Docs

2019-11-30 Thread GitBox
original-brownbear opened a new pull request #1047: MINOR: Fix Incorrect Constant Name in Codec Docs URL: https://github.com/apache/lucene-solr/pull/1047 The name was wrong here. Also, added a link to make this doc more fun to navigate in HTML form and make sure it doesn't go bad again.

[GitHub] [lucene-solr] rmuir commented on a change in pull request #1043: LUCENE-9071: Speed up BM25 scores.

2019-11-30 Thread GitBox
rmuir commented on a change in pull request #1043: LUCENE-9071: Speed up BM25 scores. URL: https://github.com/apache/lucene-solr/pull/1043#discussion_r352303377 ## File path: lucene/core/src/java/org/apache/lucene/search/similarities/BM25Similarity.java ## @@ -221,8 +251,

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1043: LUCENE-9071: Speed up BM25 scores.

2019-11-30 Thread GitBox
bruno-roustant commented on a change in pull request #1043: LUCENE-9071: Speed up BM25 scores. URL: https://github.com/apache/lucene-solr/pull/1043#discussion_r352157819 ## File path: lucene/core/src/java/org/apache/lucene/search/similarities/BM25Similarity.java ## @@ -22

[jira] [Updated] (SOLR-13988) Harden CreateCollectionCleanupTest

2019-11-30 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-13988: -- Priority: Minor (was: Major) > Harden CreateCollectionCleanupTest > --

[jira] [Updated] (SOLR-13988) Harden CreateCollectionCleanupTest

2019-11-30 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-13988: -- Status: Patch Available (was: Open) > Harden CreateCollectionCleanupTest > ---

[jira] [Updated] (SOLR-13988) Harden CreateCollectionCleanupTest

2019-11-30 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-13988: -- Attachment: SOLR-13988.patch > Harden CreateCollectionCleanupTest > ---

[jira] [Created] (SOLR-13988) Harden CreateCollectionCleanupTest

2019-11-30 Thread Erick Erickson (Jira)
Erick Erickson created SOLR-13988: - Summary: Harden CreateCollectionCleanupTest Key: SOLR-13988 URL: https://issues.apache.org/jira/browse/SOLR-13988 Project: Solr Issue Type: Improvement

[jira] [Commented] (SOLR-13982) set security-related http response headers by default

2019-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985418#comment-16985418 ] Robert Muir commented on SOLR-13982: I made a followup issue to address this {{unsafe

[jira] [Created] (SOLR-13987) fix admin UI to not rely on javascript eval()

2019-11-30 Thread Robert Muir (Jira)
Robert Muir created SOLR-13987: -- Summary: fix admin UI to not rely on javascript eval() Key: SOLR-13987 URL: https://issues.apache.org/jira/browse/SOLR-13987 Project: Solr Issue Type: Improvemen

[jira] [Commented] (SOLR-13986) remove "execute" permission from solr-tests.policy

2019-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985413#comment-16985413 ] Robert Muir commented on SOLR-13986: Attached "notyet" patch disables the execution,

[jira] [Updated] (SOLR-13986) remove "execute" permission from solr-tests.policy

2019-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated SOLR-13986: --- Attachment: SOLR-13986-notyet.patch > remove "execute" permission from solr-tests.policy > --

[jira] [Created] (SOLR-13986) remove "execute" permission from solr-tests.policy

2019-11-30 Thread Robert Muir (Jira)
Robert Muir created SOLR-13986: -- Summary: remove "execute" permission from solr-tests.policy Key: SOLR-13986 URL: https://issues.apache.org/jira/browse/SOLR-13986 Project: Solr Issue Type: Impro

[jira] [Commented] (SOLR-13984) Solr should run inside a SecurityManager

2019-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985411#comment-16985411 ] Robert Muir commented on SOLR-13984: Hi Ishan: what do you think about narrowing the

[jira] [Commented] (SOLR-13983) remove or replace process execution in SystemInfoHandler

2019-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985403#comment-16985403 ] Robert Muir commented on SOLR-13983: The only use of the e.g. {{uptime}} command run

[jira] [Updated] (SOLR-13983) remove or replace process execution in SystemInfoHandler

2019-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated SOLR-13983: --- Attachment: SOLR-13983.patch > remove or replace process execution in SystemInfoHandler > ---

[jira] [Commented] (SOLR-13982) set security-related http response headers by default

2019-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985398#comment-16985398 ] Robert Muir commented on SOLR-13982: It seems the angular framework used here can be

[jira] [Commented] (SOLR-13982) set security-related http response headers by default

2019-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985397#comment-16985397 ] Robert Muir commented on SOLR-13982: You can see the bad guy if you remove {{unsafe-e

[jira] [Commented] (SOLR-13982) set security-related http response headers by default

2019-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985392#comment-16985392 ] Robert Muir commented on SOLR-13982: {quote} How extensively do we use unsafe evaluat

[jira] [Commented] (SOLR-13982) set security-related http response headers by default

2019-11-30 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985386#comment-16985386 ] Ishan Chattopadhyaya commented on SOLR-13982: - Looks good, Robert. Thanks! b

[jira] [Updated] (SOLR-13985) bind to localhost by default

2019-11-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated SOLR-13985: --- Attachment: SOLR-13985.patch > bind to localhost by default > > >

[jira] [Created] (SOLR-13985) bind to localhost by default

2019-11-30 Thread Robert Muir (Jira)
Robert Muir created SOLR-13985: -- Summary: bind to localhost by default Key: SOLR-13985 URL: https://issues.apache.org/jira/browse/SOLR-13985 Project: Solr Issue Type: Improvement Security

[jira] [Commented] (SOLR-13984) Solr should run inside a SecurityManager

2019-11-30 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985382#comment-16985382 ] Ishan Chattopadhyaya commented on SOLR-13984: - Can someone with the expertise

[jira] [Created] (SOLR-13984) Solr should run inside a SecurityManager

2019-11-30 Thread Ishan Chattopadhyaya (Jira)
Ishan Chattopadhyaya created SOLR-13984: --- Summary: Solr should run inside a SecurityManager Key: SOLR-13984 URL: https://issues.apache.org/jira/browse/SOLR-13984 Project: Solr Issue Typ

[jira] [Assigned] (SOLR-13759) Optimize Queries when query filtering by TRA router.field

2019-11-30 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck reassigned SOLR-13759: --- Assignee: Gus Heck > Optimize Queries when query filtering by TRA router.field > ---

[jira] [Commented] (SOLR-13759) Optimize Queries when query filtering by TRA router.field

2019-11-30 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985380#comment-16985380 ] Gus Heck commented on SOLR-13759: - [~moshebla], you seem to have removed your patch? Was

[jira] [Updated] (SOLR-13759) Optimize Queries when query filtering by TRA router.field

2019-11-30 Thread mosh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mosh updated SOLR-13759: Attachment: SOLR-13759.patch > Optimize Queries when query filtering by TRA router.field >

[jira] [Updated] (SOLR-13759) Optimize Queries when query filtering by TRA router.field

2019-11-30 Thread mosh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mosh updated SOLR-13759: Attachment: (was: SOLR-13759.patch) > Optimize Queries when query filtering by TRA router.field > -

[jira] [Commented] (SOLR-13808) Query DSL should let to cache filter

2019-11-30 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985374#comment-16985374 ] Mikhail Khludnev commented on SOLR-13808: - [~caomanhdat], what's your opinion? Ca

[jira] [Commented] (LUCENE-9031) UnsupportedOperationException on highlighting Interval Query

2019-11-30 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985372#comment-16985372 ] Mikhail Khludnev commented on LUCENE-9031: -- {quote}I'd settle on looping as bet

[jira] [Updated] (LUCENE-9073) IntervalQuery to respond field on toString and explain

2019-11-30 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated LUCENE-9073: - Attachment: LUCENE-9073.patch > IntervalQuery to respond field on toString and explain >

[jira] [Commented] (SOLR-13904) Make Analytics component aware of timeAllowed

2019-11-30 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985367#comment-16985367 ] Lucene/Solr QA commented on SOLR-13904: --- | (/) *{color:green}+1 overall{color}* | \

[jira] [Commented] (SOLR-13806) SolrJ QueryResponse._explainMap is incorrectly typed

2019-11-30 Thread Guna Sekhar Dora (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985349#comment-16985349 ] Guna Sekhar Dora commented on SOLR-13806: - [~ab] May I pick this up?  > SolrJ Qu

[jira] [Updated] (SOLR-13759) Optimize Queries when query filtering by TRA router.field

2019-11-30 Thread mosh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mosh updated SOLR-13759: Status: Patch Available (was: Open) > Optimize Queries when query filtering by TRA router.field >

[jira] [Comment Edited] (SOLR-11960) Add collection level properties

2019-11-30 Thread Mia Parker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985301#comment-16985301 ] Mia Parker edited comment on SOLR-11960 at 11/30/19 9:35 AM: -

[jira] [Commented] (SOLR-11960) Add collection level properties

2019-11-30 Thread Mia Parker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985301#comment-16985301 ] Mia Parker commented on SOLR-11960: --- I like your content very much. I wanted this only.

[jira] [Commented] (SOLR-11960) Add collection level properties

2019-11-30 Thread Mia Parker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985300#comment-16985300 ] Mia Parker commented on SOLR-11960: --- I like this.. > Add collection level properties >

[jira] [Commented] (LUCENE-9066) Modal Strategy In Concurrent Query Execution

2019-11-30 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985291#comment-16985291 ] Adrien Grand commented on LUCENE-9066: -- The high level idea makes sense to me: incr