[GitHub] [lucene-solr] dweiss commented on issue #1429: LUCENE-9286: In FST, avoid using raw types.

2020-04-14 Thread GitBox
dweiss commented on issue #1429: LUCENE-9286: In FST, avoid using raw types. URL: https://github.com/apache/lucene-solr/pull/1429#issuecomment-613271182 Thanks Julie! This is an automated message from the Apache Git Service. T

[GitHub] [lucene-solr] dweiss merged pull request #1429: LUCENE-9286: In FST, avoid using raw types.

2020-04-14 Thread GitBox
dweiss merged pull request #1429: LUCENE-9286: In FST, avoid using raw types. URL: https://github.com/apache/lucene-solr/pull/1429 This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Commented] (SOLR-13138) Remove deprecated code in master

2020-04-14 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17082973#comment-17082973 ] Alan Woodward commented on SOLR-13138: -- [~dsmiley] sure, go ahead. Although I think

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1427: LUCENE-9304: Fix IW#getMaxCompletedSequenceNumber()

2020-04-14 Thread GitBox
s1monw commented on a change in pull request #1427: LUCENE-9304: Fix IW#getMaxCompletedSequenceNumber() URL: https://github.com/apache/lucene-solr/pull/1427#discussion_r407987965 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java ## @@ -3949,4

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1427: LUCENE-9304: Fix IW#getMaxCompletedSequenceNumber()

2020-04-14 Thread GitBox
s1monw commented on a change in pull request #1427: LUCENE-9304: Fix IW#getMaxCompletedSequenceNumber() URL: https://github.com/apache/lucene-solr/pull/1427#discussion_r407988034 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterDeleteQueue.java ##

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1427: LUCENE-9304: Fix IW#getMaxCompletedSequenceNumber()

2020-04-14 Thread GitBox
s1monw commented on a change in pull request #1427: LUCENE-9304: Fix IW#getMaxCompletedSequenceNumber() URL: https://github.com/apache/lucene-solr/pull/1427#discussion_r407987625 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java ## @@ -3949,4

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1427: LUCENE-9304: Fix IW#getMaxCompletedSequenceNumber()

2020-04-14 Thread GitBox
s1monw commented on a change in pull request #1427: LUCENE-9304: Fix IW#getMaxCompletedSequenceNumber() URL: https://github.com/apache/lucene-solr/pull/1427#discussion_r407988152 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterDeleteQueue.java ##

[jira] [Created] (LUCENE-9323) Fix or suppress 13 resource leak precommit warnings in lucene/replicator

2020-04-14 Thread Andras Salamon (Jira)
Andras Salamon created LUCENE-9323: -- Summary: Fix or suppress 13 resource leak precommit warnings in lucene/replicator Key: LUCENE-9323 URL: https://issues.apache.org/jira/browse/LUCENE-9323 Project:

[jira] [Updated] (LUCENE-9323) Fix or suppress 13 resource leak precommit warnings in lucene/replicator

2020-04-14 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Salamon updated LUCENE-9323: --- Status: Patch Available (was: Open) > Fix or suppress 13 resource leak precommit warnings i

[jira] [Updated] (LUCENE-9323) Fix or suppress 13 resource leak precommit warnings in lucene/replicator

2020-04-14 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Salamon updated LUCENE-9323: --- Attachment: LUCENE-9323-01.patch > Fix or suppress 13 resource leak precommit warnings in lu

[jira] [Created] (LUCENE-9324) Give IDs to SegmentCommitInfo

2020-04-14 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-9324: Summary: Give IDs to SegmentCommitInfo Key: LUCENE-9324 URL: https://issues.apache.org/jira/browse/LUCENE-9324 Project: Lucene - Core Issue Type: New Feature

[GitHub] [lucene-solr] s1monw opened a new pull request #1431: Move DWPT private deletes out of FrozenBufferedUpdates

2020-04-14 Thread GitBox
s1monw opened a new pull request #1431: Move DWPT private deletes out of FrozenBufferedUpdates URL: https://github.com/apache/lucene-solr/pull/1431 This change moves the deletes tracked by FrozenBufferedUpdates that are private to the DWPT and never used in a global context out of Fro

[jira] [Assigned] (SOLR-14159) Fix errors in TestCloudConsistency

2020-04-14 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson reassigned SOLR-14159: - Assignee: (was: Erick Erickson) > Fix errors in TestCloudConsistency > -

[jira] [Commented] (SOLR-14159) Fix errors in TestCloudConsistency

2020-04-14 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083158#comment-17083158 ] Erick Erickson commented on SOLR-14159: --- I'm unassigning this, there haven't been f

[jira] [Commented] (SOLR-14359) Admin UI has "Select an option" for collections and cores drop-downs.

2020-04-14 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083187#comment-17083187 ] Jan Høydahl commented on SOLR-14359: When testing 8.5.1 RC1, the dropdowns are still

[jira] [Commented] (SOLR-14359) Admin UI has "Select an option" for collections and cores drop-downs.

2020-04-14 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083193#comment-17083193 ] Jan Høydahl commented on SOLR-14359: >From Cassandra in VOTE thread: {quote} Jan, I a

[jira] [Reopened] (SOLR-14359) Admin UI has "Select an option" for collections and cores drop-downs.

2020-04-14 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reopened SOLR-14359: Re-opening for a fix > Admin UI has "Select an option" for collections and cores drop-downs. > ---

[jira] [Updated] (SOLR-14404) CoreContainer level custom requesthandlers

2020-04-14 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-14404: -- Description: caveats: * The class should be annotated with  {{org.apache.solr.api.EndPoint}}. Which m

[jira] [Commented] (SOLR-14359) Admin UI has "Select an option" for collections and cores drop-downs.

2020-04-14 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083204#comment-17083204 ] Jan Høydahl commented on SOLR-14359: Cassandra: We have several moving parts here:  

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1427: LUCENE-9304: Fix IW#getMaxCompletedSequenceNumber()

2020-04-14 Thread GitBox
dnhatn commented on a change in pull request #1427: LUCENE-9304: Fix IW#getMaxCompletedSequenceNumber() URL: https://github.com/apache/lucene-solr/pull/1427#discussion_r408138324 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterDeleteQueue.java ##

[GitHub] [lucene-solr] noblepaul opened a new pull request #1432: SOLR-14404 CoreContainer level custom requesthandlers

2020-04-14 Thread GitBox
noblepaul opened a new pull request #1432: SOLR-14404 CoreContainer level custom requesthandlers URL: https://github.com/apache/lucene-solr/pull/1432 This is an automated message from the Apache Git Service. To respond to th

[jira] [Commented] (SOLR-14359) Admin UI has "Select an option" for collections and cores drop-downs.

2020-04-14 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083233#comment-17083233 ] Jan Høydahl commented on SOLR-14359: Ok, did some research and I must have somehow ch

[jira] [Commented] (SOLR-14359) Admin UI has "Select an option" for collections and cores drop-downs.

2020-04-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083238#comment-17083238 ] ASF subversion and git services commented on SOLR-14359: Commit e

[jira] [Commented] (SOLR-14359) Admin UI has "Select an option" for collections and cores drop-downs.

2020-04-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083240#comment-17083240 ] ASF subversion and git services commented on SOLR-14359: Commit 4

[jira] [Updated] (SOLR-14404) CoreContainer level custom requesthandlers

2020-04-14 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-14404: -- Description: caveats: * The class should be annotated with  {{org.apache.solr.api.EndPoint}}. Which m

[jira] [Updated] (SOLR-14359) Admin UI has "Select an option" for collections and cores drop-downs.

2020-04-14 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-14359: --- Attachment: SOLR-14359-fix.patch > Admin UI has "Select an option" for collections and cores drop-dow

[jira] [Commented] (SOLR-14359) Admin UI has "Select an option" for collections and cores drop-downs.

2020-04-14 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083254#comment-17083254 ] Cassandra Targett commented on SOLR-14359: -- Cool - I made the same changes local

[jira] [Commented] (SOLR-14210) Add replica state option for HealthCheckHandler

2020-04-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083271#comment-17083271 ] ASF subversion and git services commented on SOLR-14210: Commit 6

[jira] [Commented] (LUCENE-9314) Lucene monitor module uses ByteBuffersDirectory rather than MemoryIndex when matching a single document

2020-04-14 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083282#comment-17083282 ] Alan Woodward commented on LUCENE-9314: --- Thanks - I think we should probably throw

[jira] [Commented] (SOLR-12847) Cut over implementation of maxShardsPerNode to a collection policy

2020-04-14 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083310#comment-17083310 ] Andrzej Bialecki commented on SOLR-12847: - I started working on this (see the PR)

[jira] [Updated] (SOLR-12847) Cut over implementation of maxShardsPerNode to a collection policy

2020-04-14 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-12847: Fix Version/s: (was: 8.2) > Cut over implementation of maxShardsPerNode to a collection

[jira] [Commented] (SOLR-14210) Add replica state option for HealthCheckHandler

2020-04-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083318#comment-17083318 ] ASF subversion and git services commented on SOLR-14210: Commit c

[jira] [Comment Edited] (SOLR-12847) Cut over implementation of maxShardsPerNode to a collection policy

2020-04-14 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083310#comment-17083310 ] Andrzej Bialecki edited comment on SOLR-12847 at 4/14/20, 3:07 PM:

[jira] [Resolved] (SOLR-14210) Add replica state option for HealthCheckHandler

2020-04-14 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-14210. Resolution: Fixed > Add replica state option for HealthCheckHandler > -

[jira] [Commented] (SOLR-14210) Add replica state option for HealthCheckHandler

2020-04-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083331#comment-17083331 ] ASF subversion and git services commented on SOLR-14210: Commit 7

[jira] [Commented] (SOLR-14210) Add replica state option for HealthCheckHandler

2020-04-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083330#comment-17083330 ] ASF subversion and git services commented on SOLR-14210: Commit 8

[jira] [Updated] (LUCENE-9322) Discussing a unified vectors format API

2020-04-14 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-9322: - Description: Two different approximate nearest neighbor approaches are currently being

[jira] [Commented] (LUCENE-9322) Discussing a unified vectors format API

2020-04-14 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083332#comment-17083332 ] Julie Tibshirani commented on LUCENE-9322: -- I pushed a proposal for the API her

[jira] [Created] (LUCENE-9325) Sort and SortField are not immutable

2020-04-14 Thread Alan Woodward (Jira)
Alan Woodward created LUCENE-9325: - Summary: Sort and SortField are not immutable Key: LUCENE-9325 URL: https://issues.apache.org/jira/browse/LUCENE-9325 Project: Lucene - Core Issue Type: Im

[jira] [Commented] (LUCENE-9136) Introduce IVFFlat to Lucene for ANN similarity search

2020-04-14 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083372#comment-17083372 ] Julie Tibshirani commented on LUCENE-9136: -- A note that I filed https://issues.

[jira] [Commented] (LUCENE-9323) Fix or suppress 13 resource leak precommit warnings in lucene/replicator

2020-04-14 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083401#comment-17083401 ] Lucene/Solr QA commented on LUCENE-9323: | (/) *{color:green}+1 overall{color}*

[jira] [Commented] (LUCENE-9304) Clean up DWPTPool

2020-04-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083464#comment-17083464 ] ASF subversion and git services commented on LUCENE-9304: - Commi

[GitHub] [lucene-solr] s1monw merged pull request #1427: LUCENE-9304: Fix IW#getMaxCompletedSequenceNumber()

2020-04-14 Thread GitBox
s1monw merged pull request #1427: LUCENE-9304: Fix IW#getMaxCompletedSequenceNumber() URL: https://github.com/apache/lucene-solr/pull/1427 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (LUCENE-9304) Clean up DWPTPool

2020-04-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083465#comment-17083465 ] ASF subversion and git services commented on LUCENE-9304: - Commi

[jira] [Commented] (LUCENE-9304) Clean up DWPTPool

2020-04-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083468#comment-17083468 ] ASF subversion and git services commented on LUCENE-9304: - Commi

[jira] [Commented] (LUCENE-9304) Clean up DWPTPool

2020-04-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083469#comment-17083469 ] ASF subversion and git services commented on LUCENE-9304: - Commi

[jira] [Commented] (LUCENE-9325) Sort and SortField are not immutable

2020-04-14 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083471#comment-17083471 ] Michael Sokolov commented on LUCENE-9325: - +1 for this. It's even possible to al

[GitHub] [lucene-solr] s1monw merged pull request #1431: Move DWPT private deletes out of FrozenBufferedUpdates

2020-04-14 Thread GitBox
s1monw merged pull request #1431: Move DWPT private deletes out of FrozenBufferedUpdates URL: https://github.com/apache/lucene-solr/pull/1431 This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Updated] (SOLR-14407) Add subtype_s field to postlogs tool

2020-04-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14407: -- Summary: Add subtype_s field to postlogs tool (was: Improve add subtype_s field to postlogs t

[jira] [Created] (SOLR-14407) Improve add subtype_s field to postlogs tool

2020-04-14 Thread Joel Bernstein (Jira)
Joel Bernstein created SOLR-14407: - Summary: Improve add subtype_s field to postlogs tool Key: SOLR-14407 URL: https://issues.apache.org/jira/browse/SOLR-14407 Project: Solr Issue Type: New

[jira] [Assigned] (SOLR-14407) Add subtype_s field to postlogs tool

2020-04-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein reassigned SOLR-14407: - Assignee: Joel Bernstein > Add subtype_s field to postlogs tool > -

[jira] [Updated] (SOLR-14407) Add subtypes to the postlogs tool

2020-04-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14407: -- Summary: Add subtypes to the postlogs tool (was: Add subtype_s field to postlogs tool ) > Ad

[GitHub] [lucene-solr] dsmiley closed pull request #1407: Use QueryUtils.combineQueryAndFilter more

2020-04-14 Thread GitBox
dsmiley closed pull request #1407: Use QueryUtils.combineQueryAndFilter more URL: https://github.com/apache/lucene-solr/pull/1407 This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Comment Edited] (LUCENE-9314) Lucene monitor module uses ByteBuffersDirectory rather than MemoryIndex when matching a single document

2020-04-14 Thread Pierre-Luc Perron (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083689#comment-17083689 ] Pierre-Luc Perron edited comment on LUCENE-9314 at 4/14/20, 11:34 PM:

[jira] [Commented] (LUCENE-9314) Lucene monitor module uses ByteBuffersDirectory rather than MemoryIndex when matching a single document

2020-04-14 Thread Pierre-Luc Perron (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083689#comment-17083689 ] Pierre-Luc Perron commented on LUCENE-9314: --- I agree, and I found the decision

[jira] [Comment Edited] (LUCENE-9314) Lucene monitor module uses ByteBuffersDirectory rather than MemoryIndex when matching a single document

2020-04-14 Thread Pierre-Luc Perron (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083689#comment-17083689 ] Pierre-Luc Perron edited comment on LUCENE-9314 at 4/14/20, 11:35 PM:

[jira] [Commented] (LUCENE-9314) Lucene monitor module uses ByteBuffersDirectory rather than MemoryIndex when matching a single document

2020-04-14 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083690#comment-17083690 ] Alan Woodward commented on LUCENE-9314: --- Yes, let's throw an exception.  I don't t

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-14 Thread GitBox
mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r408521182 ## File path: lucene/test-framework/src/java/org/apache/lucene/search/AssertingLeafCollec

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-14 Thread GitBox
mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r408522075 ## File path: lucene/core/src/java/org/apache/lucene/search/ScoreMode.java ## @@

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-14 Thread GitBox
mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r408522716 ## File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ##

[jira] [Commented] (SOLR-13138) Remove deprecated code in master

2020-04-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083789#comment-17083789 ] David Smiley commented on SOLR-13138: - I'll merge it then. I'll resume this no soone