[
https://issues.apache.org/jira/browse/SOLR-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143041#comment-17143041
]
ASF subversion and git services commented on SOLR-14584:
Commit 3
[
https://issues.apache.org/jira/browse/SOLR-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143040#comment-17143040
]
ASF subversion and git services commented on SOLR-14584:
Commit 3
[
https://issues.apache.org/jira/browse/SOLR-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143039#comment-17143039
]
ASF subversion and git services commented on SOLR-14584:
Commit d
gerlowskija edited a comment on pull request #1600:
URL: https://github.com/apache/lucene-solr/pull/1600#issuecomment-648235882
> My only concern, which seems to be shared by you, is that CoreContainer is
pretty big as it is. But I think this path and it's initialization is in scope
of its
gerlowskija commented on pull request #1600:
URL: https://github.com/apache/lucene-solr/pull/1600#issuecomment-648235882
> My only concern, which seems to be shared by you, is that CoreContainer is
pretty big as it is. But I think this path and it's initialization is in scope
of its respon
markharwood commented on a change in pull request #1541:
URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r444284423
##
File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java
##
@@ -743,6 +792,30 @@ private Automaton
toAutomatonInternal(Map
[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142989#comment-17142989
]
Dawid Weiss commented on LUCENE-9411:
-
It's not your fault, Erick, so no blame!
{qu
murblanc commented on pull request #1504:
URL: https://github.com/apache/lucene-solr/pull/1504#issuecomment-648188037
@noblepaul if no objections, I'll merge that soon (after rebasing,
precommitting and checking all is ok).
[
https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142974#comment-17142974
]
ASF subversion and git services commented on SOLR-14546:
Commit 3
[
https://issues.apache.org/jira/browse/SOLR-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142973#comment-17142973
]
ASF subversion and git services commented on SOLR-14546:
Commit 3
murblanc merged pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul updated SOLR-14586:
--
Description:
continuing discussion from SOLR-14579
consider the following
{code:java}
mapObject.compu
dsmiley commented on pull request #1600:
URL: https://github.com/apache/lucene-solr/pull/1600#issuecomment-648157149
> Why clutter up CoreContainer with path logic when we have classes
specifically meant to hold that?
`CoreContainer.getSolrHome()` and `CoreContainer.getCoreRootDirect
mikemccand commented on a change in pull request #1593:
URL: https://github.com/apache/lucene-solr/pull/1593#discussion_r444216252
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene86/Lucene86PointsWriter.java
##
@@ -68,11 +71,9 @@ public Lucene86PointsWriter(S
markharwood commented on a change in pull request #1541:
URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r444201265
##
File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java
##
@@ -743,6 +792,30 @@ private Automaton
toAutomatonInternal(Map
[
https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136783#comment-17136783
]
Bruno Roustant edited comment on LUCENE-9379 at 6/23/20, 12:51 PM:
---
gerlowskija edited a comment on pull request #1600:
URL: https://github.com/apache/lucene-solr/pull/1600#issuecomment-648114057
I don't mind this PR at all, I just have some questions. I don't really
understand the aversion to `SolrPaths` and `File`. More detailed questions
below. Treat
gerlowskija commented on pull request #1600:
URL: https://github.com/apache/lucene-solr/pull/1600#issuecomment-648114057
I don't mind this PR at all, I just have some questions. I don't really
understand the aversion to `SolrPaths` and `File`. More detailed questions
below. Treat this c
markharwood commented on a change in pull request #1541:
URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r444182510
##
File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java
##
@@ -743,6 +792,30 @@ private Automaton
toAutomatonInternal(Map
[
https://issues.apache.org/jira/browse/SOLR-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142864#comment-17142864
]
Erick Erickson commented on SOLR-13268:
---
I'm thinking of reverting _testing_ to use
jimczi commented on a change in pull request #1541:
URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r444163411
##
File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java
##
@@ -743,6 +792,30 @@ private Automaton
toAutomatonInternal(Map auto
Atri Sharma created SOLR-14588:
--
Summary: Circuit Breakers Infrastructure and Real JVM Based
Circuit Breaker
Key: SOLR-14588
URL: https://issues.apache.org/jira/browse/SOLR-14588
Project: Solr
[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142836#comment-17142836
]
Erick Erickson commented on LUCENE-9411:
Thanks, I'll check it out and then push
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142831#comment-17142831
]
Noble Paul commented on SOLR-14586:
---
{quote}I'm finding your tone quite aggressive,
{qu
markharwood commented on a change in pull request #1541:
URL: https://github.com/apache/lucene-solr/pull/1541#discussion_r444134039
##
File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java
##
@@ -743,6 +792,30 @@ private Automaton
toAutomatonInternal(Map
[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142809#comment-17142809
]
Dawid Weiss commented on LUCENE-9411:
-
For gradle-only I don't think we need to care
[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9411:
Attachment: LUCENE-9411.patch
> Fail complation on warnings
> ---
>
>
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142802#comment-17142802
]
Nitsan Wakart commented on SOLR-14586:
--
"do you expect a developer to run a perf ben
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142802#comment-17142802
]
Nitsan Wakart edited comment on SOLR-14586 at 6/23/20, 9:45 AM:
---
[
https://issues.apache.org/jira/browse/SOLR-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142751#comment-17142751
]
Florin Babes commented on SOLR-14571:
-
kind reminder
> Index download speed while re
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142718#comment-17142718
]
Noble Paul edited comment on SOLR-14586 at 6/23/20, 8:25 AM:
-
noblepaul commented on pull request #1598:
URL: https://github.com/apache/lucene-solr/pull/1598#issuecomment-647991595
@sigram
shall I go ahead and merge this?
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142718#comment-17142718
]
Noble Paul commented on SOLR-14586:
---
[~megancarey] {{putIfAbsent() }} is particularly b
atris commented on pull request #1605:
URL: https://github.com/apache/lucene-solr/pull/1605#issuecomment-647988672
How is this different from #1605 ?
I have not looked at the PRs yet, but they seem scattered and incomplete.
Most of the code is not licensed to ASF, there are no tests
DEVILCODER-SB99 opened a new pull request #1605:
URL: https://github.com/apache/lucene-solr/pull/1605
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Please provide a short description of the a
[
https://issues.apache.org/jira/browse/SOLR-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142708#comment-17142708
]
Nitsan Wakart commented on SOLR-14586:
--
Lambdas can sometimes be slow, and induce al
[
https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Willnauer updated LUCENE-8962:
Attachment: test.diff
Status: Reopened (was: Reopened)
here is a test that shows
[
https://issues.apache.org/jira/browse/SOLR-14581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142675#comment-17142675
]
Bram Van Dam commented on SOLR-14581:
-
I originally asked about how the commit mechan
101 - 138 of 138 matches
Mail list logo
