[GitHub] [lucene-solr] atris merged pull request #1682: Use FileSystem.newInstance instead of get in HDFSBackupRepository

2020-07-23 Thread GitBox
atris merged pull request #1682: URL: https://github.com/apache/lucene-solr/pull/1682 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (SOLR-14383) Fix indexing-nested-documents.adoc XML/JSON examples to be accurate, consistent, and clear

2020-07-23 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-14383: -- Attachment: SOLR-14383.patch Status: Open (was: Open) bq. You have some

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

2020-07-23 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164040#comment-17164040 ] Ilan Ginzburg commented on SOLR-14613: -- I have updated the PRĀ 

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-07-23 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164029#comment-17164029 ] Mark Robert Miller commented on SOLR-14636: --- The two vm runs are from a solr/clean so that

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-07-23 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164025#comment-17164025 ] Mark Robert Miller commented on SOLR-14636: --- Here is that same all module run on the bare metal

[jira] [Comment Edited] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-07-23 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164024#comment-17164024 ] Mark Robert Miller edited comment on SOLR-14636 at 7/23/20, 11:34 PM:

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-07-23 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164024#comment-17164024 ] Mark Robert Miller commented on SOLR-14636: --- All modules test run on the two CPU VM in a Mac:

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for plugin interface

2020-07-23 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r459773371 ## File path: solr/core/src/java/org/apache/solr/cloud/gumi/PropertyKeyFactory.java ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-07-23 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163996#comment-17163996 ] Mark Robert Miller commented on SOLR-14636: --- First pass on all modules test run on the one CPU

[jira] [Assigned] (SOLR-14581) Document the way auto commits work in SolrCloud

2020-07-23 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh reassigned SOLR-14581: -- Assignee: David Eric Pugh > Document the way auto commits work in SolrCloud >

[jira] [Updated] (SOLR-14435) createNodeSet and createNodeSet.shuffle parameters missing from Collection Restore RefGuide

2020-07-23 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh updated SOLR-14435: --- Fix Version/s: 8.7 Resolution: Fixed Status: Resolved (was: Patch

[jira] [Commented] (SOLR-14435) createNodeSet and createNodeSet.shuffle parameters missing from Collection Restore RefGuide

2020-07-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163988#comment-17163988 ] ASF subversion and git services commented on SOLR-14435: Commit

[GitHub] [lucene-solr] epugh merged pull request #1683: SOLR-14435: Update collection management docs on RESTORE

2020-07-23 Thread GitBox
epugh merged pull request #1683: URL: https://github.com/apache/lucene-solr/pull/1683 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (SOLR-14676) Update commons-collections to 4.4 and use it in Solr

2020-07-23 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-14676. --- Fix Version/s: 8.7 Resolution: Fixed > Update commons-collections to 4.4 and use it

[GitHub] [lucene-site] anshumg opened a new pull request #24: Update website

2020-07-23 Thread GitBox
anshumg opened a new pull request #24: URL: https://github.com/apache/lucene-site/pull/24 - Add 8.6 to available ref guide versions - Doron Cohen as Emeritus PMC member - Ilan Ginzburg as committer This is an

[jira] [Commented] (SOLR-13205) StringIndexOutOfBoundsException in SolrQueryParserBase.getFieldQuery

2020-07-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163967#comment-17163967 ] ASF subversion and git services commented on SOLR-13205: Commit

[jira] [Commented] (SOLR-14676) Update commons-collections to 4.4 and use it in Solr

2020-07-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163971#comment-17163971 ] ASF subversion and git services commented on SOLR-14676: Commit

[jira] [Commented] (SOLR-14435) createNodeSet and createNodeSet.shuffle parameters missing from Collection Restore RefGuide

2020-07-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163972#comment-17163972 ] ASF subversion and git services commented on SOLR-14435: Commit

[jira] [Commented] (LUCENE-9437) Make DocValuesOrdinalsReader.decode(BytesRef, IntsRef) method publicly accessible

2020-07-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163970#comment-17163970 ] ASF subversion and git services commented on LUCENE-9437: - Commit

[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)

2020-07-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163968#comment-17163968 ] ASF subversion and git services commented on LUCENE-9312: - Commit

[jira] [Commented] (LUCENE-9312) Allow builds against arbitrary JVMs (even those unsupported by gradle)

2020-07-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163969#comment-17163969 ] ASF subversion and git services commented on LUCENE-9312: - Commit

[GitHub] [lucene-site] anshumg merged pull request #23: Mark Doron Cohen as Emeritus PMC member

2020-07-23 Thread GitBox
anshumg merged pull request #23: URL: https://github.com/apache/lucene-site/pull/23 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (SOLR-14676) Update commons-collections to 4.4 and use it in Solr

2020-07-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163959#comment-17163959 ] ASF subversion and git services commented on SOLR-14676: Commit

[jira] [Commented] (SOLR-14676) Update commons-collections to 4.4 and use it in Solr

2020-07-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163958#comment-17163958 ] ASF subversion and git services commented on SOLR-14676: Commit

[jira] [Commented] (LUCENE-9295) Removing grave accent in Dutch Snowball algorithm

2020-07-23 Thread Selene Broers (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163861#comment-17163861 ] Selene Broers commented on LUCENE-9295: --- Linguist/software engineer/native Dutch speaker here.

[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort

2020-07-23 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163829#comment-17163829 ] Erick Erickson commented on SOLR-13939: --- [~munendrasn] When I was cleaning up a few things in

[jira] [Commented] (SOLR-14678) [child] DocTransformer doesn't work unless (request) fl inlcudes '*'

2020-07-23 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163815#comment-17163815 ] Chris M. Hostetter commented on SOLR-14678: --- Hmmm, yes ... i see. Really what this comes down

[jira] [Commented] (SOLR-14678) [child] DocTransformer doesn't work unless (request) fl inlcudes '*'

2020-07-23 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163763#comment-17163763 ] Munendra S N commented on SOLR-14678: - [~hossman] {code:java} curl --globoff

[jira] [Commented] (SOLR-14583) Spell suggestion is returned even if hits are non-zero when spellcheck.maxResultsForSuggest=0

2020-07-23 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163748#comment-17163748 ] Munendra S N commented on SOLR-14583: - I'm planning to commit this over the weekend, let me know if

[jira] [Commented] (SOLR-14516) NPE during Realtime GET

2020-07-23 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163745#comment-17163745 ] Munendra S N commented on SOLR-14516: - I'm planning to commit this over the weekend, let me know if

[jira] [Comment Edited] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort

2020-07-23 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163740#comment-17163740 ] Munendra S N edited comment on SOLR-13939 at 7/23/20, 4:26 PM: ---

[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort

2020-07-23 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163740#comment-17163740 ] Munendra S N commented on SOLR-13939: - [~erickerickson] While looking into SOLR-14678, I saw that,

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-07-23 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163732#comment-17163732 ] Tomoko Uchida commented on LUCENE-9321: --- Yes, I will open a PR for review in the next few days. >

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-07-23 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163701#comment-17163701 ] Uwe Schindler commented on LUCENE-9321: --- Depending on the way to do this, can you share a PR

[jira] [Commented] (LUCENE-9440) FieldInfo#checkConsistency called twice from Lucene50FieldInfosFormat#read

2020-07-23 Thread Yauheni Putsykovich (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163662#comment-17163662 ] Yauheni Putsykovich commented on LUCENE-9440: - It makes total sense to me. So if we're agree

[jira] [Comment Edited] (LUCENE-9321) Port documentation task to gradle

2020-07-23 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163645#comment-17163645 ] Tomoko Uchida edited comment on LUCENE-9321 at 7/23/20, 2:45 PM: - Thank

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-07-23 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163645#comment-17163645 ] Tomoko Uchida commented on LUCENE-9321: --- Thank you for the comment/information. I will fix either

[jira] [Commented] (SOLR-12845) Add a default cluster policy

2020-07-23 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163610#comment-17163610 ] Houston Putman commented on SOLR-12845: --- Have we agreed to revert this commit on 8_6 and 8x? (I'm

[jira] [Commented] (SOLR-14668) CompositeID change provokes duplicates

2020-07-23 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163594#comment-17163594 ] Erick Erickson commented on SOLR-14668: --- I'd create a copyField with the appropriate analysis chain

[jira] [Commented] (SOLR-14676) Update commons-collections to 4.4 and use it in Solr

2020-07-23 Thread Bernd Wahlen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163586#comment-17163586 ] Bernd Wahlen commented on SOLR-14676: - :) > Update commons-collections to 4.4 and use it in Solr >

[jira] [Comment Edited] (SOLR-14668) CompositeID change provokes duplicates

2020-07-23 Thread Alexander S. (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163568#comment-17163568 ] Alexander S. edited comment on SOLR-14668 at 7/23/20, 1:38 PM: --- I realized

[jira] [Commented] (SOLR-14668) CompositeID change provokes duplicates

2020-07-23 Thread Alexander S. (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163568#comment-17163568 ] Alexander S. commented on SOLR-14668: - I realized that Solr stores the composite part along with ID

[jira] [Commented] (LUCENE-9440) FieldInfo#checkConsistency called twice from Lucene50FieldInfosFormat#read

2020-07-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163566#comment-17163566 ] Robert Muir commented on LUCENE-9440: - I agree with you: the sanity checks here aren't very

[GitHub] [lucene-solr] mayya-sharipova commented on pull request #1610: LUCENE-9384: Backport for field sort optimization

2020-07-23 Thread GitBox
mayya-sharipova commented on pull request #1610: URL: https://github.com/apache/lucene-solr/pull/1610#issuecomment-663000392 @jimczi @jpountz Thanks for your feedback, I have addressed it: - renamed `SortField#setSkipNonCompetitiveDocs` to `SortField#setCanUsePoints ` - remove

[jira] [Comment Edited] (LUCENE-9321) Port documentation task to gradle

2020-07-23 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163541#comment-17163541 ] Uwe Schindler edited comment on LUCENE-9321 at 7/23/20, 1:00 PM: - We can

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-07-23 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163541#comment-17163541 ] Uwe Schindler commented on LUCENE-9321: --- We can also use the ANT-approach to make "file://" urls

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-07-23 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163536#comment-17163536 ] Uwe Schindler commented on LUCENE-9321: --- Jenkins sets the URL via system properties for snapshot

[jira] [Commented] (SOLR-13205) StringIndexOutOfBoundsException in SolrQueryParserBase.getFieldQuery

2020-07-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163533#comment-17163533 ] ASF subversion and git services commented on SOLR-13205: Commit

[jira] [Commented] (SOLR-13205) StringIndexOutOfBoundsException in SolrQueryParserBase.getFieldQuery

2020-07-23 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163534#comment-17163534 ] Jason Gerlowski commented on SOLR-13205: Tests looked clean so I backported this to 8x - will

[jira] [Resolved] (SOLR-13205) StringIndexOutOfBoundsException in SolrQueryParserBase.getFieldQuery

2020-07-23 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-13205. Fix Version/s: 8.7 master (9.0) Resolution: Fixed >

[jira] [Commented] (LUCENE-9440) FieldInfo#checkConsistency called twice from Lucene50FieldInfosFormat#read

2020-07-23 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163509#comment-17163509 ] Lucene/Solr QA commented on LUCENE-9440: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Updated] (SOLR-14676) Update commons-collections to 4.4 and use it in Solr

2020-07-23 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-14676: -- Description: solr-test-framework has dependency to commons-collections:commons-collections

[jira] [Updated] (SOLR-14676) Update commons-collections to 4.4 and use it in Solr

2020-07-23 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-14676: -- Summary: Update commons-collections to 4.4 and use it in Solr (was: solr-test-framework

[jira] [Assigned] (SOLR-14676) solr-test-framework update/remove old commons-collections dependency

2020-07-23 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson reassigned SOLR-14676: - Assignee: Erick Erickson > solr-test-framework update/remove old commons-collections

[jira] [Commented] (SOLR-14676) solr-test-framework update/remove old commons-collections dependency

2020-07-23 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163503#comment-17163503 ] Erick Erickson commented on SOLR-14676: --- We can't completely. There's a transitive dependency from

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1689: LUCENE-9439: Matches API should enumerate hit fields that have no positions (support empty iterator)

2020-07-23 Thread GitBox
dweiss commented on a change in pull request #1689: URL: https://github.com/apache/lucene-solr/pull/1689#discussion_r459332378 ## File path: lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java ## @@ -195,7 +195,9 @@ public Matches

[jira] [Reopened] (LUCENE-9321) Port documentation task to gradle

2020-07-23 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida reopened LUCENE-9321: --- I noticed that {{checkBrokenLinks}} task for Solr fails on snapshot builds with "BAD EXTERNAL

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-07-23 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163384#comment-17163384 ] Dawid Weiss commented on LUCENE-9439: - I tried to make it minimally intrusive and still functional

[GitHub] [lucene-solr] dweiss opened a new pull request #1689: LUCENE-9439: Matches API should enumerate hit fields that have no positions (support empty iterator)

2020-07-23 Thread GitBox
dweiss opened a new pull request #1689: URL: https://github.com/apache/lucene-solr/pull/1689 A minimally-intrusive patch that seems to work just fine. This is an automated message from the Apache Git Service. To respond to

[jira] [Updated] (LUCENE-9440) FieldInfo#checkConsistency called twice from Lucene50FieldInfosFormat#read

2020-07-23 Thread Yauheni Putsykovich (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yauheni Putsykovich updated LUCENE-9440: Attachment: LUCENE-9440.patch > FieldInfo#checkConsistency called twice from

[jira] [Updated] (LUCENE-9440) FieldInfo#checkConsistency called twice from Lucene50FieldInfosFormat#read

2020-07-23 Thread Yauheni Putsykovich (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yauheni Putsykovich updated LUCENE-9440: Attachment: (was: SOLR-9440) > FieldInfo#checkConsistency called twice from

[GitHub] [lucene-solr] noblepaul commented on pull request #1684: SOLR-14613: strongly typed initial proposal for plugin interface

2020-07-23 Thread GitBox
noblepaul commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-662837142 I don't believe we should have a set of interfaces that duplicate existing classes just for this functionality. This is a common mistake that we all do. When we design a