[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1724: SOLR-14684: CloudExitableDirectoryReaderTest failing about 25% of the time

2020-08-10 Thread GitBox
dsmiley commented on a change in pull request #1724: URL: https://github.com/apache/lucene-solr/pull/1724#discussion_r468335971 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBSolrClient.java ## @@ -155,6 +159,7 @@ public ServerIterator(Req req, Map

[jira] [Commented] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175239#comment-17175239 ] ASF subversion and git services commented on SOLR-14680: Commit

[GitHub] [lucene-solr] noblepaul merged pull request #1694: SOLR-14680: Provide simple interfaces to our cloud classes (only API)

2020-08-10 Thread GitBox
noblepaul merged pull request #1694: URL: https://github.com/apache/lucene-solr/pull/1694 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] dsmiley opened a new pull request #1735: LUCENE spell: Implement SuggestWord.toString

2020-08-10 Thread GitBox
dsmiley opened a new pull request #1735: URL: https://github.com/apache/lucene-solr/pull/1735 This is simply an obvious toString impl on SuggestWord. This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene-solr] madrob commented on a change in pull request #1726: SOLR-14722: timeAllowed should track from req creation

2020-08-10 Thread GitBox
madrob commented on a change in pull request #1726: URL: https://github.com/apache/lucene-solr/pull/1726#discussion_r468315778 ## File path: solr/core/src/java/org/apache/solr/search/SolrQueryTimeoutImpl.java ## @@ -67,8 +69,21 @@ public boolean shouldExit() { } /** -

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-10 Thread GitBox
noblepaul commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r468260502 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/plugins/SamplePluginMinimizeCores.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to

[jira] [Commented] (SOLR-13412) Make the Lucene Luke module available from a Solr distribution

2020-08-10 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175124#comment-17175124 ] Erick Erickson commented on SOLR-13412: --- Given the discussion on the dev list, I'm going to close

[jira] [Comment Edited] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-08-10 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169538#comment-17169538 ] Mark Robert Miller edited comment on SOLR-14636 at 8/11/20, 12:36 AM:

[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1730: SOLR-14680: Provide an implementation for the new SolrCluster API

2020-08-10 Thread GitBox
noblepaul edited a comment on pull request #1730: URL: https://github.com/apache/lucene-solr/pull/1730#issuecomment-671651150 >what is the target use case of the interface and lazy implementation? The objectives are many - Totally refactor Solr code base to minimize

[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1730: SOLR-14680: Provide an implementation for the new SolrCluster API

2020-08-10 Thread GitBox
noblepaul edited a comment on pull request #1730: URL: https://github.com/apache/lucene-solr/pull/1730#issuecomment-671651150 >what is the target use case of the interface and lazy implementation? The objectives are many - The `LazySolrCluster` will be the default impl for

[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1730: SOLR-14680: Provide an implementation for the new SolrCluster API

2020-08-10 Thread GitBox
noblepaul edited a comment on pull request #1730: URL: https://github.com/apache/lucene-solr/pull/1730#issuecomment-671651150 >what is the target use case of the interface and lazy implementation? The objectives are many - Totally refactor Solr code base to minimize

[GitHub] [lucene-solr] noblepaul commented on pull request #1730: SOLR-14680: Provide an implementation for the new SolrCluster API

2020-08-10 Thread GitBox
noblepaul commented on pull request #1730: URL: https://github.com/apache/lucene-solr/pull/1730#issuecomment-671651150 >what is the target use case of the interface and lazy implementation? The objectives are many - Totally refactor Solr code base to minimize dependencies on

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

2020-08-10 Thread Cao Manh Dat (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175118#comment-17175118 ] Cao Manh Dat commented on SOLR-14354: - [~rishisankar] sure, if you can also do the benchmark that

[jira] [Commented] (SOLR-13412) Make the Lucene Luke module available from a Solr distribution

2020-08-10 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175099#comment-17175099 ] Tomoko Uchida commented on SOLR-13412: -- FWIW, an Elasticsearch user notified us that he/she created

[GitHub] [lucene-solr] madrob opened a new pull request #1734: LUCENE-9453 Add sync around volatile write

2020-08-10 Thread GitBox
madrob opened a new pull request #1734: URL: https://github.com/apache/lucene-solr/pull/1734 checkoutAndBlock is not synchronized, but has a non-atomic write to numPending. Meanwhile, all of the other writes to numPending are in sync methods. In this case it turns out to be ok

[GitHub] [lucene-solr] madrob commented on a change in pull request #1732: Clean up many small fixes

2020-08-10 Thread GitBox
madrob commented on a change in pull request #1732: URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r468227099 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java ## @@ -324,12 +324,12 @@ synchronized void

[jira] [Created] (LUCENE-9453) DocumentWriterFlushControl missing explicit sync on write

2020-08-10 Thread Mike Drob (Jira)
Mike Drob created LUCENE-9453: - Summary: DocumentWriterFlushControl missing explicit sync on write Key: LUCENE-9453 URL: https://issues.apache.org/jira/browse/LUCENE-9453 Project: Lucene - Core

[GitHub] [lucene-solr] madrob commented on a change in pull request #1732: Clean up many small fixes

2020-08-10 Thread GitBox
madrob commented on a change in pull request #1732: URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r468221630 ## File path: lucene/core/src/java/org/apache/lucene/index/DocValuesUpdate.java ## @@ -152,12 +152,12 @@ static BytesRef readFrom(DataInput in,

[jira] [Commented] (SOLR-14687) Make child/parent query parsers natively aware of _nest_path_

2020-08-10 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175086#comment-17175086 ] Chris M. Hostetter commented on SOLR-14687: --- besides that fact that Jira's WYSIWYG editor lied

[GitHub] [lucene-solr] madrob commented on a change in pull request #1732: Clean up many small fixes

2020-08-10 Thread GitBox
madrob commented on a change in pull request #1732: URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r468220684 ## File path: lucene/core/src/java/org/apache/lucene/codecs/blocktree/BlockTreeTermsWriter.java ## @@ -709,7 +709,7 @@ private PendingBlock

[GitHub] [lucene-solr] madrob commented on a change in pull request #1732: Clean up many small fixes

2020-08-10 Thread GitBox
madrob commented on a change in pull request #1732: URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r468220535 ## File path: lucene/core/src/java/org/apache/lucene/analysis/Analyzer.java ## @@ -94,7 +94,7 @@ * Create a new Analyzer, reusing the same set of

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-10 Thread Roman (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175081#comment-17175081 ] Roman commented on LUCENE-8776: --- I too suffer from the same issue, we have multi-token synonyms that can

[GitHub] [lucene-solr] gautamworah96 opened a new pull request #1733: LUCENE-9450 Use BinaryDocValues in the taxonomy writer

2020-08-10 Thread GitBox
gautamworah96 opened a new pull request #1733: URL: https://github.com/apache/lucene-solr/pull/1733 # Description This PR modifies the taxonomy writer and reader implementation to use BinaryDocValues instead of StoredValues. The taxonomy index uses stored fields

[jira] [Commented] (SOLR-13528) Rate limiting in Solr

2020-08-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175072#comment-17175072 ] ASF subversion and git services commented on SOLR-13528: Commit

[jira] [Comment Edited] (SOLR-13528) Rate limiting in Solr

2020-08-10 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175070#comment-17175070 ] Cassandra Targett edited comment on SOLR-13528 at 8/10/20, 9:34 PM:

[jira] [Commented] (SOLR-13528) Rate limiting in Solr

2020-08-10 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175070#comment-17175070 ] Cassandra Targett commented on SOLR-13528: -- The Ref Guide docs in this commit were throwing some

[jira] [Resolved] (LUCENE-9452) Remove jenkins.build.ref.guide.sh

2020-08-10 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett resolved LUCENE-9452. --- Fix Version/s: 8.7 Resolution: Fixed I only backported to branch_8x, but

[jira] [Commented] (LUCENE-9452) Remove jenkins.build.ref.guide.sh

2020-08-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175051#comment-17175051 ] ASF subversion and git services commented on LUCENE-9452: - Commit

[jira] [Commented] (LUCENE-9452) Remove jenkins.build.ref.guide.sh

2020-08-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175050#comment-17175050 ] ASF subversion and git services commented on LUCENE-9452: - Commit

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

2020-08-10 Thread Rishi Sankar (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175025#comment-17175025 ] Rishi Sankar commented on SOLR-14354: - [~caomanhdat] I am interested in this work as well, I am down

[jira] [Created] (LUCENE-9452) Remove jenkins.build.ref.guide.sh

2020-08-10 Thread Cassandra Targett (Jira)
Cassandra Targett created LUCENE-9452: - Summary: Remove jenkins.build.ref.guide.sh Key: LUCENE-9452 URL: https://issues.apache.org/jira/browse/LUCENE-9452 Project: Lucene - Core Issue

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1732: Clean up many small fixes

2020-08-10 Thread GitBox
dweiss commented on a change in pull request #1732: URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r468106643 ## File path: lucene/core/src/java/org/apache/lucene/codecs/blocktree/BlockTreeTermsWriter.java ## @@ -709,7 +709,7 @@ private PendingBlock

[GitHub] [lucene-solr] madrob opened a new pull request #1732: Clean up many small fixes

2020-08-10 Thread GitBox
madrob opened a new pull request #1732: URL: https://github.com/apache/lucene-solr/pull/1732 * Abstract classes don't need public constructors since they can only be called by subclasses * Don't escape html characters in @code tags in javadoc * Fixed a few int/long arithmetic

[jira] [Commented] (LUCENE-2822) TimeLimitingCollector starts thread in static {} with no way to stop them

2020-08-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175004#comment-17175004 ] David Smiley commented on LUCENE-2822: -- I could imagine an implementation that tracks doc ID

[jira] [Commented] (LUCENE-8626) standardise test class naming

2020-08-10 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174997#comment-17174997 ] Dawid Weiss commented on LUCENE-8626: - bq. Still, without automated enforcement For LuceneTestCase

[jira] [Commented] (SOLR-14726) Streamline getting started experience

2020-08-10 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174995#comment-17174995 ] David Eric Pugh commented on SOLR-14726: I notice that on the page where we discuss curl,

[GitHub] [lucene-solr] murblanc commented on pull request #1730: SOLR-14680: Provide an implementation for the new SolrCluster API

2020-08-10 Thread GitBox
murblanc commented on pull request #1730: URL: https://github.com/apache/lucene-solr/pull/1730#issuecomment-671509879 > The current concrete classes do not use/implement these interfaces. These interfaces will only be a part of implementations. for instance, the `LazySolrCluster` is

[jira] [Resolved] (SOLR-14702) Remove Master and Slave from Code Base and Docs

2020-08-10 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe resolved SOLR-14702. -- Fix Version/s: 8.7 master (9.0)

[jira] [Commented] (SOLR-14726) Streamline getting started experience

2020-08-10 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174951#comment-17174951 ] Ishan Chattopadhyaya commented on SOLR-14726: - The main idea behind using curl is not just to

[jira] [Commented] (SOLR-14726) Streamline getting started experience

2020-08-10 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174948#comment-17174948 ] Ishan Chattopadhyaya commented on SOLR-14726: - bq. Everyone knows cURL. Agree with Marcus

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-10 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r468065465 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PlacementPlugin.java ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software

[jira] [Comment Edited] (LUCENE-2822) TimeLimitingCollector starts thread in static {} with no way to stop them

2020-08-10 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174930#comment-17174930 ] Uwe Schindler edited comment on LUCENE-2822 at 8/10/20, 5:18 PM: - In

[jira] [Commented] (LUCENE-2822) TimeLimitingCollector starts thread in static {} with no way to stop them

2020-08-10 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174930#comment-17174930 ] Uwe Schindler commented on LUCENE-2822: --- In addition, the extra thread will soon be no issue

[jira] [Commented] (LUCENE-2822) TimeLimitingCollector starts thread in static {} with no way to stop them

2020-08-10 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174917#comment-17174917 ] Uwe Schindler commented on LUCENE-2822: --- Hi, it depends on the operating system. Nanotime is still

[jira] [Commented] (LUCENE-2822) TimeLimitingCollector starts thread in static {} with no way to stop them

2020-08-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174461#comment-17174461 ] David Smiley commented on LUCENE-2822: -- [~uschindler] (or anyone), is System.nanoTime still

[jira] [Commented] (SOLR-14726) Streamline getting started experience

2020-08-10 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174436#comment-17174436 ] Marcus Eagan commented on SOLR-14726: - bq. My experience from delivering the Solr version of Think

[GitHub] [lucene-solr] madrob commented on a change in pull request #1731: LUCENE-9451 Sort.rewrite does not always return this when unchanged

2020-08-10 Thread GitBox
madrob commented on a change in pull request #1731: URL: https://github.com/apache/lucene-solr/pull/1731#discussion_r468031592 ## File path: lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.java ## @@ -456,13 +456,16 @@ public String toString() {

[GitHub] [lucene-solr] madrob opened a new pull request #1731: LUCENE-9451 Sort.rewrite does not always return this when unchanged

2020-08-10 Thread GitBox
madrob opened a new pull request #1731: URL: https://github.com/apache/lucene-solr/pull/1731 https://issues.apache.org/jira/browse/LUCENE-9451 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (SOLR-14726) Streamline getting started experience

2020-08-10 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174433#comment-17174433 ] David Eric Pugh commented on SOLR-14726: My experience from delivering the Solr version of _Think

[jira] [Commented] (SOLR-14726) Streamline getting started experience

2020-08-10 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174434#comment-17174434 ] Marcus Eagan commented on SOLR-14726: - bq. If we could rely on Python and felt free to ask people to

[jira] [Created] (LUCENE-9451) Sort.rewrite doesn't always return this when unchanged

2020-08-10 Thread Mike Drob (Jira)
Mike Drob created LUCENE-9451: - Summary: Sort.rewrite doesn't always return this when unchanged Key: LUCENE-9451 URL: https://issues.apache.org/jira/browse/LUCENE-9451 Project: Lucene - Core

[jira] [Commented] (SOLR-14726) Streamline getting started experience

2020-08-10 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174412#comment-17174412 ] Alexandre Rafalovitch commented on SOLR-14726: -- If we could rely on Python and felt free to

[GitHub] [lucene-solr] HoustonPutman merged pull request #1716: SOLR-14706: Fix support for default autoscaling policy

2020-08-10 Thread GitBox
HoustonPutman merged pull request #1716: URL: https://github.com/apache/lucene-solr/pull/1716 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (SOLR-14706) Upgrading 8.6.0 to 8.6.1 causes collection creation to fail

2020-08-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174398#comment-17174398 ] ASF subversion and git services commented on SOLR-14706: Commit

[jira] [Commented] (LUCENE-2458) queryparser makes all CJK queries phrase queries regardless of analyzer

2020-08-10 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174394#comment-17174394 ] Tomoko Uchida commented on LUCENE-2458: --- Seems spam account?  > queryparser makes all CJK queries

[jira] [Comment Edited] (LUCENE-2458) queryparser makes all CJK queries phrase queries regardless of analyzer

2020-08-10 Thread Mr. Aleem (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174386#comment-17174386 ] Mr. Aleem edited comment on LUCENE-2458 at 8/10/20, 3:26 PM: - Я думаю, [A

[jira] [Comment Edited] (LUCENE-2458) queryparser makes all CJK queries phrase queries regardless of analyzer

2020-08-10 Thread Mr. Aleem (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174386#comment-17174386 ] Mr. Aleem edited comment on LUCENE-2458 at 8/10/20, 3:26 PM: - Я думаю, [A

[jira] [Comment Edited] (LUCENE-2458) queryparser makes all CJK queries phrase queries regardless of analyzer

2020-08-10 Thread Mr. Aleem (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174386#comment-17174386 ] Mr. Aleem edited comment on LUCENE-2458 at 8/10/20, 3:19 PM: - Я думаю, [A

[jira] [Comment Edited] (LUCENE-2458) queryparser makes all CJK queries phrase queries regardless of analyzer

2020-08-10 Thread Mr. Aleem (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174386#comment-17174386 ] Mr. Aleem edited comment on LUCENE-2458 at 8/10/20, 3:17 PM: - Я думаю,

[jira] [Commented] (LUCENE-2458) queryparser makes all CJK queries phrase queries regardless of analyzer

2020-08-10 Thread Mr. Aleem (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174386#comment-17174386 ] Mr. Aleem commented on LUCENE-2458: --- Я думаю, https://piratesfile.com/;>A Place to download All PC

[jira] [Issue Comment Deleted] (LUCENE-2458) queryparser makes all CJK queries phrase queries regardless of analyzer

2020-08-10 Thread Mr. Aleem (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr. Aleem updated LUCENE-2458: -- Comment: was deleted (was: Я думаю, https://piratesfile.com/;>A Place to download All PC Softwareчто

[jira] [Comment Edited] (LUCENE-2458) queryparser makes all CJK queries phrase queries regardless of analyzer

2020-08-10 Thread Mr. Aleem (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174385#comment-17174385 ] Mr. Aleem edited comment on LUCENE-2458 at 8/10/20, 3:15 PM: - Я думаю,

[jira] [Commented] (LUCENE-2458) queryparser makes all CJK queries phrase queries regardless of analyzer

2020-08-10 Thread Mr. Aleem (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174385#comment-17174385 ] Mr. Aleem commented on LUCENE-2458: --- Я думаю, https://piratesfile.com/;>A Place to download All PC

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-10 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r467947455 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PlacementPlanFactory.java ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-10 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r467945960 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PlacementPlanFactory.java ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-10 Thread GitBox
murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r467943083 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/Cluster.java ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (LUCENE-9450) Taxonomy index should use DocValues not StoredFields

2020-08-10 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174343#comment-17174343 ] Michael McCandless commented on LUCENE-9450: +1, thanks [~gworah]!  It is really silly that

[jira] [Commented] (SOLR-13381) Unexpected docvalues type SORTED_NUMERIC Exception when grouping by a PointField facet

2020-08-10 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174336#comment-17174336 ] Cassandra Targett commented on SOLR-13381: -- The exact strategies your addition mentions in

[jira] [Updated] (SOLR-13381) Unexpected docvalues type SORTED_NUMERIC Exception when grouping by a PointField facet

2020-08-10 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-13381: -- Attachment: SOLR-13381.patch Status: Reopened (was: Reopened) [~ctargett] (or anyone)

[jira] [Assigned] (SOLR-13381) Unexpected docvalues type SORTED_NUMERIC Exception when grouping by a PointField facet

2020-08-10 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson reassigned SOLR-13381: - Assignee: Erick Erickson > Unexpected docvalues type SORTED_NUMERIC Exception when

[jira] [Reopened] (SOLR-13381) Unexpected docvalues type SORTED_NUMERIC Exception when grouping by a PointField facet

2020-08-10 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson reopened SOLR-13381: --- Good point, I'll add a note to the docs. > Unexpected docvalues type SORTED_NUMERIC Exception

[jira] [Updated] (SOLR-14691) Metrics reporting should avoid creating objects

2020-08-10 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-14691: -- Priority: Blocker (was: Major) > Metrics reporting should avoid creating objects >

[jira] [Updated] (SOLR-14691) Metrics reporting should avoid creating objects

2020-08-10 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-14691: -- Fix Version/s: 8.7 > Metrics reporting should avoid creating objects >

[GitHub] [lucene-solr] noblepaul commented on pull request #1694: SOLR-14680: Provide simple interfaces to our cloud classes (only API)

2020-08-10 Thread GitBox
noblepaul commented on pull request #1694: URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-671305266 I intend to merge this soon This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1694: SOLR-14680: Provide simple interfaces to our cloud classes (only API)

2020-08-10 Thread GitBox
noblepaul commented on a change in pull request #1694: URL: https://github.com/apache/lucene-solr/pull/1694#discussion_r467845512 ## File path: solr/solrj/src/java/org/apache/solr/cluster/api/SolrNode.java ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene-solr] s1monw commented on pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-10 Thread GitBox
s1monw commented on pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#issuecomment-671301636 @mikemccand I do understand the issue now why holding the _flushLock_ is illegal here. The problem is again the lock ordering in combination with the _commitLock_. One

[jira] [Commented] (SOLR-14641) PeerSync, remove canHandleVersionRanges check

2020-08-10 Thread Cao Manh Dat (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174251#comment-17174251 ] Cao Manh Dat commented on SOLR-14641: - bq. I disagree. In general, whoever wishes to introduce a

[jira] [Commented] (SOLR-14684) CloudExitableDirectoryReaderTest failing about 25% of the time

2020-08-10 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174249#comment-17174249 ] Erick Erickson commented on SOLR-14684: --- [~caomanhdat] I was able to run 1,000 iterations with the

[jira] [Commented] (SOLR-14641) PeerSync, remove canHandleVersionRanges check

2020-08-10 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174244#comment-17174244 ] Ishan Chattopadhyaya commented on SOLR-14641: - bq. But that quite non-sense to me from the

[jira] [Commented] (SOLR-14641) PeerSync, remove canHandleVersionRanges check

2020-08-10 Thread Cao Manh Dat (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174241#comment-17174241 ] Cao Manh Dat commented on SOLR-14641: - But that quite non-sense to me from the point of who did the

[GitHub] [lucene-solr] sigram commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-10 Thread GitBox
sigram commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r467810904 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PropertyKeyFactory.java ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache

[jira] [Comment Edited] (SOLR-14641) PeerSync, remove canHandleVersionRanges check

2020-08-10 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174239#comment-17174239 ] Ishan Chattopadhyaya edited comment on SOLR-14641 at 8/10/20, 10:41 AM:

[jira] [Commented] (SOLR-14641) PeerSync, remove canHandleVersionRanges check

2020-08-10 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174239#comment-17174239 ] Ishan Chattopadhyaya commented on SOLR-14641: - bq. It doesn't make sense to asking everyone

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

2020-08-10 Thread Cao Manh Dat (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174236#comment-17174236 ] Cao Manh Dat commented on SOLR-14354: - Ok then I will try my best to run it. > HttpShardHandler send

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

2020-08-10 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174234#comment-17174234 ] Ishan Chattopadhyaya commented on SOLR-14354: - bq. Ishan Chattopadhyaya, fair enough, do you

[jira] [Comment Edited] (SOLR-14641) PeerSync, remove canHandleVersionRanges check

2020-08-10 Thread Cao Manh Dat (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174228#comment-17174228 ] Cao Manh Dat edited comment on SOLR-14641 at 8/10/20, 10:29 AM: I believe

[jira] [Commented] (SOLR-14641) PeerSync, remove canHandleVersionRanges check

2020-08-10 Thread Cao Manh Dat (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174228#comment-17174228 ] Cao Manh Dat commented on SOLR-14641: - I believe the right way to ensure performance is coming up

[jira] [Commented] (SOLR-14641) PeerSync, remove canHandleVersionRanges check

2020-08-10 Thread Cao Manh Dat (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174226#comment-17174226 ] Cao Manh Dat commented on SOLR-14641: - I kinda hesitate to do such performance testing for this one,

[GitHub] [lucene-solr] sigram commented on a change in pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-10 Thread GitBox
sigram commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r467801413 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/Cluster.java ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (SOLR-14641) PeerSync, remove canHandleVersionRanges check

2020-08-10 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174225#comment-17174225 ] Ishan Chattopadhyaya commented on SOLR-14641: - Since this is a change that affects all users

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

2020-08-10 Thread Cao Manh Dat (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174224#comment-17174224 ] Cao Manh Dat commented on SOLR-14354: - [~ichattopadhyaya], fair enough, do you want to do the

[jira] [Commented] (SOLR-14641) PeerSync, remove canHandleVersionRanges check

2020-08-10 Thread Cao Manh Dat (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174220#comment-17174220 ] Cao Manh Dat commented on SOLR-14641: - [~ichattopadhyaya] I don't think this will be a seeable boost

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

2020-08-10 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174221#comment-17174221 ] Ishan Chattopadhyaya commented on SOLR-14354: - For a change like this, I would like to see

[jira] [Commented] (SOLR-14641) PeerSync, remove canHandleVersionRanges check

2020-08-10 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174214#comment-17174214 ] Ishan Chattopadhyaya commented on SOLR-14641: - bq. it should be removed to [...] a

[GitHub] [lucene-solr] noblepaul commented on pull request #1730: SOLR-14680: Provide an implementation for the new SolrCluster API

2020-08-10 Thread GitBox
noblepaul commented on pull request #1730: URL: https://github.com/apache/lucene-solr/pull/1730#issuecomment-671263417 I realized that I had to tweak the APIs after writing an implementation. I have updated the API-only PR #1694 to reflect the latest

[jira] [Commented] (SOLR-6152) Pre-populating values into search parameters on the query page of solr admin

2020-08-10 Thread Jakob Furrer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174211#comment-17174211 ] Jakob Furrer commented on SOLR-6152: New Patch: * Regression regarding the raw value field has been

[jira] [Updated] (SOLR-6152) Pre-populating values into search parameters on the query page of solr admin

2020-08-10 Thread Jakob Furrer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Furrer updated SOLR-6152: --- Attachment: SOLR-6152.patch > Pre-populating values into search parameters on the query page of solr

[jira] [Commented] (LUCENE-9448) Make an equivalent to Ant's "run" target for Luke module

2020-08-10 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174199#comment-17174199 ] Tomoko Uchida commented on LUCENE-9448: --- {quote}I always thought Luke is still a "stand-alone"

[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1730: SOLR-14680: Provide an implementation for the new SolrCluster API

2020-08-10 Thread GitBox
noblepaul edited a comment on pull request #1730: URL: https://github.com/apache/lucene-solr/pull/1730#issuecomment-671229892 > Separating out the new lazy implementations into another PR and keeping this one for adding interfaces to internal classes would have made reviewing easier.

[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1730: SOLR-14680: Provide simple interfaces to our concrete SolrCloud classes

2020-08-10 Thread GitBox
noblepaul edited a comment on pull request #1730: URL: https://github.com/apache/lucene-solr/pull/1730#issuecomment-671229892 > Separating out the new lazy implementations into another PR and keeping this one for adding interfaces to internal classes would have made reviewing easier.

  1   2   >