dweiss commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688661171
I'm committing it then, ok Uwe?
This is an automated message from the Apache Git Service.
To respond to the m
iverase merged pull request #1697:
URL: https://github.com/apache/lucene-solr/pull/1697
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-9292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191991#comment-17191991
]
ASF subversion and git services commented on LUCENE-9292:
-
Commi
dweiss commented on a change in pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#discussion_r484695767
##
File path: gradle/validation/validate-source-patterns.gradle
##
@@ -29,50 +33,127 @@ buildscript {
}
}
-configure(rootProject) {
- task("vali
uschindler commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688665608
I don't think that's the case. Running the whole thing a second time is
quite fast. I remember that all those filters in Maven and Ant are based on the
same code pattern
uschindler commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-68890
Ok merge it. Thanks.
This is an automated message from the Apache Git Service.
To respond to the message,
uschindler edited a comment on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688665608
I don't think that's the case. Running the whole thing a second time is
quite fast. I remember that all those filters in Maven and Ant are based on the
same code p
dweiss commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688666744
> I don't think that's the case. Running the whole thing a second time is
quite fast.
Because it's cached in the daemon? No way of telling without actually
digging at
uschindler commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688668964
Of course, running without daemon. Configure time is same. Execution is done
very fast.
This is an autom
uschindler commented on a change in pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#discussion_r484709609
##
File path: gradle/validation/validate-source-patterns.gradle
##
@@ -181,8 +252,13 @@ class ValidateSourcePatternsTask extends DefaultTask {
uschindler commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688686424
I checked source code: Actually Gradle does not use the Ant/Plexus
DirectoryScanner, it has a new Java 7 based one. This one handles inclusions
and exclusions in the same
[
https://issues.apache.org/jira/browse/SOLR-14840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192016#comment-17192016
]
Ilan Ginzburg commented on SOLR-14840:
--
Thanks [~ctargett] this is awesome! I didn't
uschindler commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688688433
I just pushed one more small change, ready to go!
This is an automated message from the Apache Git Servic
iverase opened a new pull request #1840:
URL: https://github.com/apache/lucene-solr/pull/1840
backport of #1697
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dweiss merged pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192025#comment-17192025
]
ASF subversion and git services commented on LUCENE-9506:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192026#comment-17192026
]
ASF subversion and git services commented on LUCENE-9506:
-
Commi
dweiss commented on pull request #1820:
URL: https://github.com/apache/lucene-solr/pull/1820#issuecomment-688700244
Ping, @romseygeek ? Let me know if you don't have time to take a look.
This is an automated message from the
[
https://issues.apache.org/jira/browse/LUCENE-9292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192031#comment-17192031
]
ASF subversion and git services commented on LUCENE-9292:
-
Commi
iverase merged pull request #1840:
URL: https://github.com/apache/lucene-solr/pull/1840
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
uschindler commented on pull request #1830:
URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-688708102
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log o
[
https://issues.apache.org/jira/browse/LUCENE-9292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-9292.
--
Fix Version/s: 8.7
Assignee: Ignacio Vera
Resolution: Fixed
> BKDWriter refact
Uwe Schindler created LUCENE-9512:
-
Summary: Add test-lock-factory to Gradle build
Key: LUCENE-9512
URL: https://issues.apache.org/jira/browse/LUCENE-9512
Project: Lucene - Core
Issue Type: T
[
https://issues.apache.org/jira/browse/LUCENE-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-9512:
--
Description:
When porting to Gradle, the following task was missed to be ported to Gradle:
htt
atris opened a new pull request #1841:
URL: https://github.com/apache/lucene-solr/pull/1841
This commit refactors rate limiters configuration to now be modelled as a
plugin and move its configuration from web.xml to a dedicated section in
solr.xml
Andrzej Bialecki created SOLR-14843:
---
Summary: Define strongly-typed cluster configuration API
Key: SOLR-14843
URL: https://issues.apache.org/jira/browse/SOLR-14843
Project: Solr
Issue Type
[
https://issues.apache.org/jira/browse/SOLR-14843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrzej Bialecki updated SOLR-14843:
Fix Version/s: master (9.0)
> Define strongly-typed cluster configuration API
> ---
[
https://issues.apache.org/jira/browse/SOLR-14843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192099#comment-17192099
]
Ishan Chattopadhyaya commented on SOLR-14843:
-
This warrants a SIP, imho.
>
[
https://issues.apache.org/jira/browse/SOLR-14843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192104#comment-17192104
]
Ilan Ginzburg commented on SOLR-14843:
--
I would suggest this new system allows setti
[
https://issues.apache.org/jira/browse/SOLR-14821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski resolved SOLR-14821.
Fix Version/s: 8.7
master (9.0)
Resolution: Fixed
Thanks again An
[
https://issues.apache.org/jira/browse/LUCENE-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192152#comment-17192152
]
Dawid Weiss commented on LUCENE-9512:
-
And why this can't be a regular test forking
[
https://issues.apache.org/jira/browse/LUCENE-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192155#comment-17192155
]
Uwe Schindler commented on LUCENE-9512:
---
I checked the code. IMHO, it's easier to
[
https://issues.apache.org/jira/browse/LUCENE-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192156#comment-17192156
]
Uwe Schindler commented on LUCENE-9512:
---
Hah same idea same time. I'll work on it.
[
https://issues.apache.org/jira/browse/LUCENE-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192158#comment-17192158
]
Dawid Weiss commented on LUCENE-9512:
-
Ping me when you have it for review, I'll tak
romseygeek commented on a change in pull request #1820:
URL: https://github.com/apache/lucene-solr/pull/1820#discussion_r484891054
##
File path:
lucene/highlighter/src/test/org/apache/lucene/search/matchhighlight/TestMatchHighlighter.java
##
@@ -0,0 +1,466 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/SOLR-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192193#comment-17192193
]
Colvin Cowie commented on SOLR-14768:
-
[~dsmiley] thanks, I've built a new solr-core
dweiss commented on a change in pull request #1820:
URL: https://github.com/apache/lucene-solr/pull/1820#discussion_r484900156
##
File path:
lucene/highlighter/src/test/org/apache/lucene/search/matchhighlight/TestMatchHighlighter.java
##
@@ -0,0 +1,466 @@
+/*
+ * Licensed to t
Cassandra Targett created SOLR-14844:
Summary: Upgrade Jetty to 9.4.30+
Key: SOLR-14844
URL: https://issues.apache.org/jira/browse/SOLR-14844
Project: Solr
Issue Type: Improvement
S
mikemccand commented on a change in pull request #1839:
URL: https://github.com/apache/lucene-solr/pull/1839#discussion_r484909064
##
File path:
lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java
##
@@ -351,7 +354,7 @@ FlushedSegment flush(DocumentsWrit
[
https://issues.apache.org/jira/browse/SOLR-14840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192237#comment-17192237
]
Cassandra Targett commented on SOLR-14840:
--
bq. Only issue I noticed is in the b
mayya-sharipova commented on a change in pull request #1725:
URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r484953402
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestFieldSortOptimizationSkipping.java
##
@@ -290,5 +299,114 @@ public void testF
mayya-sharipova commented on a change in pull request #1725:
URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r484953808
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestFieldSortOptimizationSkipping.java
##
@@ -290,5 +299,114 @@ public void testF
Jeff created SOLR-14845:
---
Summary: Backup failing with solr 7.7.2 java.io.IOException:
Interrupted system call
Key: SOLR-14845
URL: https://issues.apache.org/jira/browse/SOLR-14845
Project: Solr
Issue
[
https://issues.apache.org/jira/browse/LUCENE-9504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved LUCENE-9504.
---
Fix Version/s: master (9.0)
Resolution: Fixed
> DocumentsWriterDeleteQueue.forceApplyGlobalSl
[
https://issues.apache.org/jira/browse/LUCENE-9504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192268#comment-17192268
]
ASF subversion and git services commented on LUCENE-9504:
-
Commi
madrob merged pull request #1826:
URL: https://github.com/apache/lucene-solr/pull/1826
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
madrob commented on pull request #1732:
URL: https://github.com/apache/lucene-solr/pull/1732#issuecomment-688947909
@vthacker this is also some error-prone warnings, so may overlap with what
you're looking at.
This is an aut
madrob merged pull request #1469:
URL: https://github.com/apache/lucene-solr/pull/1469
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-14770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved SOLR-14770.
--
Fix Version/s: master (9.0)
Resolution: Fixed
> Multiple CoreContainers register same JVM gauge
[
https://issues.apache.org/jira/browse/SOLR-14770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192272#comment-17192272
]
ASF subversion and git services commented on SOLR-14770:
Commit 9
[
https://issues.apache.org/jira/browse/SOLR-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson reassigned SOLR-14844:
-
Assignee: Erick Erickson
> Upgrade Jetty to 9.4.30+
>
>
>
[
https://issues.apache.org/jira/browse/SOLR-14840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192275#comment-17192275
]
Cassandra Targett commented on SOLR-14840:
--
Pushed fixes to the bookmarks. There
madrob merged pull request #1732:
URL: https://github.com/apache/lucene-solr/pull/1732
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-14844:
--
Summary: Upgrade Jetty to 9.4.31 (was: Upgrade Jetty to 9.4.30+)
> Upgrade Jetty to 9.4.31
> -
rmuir commented on pull request #1837:
URL: https://github.com/apache/lucene-solr/pull/1837#issuecomment-688956220
Nice improvement here. I think we should not let the stacktrace stuff be a
blocker for this optimization. Out of box, the user should never even see
exceptions anyway: the exp
[
https://issues.apache.org/jira/browse/SOLR-14840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192285#comment-17192285
]
Ilan Ginzburg commented on SOLR-14840:
--
I think we're good now. I fixed a few occurr
s1monw commented on a change in pull request #1839:
URL: https://github.com/apache/lucene-solr/pull/1839#discussion_r485030437
##
File path:
lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java
##
@@ -351,7 +354,7 @@ FlushedSegment flush(DocumentsWriter.F
s1monw commented on a change in pull request #1839:
URL: https://github.com/apache/lucene-solr/pull/1839#discussion_r485030591
##
File path:
lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java
##
@@ -292,7 +295,7 @@ private void deleteLastDocs(int docCou
s1monw commented on a change in pull request #1839:
URL: https://github.com/apache/lucene-solr/pull/1839#discussion_r485031017
##
File path:
lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java
##
@@ -52,7 +52,7 @@
/** Default general purpose indexing chain,
s1monw commented on pull request #1839:
URL: https://github.com/apache/lucene-solr/pull/1839#issuecomment-688977953
> Change looks great! Was there a real user use case that triggered this? Or
a randomized test failure? I'm curious if the amount of RAM StoredFieldsWriter
uses is sometimes
[
https://issues.apache.org/jira/browse/SOLR-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192293#comment-17192293
]
Joe Doupnik commented on SOLR-14768:
Colvin and David,
That's good news, but looking
[
https://issues.apache.org/jira/browse/LUCENE-9511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192299#comment-17192299
]
ASF subversion and git services commented on LUCENE-9511:
-
Commi
s1monw merged pull request #1839:
URL: https://github.com/apache/lucene-solr/pull/1839
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jtibshirani commented on a change in pull request #1834:
URL: https://github.com/apache/lucene-solr/pull/1834#discussion_r485055929
##
File path:
lucene/test-framework/src/java/org/apache/lucene/search/AssertingWeight.java
##
@@ -85,11 +85,18 @@ public long cost() {
@Over
[
https://issues.apache.org/jira/browse/LUCENE-9511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192312#comment-17192312
]
ASF subversion and git services commented on LUCENE-9511:
-
Commi
[
https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192315#comment-17192315
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14151:
--
Sorry to be
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192342#comment-17192342
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14723:
--
bq. Should I
uschindler opened a new pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842
This PR moves the lock factory stress test to be a :lucene:core
unit/integration test. In verbose mode the output of clients is inherited, in
standard test mode its written to files (to allow d
[
https://issues.apache.org/jira/browse/LUCENE-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192346#comment-17192346
]
Uwe Schindler commented on LUCENE-9512:
---
Hi Dawid, I created a PR: https://github.
[
https://issues.apache.org/jira/browse/LUCENE-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192348#comment-17192348
]
Uwe Schindler commented on LUCENE-9512:
---
output looks like that (verbose mode):
{
murblanc commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-689041781
I am closing this PR now. Will create a new one with the up to date state of
the code as resulting from the discussions here, but things became way too slow
to still be usa
murblanc closed pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
murblanc commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-689042430
And please DO NOT DELETE the murblanc:SOLR-14613-gumi branch, I need it
around for a while.
This is an aut
[
https://issues.apache.org/jira/browse/LUCENE-9449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192379#comment-17192379
]
ASF subversion and git services commented on LUCENE-9449:
-
Commi
mayya-sharipova merged pull request #1725:
URL: https://github.com/apache/lucene-solr/pull/1725
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
[
https://issues.apache.org/jira/browse/LUCENE-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192380#comment-17192380
]
ASF subversion and git services commented on LUCENE-9280:
-
Commi
Mike Drob created SOLR-14846:
Summary: Avoid use of Optional.ofNullable.orElse in the same line
Key: SOLR-14846
URL: https://issues.apache.org/jira/browse/SOLR-14846
Project: Solr
Issue Type: Imp
madrob opened a new pull request #1843:
URL: https://github.com/apache/lucene-solr/pull/1843
https://issues.apache.org/jira/browse/SOLR-14846
This is an automated message from the Apache Git Service.
To respond to the message
[
https://issues.apache.org/jira/browse/SOLR-14846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192385#comment-17192385
]
Mike Drob commented on SOLR-14846:
--
He also discourages using Optional as an Object fiel
[
https://issues.apache.org/jira/browse/SOLR-14846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192386#comment-17192386
]
Mike Drob commented on SOLR-14846:
--
cc: [~varun] - you contributed some of the Backup st
dweiss commented on a change in pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#discussion_r485116034
##
File path: gradle/testing/randomization/policies/tests.policy
##
@@ -64,6 +64,9 @@ grant {
permission java.lang.RuntimePermission "getClassLoader
[
https://issues.apache.org/jira/browse/LUCENE-9511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192398#comment-17192398
]
Michael McCandless commented on LUCENE-9511:
{quote}The reason are very freq
mikemccand commented on pull request #1837:
URL: https://github.com/apache/lucene-solr/pull/1837#issuecomment-689070197
Whoa, thanks @uschindler -- this looks awesome.
> @mikemccand can you test this with JDK 15 (release candidate) and your
test. You should not see any locks anymore,
rmuir commented on a change in pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#discussion_r485136795
##
File path:
lucene/core/src/test/org/apache/lucene/store/TestLockFactoriesMultiJVM.java
##
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software
rmuir commented on a change in pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#discussion_r485138469
##
File path:
lucene/core/src/test/org/apache/lucene/store/TestLockFactoriesMultiJVM.java
##
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software
dweiss commented on a change in pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#discussion_r485152152
##
File path:
lucene/core/src/test/org/apache/lucene/store/TestLockFactoriesMultiJVM.java
##
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/SOLR-14846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192418#comment-17192418
]
Varun Thacker commented on SOLR-14846:
--
Thanks for linking the video! I think the ch
vthacker commented on a change in pull request #1843:
URL: https://github.com/apache/lucene-solr/pull/1843#discussion_r485154167
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java
##
@@ -36,7 +35,7 @@
*by confi
[
https://issues.apache.org/jira/browse/SOLR-14844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192420#comment-17192420
]
Erick Erickson commented on SOLR-14844:
---
I'm getting a 100% reproducible error on 8
Mike Drob created SOLR-14847:
Summary: Solr packaging needs to produce server tgz for release
Key: SOLR-14847
URL: https://issues.apache.org/jira/browse/SOLR-14847
Project: Solr
Issue Type: Task
madrob opened a new pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/SOLR-14843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192425#comment-17192425
]
David Smiley commented on SOLR-14843:
-
Yeah a SIP. Lets look at this in a light-weig
dweiss commented on a change in pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#discussion_r485162521
##
File path: solr/packaging/build.gradle
##
@@ -109,6 +109,21 @@ task toDir(type: Sync) {
}
}
+task toTgz(type: Tar) {
Review comment:
I
uschindler commented on a change in pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#discussion_r485169448
##
File path:
lucene/core/src/test/org/apache/lucene/store/TestLockFactoriesMultiJVM.java
##
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Soft
uschindler commented on a change in pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#discussion_r485169213
##
File path: gradle/testing/randomization/policies/tests.policy
##
@@ -64,6 +64,9 @@ grant {
permission java.lang.RuntimePermission "getClassLo
uschindler commented on a change in pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#discussion_r485170130
##
File path:
lucene/core/src/test/org/apache/lucene/store/TestLockFactoriesMultiJVM.java
##
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Soft
uschindler commented on a change in pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#discussion_r485170867
##
File path:
lucene/core/src/test/org/apache/lucene/store/TestLockFactoriesMultiJVM.java
##
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Soft
dweiss commented on a change in pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#discussion_r485175148
##
File path:
lucene/core/src/test/org/apache/lucene/store/TestLockFactoriesMultiJVM.java
##
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software
uschindler commented on a change in pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#discussion_r485169213
##
File path: gradle/testing/randomization/policies/tests.policy
##
@@ -64,6 +64,9 @@ grant {
permission java.lang.RuntimePermission "getClassLo
uschindler commented on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689117698
I pushed some fixes:
- Removed the AtomicInteger for the port number. As the server is running in
test, we just call the server directly and it uses a Consumer(InetAddr
1 - 100 of 121 matches
Mail list logo
