[jira] [Commented] (SOLR-14883) Add a Muse (CI) configuration file

2020-09-21 Thread Thomas DuBuisson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199812#comment-17199812 ] Thomas DuBuisson commented on SOLR-14883: - [~dsmiley] Gladly, though I have no links that address

[GitHub] [lucene-solr] ErickErickson commented on pull request #1881: SOLR-14876: Upgrade to zookeeper 3.6.2

2020-09-21 Thread GitBox
ErickErickson commented on pull request #1881: URL: https://github.com/apache/lucene-solr/pull/1881#issuecomment-695867035 This has been fixed in Solr 8.7... This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr] madrob commented on pull request #5: SOLR-8639 replace static SimpleDateFormat with threadsafe jodatimeDateFormatter

2020-09-21 Thread GitBox
madrob commented on pull request #5: URL: https://github.com/apache/lucene-solr/pull/5#issuecomment-696234934 DIH has been moved out to an external package, please consider submitting your patch to https://github.com/rohitbemax/dataimporthandler - thank you!

[GitHub] [lucene-solr] dsmiley closed pull request #1875: SOLR-14802: Allow LLPSF fields as geodist argument

2020-09-21 Thread GitBox
dsmiley closed pull request #1875: URL: https://github.com/apache/lucene-solr/pull/1875 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1861: SOLR-10391: Add overwrite option to UPLOAD ConfigSet action

2020-09-21 Thread GitBox
tflobbe commented on a change in pull request #1861: URL: https://github.com/apache/lucene-solr/pull/1861#discussion_r492423507 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ConfigSetsHandler.java ## @@ -170,21 +176,90 @@ private void

[GitHub] [lucene-solr] madrob commented on a change in pull request #1891: SOLR-14877: Add github action for running SolrJ tests.

2020-09-21 Thread GitBox
madrob commented on a change in pull request #1891: URL: https://github.com/apache/lucene-solr/pull/1891#discussion_r492179162 ## File path: .github/workflows/solrj-test.yml ## @@ -0,0 +1,27 @@ +name: SolrJ Tests + +on: + pull_request: +branches: + - 'master' +

[GitHub] [lucene-solr] TomMD commented on a change in pull request #1901: SOLR-14883 Add a Muse (Continuous assurance platform) configuration

2020-09-21 Thread GitBox
TomMD commented on a change in pull request #1901: URL: https://github.com/apache/lucene-solr/pull/1901#discussion_r492311229 ## File path: .muse/config.toml ## @@ -0,0 +1 @@ +jdk11 = true Review comment: @tflobbe Sure, I'll put that here and amend the commit.

[GitHub] [lucene-solr] mayya-sharipova commented on pull request #1903: Fix bug in sort optimization

2020-09-21 Thread GitBox
mayya-sharipova commented on pull request #1903: URL: https://github.com/apache/lucene-solr/pull/1903#issuecomment-696373592 @jimczi I could not reproduce an issue of duplicate documents in Lucene, and I am still not sure how it actually happens. Even as we were [incorrectly

[GitHub] [lucene-solr] dsmiley commented on pull request #1740: LUCENE-9458: WDGF and WDF should tie-break by endOffset

2020-09-21 Thread GitBox
dsmiley commented on pull request #1740: URL: https://github.com/apache/lucene-solr/pull/1740#issuecomment-696351031 Sorry for the delay; I have had a solution for over a month locally but didn't share it yet. I'm pretty comfortable with what I just pushed. I did some "fuzz

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1896: SOLR-14880: Support coreRootDirectory setting when create new cores from command line, in standalone mode

2020-09-21 Thread GitBox
dsmiley commented on a change in pull request #1896: URL: https://github.com/apache/lucene-solr/pull/1896#discussion_r492238398 ## File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java ## @@ -1675,9 +1675,9 @@ protected void runImpl(CommandLine cli) throws Exception

[GitHub] [lucene-solr] arafalov commented on a change in pull request #1894: SOLR-14878: Expose solr.xml's coreRootDirectory property via the System Settings API

2020-09-21 Thread GitBox
arafalov commented on a change in pull request #1894: URL: https://github.com/apache/lucene-solr/pull/1894#discussion_r492270332 ## File path: solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java ## @@ -139,8 +140,19 @@ public void

[GitHub] [lucene-solr] HoustonPutman merged pull request #1899: Adding dev-docs around the use of Git Worktree.

2020-09-21 Thread GitBox
HoustonPutman merged pull request #1899: URL: https://github.com/apache/lucene-solr/pull/1899 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene-solr] arafalov commented on pull request #1898: SOLR-14882

2020-09-21 Thread GitBox
arafalov commented on pull request #1898: URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696160912 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene-solr] sigram commented on pull request #1758: SOLR-14749: Provide a clean API for cluster-level event processing, Initial draft.

2020-09-21 Thread GitBox
sigram commented on pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#issuecomment-696057300 @murblanc See `CollectionsRepairEventListener` for an example. Also the `ClusterEventProducerTest` unit test.

[GitHub] [lucene-solr] arafalov merged pull request #1897: SOLR-9607: Finalize move of Terms component and request handler into the implicit definitions

2020-09-21 Thread GitBox
arafalov merged pull request #1897: URL: https://github.com/apache/lucene-solr/pull/1897 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1901: SOLR-14883 Add a Muse (Continuous assurance platform) configuration

2020-09-21 Thread GitBox
tflobbe commented on a change in pull request #1901: URL: https://github.com/apache/lucene-solr/pull/1901#discussion_r492252479 ## File path: .muse/config.toml ## @@ -0,0 +1 @@ +jdk11 = true Review comment: Could you add a comment or two pointing to the documentation

[GitHub] [lucene-solr] ErickErickson closed pull request #1881: SOLR-14876: Upgrade to zookeeper 3.6.2

2020-09-21 Thread GitBox
ErickErickson closed pull request #1881: URL: https://github.com/apache/lucene-solr/pull/1881 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1894: SOLR-14878: Expose solr.xml's coreRootDirectory property via the System Settings API

2020-09-21 Thread GitBox
dsmiley commented on a change in pull request #1894: URL: https://github.com/apache/lucene-solr/pull/1894#discussion_r492252261 ## File path: solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java ## @@ -139,8 +140,19 @@ public void

[GitHub] [lucene-solr] sigram commented on a change in pull request #1758: SOLR-14749: Provide a clean API for cluster-level event processing, Initial draft.

2020-09-21 Thread GitBox
sigram commented on a change in pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r491867642 ## File path: solr/core/src/java/org/apache/solr/cluster/events/CollectionsAddedEvent.java ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] goankur commented on pull request #1733: LUCENE-9450 Use BinaryDocValues in the taxonomy writer

2020-09-21 Thread GitBox
goankur commented on pull request #1733: URL: https://github.com/apache/lucene-solr/pull/1733#issuecomment-696420384 Thanks @gautamworah96 for this impactful change and @mikemccand for reviewing it. A few thoughts 1. This change disables STORED fields part but keeps the

[GitHub] [lucene-solr] noblepaul commented on pull request #1897: SOLR-9607: Finalize move of Terms component and request handler into the implicit definitions

2020-09-21 Thread GitBox
noblepaul commented on pull request #1897: URL: https://github.com/apache/lucene-solr/pull/1897#issuecomment-696079153  This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene-solr] madrob closed pull request #5: SOLR-8639 replace static SimpleDateFormat with threadsafe jodatimeDateFormatter

2020-09-21 Thread GitBox
madrob closed pull request #5: URL: https://github.com/apache/lucene-solr/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1891: SOLR-14877: Add github action for running SolrJ tests.

2020-09-21 Thread GitBox
HoustonPutman commented on a change in pull request #1891: URL: https://github.com/apache/lucene-solr/pull/1891#discussion_r492184982 ## File path: .github/workflows/solrj-test.yml ## @@ -0,0 +1,27 @@ +name: SolrJ Tests + +on: + pull_request: +branches: + - 'master'

[GitHub] [lucene-solr] munendrasn commented on pull request #1900: [SSK-14036]: Remove explicit distrib=false from /terms handler

2020-09-21 Thread GitBox
munendrasn commented on pull request #1900: URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696242179 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1877: SOLR-13181: param macro expansion could throw

2020-09-21 Thread GitBox
dsmiley commented on a change in pull request #1877: URL: https://github.com/apache/lucene-solr/pull/1877#discussion_r492226769 ## File path: solr/core/src/test/org/apache/solr/request/macro/TestMacroExpander.java ## @@ -143,15 +142,31 @@ public void testMapExprExpandOn() {

[GitHub] [lucene-solr] Hronom commented on a change in pull request #1864: SOLR-14850 ExactStatsCache NullPointerException when shards.tolerant=true

2020-09-21 Thread GitBox
Hronom commented on a change in pull request #1864: URL: https://github.com/apache/lucene-solr/pull/1864#discussion_r492247322 ## File path: solr/core/src/java/org/apache/solr/search/stats/ExactStatsCache.java ## @@ -94,6 +94,12 @@ protected ShardRequest

[GitHub] [lucene-solr] dsmiley commented on pull request #1875: SOLR-14802: Allow LLPSF fields as geodist argument

2020-09-21 Thread GitBox
dsmiley commented on pull request #1875: URL: https://github.com/apache/lucene-solr/pull/1875#issuecomment-695886358 I made some tweaks and committed to master & branch_8x This is an automated message from the Apache Git

[GitHub] [lucene-solr] arafalov commented on a change in pull request #1896: SOLR-14880: Support coreRootDirectory setting when create new cores from command line, in standalone mode

2020-09-21 Thread GitBox
arafalov commented on a change in pull request #1896: URL: https://github.com/apache/lucene-solr/pull/1896#discussion_r492241814 ## File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java ## @@ -1675,9 +1675,9 @@ protected void runImpl(CommandLine cli) throws Exception

[GitHub] [lucene-solr] arafalov commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler

2020-09-21 Thread GitBox
arafalov commented on pull request #1900: URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696269537 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene-solr] arafalov merged pull request #1904: SOLR-14878: Expose solr.xml's coreRootDirectory property via the System Settings API (part 2)

2020-09-21 Thread GitBox
arafalov merged pull request #1904: URL: https://github.com/apache/lucene-solr/pull/1904 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1877: SOLR-13181: param macro expansion could throw

2020-09-21 Thread GitBox
cpoerschke commented on a change in pull request #1877: URL: https://github.com/apache/lucene-solr/pull/1877#discussion_r492216575 ## File path: solr/core/src/test/org/apache/solr/request/macro/TestMacroExpander.java ## @@ -143,15 +142,31 @@ public void testMapExprExpandOn()

[GitHub] [lucene-solr] epugh commented on pull request #1898: SOLR-14882

2020-09-21 Thread GitBox
epugh commented on pull request #1898: URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696166997 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1758: SOLR-14749: Provide a clean API for cluster-level event processing, Initial draft.

2020-09-21 Thread GitBox
murblanc commented on a change in pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r491887454 ## File path: solr/core/src/java/org/apache/solr/cluster/events/ClusterEventProducer.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] madrob commented on pull request #1638: SOLR-14066: Deprecate DIH

2020-09-21 Thread GitBox
madrob commented on pull request #1638: URL: https://github.com/apache/lucene-solr/pull/1638#issuecomment-696235285 @chatman Can we close this? It looks like DIH has already been removed in master branch. This is an

[GitHub] [lucene-solr] madrob commented on pull request #1898: SOLR-14882

2020-09-21 Thread GitBox
madrob commented on pull request #1898: URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696213908 Please add a CHANGES entry This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] madrob commented on a change in pull request #1864: SOLR-14850 ExactStatsCache NullPointerException when shards.tolerant=true

2020-09-21 Thread GitBox
madrob commented on a change in pull request #1864: URL: https://github.com/apache/lucene-solr/pull/1864#discussion_r492181202 ## File path: solr/core/src/java/org/apache/solr/search/stats/ExactStatsCache.java ## @@ -94,6 +94,12 @@ protected ShardRequest

[GitHub] [lucene-solr] tflobbe commented on pull request #1861: SOLR-10391: Add overwrite option to UPLOAD ConfigSet action

2020-09-21 Thread GitBox
tflobbe commented on pull request #1861: URL: https://github.com/apache/lucene-solr/pull/1861#issuecomment-696456676 I plan to merge this tomorrow This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] dsmiley commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler

2020-09-21 Thread GitBox
dsmiley commented on pull request #1900: URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696260676 I'm glad to see this :-) I think the change of default behavior for users using /terms should be master-only and have a note in `solr-upgrade-notes.adoc`. If you

[GitHub] [lucene-solr] ctargett commented on pull request #1869: SOLR-14866 autowidth tables in ref guide

2020-09-21 Thread GitBox
ctargett commented on pull request #1869: URL: https://github.com/apache/lucene-solr/pull/1869#issuecomment-696366569 I'm a little confused what's going on here at this point. It seems the latest commits increase the mixing of styles, which as I said is fine with me in general, but sort

[jira] [Commented] (SOLR-14878) SystemInfoHandler need to expose coreRootDirectory

2020-09-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199741#comment-17199741 ] ASF subversion and git services commented on SOLR-14878: Commit

[GitHub] [lucene-solr] arafalov merged pull request #1904: SOLR-14878: Expose solr.xml's coreRootDirectory property via the System Settings API (part 2)

2020-09-21 Thread GitBox
arafalov merged pull request #1904: URL: https://github.com/apache/lucene-solr/pull/1904 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (LUCENE-9537) Add Indri Search Engine Functionality to Lucene

2020-09-21 Thread Cameron VandenBerg (Jira)
Cameron VandenBerg created LUCENE-9537: -- Summary: Add Indri Search Engine Functionality to Lucene Key: LUCENE-9537 URL: https://issues.apache.org/jira/browse/LUCENE-9537 Project: Lucene - Core

[jira] [Commented] (LUCENE-9528) Clean up obsolete and commented-out cruft from StandardSyntaxParser.jj

2020-09-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199740#comment-17199740 ] David Smiley commented on LUCENE-9528: -- Just curious; are you (Dawid) improving the flexible query

[jira] [Commented] (SOLR-14884) TestContainerPlugin.testApiFromPackage jenkins failures

2020-09-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199733#comment-17199733 ] ASF subversion and git services commented on SOLR-14884: Commit

[jira] [Commented] (SOLR-14884) TestContainerPlugin.testApiFromPackage jenkins failures

2020-09-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199732#comment-17199732 ] ASF subversion and git services commented on SOLR-14884: Commit

[jira] [Commented] (SOLR-14884) TestContainerPlugin.testApiFromPackage jenkins failures

2020-09-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199729#comment-17199729 ] ASF subversion and git services commented on SOLR-14884: Commit

[jira] [Commented] (SOLR-14884) TestContainerPlugin.testApiFromPackage jenkins failures

2020-09-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199728#comment-17199728 ] ASF subversion and git services commented on SOLR-14884: Commit

[jira] [Commented] (SOLR-14597) Advanced Query Parser

2020-09-21 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199726#comment-17199726 ] Gus Heck commented on SOLR-14597: - looks like LUCENE-9531 has caused a conflict with the patch, and there

[GitHub] [lucene-solr] tflobbe commented on pull request #1861: SOLR-10391: Add overwrite option to UPLOAD ConfigSet action

2020-09-21 Thread GitBox
tflobbe commented on pull request #1861: URL: https://github.com/apache/lucene-solr/pull/1861#issuecomment-696456676 I plan to merge this tomorrow This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1861: SOLR-10391: Add overwrite option to UPLOAD ConfigSet action

2020-09-21 Thread GitBox
tflobbe commented on a change in pull request #1861: URL: https://github.com/apache/lucene-solr/pull/1861#discussion_r492423507 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ConfigSetsHandler.java ## @@ -170,21 +176,90 @@ private void

[jira] [Created] (SOLR-14884) TestContainerPlugin.testApiFromPackage jenkins failures

2020-09-21 Thread Noble Paul (Jira)
Noble Paul created SOLR-14884: - Summary: TestContainerPlugin.testApiFromPackage jenkins failures Key: SOLR-14884 URL: https://issues.apache.org/jira/browse/SOLR-14884 Project: Solr Issue Type:

[GitHub] [lucene-solr] madrob opened a new pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-09-21 Thread GitBox
madrob opened a new pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905 Deleted lucene/version.properties again This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [lucene-solr] goankur commented on pull request #1733: LUCENE-9450 Use BinaryDocValues in the taxonomy writer

2020-09-21 Thread GitBox
goankur commented on pull request #1733: URL: https://github.com/apache/lucene-solr/pull/1733#issuecomment-696420384 Thanks @gautamworah96 for this impactful change and @mikemccand for reviewing it. A few thoughts 1. This change disables STORED fields part but keeps the

[GitHub] [lucene-solr] arafalov opened a new pull request #1904: SOLR-14878: Expose solr.xml's coreRootDirectory property via the System Settings API (part 2)

2020-09-21 Thread GitBox
arafalov opened a new pull request #1904: URL: https://github.com/apache/lucene-solr/pull/1904 # Description Adjustment based on comments in - merged - #1894 # Solution 1. Shorten the name solr_core_root->core_root 2. Always return the value, even if not explicitly

[jira] [Commented] (SOLR-14883) Add a Muse (CI) configuration file

2020-09-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199686#comment-17199686 ] David Smiley commented on SOLR-14883: - Can you please add some links here on ASF infra's / GitHub's

[GitHub] [lucene-solr] arafalov commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler

2020-09-21 Thread GitBox
arafalov commented on pull request #1900: URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696402318 > @arafalov > There is one already which I have modified(DistributedTermsComponentTest) -

[jira] [Created] (LUCENE-9536) Optimize OrdinalMap when one segment contains all distinct values?

2020-09-21 Thread Julie Tibshirani (Jira)
Julie Tibshirani created LUCENE-9536: Summary: Optimize OrdinalMap when one segment contains all distinct values? Key: LUCENE-9536 URL: https://issues.apache.org/jira/browse/LUCENE-9536 Project:

[jira] [Commented] (SOLR-10305) uniqueKey field store=false will throw null NullPointerException

2020-09-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199665#comment-17199665 ] David Smiley commented on SOLR-10305: - For awhile now, uniqueKey supports docValues=true

[GitHub] [lucene-solr] mayya-sharipova commented on pull request #1903: Fix bug in sort optimization

2020-09-21 Thread GitBox
mayya-sharipova commented on pull request #1903: URL: https://github.com/apache/lucene-solr/pull/1903#issuecomment-696373592 @jimczi I could not reproduce an issue of duplicate documents in Lucene, and I am still not sure how it actually happens. Even as we were [incorrectly

[GitHub] [lucene-solr] mayya-sharipova opened a new pull request #1903: Fix bug in sort optimization

2020-09-21 Thread GitBox
mayya-sharipova opened a new pull request #1903: URL: https://github.com/apache/lucene-solr/pull/1903 Fix bug how iterator with skipping functionality advances and produces docs Relates to #1725 This is an

[GitHub] [lucene-solr] dsmiley commented on pull request #1740: LUCENE-9458: WDGF and WDF should tie-break by endOffset

2020-09-21 Thread GitBox
dsmiley commented on pull request #1740: URL: https://github.com/apache/lucene-solr/pull/1740#issuecomment-696351031 Sorry for the delay; I have had a solution for over a month locally but didn't share it yet. I'm pretty comfortable with what I just pushed. I did some "fuzz

[GitHub] [lucene-solr] TomMD commented on a change in pull request #1901: SOLR-14883 Add a Muse (Continuous assurance platform) configuration

2020-09-21 Thread GitBox
TomMD commented on a change in pull request #1901: URL: https://github.com/apache/lucene-solr/pull/1901#discussion_r492311229 ## File path: .muse/config.toml ## @@ -0,0 +1 @@ +jdk11 = true Review comment: @tflobbe Sure, I'll put that here and amend the commit.

[jira] [Commented] (LUCENE-9464) Add high(er)-level hit highlighter example that demonstrates and uses low-level components

2020-09-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199621#comment-17199621 ] David Smiley commented on LUCENE-9464: -- Yes, "lucene.experimental" is mostly about API stability

[jira] [Commented] (LUCENE-3550) Create example code for core

2020-09-21 Thread Animesh Pandey (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-3550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199616#comment-17199616 ] Animesh Pandey commented on LUCENE-3550: Hi, This is a pretty old Jira but I see that it is

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1894: SOLR-14878: Expose solr.xml's coreRootDirectory property via the System Settings API

2020-09-21 Thread GitBox
dsmiley commented on a change in pull request #1894: URL: https://github.com/apache/lucene-solr/pull/1894#discussion_r492274546 ## File path: solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java ## @@ -139,8 +140,19 @@ public void

[GitHub] [lucene-solr] epugh commented on pull request #1898: SOLR-14882

2020-09-21 Thread GitBox
epugh commented on pull request #1898: URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696301654 This is why we need a full overhaul of the SolrCLI, get all this logic out of the solr shell and cmd files, and into Java, and have one way of doing everything!

[GitHub] [lucene-solr] epugh commented on pull request #1898: SOLR-14882

2020-09-21 Thread GitBox
epugh commented on pull request #1898: URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696299309 Okay, turns out my not loading json was due to something odd in the sample data I exported (sigh)... However, the more_books.jsonl works just fine.

[GitHub] [lucene-solr] arafalov commented on a change in pull request #1894: SOLR-14878: Expose solr.xml's coreRootDirectory property via the System Settings API

2020-09-21 Thread GitBox
arafalov commented on a change in pull request #1894: URL: https://github.com/apache/lucene-solr/pull/1894#discussion_r492270332 ## File path: solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java ## @@ -139,8 +140,19 @@ public void

[GitHub] [lucene-solr] arafalov commented on pull request #1898: SOLR-14882

2020-09-21 Thread GitBox
arafalov commented on pull request #1898: URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696296773 > Okay, so @arafalov I am having NO luck in finding the text `usage:` or where it is comiong from... I can live with it... It helps to see where other invocations do

[GitHub] [lucene-solr] epugh commented on pull request #1898: SOLR-14882

2020-09-21 Thread GitBox
epugh commented on pull request #1898: URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696292278 Okay, working on testing the CURL commands in the solr-control-script-reference.adoc...I am not able to do this: ``` curl -X POST -d @big.jsonl

[GitHub] [lucene-solr] HoustonPutman merged pull request #1899: Adding dev-docs around the use of Git Worktree.

2020-09-21 Thread GitBox
HoustonPutman merged pull request #1899: URL: https://github.com/apache/lucene-solr/pull/1899 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene-solr] epugh commented on pull request #1898: SOLR-14882

2020-09-21 Thread GitBox
epugh commented on pull request #1898: URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696284466 Okay, so @arafalov I am having NO luck in finding the text `usage:` or where it is comiong from... I can live with it...

[jira] [Commented] (SOLR-9607) Finalize /terms implicit definition and remove explicit one from configsets

2020-09-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199566#comment-17199566 ] David Smiley commented on SOLR-9607: Oops; I was confused with SOLR-14036; nevermind. > Finalize

[jira] [Commented] (SOLR-9607) Finalize /terms implicit definition and remove explicit one from configsets

2020-09-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199564#comment-17199564 ] David Smiley commented on SOLR-9607: My code review indicated that you should update

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1901: SOLR-14883 Add a Muse (Continuous assurance platform) configuration

2020-09-21 Thread GitBox
tflobbe commented on a change in pull request #1901: URL: https://github.com/apache/lucene-solr/pull/1901#discussion_r492252479 ## File path: .muse/config.toml ## @@ -0,0 +1 @@ +jdk11 = true Review comment: Could you add a comment or two pointing to the documentation

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1894: SOLR-14878: Expose solr.xml's coreRootDirectory property via the System Settings API

2020-09-21 Thread GitBox
dsmiley commented on a change in pull request #1894: URL: https://github.com/apache/lucene-solr/pull/1894#discussion_r492252261 ## File path: solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java ## @@ -139,8 +140,19 @@ public void

[GitHub] [lucene-solr] Hronom commented on a change in pull request #1864: SOLR-14850 ExactStatsCache NullPointerException when shards.tolerant=true

2020-09-21 Thread GitBox
Hronom commented on a change in pull request #1864: URL: https://github.com/apache/lucene-solr/pull/1864#discussion_r492247322 ## File path: solr/core/src/java/org/apache/solr/search/stats/ExactStatsCache.java ## @@ -94,6 +94,12 @@ protected ShardRequest

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

2020-09-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199558#comment-17199558 ] David Smiley commented on SOLR-14354: - It's nice to see you participating in other issues, Mark ;-)

[GitHub] [lucene-solr] munendrasn commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler

2020-09-21 Thread GitBox
munendrasn commented on pull request #1900: URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696271215 @arafalov There is one already which I have modified(DistributedTermsComponentTest) -

[GitHub] [lucene-solr] arafalov commented on a change in pull request #1896: SOLR-14880: Support coreRootDirectory setting when create new cores from command line, in standalone mode

2020-09-21 Thread GitBox
arafalov commented on a change in pull request #1896: URL: https://github.com/apache/lucene-solr/pull/1896#discussion_r492241814 ## File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java ## @@ -1675,9 +1675,9 @@ protected void runImpl(CommandLine cli) throws Exception

[GitHub] [lucene-solr] arafalov commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler

2020-09-21 Thread GitBox
arafalov commented on pull request #1900: URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696269537 I can't comment on the code, as I did not understand the shard part. I am happy if the extra parameter (distrib=false) is not needed. I did feel that maybe a test was

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1896: SOLR-14880: Support coreRootDirectory setting when create new cores from command line, in standalone mode

2020-09-21 Thread GitBox
dsmiley commented on a change in pull request #1896: URL: https://github.com/apache/lucene-solr/pull/1896#discussion_r492238398 ## File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java ## @@ -1675,9 +1675,9 @@ protected void runImpl(CommandLine cli) throws Exception

[GitHub] [lucene-solr] munendrasn commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler

2020-09-21 Thread GitBox
munendrasn commented on pull request #1900: URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696263900 >I think the change of default behavior for users using /terms should be master-only and have a note in solr-upgrade-notes.adoc. If you like, you could backport the

[GitHub] [lucene-solr] munendrasn commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler

2020-09-21 Thread GitBox
munendrasn commented on pull request #1900: URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696262897 @joel-bernstein Please review(not able to tags as a reviewer so the ping) This is an automated message

[GitHub] [lucene-solr] dsmiley commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler

2020-09-21 Thread GitBox
dsmiley commented on pull request #1900: URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696260676 I'm glad to see this :-) I think the change of default behavior for users using /terms should be master-only and have a note in `solr-upgrade-notes.adoc`. If you

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1877: SOLR-13181: param macro expansion could throw

2020-09-21 Thread GitBox
dsmiley commented on a change in pull request #1877: URL: https://github.com/apache/lucene-solr/pull/1877#discussion_r492226769 ## File path: solr/core/src/test/org/apache/solr/request/macro/TestMacroExpander.java ## @@ -143,15 +142,31 @@ public void testMapExprExpandOn() {

[GitHub] [lucene-solr] murblanc opened a new pull request #1902: SOLR-14840: Overseer doc in asciidoc

2020-09-21 Thread GitBox
murblanc opened a new pull request #1902: URL: https://github.com/apache/lucene-solr/pull/1902 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (SOLR-14840) Convert Overseer Google doc to asciidoc for addition to Git repo

2020-09-21 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199524#comment-17199524 ] Ilan Ginzburg commented on SOLR-14840: -- Thanks [~ctargett]. Will merge then resolve this Jira. Good

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1877: SOLR-13181: param macro expansion could throw

2020-09-21 Thread GitBox
cpoerschke commented on a change in pull request #1877: URL: https://github.com/apache/lucene-solr/pull/1877#discussion_r492216575 ## File path: solr/core/src/test/org/apache/solr/request/macro/TestMacroExpander.java ## @@ -143,15 +142,31 @@ public void testMapExprExpandOn()

[jira] [Updated] (SOLR-14036) TermsComponent distributed search (shards) doesn't work with SolrCloud

2020-09-21 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-14036: Status: Patch Available (was: Reopened) > TermsComponent distributed search (shards) doesn't work

[jira] [Commented] (SOLR-14036) TermsComponent distributed search (shards) doesn't work with SolrCloud

2020-09-21 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199521#comment-17199521 ] Munendra S N commented on SOLR-14036: - I had forgotten about this one. I have raised the PR(due to

[jira] [Assigned] (SOLR-14036) TermsComponent distributed search (shards) doesn't work with SolrCloud

2020-09-21 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N reassigned SOLR-14036: --- Assignee: Munendra S N > TermsComponent distributed search (shards) doesn't work with

[GitHub] [lucene-solr] tflobbe merged pull request #1892: Improve TestConfigSetsAPI

2020-09-21 Thread GitBox
tflobbe merged pull request #1892: URL: https://github.com/apache/lucene-solr/pull/1892 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] TomMD opened a new pull request #1901: SOLR-14883 Add a Muse (Continuous assurance platform) configuration

2020-09-21 Thread GitBox
TomMD opened a new pull request #1901: URL: https://github.com/apache/lucene-solr/pull/1901 # Description The Apache infrastructure team has installed the Muse GitHub application. In order for Lucene-Solr to benefit the application must understand how to build the project. While

[jira] [Created] (SOLR-14883) Add a Muse (CI) configuration file

2020-09-21 Thread Thomas DuBuisson (Jira)
Thomas DuBuisson created SOLR-14883: --- Summary: Add a Muse (CI) configuration file Key: SOLR-14883 URL: https://issues.apache.org/jira/browse/SOLR-14883 Project: Solr Issue Type: Test

[jira] [Commented] (SOLR-14859) [* TO *] queries on DateRange fields miss results

2020-09-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199502#comment-17199502 ] ASF subversion and git services commented on SOLR-14859: Commit

[GitHub] [lucene-solr] munendrasn commented on pull request #1900: [SSK-14036]: Remove explicit distrib=false from /terms handler

2020-09-21 Thread GitBox
munendrasn commented on pull request #1900: URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696242179 @tflobbe I have removed CustomTermsComponentTest as none of the components currently have custom handling of shardWhitelist. Let me know if that should be added back

[GitHub] [lucene-solr] munendrasn opened a new pull request #1900: [SSK-14036]: Remove explicit distrib=false from /terms handler

2020-09-21 Thread GitBox
munendrasn opened a new pull request #1900: URL: https://github.com/apache/lucene-solr/pull/1900 * This removes shards, shards.qt, and shard whitelisting checks from TermsComponent. Similar to other components, this check will be done in HttpShardHandler

[jira] [Commented] (SOLR-14840) Convert Overseer Google doc to asciidoc for addition to Git repo

2020-09-21 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199500#comment-17199500 ] Cassandra Targett commented on SOLR-14840: -- Yes, I've just been busy with work and local

[GitHub] [lucene-solr] madrob commented on pull request #1638: SOLR-14066: Deprecate DIH

2020-09-21 Thread GitBox
madrob commented on pull request #1638: URL: https://github.com/apache/lucene-solr/pull/1638#issuecomment-696235285 @chatman Can we close this? It looks like DIH has already been removed in master branch. This is an

  1   2   >