[GitHub] [lucene-solr] atris commented on a change in pull request #1906: SOLR-13528: Implement API Based Config For Rate Limiters

2020-09-22 Thread GitBox
atris commented on a change in pull request #1906: URL: https://github.com/apache/lucene-solr/pull/1906#discussion_r493238083 ## File path: solr/core/src/java/org/apache/solr/servlet/RateLimiterConfig.java ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [lucene-solr] atris commented on a change in pull request #1906: SOLR-13528: Implement API Based Config For Rate Limiters

2020-09-22 Thread GitBox
atris commented on a change in pull request #1906: URL: https://github.com/apache/lucene-solr/pull/1906#discussion_r493214015 ## File path: solr/core/src/java/org/apache/solr/handler/ClusterAPI.java ## @@ -171,10 +172,30 @@ public void setPlacementPlugin(PayloadObj> obj) {

[GitHub] [lucene-solr] atris commented on a change in pull request #1906: SOLR-13528: Implement API Based Config For Rate Limiters

2020-09-22 Thread GitBox
atris commented on a change in pull request #1906: URL: https://github.com/apache/lucene-solr/pull/1906#discussion_r493207484 ## File path: solr/core/src/java/org/apache/solr/handler/ClusterAPI.java ## @@ -171,10 +172,30 @@ public void setPlacementPlugin(PayloadObj> obj) {

[GitHub] [lucene-solr] goankur commented on a change in pull request #1893: LUCENE-9444 Utility class to get facet labels from taxonomy for a fac…

2020-09-22 Thread GitBox
goankur commented on a change in pull request #1893: URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r493112985 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetLabels.java ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Sof

[GitHub] [lucene-solr] mocobeta commented on pull request #1836: LUCENE-9317: Clean up split package in analyzers-common

2020-09-22 Thread GitBox
mocobeta commented on pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-696524047 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene-solr] madrob closed pull request #1176: LUCENE-9143 Add error-prone checks to build, but disabled

2020-09-22 Thread GitBox
madrob closed pull request #1176: URL: https://github.com/apache/lucene-solr/pull/1176 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] noblepaul closed pull request #1880: SOLR-14151: Do not reload core for schema changes

2020-09-22 Thread GitBox
noblepaul closed pull request #1880: URL: https://github.com/apache/lucene-solr/pull/1880 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] madrob commented on a change in pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-09-22 Thread GitBox
madrob commented on a change in pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r492937930 ## File path: lucene/build.gradle ## @@ -15,8 +15,56 @@ * limitations under the License. */ +// Should we do this as :lucene:packaging similar to

[GitHub] [lucene-solr] sigram commented on a change in pull request #1864: SOLR-14850 ExactStatsCache NullPointerException when shards.tolerant=true

2020-09-22 Thread GitBox
sigram commented on a change in pull request #1864: URL: https://github.com/apache/lucene-solr/pull/1864#discussion_r492706938 ## File path: solr/core/src/java/org/apache/solr/search/stats/ExactStatsCache.java ## @@ -94,6 +94,12 @@ protected ShardRequest doRetrieveStatsRequest

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1877: SOLR-13181: param macro expansion could throw

2020-09-22 Thread GitBox
dsmiley commented on a change in pull request #1877: URL: https://github.com/apache/lucene-solr/pull/1877#discussion_r492990280 ## File path: solr/core/src/test/org/apache/solr/request/macro/TestMacroExpander.java ## @@ -143,15 +142,31 @@ public void testMapExprExpandOn() {

[GitHub] [lucene-solr] arafalov commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler

2020-09-22 Thread GitBox
arafalov commented on pull request #1900: URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696402318 > @arafalov > There is one already which I have modified(DistributedTermsComponentTest) - https://github.com/apache/lucene-solr/pull/1900/files#diff-9b9ccbcf271c6320902d

[GitHub] [lucene-solr] dsmiley merged pull request #1877: SOLR-13181: param macro expansion could throw

2020-09-22 Thread GitBox
dsmiley merged pull request #1877: URL: https://github.com/apache/lucene-solr/pull/1877 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1893: LUCENE-9444 Utility class to get facet labels from taxonomy for a fac…

2020-09-22 Thread GitBox
mikemccand commented on a change in pull request #1893: URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r493041886 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetLabels.java ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] noblepaul commented on pull request #1898: SOLR-14882

2020-09-22 Thread GitBox
noblepaul commented on pull request #1898: URL: https://github.com/apache/lucene-solr/pull/1898#issuecomment-696676802 can you please add a title? This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1909: LUCENE-9539: Remove caches from SortingCodecReader

2020-09-22 Thread GitBox
jimczi commented on a change in pull request #1909: URL: https://github.com/apache/lucene-solr/pull/1909#discussion_r492921270 ## File path: lucene/core/src/java/org/apache/lucene/index/SortingCodecReader.java ## @@ -41,21 +41,13 @@ * {@link Sort}. This can be used to re-sort

[GitHub] [lucene-solr] mikemccand commented on pull request #1733: LUCENE-9450 Use BinaryDocValues in the taxonomy writer

2020-09-22 Thread GitBox
mikemccand commented on pull request #1733: URL: https://github.com/apache/lucene-solr/pull/1733#issuecomment-696781342 > So I propose we get rid of the fullPathField altogether. Wow, +1, this looks like it is (pre-existingly?) double-indexed? Maybe we should do this as a separate p

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1877: SOLR-13181: param macro expansion could throw

2020-09-22 Thread GitBox
cpoerschke commented on a change in pull request #1877: URL: https://github.com/apache/lucene-solr/pull/1877#discussion_r492843243 ## File path: solr/core/src/test/org/apache/solr/request/macro/TestMacroExpander.java ## @@ -143,15 +142,31 @@ public void testMapExprExpandOn() {

[GitHub] [lucene-solr] arafalov merged pull request #1896: SOLR-14880: Support coreRootDirectory setting when create new cores from command line, in standalone mode

2020-09-22 Thread GitBox
arafalov merged pull request #1896: URL: https://github.com/apache/lucene-solr/pull/1896 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene-solr] madrob merged pull request #1910: Use github actions cache

2020-09-22 Thread GitBox
madrob merged pull request #1910: URL: https://github.com/apache/lucene-solr/pull/1910 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] dweiss commented on pull request #1908: LUCENE-9539: Use more compact datastructures for sorting doc-values

2020-09-22 Thread GitBox
dweiss commented on pull request #1908: URL: https://github.com/apache/lucene-solr/pull/1908#issuecomment-696652609 Nice. +1. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [lucene-solr] mayya-sharipova commented on pull request #1903: Fix bug in sort optimization

2020-09-22 Thread GitBox
mayya-sharipova commented on pull request #1903: URL: https://github.com/apache/lucene-solr/pull/1903#issuecomment-696373592 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene-solr] noblepaul commented on pull request #1880: SOLR-14151: Do not reload core for schema changes

2020-09-22 Thread GitBox
noblepaul commented on pull request #1880: URL: https://github.com/apache/lucene-solr/pull/1880#issuecomment-696677088 Not fixing right now This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Comment Edited] (LUCENE-9444) Need an API to easily fetch facet labels for a field in a document

2020-09-22 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200529#comment-17200529 ] Ankur edited comment on LUCENE-9444 at 9/23/20, 4:34 AM: - Thanks

[jira] [Commented] (LUCENE-9444) Need an API to easily fetch facet labels for a field in a document

2020-09-22 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200529#comment-17200529 ] Ankur commented on LUCENE-9444: --- [~mikemccand], I incorporated the code review feedback an

[GitHub] [lucene-solr] dweiss commented on pull request #1836: LUCENE-9317: Clean up split package in analyzers-common

2020-09-22 Thread GitBox
dweiss commented on pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-696537432 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [lucene-solr] dsmiley merged pull request #1838: SOLR-14768: Fix multipart POST to Solr.

2020-09-22 Thread GitBox
dsmiley merged pull request #1838: URL: https://github.com/apache/lucene-solr/pull/1838 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] arafalov commented on pull request #1863: SOLR-14701: GuessSchemaFields URP to replace AddSchemaFields URP in schemaless mode

2020-09-22 Thread GitBox
arafalov commented on pull request #1863: URL: https://github.com/apache/lucene-solr/pull/1863#issuecomment-696704951 @noblepaul Good point: 1. **bin/solr start** 2. Edit the default configset's add-schema-fields definition to - Replace AddSchema... with GuessSchema... URP

[GitHub] [lucene-solr] noblepaul commented on pull request #1863: SOLR-14701: GuessSchemaFields URP to replace AddSchemaFields URP in schemaless mode

2020-09-22 Thread GitBox
noblepaul commented on pull request #1863: URL: https://github.com/apache/lucene-solr/pull/1863#issuecomment-696679556 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1906: SOLR-13528: Implement API Based Config For Rate Limiters

2020-09-22 Thread GitBox
noblepaul commented on a change in pull request #1906: URL: https://github.com/apache/lucene-solr/pull/1906#discussion_r492668757 ## File path: solr/core/src/java/org/apache/solr/handler/ClusterAPI.java ## @@ -171,10 +172,30 @@ public void setPlacementPlugin(PayloadObj> obj) {

[GitHub] [lucene-solr] TomMD commented on a change in pull request #1901: SOLR-14883 Add a Muse (Continuous assurance platform) configuration

2020-09-22 Thread GitBox
TomMD commented on a change in pull request #1901: URL: https://github.com/apache/lucene-solr/pull/1901#discussion_r492995357 ## File path: .muse/config.toml ## @@ -0,0 +1 @@ +jdk11 = true Review comment: I've added the comment to the file as well now. -

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1861: SOLR-10391: Add overwrite option to UPLOAD ConfigSet action

2020-09-22 Thread GitBox
tflobbe commented on a change in pull request #1861: URL: https://github.com/apache/lucene-solr/pull/1861#discussion_r492423507 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ConfigSetsHandler.java ## @@ -170,21 +176,90 @@ private void handleConfigUploadRequest

[GitHub] [lucene-solr] dsmiley commented on pull request #1877: SOLR-13181: param macro expansion could throw

2020-09-22 Thread GitBox
dsmiley commented on pull request #1877: URL: https://github.com/apache/lucene-solr/pull/1877#issuecomment-696943683 @gus-asf (in reference to you're fix in SOLR-12891): I can appreciate you didn't want to break back-compat. In this issue/PR, I'm not getting at that matter at all, it's a

[GitHub] [lucene-solr] ErickErickson commented on pull request #1733: LUCENE-9450 Use BinaryDocValues in the taxonomy writer

2020-09-22 Thread GitBox
ErickErickson commented on pull request #1733: URL: https://github.com/apache/lucene-solr/pull/1733#issuecomment-696828850 > On Sep 22, 2020, at 11:04 AM, Michael McCandless wrote: > > > So I propose we get rid of the fullPathField altogether. > > Wow, +1, this lo

[GitHub] [lucene-solr] tflobbe merged pull request #1861: SOLR-10391: Add overwrite option to UPLOAD ConfigSet action

2020-09-22 Thread GitBox
tflobbe merged pull request #1861: URL: https://github.com/apache/lucene-solr/pull/1861 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1901: SOLR-14883 Add a Muse (Continuous assurance platform) configuration

2020-09-22 Thread GitBox
tflobbe commented on a change in pull request #1901: URL: https://github.com/apache/lucene-solr/pull/1901#discussion_r492911126 ## File path: .muse/config.toml ## @@ -0,0 +1 @@ +jdk11 = true Review comment: Ah, I noticed you added the comments on the commit. Thanks for

[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1863: SOLR-14701: GuessSchemaFields URP to replace AddSchemaFields URP in schemaless mode

2020-09-22 Thread GitBox
noblepaul edited a comment on pull request #1863: URL: https://github.com/apache/lucene-solr/pull/1863#issuecomment-697054163 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [lucene-solr] gus-asf commented on pull request #1877: SOLR-13181: param macro expansion could throw

2020-09-22 Thread GitBox
gus-asf commented on pull request #1877: URL: https://github.com/apache/lucene-solr/pull/1877#issuecomment-696867296 Did see your review request, but my life is doing that whole "it never rains but it pours" thing right now and I keep not getting to this. My primary concern wrt to this cla

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1908: LUCENE-9539: Use more compact datastructures for sorting doc-values

2020-09-22 Thread GitBox
dweiss commented on a change in pull request #1908: URL: https://github.com/apache/lucene-solr/pull/1908#discussion_r492648887 ## File path: lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java ## @@ -379,4 +352,31 @@ public long getValueCount() {

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1908: LUCENE-9539: Use more compact datastructures for sorting doc-values

2020-09-22 Thread GitBox
s1monw commented on a change in pull request #1908: URL: https://github.com/apache/lucene-solr/pull/1908#discussion_r492719968 ## File path: lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java ## @@ -379,4 +352,31 @@ public long getValueCount() {

[GitHub] [lucene-solr] arafalov merged pull request #1904: SOLR-14878: Expose solr.xml's coreRootDirectory property via the System Settings API (part 2)

2020-09-22 Thread GitBox
arafalov merged pull request #1904: URL: https://github.com/apache/lucene-solr/pull/1904 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene-solr] murblanc merged pull request #1902: SOLR-14840: Overseer doc in asciidoc

2020-09-22 Thread GitBox
murblanc merged pull request #1902: URL: https://github.com/apache/lucene-solr/pull/1902 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene-solr] tflobbe commented on pull request #1861: SOLR-10391: Add overwrite option to UPLOAD ConfigSet action

2020-09-22 Thread GitBox
tflobbe commented on pull request #1861: URL: https://github.com/apache/lucene-solr/pull/1861#issuecomment-696456676 I plan to merge this tomorrow This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [lucene-solr] s1monw merged pull request #1908: LUCENE-9539: Use more compact datastructures for sorting doc-values

2020-09-22 Thread GitBox
s1monw merged pull request #1908: URL: https://github.com/apache/lucene-solr/pull/1908 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] goankur commented on pull request #1733: LUCENE-9450 Use BinaryDocValues in the taxonomy writer

2020-09-22 Thread GitBox
goankur commented on pull request #1733: URL: https://github.com/apache/lucene-solr/pull/1733#issuecomment-696420384 Thanks @gautamworah96 for this impactful change and @mikemccand for reviewing it. A few thoughts 1. This change disables STORED fields part but keeps the POSTINGS

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-09-22 Thread GitBox
dweiss commented on a change in pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r492507019 ## File path: lucene/build.gradle ## @@ -15,8 +15,56 @@ * limitations under the License. */ +// Should we do this as :lucene:packaging similar to

[GitHub] [lucene-solr] mayya-sharipova edited a comment on pull request #1903: Fix bug in sort optimization

2020-09-22 Thread GitBox
mayya-sharipova edited a comment on pull request #1903: URL: https://github.com/apache/lucene-solr/pull/1903#issuecomment-696976768 @jimczi I was able to reproduce a bug, and in aaab92a added a test that reproducibly fails for me without this patch. It is a very particular combination of

[GitHub] [lucene-solr] ctargett commented on pull request #1869: SOLR-14866 autowidth tables in ref guide

2020-09-22 Thread GitBox
ctargett commented on pull request #1869: URL: https://github.com/apache/lucene-solr/pull/1869#issuecomment-696366569 I'm a little confused what's going on here at this point. It seems the latest commits increase the mixing of styles, which as I said is fine with me in general, but sort of

[GitHub] [lucene-solr] mocobeta edited a comment on pull request #1836: LUCENE-9317: Clean up split package in analyzers-common

2020-09-22 Thread GitBox
mocobeta edited a comment on pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-696590916 It should be able to create a subproject for classes I moved to core here. > this would make the core really separate from analysis. I don't fully under

[GitHub] [lucene-solr] goankur commented on a change in pull request #1893: LUCENE-9444 Utility class to get facet labels from taxonomy for a fac…

2020-09-22 Thread GitBox
goankur commented on a change in pull request #1893: URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r493148293 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetLabels.java ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Sof

[GitHub] [lucene-solr] goankur commented on a change in pull request #1893: LUCENE-9444 Utility class to get facet labels from taxonomy for a fac…

2020-09-22 Thread GitBox
goankur commented on a change in pull request #1893: URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r493137058 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyLabels.java ## @@ -0,0 +1,192 @@ +/* + * Licensed to the Apache Soft

[GitHub] [lucene-solr] goankur commented on a change in pull request #1893: LUCENE-9444 Utility class to get facet labels from taxonomy for a fac…

2020-09-22 Thread GitBox
goankur commented on a change in pull request #1893: URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r493137058 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyLabels.java ## @@ -0,0 +1,192 @@ +/* + * Licensed to the Apache Soft

[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1863: SOLR-14701: GuessSchemaFields URP to replace AddSchemaFields URP in schemaless mode

2020-09-22 Thread GitBox
noblepaul edited a comment on pull request #1863: URL: https://github.com/apache/lucene-solr/pull/1863#issuecomment-697054163 > At the point, the schema is created (based on all data) but nothing is actually indexed; the user can review and adjust the schema without any issues How do

[jira] [Commented] (SOLR-7520) Post filter DelegatingCollector.finish not called for multi-shard queries specifying grouping

2020-09-22 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200451#comment-17200451 ] Erick Erickson commented on SOLR-7520: -- These seem identical > Post filter Delegatin

[GitHub] [lucene-solr] goankur commented on a change in pull request #1893: LUCENE-9444 Utility class to get facet labels from taxonomy for a fac…

2020-09-22 Thread GitBox
goankur commented on a change in pull request #1893: URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r493117522 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetLabels.java ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Sof

[GitHub] [lucene-solr] goankur commented on a change in pull request #1893: LUCENE-9444 Utility class to get facet labels from taxonomy for a fac…

2020-09-22 Thread GitBox
goankur commented on a change in pull request #1893: URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r493114208 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetLabels.java ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Sof

[GitHub] [lucene-solr] goankur commented on a change in pull request #1893: LUCENE-9444 Utility class to get facet labels from taxonomy for a fac…

2020-09-22 Thread GitBox
goankur commented on a change in pull request #1893: URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r493114139 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetLabels.java ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Sof

[GitHub] [lucene-solr] goankur commented on a change in pull request #1893: LUCENE-9444 Utility class to get facet labels from taxonomy for a fac…

2020-09-22 Thread GitBox
goankur commented on a change in pull request #1893: URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r493113512 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetLabels.java ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Sof

[GitHub] [lucene-solr] goankur commented on a change in pull request #1893: LUCENE-9444 Utility class to get facet labels from taxonomy for a fac…

2020-09-22 Thread GitBox
goankur commented on a change in pull request #1893: URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r493112985 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetLabels.java ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Sof

[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1863: SOLR-14701: GuessSchemaFields URP to replace AddSchemaFields URP in schemaless mode

2020-09-22 Thread GitBox
noblepaul edited a comment on pull request #1863: URL: https://github.com/apache/lucene-solr/pull/1863#issuecomment-697054163 > At the point, the schema is created (based on all data) but nothing is actually indexed; the user can review and adjust the schema without any issues How do

[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1863: SOLR-14701: GuessSchemaFields URP to replace AddSchemaFields URP in schemaless mode

2020-09-22 Thread GitBox
noblepaul edited a comment on pull request #1863: URL: https://github.com/apache/lucene-solr/pull/1863#issuecomment-697054163 > At the point, the schema is created (based on all data) but nothing is actually indexed; the user can review and adjust the schema without any issues How do

[GitHub] [lucene-solr] noblepaul commented on pull request #1863: SOLR-14701: GuessSchemaFields URP to replace AddSchemaFields URP in schemaless mode

2020-09-22 Thread GitBox
noblepaul commented on pull request #1863: URL: https://github.com/apache/lucene-solr/pull/1863#issuecomment-697054163 ># 6 At the point, the schema is created (based on all data) but nothing is actually indexed; the user can review and adjust the schema without any issues How do you

[jira] [Comment Edited] (LUCENE-9540) Investigate double indexing of the fullPathField in the DirectoryTaxonomyWriter

2020-09-22 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200408#comment-17200408 ] Gautam Worah edited comment on LUCENE-9540 at 9/22/20, 10:30 PM: -

[jira] [Commented] (LUCENE-9540) Investigate double indexing of the fullPathField in the DirectoryTaxonomyWriter

2020-09-22 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200408#comment-17200408 ] Gautam Worah commented on LUCENE-9540: -- This should ideally be a simple change to u

[jira] [Resolved] (SOLR-14768) Multipart POST is broken; a regression since 8.6

2020-09-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-14768. - Fix Version/s: 8.7 Resolution: Fixed > Multipart POST is broken; a regression since 8.6 >

[jira] [Created] (LUCENE-9540) Investigate double indexing of the fullPathField in the DirectoryTaxonomyWriter

2020-09-22 Thread Gautam Worah (Jira)
Gautam Worah created LUCENE-9540: Summary: Investigate double indexing of the fullPathField in the DirectoryTaxonomyWriter Key: LUCENE-9540 URL: https://issues.apache.org/jira/browse/LUCENE-9540 Proje

[jira] [Commented] (SOLR-14768) Multipart POST is broken; a regression since 8.6

2020-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200399#comment-17200399 ] ASF subversion and git services commented on SOLR-14768: Commit 0

[jira] [Commented] (SOLR-14768) Multipart POST is broken; a regression since 8.6

2020-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200398#comment-17200398 ] ASF subversion and git services commented on SOLR-14768: Commit 7

[GitHub] [lucene-solr] dsmiley merged pull request #1838: SOLR-14768: Fix multipart POST to Solr.

2020-09-22 Thread GitBox
dsmiley merged pull request #1838: URL: https://github.com/apache/lucene-solr/pull/1838 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1893: LUCENE-9444 Utility class to get facet labels from taxonomy for a fac…

2020-09-22 Thread GitBox
mikemccand commented on a change in pull request #1893: URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r493041886 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetLabels.java ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache

[jira] [Closed] (SOLR-9827) Make ConcurrentUpdateSolrClient create RemoteSolrException instead of just SolrException for remote errors

2020-09-22 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe closed SOLR-9827. --- > Make ConcurrentUpdateSolrClient create RemoteSolrException instead of ju

[GitHub] [lucene-solr] mayya-sharipova edited a comment on pull request #1903: Fix bug in sort optimization

2020-09-22 Thread GitBox
mayya-sharipova edited a comment on pull request #1903: URL: https://github.com/apache/lucene-solr/pull/1903#issuecomment-696976768 @jimczi I was able to reproduce a bug, and in aaab92a added a test that reproducibly fails for me without this patch. It is a very particular combination of

[GitHub] [lucene-solr] mayya-sharipova commented on pull request #1903: Fix bug in sort optimization

2020-09-22 Thread GitBox
mayya-sharipova commented on pull request #1903: URL: https://github.com/apache/lucene-solr/pull/1903#issuecomment-696976768 @jimczi I was able to reproduce a bug, and in aaab92a added a test that reproducibly fails for me without this patch. It is a very particular combination of docs an

[jira] [Commented] (LUCENE-9536) Optimize OrdinalMap when one segment contains all distinct values?

2020-09-22 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200371#comment-17200371 ] Adrien Grand commented on LUCENE-9536: -- +1 > Optimize OrdinalMap when one segment

[jira] [Commented] (LUCENE-9537) Add Indri Search Engine Functionality to Lucene

2020-09-22 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200370#comment-17200370 ] Adrien Grand commented on LUCENE-9537: -- Sorry, this might be a very naive question,

[jira] [Resolved] (SOLR-10391) ConfigSet overwrite

2020-09-22 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe resolved SOLR-10391. -- Fix Version/s: 8.7 master (9.0) Assi

[jira] [Commented] (SOLR-10391) ConfigSet overwrite

2020-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200368#comment-17200368 ] ASF subversion and git services commented on SOLR-10391: Commit a

[jira] [Resolved] (SOLR-13181) NullPointerException in org.apache.solr.request.macro.MacroExpander

2020-09-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-13181. - Fix Version/s: 8.7 Resolution: Fixed > NullPointerException in org.apache.solr.request.mac

[jira] [Issue Comment Deleted] (SOLR-13181) NullPointerException in org.apache.solr.request.macro.MacroExpander

2020-09-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-13181: Comment: was deleted (was: Commit 2197776be67384d628f12a5def8663db9e4220cf in lucene-solr's branch

[jira] [Issue Comment Deleted] (SOLR-13181) NullPointerException in org.apache.solr.request.macro.MacroExpander

2020-09-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-13181: Comment: was deleted (was: Commit 2197776be67384d628f12a5def8663db9e4220cf in lucene-solr's branch

[jira] [Issue Comment Deleted] (SOLR-13181) NullPointerException in org.apache.solr.request.macro.MacroExpander

2020-09-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-13181: Comment: was deleted (was: Commit 2197776be67384d628f12a5def8663db9e4220cf in lucene-solr's branch

[jira] [Commented] (SOLR-13181) NullPointerException in org.apache.solr.request.macro.MacroExpander

2020-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200358#comment-17200358 ] ASF subversion and git services commented on SOLR-13181: Commit 0

[jira] [Commented] (SOLR-13181) NullPointerException in org.apache.solr.request.macro.MacroExpander

2020-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200349#comment-17200349 ] ASF subversion and git services commented on SOLR-13181: Commit 2

[jira] [Commented] (SOLR-13181) NullPointerException in org.apache.solr.request.macro.MacroExpander

2020-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200346#comment-17200346 ] ASF subversion and git services commented on SOLR-13181: Commit 2

[jira] [Commented] (SOLR-13181) NullPointerException in org.apache.solr.request.macro.MacroExpander

2020-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200344#comment-17200344 ] ASF subversion and git services commented on SOLR-13181: Commit 2

[GitHub] [lucene-solr] TomMD commented on a change in pull request #1901: SOLR-14883 Add a Muse (Continuous assurance platform) configuration

2020-09-22 Thread GitBox
TomMD commented on a change in pull request #1901: URL: https://github.com/apache/lucene-solr/pull/1901#discussion_r492995357 ## File path: .muse/config.toml ## @@ -0,0 +1 @@ +jdk11 = true Review comment: I've added the comment to the file as well now. -

[jira] [Commented] (SOLR-13181) NullPointerException in org.apache.solr.request.macro.MacroExpander

2020-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200342#comment-17200342 ] ASF subversion and git services commented on SOLR-13181: Commit 2

[GitHub] [lucene-solr] dsmiley commented on pull request #1877: SOLR-13181: param macro expansion could throw

2020-09-22 Thread GitBox
dsmiley commented on pull request #1877: URL: https://github.com/apache/lucene-solr/pull/1877#issuecomment-696943683 @gus-asf (in reference to you're fix in SOLR-12891): I can appreciate you didn't want to break back-compat. In this issue/PR, I'm not getting at that matter at all, it's a

[GitHub] [lucene-solr] dsmiley merged pull request #1877: SOLR-13181: param macro expansion could throw

2020-09-22 Thread GitBox
dsmiley merged pull request #1877: URL: https://github.com/apache/lucene-solr/pull/1877 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1877: SOLR-13181: param macro expansion could throw

2020-09-22 Thread GitBox
dsmiley commented on a change in pull request #1877: URL: https://github.com/apache/lucene-solr/pull/1877#discussion_r492990280 ## File path: solr/core/src/test/org/apache/solr/request/macro/TestMacroExpander.java ## @@ -143,15 +142,31 @@ public void testMapExprExpandOn() {

[jira] [Commented] (SOLR-14597) Advanced Query Parser

2020-09-22 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200304#comment-17200304 ] Gus Heck commented on SOLR-14597: - Right, agreed, Lucene stuff also should be broken out

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-09-22 Thread GitBox
dweiss commented on a change in pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r492962137 ## File path: lucene/build.gradle ## @@ -15,8 +15,56 @@ * limitations under the License. */ +// Should we do this as :lucene:packaging similar to

[GitHub] [lucene-solr] madrob commented on a change in pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-09-22 Thread GitBox
madrob commented on a change in pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r492937930 ## File path: lucene/build.gradle ## @@ -15,8 +15,56 @@ * limitations under the License. */ +// Should we do this as :lucene:packaging similar to

[GitHub] [lucene-solr] madrob merged pull request #1910: Use github actions cache

2020-09-22 Thread GitBox
madrob merged pull request #1910: URL: https://github.com/apache/lucene-solr/pull/1910 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (SOLR-9827) Make ConcurrentUpdateSolrClient create RemoteSolrException instead of just SolrException for remote errors

2020-09-22 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe resolved SOLR-9827. - Fix Version/s: 6.4 7.0 Resolution: Fixed

[jira] [Resolved] (SOLR-14582) Expose IWC.setMaxCommitMergeWaitMillis as an expert feature in Solr's index config

2020-09-22 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe resolved SOLR-14582. -- Resolution: Fixed > Expose IWC.setMaxCommitMergeWaitMillis as a

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1909: LUCENE-9539: Remove caches from SortingCodecReader

2020-09-22 Thread GitBox
jimczi commented on a change in pull request #1909: URL: https://github.com/apache/lucene-solr/pull/1909#discussion_r492921270 ## File path: lucene/core/src/java/org/apache/lucene/index/SortingCodecReader.java ## @@ -41,21 +41,13 @@ * {@link Sort}. This can be used to re-sort

[jira] [Commented] (SOLR-10391) ConfigSet overwrite

2020-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200261#comment-17200261 ] ASF subversion and git services commented on SOLR-10391: Commit 7

[GitHub] [lucene-solr] tflobbe merged pull request #1861: SOLR-10391: Add overwrite option to UPLOAD ConfigSet action

2020-09-22 Thread GitBox
tflobbe merged pull request #1861: URL: https://github.com/apache/lucene-solr/pull/1861 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-14889) improve templated variable escaping in ref-guide _config.yml

2020-09-22 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200259#comment-17200259 ] Uwe Schindler commented on SOLR-14889: -- +1 That's a good plan. > improve templated

[GitHub] [lucene-solr] gus-asf commented on pull request #1877: SOLR-13181: param macro expansion could throw

2020-09-22 Thread GitBox
gus-asf commented on pull request #1877: URL: https://github.com/apache/lucene-solr/pull/1877#issuecomment-696867296 Did see your review request, but my life is doing that whole "it never rains but it pours" thing right now and I keep not getting to this. My primary concern wrt to this cla

  1   2   >