[
https://issues.apache.org/jira/browse/LUCENE-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201924#comment-17201924
]
Adrien Grand commented on LUCENE-9535:
--
Indexing throughput looks like it's back to where it was
noblepaul commented on pull request #1863:
URL: https://github.com/apache/lucene-solr/pull/1863#issuecomment-698728576
I recommend a new request handler such as `/update/guess-schema`
This way we do not need to add any new functionality, nor do we need to pass
any extra params
[
https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201915#comment-17201915
]
Noble Paul commented on SOLR-14613:
---
The 2nd parameter is a varargs parameter. so, you can set a
[
https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201841#comment-17201841
]
Alexandre Rafalovitch commented on SOLR-14829:
--
Ok, the [Reference Guide
goankur commented on a change in pull request #1893:
URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r494675000
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetLabels.java
##
@@ -0,0 +1,184 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Rafalovitch updated SOLR-14829:
-
Summary: Update default components information in Reference Guide and
[
https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201815#comment-17201815
]
Alexandre Rafalovitch commented on SOLR-14829:
--
The patch no longer applies clean because
goankur commented on a change in pull request #1893:
URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r494665188
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyFacetCounts.java
##
@@ -726,6 +743,39 @@ public void testRandom()
[
https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Rafalovitch reassigned SOLR-14829:
Assignee: Alexandre Rafalovitch (was: Ishan Chattopadhyaya)
> Default
goankur commented on a change in pull request #1893:
URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r494655549
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyFacetCounts.java
##
@@ -726,6 +743,39 @@ public void testRandom()
goankur commented on a change in pull request #1893:
URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r494654559
##
File path: lucene/facet/src/test/org/apache/lucene/facet/FacetTestCase.java
##
@@ -56,6 +60,28 @@ public Facets
[
https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201802#comment-17201802
]
Uwe Schindler commented on SOLR-14889:
--
bq. can we make `templateProps` final now? ... i didn't
goankur commented on a change in pull request #1893:
URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r494637269
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyFacetCounts.java
##
@@ -711,6 +723,11 @@ public void testRandom()
dweiss commented on pull request #1919:
URL: https://github.com/apache/lucene-solr/pull/1919#issuecomment-698564766
I like the explicit field too, actually - even if you're right about
capacity of internal blocks, Adrien. - this assertion there may actually be my
mistake and the capacity
[
https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201749#comment-17201749
]
Dawid Weiss commented on SOLR-14889:
bq. references to the variables/input used that code, so that
[
https://issues.apache.org/jira/browse/SOLR-14843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201732#comment-17201732
]
Ilan Ginzburg commented on SOLR-14843:
--
I think we need to think the hierarchy carefully... Node
[
https://issues.apache.org/jira/browse/SOLR-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Munendra S N updated SOLR-14503:
Fix Version/s: 8.7
Resolution: Fixed
Status: Resolved (was: Patch Available)
[
https://issues.apache.org/jira/browse/SOLR-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201692#comment-17201692
]
ASF subversion and git services commented on SOLR-14503:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201683#comment-17201683
]
Munendra S N commented on SOLR-14503:
-
Beasted the test before committing, will shortly backport to
[
https://issues.apache.org/jira/browse/SOLR-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201682#comment-17201682
]
ASF subversion and git services commented on SOLR-14503:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201668#comment-17201668
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14843:
--
I don’t know what Andrzej
[
https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201659#comment-17201659
]
Chris M. Hostetter commented on SOLR-14889:
---
thanks guys ... this is very enlightening.
[
https://issues.apache.org/jira/browse/SOLR-14036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Munendra S N updated SOLR-14036:
Fix Version/s: master (9.0)
Resolution: Fixed (was: Invalid)
Status: Resolved
[
https://issues.apache.org/jira/browse/SOLR-14036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201648#comment-17201648
]
ASF subversion and git services commented on SOLR-14036:
Commit
munendrasn merged pull request #1900:
URL: https://github.com/apache/lucene-solr/pull/1900
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
tflobbe commented on pull request #1920:
URL: https://github.com/apache/lucene-solr/pull/1920#issuecomment-698457823
ugh, looks like I forgot to backport the CHANGES entry in my change. Thanks
Christine.
This is an
[
https://issues.apache.org/jira/browse/SOLR-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke resolved SOLR-11167.
Resolution: Fixed
> bin/solr uses $SOLR_STOP_WAIT during start
>
[
https://issues.apache.org/jira/browse/SOLR-14828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke resolved SOLR-14828.
Fix Version/s: 8.7
master (9.0)
Resolution: Fixed
>
cpoerschke opened a new pull request #1920:
URL: https://github.com/apache/lucene-solr/pull/1920
Encountered a cherry-pick merge conflict and it seems that these two entries
are present in the master branch's solr/CHANGES.txt 8.7 section but
(unintentionally?) missing in the branch_8x
munendrasn commented on pull request #1371:
URL: https://github.com/apache/lucene-solr/pull/1371#issuecomment-698447210
Fixed the failing tests and updated changes to include deprecation
This is an automated message from the
[
https://issues.apache.org/jira/browse/SOLR-14828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201621#comment-17201621
]
ASF subversion and git services commented on SOLR-14828:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201622#comment-17201622
]
ASF subversion and git services commented on SOLR-11167:
Commit
munendrasn merged pull request #1914:
URL: https://github.com/apache/lucene-solr/pull/1914
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/SOLR-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201615#comment-17201615
]
ASF subversion and git services commented on SOLR-11167:
Commit
cpoerschke merged pull request #1913:
URL: https://github.com/apache/lucene-solr/pull/1913
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/SOLR-14828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201612#comment-17201612
]
ASF subversion and git services commented on SOLR-14828:
Commit
cpoerschke merged pull request #1825:
URL: https://github.com/apache/lucene-solr/pull/1825
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
cpoerschke commented on pull request #1890:
URL: https://github.com/apache/lucene-solr/pull/1890#issuecomment-698439045
> ... if you could give me a couple days ... #1892
Sure, no problem at all.
Now that `TestConfigSetsAPI` extends `SolrCloudTestCase` too, I wonder
* if
mikemccand commented on a change in pull request #1893:
URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r494398560
##
File path: lucene/facet/src/test/org/apache/lucene/facet/FacetTestCase.java
##
@@ -56,6 +60,28 @@ public Facets
uschindler commented on pull request #1919:
URL: https://github.com/apache/lucene-solr/pull/1919#issuecomment-698416370
I like this approach more to just sum up the size when new blocks are
allocated and added to Deque.
+1
dweiss commented on pull request #1919:
URL: https://github.com/apache/lucene-solr/pull/1919#issuecomment-698412271
I will take another look. I can't remember forcing block capacity but it's
been a while!
This is an
mikemccand commented on a change in pull request #1893:
URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r494395610
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetLabels.java
##
@@ -0,0 +1,184 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/SOLR-14888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201574#comment-17201574
]
Erick Erickson commented on SOLR-14888:
---
One other thing that'd be good to do at the same time. If
jpountz commented on pull request #1919:
URL: https://github.com/apache/lucene-solr/pull/1919#issuecomment-698392573
@dweiss FYI I could not find a way to have blocks of different capacities as
we have an assertion that the allocator creates blocks of the expected
capacity, not larger.
jpountz opened a new pull request #1919:
URL: https://github.com/apache/lucene-solr/pull/1919
This helps remove the assumption that all blocks have the same size.
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/SOLR-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201565#comment-17201565
]
David Eric Pugh commented on SOLR-14549:
Happy to QA your changes [~krisden], it definitely
dweiss commented on a change in pull request #1917:
URL: https://github.com/apache/lucene-solr/pull/1917#discussion_r494352956
##
File path:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java
##
@@ -400,8 +400,13 @@ public void writeSetOfStrings(Set set)
[
https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated SOLR-14889:
---
Attachment: SOLR-14889.patch
> improve templated variable escaping in ref-guide _config.yml
>
[
https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201550#comment-17201550
]
Dawid Weiss commented on SOLR-14889:
Yep, Uwe's version looks good to me. Added a few additional
[
https://issues.apache.org/jira/browse/SOLR-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201535#comment-17201535
]
Bernd Wahlen commented on SOLR-14891:
-
thanks => close/duplicate
> Upgrade Jetty to 9.4.28+ to fix
[
https://issues.apache.org/jira/browse/SOLR-14835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201533#comment-17201533
]
Bernd Wahlen commented on SOLR-14835:
-
Solr currently using Jetty 9.4.27 which displays strange
[
https://issues.apache.org/jira/browse/SOLR-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bernd Wahlen resolved SOLR-14891.
-
Resolution: Duplicate
> Upgrade Jetty to 9.4.28+ to fix Startup Warning
>
[
https://issues.apache.org/jira/browse/SOLR-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201531#comment-17201531
]
Cassandra Targett commented on SOLR-14891:
--
I think this is a duplicate of SOLR-14835.
>
jpountz commented on a change in pull request #1917:
URL: https://github.com/apache/lucene-solr/pull/1917#discussion_r494317441
##
File path:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java
##
@@ -400,8 +400,13 @@ public void writeSetOfStrings(Set set)
jpountz commented on a change in pull request #1917:
URL: https://github.com/apache/lucene-solr/pull/1917#discussion_r494317183
##
File path:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java
##
@@ -400,8 +400,13 @@ public void writeSetOfStrings(Set set)
dweiss commented on a change in pull request #1917:
URL: https://github.com/apache/lucene-solr/pull/1917#discussion_r494314029
##
File path:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java
##
@@ -400,8 +400,13 @@ public void writeSetOfStrings(Set set)
dweiss commented on a change in pull request #1917:
URL: https://github.com/apache/lucene-solr/pull/1917#discussion_r494311008
##
File path:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java
##
@@ -400,8 +400,13 @@ public void writeSetOfStrings(Set set)
mikemccand commented on pull request #1912:
URL: https://github.com/apache/lucene-solr/pull/1912#issuecomment-698332632
Oh my!
We are talking about assigning DWPT to incoming indexing thread, right?
(And not which DWPT to pick for flushing because RAM buffer is full, which I
think
mocobeta commented on pull request #1836:
URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-698267536
> If you have any questions, please ask me on slack, there I can respond
faster.
We already have Jira and Github, I'd rather not disperse discussions onto
multiple
mocobeta edited a comment on pull request #1836:
URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-698267536
> If you have any questions, please ask me on slack, there I can respond
faster.
We already have Jira and Github, I'd rather not disperse discussions onto
[
https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201437#comment-17201437
]
Cao Manh Dat commented on SOLR-14354:
-
[~ichattopadhyaya] sorry but I gave solr-bench a shot and it
[
https://issues.apache.org/jira/browse/SOLR-14843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201427#comment-17201427
]
Ilan Ginzburg commented on SOLR-14843:
--
Would an initial step in this Jira be the ability to define
[
https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201378#comment-17201378
]
Ilan Ginzburg commented on SOLR-14613:
--
[~noble.paul] could we change {{setClusterProperty(String
[
https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201372#comment-17201372
]
Dawid Weiss commented on SOLR-14889:
I glanced at it and I think it's good, will verify in the
[
https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201368#comment-17201368
]
Uwe Schindler edited comment on SOLR-14889 at 9/24/20, 8:43 AM:
Hi
[
https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201368#comment-17201368
]
Uwe Schindler commented on SOLR-14889:
--
Hi [~dweiss], hi [~hossman],
I updated the patch, here's my
sigram commented on pull request #1758:
URL: https://github.com/apache/lucene-solr/pull/1758#issuecomment-698204377
> an example of how you register some type of plugin
Still open for suggestions. IMHO `ClusterEventListener`-s make sense only if
they are also `ClusterSingleton`-s.
[
https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-14889:
-
Attachment: SOLR-14889.patch
> improve templated variable escaping in ref-guide _config.yml
>
sigram commented on a change in pull request #1758:
URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r494134314
##
File path:
solr/core/src/java/org/apache/solr/handler/admin/ContainerPluginsApi.java
##
@@ -64,15 +64,15 @@ public
sigram commented on a change in pull request #1758:
URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r494131970
##
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##
@@ -889,7 +896,37 @@ public void load() {
ContainerPluginsApi
[
https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201364#comment-17201364
]
Dawid Weiss commented on SOLR-14889:
Darn, I didn't even look at your patch, Uwe - assumed you've
[
https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201360#comment-17201360
]
Uwe Schindler commented on SOLR-14889:
--
Hi [~dweiss]: Do you think my patch is fine. It works for
dweiss commented on pull request #1836:
URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-698189266
If there are test infrastructure that needs to be shared then I'd suggest
creating a project that is a test-configuration dependency from other
subprojects (rather than
[
https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201355#comment-17201355
]
Dawid Weiss commented on SOLR-14889:
Hi Chris. Uwe explained the particular problem, I wanted to
dweiss commented on a change in pull request #1905:
URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r494116068
##
File path: lucene/build.gradle
##
@@ -15,8 +15,56 @@
* limitations under the License.
*/
+// Should we do this as :lucene:packaging similar
noblepaul commented on a change in pull request #1906:
URL: https://github.com/apache/lucene-solr/pull/1906#discussion_r494114574
##
File path: solr/core/src/java/org/apache/solr/handler/ClusterAPI.java
##
@@ -206,7 +209,7 @@ public void setObjProperty(PayloadObj obj)
{
s1monw merged pull request #1918:
URL: https://github.com/apache/lucene-solr/pull/1918
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201335#comment-17201335
]
ASF subversion and git services commented on LUCENE-9535:
-
Commit
[
https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201326#comment-17201326
]
ASF subversion and git services commented on SOLR-14613:
Commit
s1monw commented on pull request #1918:
URL: https://github.com/apache/lucene-solr/pull/1918#issuecomment-698163487
@jpountz I had to change some stuff to make it work. Down the road I want to
clean this up more so we don't need the extra step but I want to do this after
we cut 8.7
[
https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201315#comment-17201315
]
Noble Paul commented on SOLR-14613:
---
[~ilan] you are doing multiple ZK write operations in
[
https://issues.apache.org/jira/browse/LUCENE-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krishan updated LUCENE-9542:
Description:
Score returned in search request is original score and not reranked score post
the changes
[
https://issues.apache.org/jira/browse/LUCENE-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krishan updated LUCENE-9542:
Description:
Score returned in search request is original score and not reranked score post
the changes
Krishan created LUCENE-9542:
---
Summary: Score returned in search request is original score and
not reranked score
Key: LUCENE-9542
URL: https://issues.apache.org/jira/browse/LUCENE-9542
Project: Lucene -
s1monw commented on pull request #1912:
URL: https://github.com/apache/lucene-solr/pull/1912#issuecomment-698140734
I think we came from this years ago and them moved to the last recently
used. I am trying to remember if it was easier to implement since we also fixed
that we always hit
noblepaul commented on a change in pull request #1906:
URL: https://github.com/apache/lucene-solr/pull/1906#discussion_r494062845
##
File path: solr/core/src/java/org/apache/solr/servlet/RateLimiterConfig.java
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201299#comment-17201299
]
Noble Paul commented on SOLR-14749:
---
The PR is too complex.
I would like to see a separate PR for
87 matches
Mail list logo
