[GitHub] [lucene-solr] zhzhdoai opened a new pull request #1990: Branch 8x SSRF

2020-10-15 Thread GitBox
zhzhdoai opened a new pull request #1990: URL: https://github.com/apache/lucene-solr/pull/1990 **solr-8.6.3 SSRF** # 0x01 URL: http://localhost:8983/solr/admin/autoscaling POST: ``` {'set-listener': {'afterAction': ['execute_plan'], 'class':

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1964: SOLR-14749: Cluster singleton part of PR-1785

2020-10-15 Thread GitBox
noblepaul commented on a change in pull request #1964: URL: https://github.com/apache/lucene-solr/pull/1964#discussion_r505123274 ## File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java ## @@ -168,6 +172,33 @@ public CoreLoadFailure(CoreDescriptor cd,

[jira] [Commented] (SOLR-14930) remove rulebased replica placement strategy

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215145#comment-17215145 ] ASF subversion and git services commented on SOLR-14930: Commit

[jira] [Commented] (SOLR-14930) remove rulebased replica placement strategy

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215146#comment-17215146 ] ASF subversion and git services commented on SOLR-14930: Commit

[GitHub] [lucene-solr] noblepaul merged pull request #1984: SOLR-14930: Deprecate rulebased replica placement strategy(in 8.x)

2020-10-15 Thread GitBox
noblepaul merged pull request #1984: URL: https://github.com/apache/lucene-solr/pull/1984 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #1978: LUCENE-9524: Fix NPE in SpanWeight#explain when no scoring is require…

2020-10-15 Thread GitBox
zacharymorn commented on a change in pull request #1978: URL: https://github.com/apache/lucene-solr/pull/1978#discussion_r505987825 ## File path: lucene/memory/src/test/org/apache/lucene/index/memory/TestMemoryIndex.java ## @@ -618,4 +622,21 @@ public void testToStringDebug()

[jira] [Commented] (LUCENE-9572) Allow TypeAsSynonymFilter to propagate selected flags and Ignore some types

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215114#comment-17215114 ] ASF subversion and git services commented on LUCENE-9572: - Commit

[GitHub] [lucene-solr] gus-asf merged pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-15 Thread GitBox
gus-asf merged pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (SOLR-14930) remove rulebased replica placement strategy

2020-10-15 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215077#comment-17215077 ] Noble Paul commented on SOLR-14930: --- {quote}Should package org.apache.solr.common.cloud.rule be renamed

[jira] [Commented] (SOLR-14907) Support single file upload/overwrite in configSet API

2020-10-15 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215064#comment-17215064 ] Noble Paul commented on SOLR-14907: --- {quote}I'm not sure we should make it V2 only.{quote} +1. it just

[jira] [Commented] (SOLR-14066) Deprecate DIH and migrate to a community supported package

2020-10-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215044#comment-17215044 ] David Smiley commented on SOLR-14066: - I'd like to swap the @Deprecated Java annotations for a

[jira] [Commented] (SOLR-14915) Prometheus-exporter should not depend on Solr-core

2020-10-15 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215039#comment-17215039 ] Houston Putman commented on SOLR-14915: --- I think it makes sense to remain as a contrib module, so

[GitHub] [lucene-solr] gus-asf edited a comment on pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-15 Thread GitBox
gus-asf edited a comment on pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#issuecomment-709602579 I don't disagree exactly, just seemed like that was where the doc was. Separately it might be good to have a policy that the doc is either on the factory or the

[GitHub] [lucene-solr] gus-asf commented on pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-15 Thread GitBox
gus-asf commented on pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#issuecomment-709602579 I don't disagree exactly, just seemed like that was where the doc was. Separately it might be good to have a policy that the doc is either on the factory or the filter and

[GitHub] [lucene-solr] jtibshirani edited a comment on pull request #1948: LUCENE-9536: Optimize OrdinalMap when one segment contains all distinct values.

2020-10-15 Thread GitBox
jtibshirani edited a comment on pull request #1948: URL: https://github.com/apache/lucene-solr/pull/1948#issuecomment-709601717 > Do you know if we already have tests that exercise this optimization? I think several randomized tests will hit it, for example

[GitHub] [lucene-solr] jtibshirani commented on pull request #1948: LUCENE-9536: Optimize OrdinalMap when one segment contains all distinct values.

2020-10-15 Thread GitBox
jtibshirani commented on pull request #1948: URL: https://github.com/apache/lucene-solr/pull/1948#issuecomment-709601717 > Do you know if we already have tests that exercise this optimization? I think several randomized tests will hit it, for example I noticed

[GitHub] [lucene-solr] jtibshirani commented on a change in pull request #1948: LUCENE-9536: Optimize OrdinalMap when one segment contains all distinct values.

2020-10-15 Thread GitBox
jtibshirani commented on a change in pull request #1948: URL: https://github.com/apache/lucene-solr/pull/1948#discussion_r505869567 ## File path: lucene/core/src/java/org/apache/lucene/index/OrdinalMap.java ## @@ -359,10 +375,9 @@ public long ramBytesUsed() { @Override

[GitHub] [lucene-solr] sarowe commented on pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-15 Thread GitBox
sarowe commented on pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#issuecomment-709598453 > Oh I added it to the Factory class which already has a solr xml example

[GitHub] [lucene-solr] gus-asf commented on pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-15 Thread GitBox
gus-asf commented on pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#issuecomment-709595073 Oh I added it to the Factory class which already has a solr xml example

[GitHub] [lucene-solr] sarowe commented on pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-15 Thread GitBox
sarowe commented on pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#issuecomment-709591352 > @sarowe I think I've addressed your concerns LMK if you have further thoughts Yes you have, with one exception: I left a comment that AFAICT you haven't addressed:

[GitHub] [lucene-solr] gus-asf commented on pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-15 Thread GitBox
gus-asf commented on pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#issuecomment-709582431 @sarowe I think I've addressed your concerns LMK if you have further thoughts This is an automated message

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1948: LUCENE-9536: Optimize OrdinalMap when one segment contains all distinct values.

2020-10-15 Thread GitBox
jpountz commented on a change in pull request #1948: URL: https://github.com/apache/lucene-solr/pull/1948#discussion_r505828399 ## File path: lucene/core/src/java/org/apache/lucene/index/OrdinalMap.java ## @@ -271,13 +273,26 @@ protected boolean lessThan(TermsEnumIndex a,

[GitHub] [lucene-solr] risdenk commented on pull request #1989: SOLR-14549 - Fix listing of Files in a Directory on Solr Admin UI

2020-10-15 Thread GitBox
risdenk commented on pull request #1989: URL: https://github.com/apache/lucene-solr/pull/1989#issuecomment-709572192 @epugh @janhoy would appreciate a sanity check of this. Thanks! This is an automated message from the

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1976: LUCENE-9578: TermRangeQuery empty string lower bound edge case

2020-10-15 Thread GitBox
jpountz commented on a change in pull request #1976: URL: https://github.com/apache/lucene-solr/pull/1976#discussion_r505814863 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/Automata.java ## @@ -85,7 +85,22 @@ public static Automaton makeAnyBinary() {

[jira] [Commented] (SOLR-14549) Listing of Files in a Directory on Solr Admin is Broken

2020-10-15 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214987#comment-17214987 ] Kevin Risden commented on SOLR-14549: - PR https://github.com/apache/lucene-solr/pull/1989 > Listing

[jira] [Commented] (LUCENE-9576) nuke SSD detection: was IndexWriter::commit() hangs when the server has a stale NFS mount.

2020-10-15 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214986#comment-17214986 ] Robert Muir commented on LUCENE-9576: - sure. but if i index to /data on local storage, why should

[jira] [Updated] (SOLR-14549) Listing of Files in a Directory on Solr Admin is Broken

2020-10-15 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-14549: Status: Patch Available (was: Open) > Listing of Files in a Directory on Solr Admin is Broken >

[jira] [Updated] (SOLR-14549) Listing of Files in a Directory on Solr Admin is Broken

2020-10-15 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-14549: Affects Version/s: 8.6 8.6.1 8.6.2

[GitHub] [lucene-solr] risdenk opened a new pull request #1989: SOLR-14549 - Fix listing of Files in a Directory on Solr Admin UI

2020-10-15 Thread GitBox
risdenk opened a new pull request #1989: URL: https://github.com/apache/lucene-solr/pull/1989 # Description This fixes the listing of Files in a directory in the Solr Admin UI # Solution * Ensure that jstree can update data behind the scenes * Fix file jstree object

[jira] [Resolved] (SOLR-14938) Solr 8.6.3

2020-10-15 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anshum Gupta resolved SOLR-14938. - Resolution: Invalid [~krisgurusamy] - Please ask questions regarding usage on the Solr user

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1948: LUCENE-9536: Optimize OrdinalMap when one segment contains all distinct values.

2020-10-15 Thread GitBox
mikemccand commented on a change in pull request #1948: URL: https://github.com/apache/lucene-solr/pull/1948#discussion_r505800348 ## File path: lucene/core/src/java/org/apache/lucene/index/OrdinalMap.java ## @@ -271,13 +273,26 @@ protected boolean lessThan(TermsEnumIndex a,

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1948: LUCENE-9536: Optimize OrdinalMap when one segment contains all distinct values.

2020-10-15 Thread GitBox
mikemccand commented on a change in pull request #1948: URL: https://github.com/apache/lucene-solr/pull/1948#discussion_r505798431 ## File path: lucene/core/src/java/org/apache/lucene/index/OrdinalMap.java ## @@ -271,13 +273,26 @@ protected boolean lessThan(TermsEnumIndex a,

[jira] [Commented] (LUCENE-9576) nuke SSD detection: was IndexWriter::commit() hangs when the server has a stale NFS mount.

2020-10-15 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214958#comment-17214958 ] Michael McCandless commented on LUCENE-9576: But note that a stale NFS mount might still

[jira] [Commented] (LUCENE-9576) nuke SSD detection: was IndexWriter::commit() hangs when the server has a stale NFS mount.

2020-10-15 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214956#comment-17214956 ] Michael McCandless commented on LUCENE-9576: Yeah +1 to default to assuming we are writing

[jira] [Commented] (SOLR-14651) Metrics history could disable itself better

2020-10-15 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214949#comment-17214949 ] David Smiley commented on SOLR-14651: - I'm looking back at this.  When enable="false", it's

[GitHub] [lucene-solr] epugh commented on pull request #1985: SOLR-14932: Broken "Add replica" button in solr admin UI

2020-10-15 Thread GitBox
epugh commented on pull request #1985: URL: https://github.com/apache/lucene-solr/pull/1985#issuecomment-709544426 closing since these improvements were merged in #1988.Thank you @poke19962008 for the fix, and let me know if I need to do something to make sure you get your

[GitHub] [lucene-solr] epugh closed pull request #1985: SOLR-14932: Broken "Add replica" button in solr admin UI

2020-10-15 Thread GitBox
epugh closed pull request #1985: URL: https://github.com/apache/lucene-solr/pull/1985 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] gus-asf commented on pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-15 Thread GitBox
gus-asf commented on pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#issuecomment-709522905 Oh darn, out thought myself looking at the diff where I added a setFlags forgot that the stored state is copying flags already never-mind.

[jira] [Resolved] (SOLR-14483) AdminUI - Create replica - empty drop-down

2020-10-15 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh resolved SOLR-14483. Fix Version/s: 8.7 Resolution: Fixed > AdminUI - Create replica - empty drop-down >

[jira] [Commented] (SOLR-14483) AdminUI - Create replica - empty drop-down

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214915#comment-17214915 ] ASF subversion and git services commented on SOLR-14483: Commit

[GitHub] [lucene-solr] epugh merged pull request #1988: SOLR-14483

2020-10-15 Thread GitBox
epugh merged pull request #1988: URL: https://github.com/apache/lucene-solr/pull/1988 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-14483) AdminUI - Create replica - empty drop-down

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214914#comment-17214914 ] ASF subversion and git services commented on SOLR-14483: Commit

[jira] [Commented] (SOLR-14924) Some ReplicationHandler metrics are reported using incorrect types

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214901#comment-17214901 ] ASF subversion and git services commented on SOLR-14924: Commit

[jira] [Commented] (SOLR-14930) remove rulebased replica placement strategy

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214900#comment-17214900 ] ASF subversion and git services commented on SOLR-14930: Commit

[jira] [Commented] (SOLR-14869) [child] transformer includes deleted documents

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214894#comment-17214894 ] ASF subversion and git services commented on SOLR-14869: Commit

[jira] [Commented] (SOLR-14914) Add option to disable metrics collection

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214899#comment-17214899 ] ASF subversion and git services commented on SOLR-14914: Commit

[jira] [Commented] (LUCENE-9579) Update JUnit to latest 4.x release

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214897#comment-17214897 ] ASF subversion and git services commented on LUCENE-9579: - Commit

[jira] [Commented] (LUCENE-9574) Add a token filter to drop tokens based on flags.

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214896#comment-17214896 ] ASF subversion and git services commented on LUCENE-9574: - Commit

[jira] [Commented] (SOLR-14930) remove rulebased replica placement strategy

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214902#comment-17214902 ] ASF subversion and git services commented on SOLR-14930: Commit

[GitHub] [lucene-solr] gus-asf commented on pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-15 Thread GitBox
gus-asf commented on pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#issuecomment-709500927 In re-reading things, I think it just dawned on me that I'm not quite maintaining back compatibility after all. Previously no flags at all were transferred, yet my ~0

[GitHub] [lucene-solr] epugh opened a new pull request #1988: SOLR-14483

2020-10-15 Thread GitBox
epugh opened a new pull request #1988: URL: https://github.com/apache/lucene-solr/pull/1988 # Description This builds on the work started in PR #1985 # Solution Update to the CSS and JS to fix functionality. # Tests Manually tested. #

[jira] [Commented] (SOLR-14575) Solr restore is failing when basic authentication is enabled

2020-10-15 Thread Yaswanth (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214889#comment-17214889 ] Yaswanth commented on SOLR-14575: - [~janhoy] any help about the above would be greatly appreciated.  >

[jira] [Comment Edited] (SOLR-14936) Grafana dashboard filters for collection, shard, replica, core not working

2020-10-15 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214767#comment-17214767 ] Jan Høydahl edited comment on SOLR-14936 at 10/15/20, 5:43 PM: --- PR: [GitHub

[jira] [Updated] (SOLR-14936) Grafana dashboard filters for collection, shard, replica, core not working

2020-10-15 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-14936: --- Description: !image-2020-10-15-15-33-22-332.png!

[GitHub] [lucene-solr] gus-asf commented on a change in pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-15 Thread GitBox
gus-asf commented on a change in pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#discussion_r505704432 ## File path: lucene/test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamTestCase.java ## @@ -390,19 +406,19 @@ public static void

[GitHub] [lucene-solr] gus-asf commented on a change in pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-15 Thread GitBox
gus-asf commented on a change in pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#discussion_r505703635 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/TypeAsSynonymFilterFactory.java ## @@ -46,10 +49,17 @@

[GitHub] [lucene-solr] sarowe commented on a change in pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-15 Thread GitBox
sarowe commented on a change in pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#discussion_r505683835 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/TypeAsSynonymFilterFactory.java ## @@ -18,12 +18,15 @@

[GitHub] [lucene-solr] sarowe commented on a change in pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-15 Thread GitBox
sarowe commented on a change in pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#discussion_r505682461 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/TypeAsSynonymFilter.java ## @@ -34,23 +36,39 @@ private

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1870: SOLR-14865: 'Index Merge Metrics' documentation correction

2020-10-15 Thread GitBox
cpoerschke commented on a change in pull request #1870: URL: https://github.com/apache/lucene-solr/pull/1870#discussion_r505680828 ## File path: solr/solr-ref-guide/src/metrics-reporting.adoc ## @@ -534,15 +534,34 @@ These metrics are available only on a per-core basis.

[GitHub] [lucene-solr] cpoerschke opened a new pull request #1987: SOLR-14937: Correct client.queryDefaults().set(...) calls in some JSON facet tests.

2020-10-15 Thread GitBox
cpoerschke opened a new pull request #1987: URL: https://github.com/apache/lucene-solr/pull/1987 https://issues.apache.org/jira/browse/SOLR-14937 This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (SOLR-14937) client.queryDefaults().set(...) misunderstanding in JSON facet tests

2020-10-15 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-14937: --- Summary: client.queryDefaults().set(...) misunderstanding in JSON facet tests (was:

[jira] [Created] (SOLR-14937) lient.queryDefaults().set(...) misunderstanding in JSON facet tests

2020-10-15 Thread Christine Poerschke (Jira)
Christine Poerschke created SOLR-14937: -- Summary: lient.queryDefaults().set(...) misunderstanding in JSON facet tests Key: SOLR-14937 URL: https://issues.apache.org/jira/browse/SOLR-14937

[jira] [Commented] (SOLR-14647) Importing Gradle Projects into Eclipse pollutes checkout

2020-10-15 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214802#comment-17214802 ] Robert Muir commented on SOLR-14647: I think i figured out where it comes from at least when it

[jira] [Commented] (SOLR-14907) Support single file upload/overwrite in configSet API

2020-10-15 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214775#comment-17214775 ] Houston Putman commented on SOLR-14907: --- +1 on supporting the V2 API, but since it fits fairly well

[GitHub] [lucene-solr] gus-asf commented on pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-15 Thread GitBox
gus-asf commented on pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#issuecomment-709404255 Well that was misleading. Rat is happy locally, not sure why github was blaming RulesTest's rat analysis. I did find a couple of unused imports, and realized that

[jira] [Commented] (SOLR-14936) Grafana dashboard filters for collection, shard, replica, core not working

2020-10-15 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214771#comment-17214771 ] Jan Høydahl commented on SOLR-14936: If you want to test it in 60 seconds, here is the Grafana.com

[jira] [Commented] (SOLR-14936) Grafana dashboard filters for collection, shard, replica, core not working

2020-10-15 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214767#comment-17214767 ] Jan Høydahl commented on SOLR-14936: Fixes to the Grafana JSON only. Now the dropdowns actually

[GitHub] [lucene-solr] janhoy opened a new pull request #1986: SOLR-14936: Fixed Grafana dashboard filters

2020-10-15 Thread GitBox
janhoy opened a new pull request #1986: URL: https://github.com/apache/lucene-solr/pull/1986 See https://issues.apache.org/jira/browse/SOLR-14936 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] janhoy commented on pull request #1949: Jinja2_autoescape_false set to True

2020-10-15 Thread GitBox
janhoy commented on pull request #1949: URL: https://github.com/apache/lucene-solr/pull/1949#issuecomment-709381693 Ah, cool. I thought it must have been some automated check :) Really appreciate that you take time to contribute. Have you tested your change, that it actually works?

[jira] [Commented] (SOLR-14930) remove rulebased replica placement strategy

2020-10-15 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214748#comment-17214748 ] Ilan Ginzburg commented on SOLR-14930: -- Should package {{org.apache.solr.common.cloud.rule}} be

[GitHub] [lucene-solr] epugh commented on pull request #1985: SOLR-14932: Broken "Add replica" button in solr admin UI

2020-10-15 Thread GitBox
epugh commented on pull request #1985: URL: https://github.com/apache/lucene-solr/pull/1985#issuecomment-709348656 Definilty @poke19962008, we have another PR that has that label. Keep em coming! This is an automated

[jira] [Commented] (SOLR-14647) Importing Gradle Projects into Eclipse pollutes checkout

2020-10-15 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214714#comment-17214714 ] Dawid Weiss commented on SOLR-14647: Where does this come from them? {code} {code} Does Eclipse add

[GitHub] [lucene-solr] gus-asf commented on pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-15 Thread GitBox
gus-asf commented on pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#issuecomment-709338043 Puzzling why RulesTest in solr is suddenly failing rat. It sure looks like it has a license just like all others and I didn't touch it.

[jira] [Commented] (SOLR-14914) Add option to disable metrics collection

2020-10-15 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214705#comment-17214705 ] Noble Paul commented on SOLR-14914: --- So, you mean nobody will know what you're gonna build & commit

[jira] [Resolved] (SOLR-14914) Add option to disable metrics collection

2020-10-15 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-14914. - Resolution: Fixed > Add option to disable metrics collection >

[jira] [Commented] (SOLR-14914) Add option to disable metrics collection

2020-10-15 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214698#comment-17214698 ] Andrzej Bialecki commented on SOLR-14914: - [~noble.paul] see the RefGuide. > Add option to

[jira] [Resolved] (SOLR-14924) Some ReplicationHandler metrics are reported using incorrect types

2020-10-15 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-14924. - Resolution: Fixed > Some ReplicationHandler metrics are reported using incorrect types >

[jira] [Commented] (SOLR-14924) Some ReplicationHandler metrics are reported using incorrect types

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214693#comment-17214693 ] ASF subversion and git services commented on SOLR-14924: Commit

[GitHub] [lucene-solr] poke19962008 commented on pull request #1985: SOLR-14932: Broken "Add replica" button in solr admin UI

2020-10-15 Thread GitBox
poke19962008 commented on pull request #1985: URL: https://github.com/apache/lucene-solr/pull/1985#issuecomment-709330918 also @epugh is it possible to add "hacktoberfest-accepted" label to this PR? This is an automated

[jira] [Commented] (SOLR-14647) Importing Gradle Projects into Eclipse pollutes checkout

2020-10-15 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214687#comment-17214687 ] Robert Muir commented on SOLR-14647: {quote} The .gitignore should be sufficient for everyone (any

[jira] [Created] (SOLR-14936) Grafana dashboard filters for collection, shard, replica, core not working

2020-10-15 Thread Jira
Jan Høydahl created SOLR-14936: -- Summary: Grafana dashboard filters for collection, shard, replica, core not working Key: SOLR-14936 URL: https://issues.apache.org/jira/browse/SOLR-14936 Project: Solr

[jira] [Commented] (SOLR-14930) remove rulebased replica placement strategy

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214677#comment-17214677 ] ASF subversion and git services commented on SOLR-14930: Commit

[jira] [Comment Edited] (SOLR-14914) Add option to disable metrics collection

2020-10-15 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214673#comment-17214673 ] Noble Paul edited comment on SOLR-14914 at 10/15/20, 12:46 PM: --- Can you

[jira] [Commented] (SOLR-14914) Add option to disable metrics collection

2020-10-15 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214673#comment-17214673 ] Noble Paul commented on SOLR-14914: --- Can you please tell us how a user can do this? Any public facing

[jira] [Updated] (SOLR-14930) remove rulebased replica placement strategy

2020-10-15 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-14930: -- Summary: remove rulebased replica placement strategy (was: Deprecate rulebased replica placement

[jira] [Commented] (SOLR-14930) Deprecate rulebased replica placement strategy

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214671#comment-17214671 ] ASF subversion and git services commented on SOLR-14930: Commit

[jira] [Commented] (SOLR-14924) Some ReplicationHandler metrics are reported using incorrect types

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214667#comment-17214667 ] ASF subversion and git services commented on SOLR-14924: Commit

[jira] [Commented] (SOLR-14933) Ability to add T and P type replica from admin UI

2020-10-15 Thread Sayan Das (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214665#comment-17214665 ] Sayan Das commented on SOLR-14933: -- oh i see. okay i will create sub tasks and start development for the

[jira] [Commented] (SOLR-14933) Ability to add T and P type replica from admin UI

2020-10-15 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214651#comment-17214651 ] Erick Erickson commented on SOLR-14933: --- Unless you have a _lot_ of leaders on a single node, the

[jira] [Commented] (SOLR-3729) ExtendedDismaxQParser (edismax) doesn't parse (*:*) properly

2020-10-15 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214649#comment-17214649 ] Erick Erickson commented on SOLR-3729: -- Patches welcome. > ExtendedDismaxQParser (edismax) doesn't

[jira] [Commented] (SOLR-14914) Add option to disable metrics collection

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214626#comment-17214626 ] ASF subversion and git services commented on SOLR-14914: Commit

[GitHub] [lucene-solr] epugh commented on pull request #1985: SOLR-14932: Broken "Add replica" button in solr admin UI

2020-10-15 Thread GitBox
epugh commented on pull request #1985: URL: https://github.com/apache/lucene-solr/pull/1985#issuecomment-709076317 I was messing with this yesterday, and I could t get the css to work! This is much better. I will test and merge.

[jira] [Commented] (SOLR-3729) ExtendedDismaxQParser (edismax) doesn't parse (*:*) properly

2020-10-15 Thread Romain MERESSE (Jira)
[ https://issues.apache.org/jira/browse/SOLR-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214551#comment-17214551 ] Romain MERESSE commented on SOLR-3729: -- No update on this issue ? > ExtendedDismaxQParser (edismax)

[jira] [Commented] (SOLR-14930) Deprecate rulebased replica placement strategy

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214540#comment-17214540 ] ASF subversion and git services commented on SOLR-14930: Commit

[jira] [Commented] (SOLR-14930) Deprecate rulebased replica placement strategy

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214531#comment-17214531 ] ASF subversion and git services commented on SOLR-14930: Commit

[GitHub] [lucene-solr] cbuescher commented on pull request #1976: LUCENE-9578: TermRangeQuery empty string lower bound edge case

2020-10-15 Thread GitBox
cbuescher commented on pull request #1976: URL: https://github.com/apache/lucene-solr/pull/1976#issuecomment-709015096 @jpountz thanks for the review, I added another commit that should fix the problem you detected. This is

[GitHub] [lucene-solr] cbuescher commented on a change in pull request #1976: LUCENE-9578: TermRangeQuery empty string lower bound edge case

2020-10-15 Thread GitBox
cbuescher commented on a change in pull request #1976: URL: https://github.com/apache/lucene-solr/pull/1976#discussion_r505373344 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/Automata.java ## @@ -85,7 +85,15 @@ public static Automaton makeAnyBinary() {

[GitHub] [lucene-solr] noblepaul merged pull request #1980: SOLR-14930: Deprecate rulebased replica placement strategy (remove in 9.0)

2020-10-15 Thread GitBox
noblepaul merged pull request #1980: URL: https://github.com/apache/lucene-solr/pull/1980 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-15 Thread GitBox
uschindler commented on a change in pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#discussion_r505364302 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/miscellaneous/TestTypeAsSynonymFilter.java ## @@ -0,0 +1,99 @@ +/* + *

[jira] [Commented] (SOLR-14914) Add option to disable metrics collection

2020-10-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214503#comment-17214503 ] ASF subversion and git services commented on SOLR-14914: Commit

  1   2   >