jpountz commented on a change in pull request #1912:
URL: https://github.com/apache/lucene-solr/pull/1912#discussion_r526737612
##
File path:
lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThreadPool.java
##
@@ -112,19 +110,12 @@ private synchronized DocumentsW
jpountz commented on pull request #1912:
URL: https://github.com/apache/lucene-solr/pull/1912#issuecomment-730272727
I'm planning to merge this change to see how it plays with nightly
benchmarks, especially now that it moved to a ThreadRipper 3990X. I'll revert
if it makes things slower.
dweiss commented on pull request #1912:
URL: https://github.com/apache/lucene-solr/pull/1912#issuecomment-730275557
bq. especially now that it moved to a ThreadRipper 3990X. I'll revert if it
makes things slower.
Who's 'it'? :)
I've been playing with TR 3970X and I can cause i
jpountz edited a comment on pull request #1912:
URL: https://github.com/apache/lucene-solr/pull/1912#issuecomment-730272727
I'm planning to merge this change to see how it plays with nightly
benchmarks, especially now that ~~it~~ they moved to a ThreadRipper 3990X. I'll
revert if it makes
jpountz commented on pull request #1912:
URL: https://github.com/apache/lucene-solr/pull/1912#issuecomment-730276978
Woops I meant the nightly bencmarks, I edited my above message.
This is an automated message from the Apache
Radu Gheorghe created SOLR-15008:
Summary: Avoid building OrdinalMap for each facet
Key: SOLR-15008
URL: https://issues.apache.org/jira/browse/SOLR-15008
Project: Solr
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/SOLR-15008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Gheorghe updated SOLR-15008:
-
Description:
I'm running against the following scenario:
* [JSON] faceting on a high cardinality
[
https://issues.apache.org/jira/browse/SOLR-15008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Gheorghe updated SOLR-15008:
-
Description:
I'm running against the following scenario:
* [JSON] faceting on a high cardinality
[
https://issues.apache.org/jira/browse/SOLR-15008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Gheorghe updated SOLR-15008:
-
Description:
I'm running against the following scenario:
* [JSON] faceting on a high cardinality
[
https://issues.apache.org/jira/browse/LUCENE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235360#comment-17235360
]
Yury Hohin commented on LUCENE-9431:
Hi, I want to help to solve this issue. Could y
[
https://issues.apache.org/jira/browse/LUCENE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235385#comment-17235385
]
Erick Erickson commented on LUCENE-9431:
Yuri:
The Jira system only allows assi
[
https://issues.apache.org/jira/browse/LUCENE-9614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235437#comment-17235437
]
Adrien Grand commented on LUCENE-9614:
--
I wonder if we should use the Query API at
msfroh commented on pull request #2088:
URL: https://github.com/apache/lucene-solr/pull/2088#issuecomment-730361695
> I'm suspicious that this is safe to do. What if another thread is calling
addDocument at the same time?
As long as `FieldNumbers.clear()` is only called from
`IndexW
dsmiley commented on a change in pull request #2088:
URL: https://github.com/apache/lucene-solr/pull/2088#discussion_r526893867
##
File path: lucene/CHANGES.txt
##
@@ -184,6 +184,9 @@ Bug fixes
* LUCENE-9365: FuzzyQuery was missing matches when prefix length was equal to
the
rmuir commented on pull request #2088:
URL: https://github.com/apache/lucene-solr/pull/2088#issuecomment-730387967
> As long as FieldNumbers.clear() is only called from
IndexWriter.deleteAll(), my understanding is that the safety is provided by the
try (Closeable finalizer = docWriter.lock
[
https://issues.apache.org/jira/browse/SOLR-15008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235549#comment-17235549
]
Michael Gibney commented on SOLR-15008:
---
Interesting; I'm surprised that profiling
[
https://issues.apache.org/jira/browse/SOLR-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235554#comment-17235554
]
ASF subversion and git services commented on SOLR-14560:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235576#comment-17235576
]
Mark Robert Miller commented on SOLR-14788:
---
{quote}Mark, I have something of e
thelabdude commented on pull request #2067:
URL: https://github.com/apache/lucene-solr/pull/2067#issuecomment-730490848
Hi @joel-bernstein wasn't able to assign you as a reviewer on this, but
would love for you to take a look when convenient.
--
thelabdude commented on a change in pull request #2067:
URL: https://github.com/apache/lucene-solr/pull/2067#discussion_r527028199
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/CloudSolrStream.java
##
@@ -334,88 +330,76 @@ private StreamComparator pa
thelabdude commented on a change in pull request #2067:
URL: https://github.com/apache/lucene-solr/pull/2067#discussion_r527029201
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/SolrStream.java
##
@@ -268,8 +275,7 @@ private Map mapFields(Map fields,
thelabdude commented on a change in pull request #2067:
URL: https://github.com/apache/lucene-solr/pull/2067#discussion_r527027234
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/CloudSolrStream.java
##
@@ -334,88 +330,76 @@ private StreamComparator pa
thelabdude commented on a change in pull request #2067:
URL: https://github.com/apache/lucene-solr/pull/2067#discussion_r527027557
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/CloudSolrStream.java
##
@@ -334,11 +334,6 @@ private StreamComparator par
[
https://issues.apache.org/jira/browse/SOLR-14035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235629#comment-17235629
]
Christine Poerschke commented on SOLR-14035:
Hello [~Alexey Bulygin], welcome
[
https://issues.apache.org/jira/browse/SOLR-14035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke reassigned SOLR-14035:
--
Assignee: Christine Poerschke
> remove deprecated preferLocalShards references
[
https://issues.apache.org/jira/browse/SOLR-14035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235638#comment-17235638
]
ASF subversion and git services commented on SOLR-14035:
Commit c
[
https://issues.apache.org/jira/browse/SOLR-14035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke resolved SOLR-14035.
Resolution: Fixed
> remove deprecated preferLocalShards references
> --
[
https://issues.apache.org/jira/browse/LUCENE-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235643#comment-17235643
]
Adrien Grand commented on LUCENE-9616:
--
I had not though about naming the class Luc
Haoyu Zhai created LUCENE-9618:
--
Summary: Improve IntervalIterator.nextInterval's
behavior/documentation/test
Key: LUCENE-9618
URL: https://issues.apache.org/jira/browse/LUCENE-9618
Project: Lucene - Cor
zhaih opened a new pull request #2090:
URL: https://github.com/apache/lucene-solr/pull/2090
# Description
This PR is not intended to be merged. It's just for demonstration of issues
mentioned in [LUCENE-9618](https://issues.apache.org/jira/browse/LUCENE-9618)
--
[
https://issues.apache.org/jira/browse/LUCENE-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235652#comment-17235652
]
Haoyu Zhai commented on LUCENE-9618:
I created a [PR|https://github.com/apache/lucen
[
https://issues.apache.org/jira/browse/SOLR-13671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235656#comment-17235656
]
Christine Poerschke commented on SOLR-13671:
bq. ... lucene/tools/src/groovy/
[
https://issues.apache.org/jira/browse/LUCENE-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235675#comment-17235675
]
Michael McCandless commented on LUCENE-9618:
Hmm it is weird that these quer
[
https://issues.apache.org/jira/browse/LUCENE-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235677#comment-17235677
]
Michael McCandless commented on LUCENE-9618:
And thank you [~zhai7631] for t
[
https://issues.apache.org/jira/browse/LUCENE-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haoyu Zhai updated LUCENE-9618:
---
Description:
I'm trying to play around with my own {{IntervalSource}} and found out that
{{nextInte
[
https://issues.apache.org/jira/browse/LUCENE-9617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235680#comment-17235680
]
Michael McCandless commented on LUCENE-9617:
Whoa, good catch [~msfroh]! I'
[
https://issues.apache.org/jira/browse/SOLR-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235711#comment-17235711
]
Houston Putman commented on SOLR-6733:
--
Is there still interest in this idea? If so,
[
https://issues.apache.org/jira/browse/LUCENE-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235738#comment-17235738
]
Alan Woodward commented on LUCENE-9618:
---
Thank you for opening this [~zhai7631].
[
https://issues.apache.org/jira/browse/SOLR-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235777#comment-17235777
]
David Smiley commented on SOLR-6733:
In my mind, this is a controversial topic. We'd
[
https://issues.apache.org/jira/browse/SOLR-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235779#comment-17235779
]
David Smiley commented on SOLR-6733:
For example my colleagues added some specialized
[
https://issues.apache.org/jira/browse/SOLR-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235783#comment-17235783
]
Ilan Ginzburg commented on SOLR-14788:
--
I believe with a central {{/clusterstate.jso
[
https://issues.apache.org/jira/browse/LUCENE-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235801#comment-17235801
]
Robert Muir commented on LUCENE-9616:
-
+1 to more aggressively copy-on-write the for
[
https://issues.apache.org/jira/browse/SOLR-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235852#comment-17235852
]
Mark Robert Miller commented on SOLR-14788:
---
My initial implementation only rea
jtibshirani merged pull request #2084:
URL: https://github.com/apache/lucene-solr/pull/2084
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
[
https://issues.apache.org/jira/browse/LUCENE-9592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235858#comment-17235858
]
ASF subversion and git services commented on LUCENE-9592:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani resolved LUCENE-9592.
--
Resolution: Fixed
> TestVectorUtil can fail with assertion error
> ---
zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r527373046
##
File path:
lucene/misc/src/test/org/apache/lucene/misc/store/TestDirectIODirectory.java
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Sof
[
https://issues.apache.org/jira/browse/SOLR-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235952#comment-17235952
]
Mark Robert Miller commented on SOLR-14788:
---
And let me just say again, I don’t
[
https://issues.apache.org/jira/browse/SOLR-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235952#comment-17235952
]
Mark Robert Miller edited comment on SOLR-14788 at 11/20/20, 7:26 AM:
-
[
https://issues.apache.org/jira/browse/SOLR-15008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Gheorghe updated SOLR-15008:
-
Attachment: writes_commits.png
> Avoid building OrdinalMap for each facet
> -
50 matches
Mail list logo
