[GitHub] [lucene-solr] tflobbe commented on pull request #2163: LUCENE-9647 Add back github action for Ant

2020-12-22 Thread GitBox
tflobbe commented on pull request #2163: URL: https://github.com/apache/lucene-solr/pull/2163#issuecomment-749862991 Does this go yo master or to 8.x branch? I don't think we had it running in 8.x before? This is an

[jira] [Commented] (SOLR-15052) Reducing overseer bottlenecks using per-replica states

2020-12-22 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253820#comment-17253820 ] Noble Paul commented on SOLR-15052: --- {quote}Then the {{R5}} update is also going to read the directory

[jira] [Updated] (SOLR-15052) Reducing overseer bottlenecks using per-replica states

2020-12-22 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-15052: -- Issue Type: Improvement (was: Bug) > Reducing overseer bottlenecks using per-replica states >

[GitHub] [lucene-solr] trdillon commented on a change in pull request #2152: SOLR-14034: remove deprecated min_rf references

2020-12-22 Thread GitBox
trdillon commented on a change in pull request #2152: URL: https://github.com/apache/lucene-solr/pull/2152#discussion_r547561917 ## File path: solr/core/src/test/org/apache/solr/cloud/HttpPartitionTest.java ## @@ -548,9 +548,6 @@ protected int sendDoc(int docId, Integer minRf,

[GitHub] [lucene-solr] madrob commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks

2020-12-22 Thread GitBox
madrob commented on a change in pull request #2148: URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r547543008 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/PerReplicaStates.java ## @@ -0,0 +1,587 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] madrob commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks

2020-12-22 Thread GitBox
madrob commented on a change in pull request #2148: URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r547542705 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java ## @@ -1609,12 +1611,41 @@ public void publish(final CoreDescriptor cd, final

[GitHub] [lucene-solr] madrob commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks

2020-12-22 Thread GitBox
madrob commented on a change in pull request #2148: URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r547542479 ## File path: solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java ## @@ -81,6 +81,7 @@ public class SolrCloudTestCase extends

[GitHub] [lucene-solr] madrob opened a new pull request #2163: LUCENE-9647 Add back github action for Ant

2020-12-22 Thread GitBox
madrob opened a new pull request #2163: URL: https://github.com/apache/lucene-solr/pull/2163 https://issues.apache.org/jira/browse/LUCENE-9647 Tagging @tflobbe for review because you removed the file in the first place. If there's a better place to put it, let me know.

[jira] [Commented] (SOLR-15051) Shared storage -- BlobDirectory (de-duping)

2020-12-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253791#comment-17253791 ] David Smiley commented on SOLR-15051: - In Solr we have a "BackupRepository" abstraction already for

[jira] [Created] (LUCENE-9647) Add back ant precommit on PR for branch 8

2020-12-22 Thread Mike Drob (Jira)
Mike Drob created LUCENE-9647: - Summary: Add back ant precommit on PR for branch 8 Key: LUCENE-9647 URL: https://issues.apache.org/jira/browse/LUCENE-9647 Project: Lucene - Core Issue Type: Task

[jira] [Resolved] (SOLR-15031) NPE caused by FunctionQParser returning a null ValueSource

2020-12-22 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-15031. -- Fix Version/s: master (9.0) 8.8 Assignee: Mike Drob Resolution:

[jira] [Commented] (SOLR-15031) NPE caused by FunctionQParser returning a null ValueSource

2020-12-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253780#comment-17253780 ] ASF subversion and git services commented on SOLR-15031: Commit

[jira] [Commented] (SOLR-15031) NPE caused by FunctionQParser returning a null ValueSource

2020-12-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253779#comment-17253779 ] ASF subversion and git services commented on SOLR-15031: Commit

[GitHub] [lucene-solr] madrob closed pull request #2118: SOLR-15031: Prevent null being wrapped in a QueryValueSource

2020-12-22 Thread GitBox
madrob closed pull request #2118: URL: https://github.com/apache/lucene-solr/pull/2118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

2020-12-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253756#comment-17253756 ] David Smiley commented on SOLR-14923: - I pushed a branch_8x back-port to my fork which only needed a

[jira] [Commented] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied

2020-12-22 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253719#comment-17253719 ] Dawid Weiss commented on LUCENE-9570: - Very long string concatenations (and arithmetic expressions)

[jira] [Commented] (SOLR-15051) Shared storage -- BlobDirectory (de-duping)

2020-12-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253696#comment-17253696 ] David Smiley commented on SOLR-15051: - Thanks for the look [~krisden]! bq. There will be a

[jira] [Updated] (SOLR-14951) Upgrade Angular JS 1.7.9 to 1.8.0

2020-12-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-14951: Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade Angular JS 1.7.9 to

[jira] [Commented] (SOLR-14951) Upgrade Angular JS 1.7.9 to 1.8.0

2020-12-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253670#comment-17253670 ] ASF subversion and git services commented on SOLR-14951: Commit

[jira] [Commented] (SOLR-14951) Upgrade Angular JS 1.7.9 to 1.8.0

2020-12-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253640#comment-17253640 ] ASF subversion and git services commented on SOLR-14951: Commit

[GitHub] [lucene-solr] risdenk closed pull request #2008: SOLR-14951: Upgrade Angular JS 1.7.9 to 1.8.0

2020-12-22 Thread GitBox
risdenk closed pull request #2008: URL: https://github.com/apache/lucene-solr/pull/2008 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (LUCENE-9646) Set BM25Similarity discountOverlaps via the constructor

2020-12-22 Thread Patrick Marty (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Marty updated LUCENE-9646: -- Description: BM25Similarity discountOverlaps parameter is true by default. It can be set

[GitHub] [lucene-solr] patrickmarty opened a new pull request #2161: LUCENE-9646: Set BM25Similarity discountOverlaps via the constructor

2020-12-22 Thread GitBox
patrickmarty opened a new pull request #2161: URL: https://github.com/apache/lucene-solr/pull/2161 # Description BM25Similarity discountOverlaps parameter can be set with org.apache.lucene.search.similarities.BM25Similarity#setDiscountOverlaps method. But this method makes

[jira] [Commented] (SOLR-15052) Reducing overseer bottlenecks using per-replica states

2020-12-22 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253612#comment-17253612 ] Ilan Ginzburg commented on SOLR-15052: -- I agree [~noble.paul]. There's no serialization, I meant to

[jira] [Updated] (LUCENE-9646) Set BM25Similarity discountOverlaps via the constructor

2020-12-22 Thread Patrick Marty (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Marty updated LUCENE-9646: -- Summary: Set BM25Similarity discountOverlaps via the constructor (was: Set BM25Similarity

[jira] [Commented] (SOLR-14688) First party package implementation design

2020-12-22 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253598#comment-17253598 ] Jan Høydahl commented on SOLR-14688: So, how can we achieve these to goals? # Support

[jira] [Commented] (SOLR-15051) Shared storage -- BlobDirectory (de-duping)

2020-12-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253596#comment-17253596 ] Kevin Risden commented on SOLR-15051: - I can't add a comment to the design doc, but wanted to address

[jira] [Resolved] (SOLR-14088) Tika and commons-compress dependency in solr core causes classloader issue

2020-12-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden resolved SOLR-14088. - Resolution: Cannot Reproduce This hasn't come up again and I'm not planning to track it down any

[jira] [Commented] (SOLR-14963) Child "rows" param should apply per level

2020-12-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253585#comment-17253585 ] David Smiley commented on SOLR-14963: - It'd be great to have something for 8.8, thus gets committed

[GitHub] [lucene-solr] cpoerschke commented on pull request #2152: SOLR-14034: remove deprecated min_rf references

2020-12-22 Thread GitBox
cpoerschke commented on pull request #2152: URL: https://github.com/apache/lucene-solr/pull/2152#issuecomment-749604771 At https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.7.0/solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java#L754-L756

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #2152: SOLR-14034: remove deprecated min_rf references

2020-12-22 Thread GitBox
cpoerschke commented on a change in pull request #2152: URL: https://github.com/apache/lucene-solr/pull/2152#discussion_r547337314 ## File path: solr/core/src/test/org/apache/solr/cloud/HttpPartitionTest.java ## @@ -548,9 +548,6 @@ protected int sendDoc(int docId, Integer

[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #2153: LUCENE-9570: A non-mergable PR with reformatted code.

2020-12-22 Thread GitBox
muse-dev[bot] commented on a change in pull request #2153: URL: https://github.com/apache/lucene-solr/pull/2153#discussion_r547326682 ## File path: lucene/core/src/test/org/apache/lucene/util/TestSmallFloat.java ## @@ -167,22 +170,24 @@ public void testByte4() { } }

[jira] [Updated] (SOLR-15057) avoid unnecessary object retention in FacetRangeProcessor

2020-12-22 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-15057: --- Description: * The (private) {{doSubs}} method is a no-op if there are no

[GitHub] [lucene-solr] cpoerschke opened a new pull request #2160: SOLR-15057: avoid unnecessary object retention in FacetRangeProcessor

2020-12-22 Thread GitBox
cpoerschke opened a new pull request #2160: URL: https://github.com/apache/lucene-solr/pull/2160 https://issues.apache.org/jira/browse/SOLR-15057 This is an automated message from the Apache Git Service. To respond to the

[jira] [Resolved] (LUCENE-9644) HNSW diverse neighbor selection heuristic

2020-12-22 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Sokolov resolved LUCENE-9644. - Resolution: Fixed > HNSW diverse neighbor selection heuristic >

[jira] [Created] (SOLR-15057) avoid unnecessary object retention in FacetRangeProcessor

2020-12-22 Thread Christine Poerschke (Jira)
Christine Poerschke created SOLR-15057: -- Summary: avoid unnecessary object retention in FacetRangeProcessor Key: SOLR-15057 URL: https://issues.apache.org/jira/browse/SOLR-15057 Project: Solr

[jira] [Commented] (LUCENE-9644) HNSW diverse neighbor selection heuristic

2020-12-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253546#comment-17253546 ] ASF subversion and git services commented on LUCENE-9644: - Commit

[GitHub] [lucene-solr] msokolov merged pull request #2157: LUCENE-9644: diversity heuristic for HNSW graph neighbor selection

2020-12-22 Thread GitBox
msokolov merged pull request #2157: URL: https://github.com/apache/lucene-solr/pull/2157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Resolved] (SOLR-15049) Optimize TopLevelJoinQuery "self joins"

2020-12-22 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-15049. Fix Version/s: master (9.0) 8.8 Resolution: Fixed > Optimize

[jira] [Commented] (SOLR-15049) Optimize TopLevelJoinQuery "self joins"

2020-12-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253528#comment-17253528 ] ASF subversion and git services commented on SOLR-15049: Commit

[jira] [Commented] (LUCENE-7344) Deletion by query of uncommitted docs not working with DV updates

2020-12-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253513#comment-17253513 ] David Smiley commented on LUCENE-7344: -- I know it's been 4 years but I want to add that a Lucene

[jira] [Commented] (SOLR-15049) Optimize TopLevelJoinQuery "self joins"

2020-12-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17253501#comment-17253501 ] ASF subversion and git services commented on SOLR-15049: Commit

[GitHub] [lucene-solr] gerlowskija merged pull request #2146: SOLR-15049: Add TopLevelJoinQuery optimization for 'self-joins'

2020-12-22 Thread GitBox
gerlowskija merged pull request #2146: URL: https://github.com/apache/lucene-solr/pull/2146 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks

2020-12-22 Thread GitBox
murblanc commented on a change in pull request #2148: URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r547236069 ## File path: solr/core/src/java/org/apache/solr/cloud/overseer/CollectionMutator.java ## @@ -136,8 +154,13 @@ public ZkWriteCommand

[GitHub] [lucene-solr] iverase commented on a change in pull request #2155: LUCENE-9641: Support for spatial relationships in LatLonPoint

2020-12-22 Thread GitBox
iverase commented on a change in pull request #2155: URL: https://github.com/apache/lucene-solr/pull/2155#discussion_r547166564 ## File path: lucene/core/src/java/org/apache/lucene/document/LatLonPointQuery.java ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] iverase commented on a change in pull request #2155: LUCENE-9641: Support for spatial relationships in LatLonPoint

2020-12-22 Thread GitBox
iverase commented on a change in pull request #2155: URL: https://github.com/apache/lucene-solr/pull/2155#discussion_r547165818 ## File path: lucene/core/src/java/org/apache/lucene/document/LatLonPointQuery.java ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software