[GitHub] [lucene-solr] noblepaul commented on a change in pull request #2187: SOLR-15052 Reducing overseer bottlenecks using per-replica states (8x)

2021-01-08 Thread GitBox
noblepaul commented on a change in pull request #2187: URL: https://github.com/apache/lucene-solr/pull/2187#discussion_r554294274 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/PerReplicaStates.java ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software

[jira] [Comment Edited] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261727#comment-17261727 ] Joel Bernstein edited comment on SOLR-15036 at 1/9/21, 2:34 AM: A little

[jira] [Comment Edited] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261727#comment-17261727 ] Joel Bernstein edited comment on SOLR-15036 at 1/9/21, 2:34 AM: A little

[jira] [Comment Edited] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261727#comment-17261727 ] Joel Bernstein edited comment on SOLR-15036 at 1/9/21, 2:19 AM: A little

[jira] [Comment Edited] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261727#comment-17261727 ] Joel Bernstein edited comment on SOLR-15036 at 1/9/21, 2:18 AM: A little

[jira] [Comment Edited] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261727#comment-17261727 ] Joel Bernstein edited comment on SOLR-15036 at 1/9/21, 2:18 AM: A little

[jira] [Comment Edited] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261727#comment-17261727 ] Joel Bernstein edited comment on SOLR-15036 at 1/9/21, 2:17 AM: A little

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261727#comment-17261727 ] Joel Bernstein commented on SOLR-15036: --- A little more the SolrStream. The SolrStream is meant to

[jira] [Comment Edited] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261708#comment-17261708 ] Joel Bernstein edited comment on SOLR-15036 at 1/9/21, 1:39 AM: So, basic

[jira] [Comment Edited] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261708#comment-17261708 ] Joel Bernstein edited comment on SOLR-15036 at 1/9/21, 1:39 AM: So, basic

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261708#comment-17261708 ] Joel Bernstein commented on SOLR-15036: --- So, basic auth happens automatically under the covers.

[GitHub] [lucene-solr] tflobbe merged pull request #2174: Remove unused test file

2021-01-08 Thread GitBox
tflobbe merged pull request #2174: URL: https://github.com/apache/lucene-solr/pull/2174 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Resolved] (SOLR-14999) Add built-in option to advertise Solr with a different port than Jetty listens on.

2021-01-08 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-14999. --- Fix Version/s: 8.8 Resolution: Fixed > Add built-in option to advertise Solr with a

[jira] [Commented] (SOLR-14999) Add built-in option to advertise Solr with a different port than Jetty listens on.

2021-01-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261686#comment-17261686 ] ASF subversion and git services commented on SOLR-14999: Commit

[jira] [Commented] (SOLR-15025) MiniSolrCloudCluster.waitForAllNodes ignores passed timeout value

2021-01-08 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261672#comment-17261672 ] Mike Drob commented on SOLR-15025: -- If the passed timeout is null, that should probably be an error. We

[jira] [Commented] (SOLR-15025) MiniSolrCloudCluster.waitForAllNodes ignores passed timeout value

2021-01-08 Thread Tim Dillon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261668#comment-17261668 ] Tim Dillon commented on SOLR-15025: --- [~mdrob] I'm a new dev and would be interested in working on this

[jira] [Commented] (SOLR-14999) Add built-in option to advertise Solr with a different port than Jetty listens on.

2021-01-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261667#comment-17261667 ] ASF subversion and git services commented on SOLR-14999: Commit

[GitHub] [lucene-solr] HoustonPutman merged pull request #2089: SOLR-14999: Option to set the advertised port for Solr.

2021-01-08 Thread GitBox
HoustonPutman merged pull request #2089: URL: https://github.com/apache/lucene-solr/pull/2089 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene-solr] HoustonPutman merged pull request #2191: Add gradle settings for github actions.

2021-01-08 Thread GitBox
HoustonPutman merged pull request #2191: URL: https://github.com/apache/lucene-solr/pull/2191 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene-solr] HoustonPutman commented on pull request #2191: Add gradle settings for github actions.

2021-01-08 Thread GitBox
HoustonPutman commented on pull request #2191: URL: https://github.com/apache/lucene-solr/pull/2191#issuecomment-757042563 Not sure why it cause docker tests to fail, but oh well. Works fine for the SolrJ and Gradle Precommit.

[jira] [Commented] (SOLR-15056) CPU circuit breaker needs to use CPU utilization, not Unix load average

2021-01-08 Thread Walter Underwood (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261656#comment-17261656 ] Walter Underwood commented on SOLR-15056: - The factory will return null if that MXBean isn't

[jira] [Commented] (SOLR-15056) CPU circuit breaker needs to use CPU utilization, not Unix load average

2021-01-08 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261634#comment-17261634 ] Mike Drob commented on SOLR-15056: -- Looking at the code, it should be ok to test for it and attempt to

[jira] [Commented] (SOLR-15010) Missing jstack warning is alarming, when using bin/solr as client interface to solr

2021-01-08 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261628#comment-17261628 ] David Eric Pugh commented on SOLR-15010: [~janhoy][~cpoerschke] I've pushed up a PR for this, I'd

[GitHub] [lucene-solr] epugh opened a new pull request #2192: SOLR-15010 Try to use jattach for threaddump if jstack is missing

2021-01-08 Thread GitBox
epugh opened a new pull request #2192: URL: https://github.com/apache/lucene-solr/pull/2192 Introduce jattach check if jstack is missing. jattach ships in the Solr docker image instead of jstack. # Description With the Solr Docker image you get an alarming

[jira] [Closed] (SOLR-11179) Ability to dump jstack

2021-01-08 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh closed SOLR-11179. -- > Ability to dump jstack > -- > > Key: SOLR-11179 >

[jira] [Resolved] (SOLR-11179) Ability to dump jstack

2021-01-08 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh resolved SOLR-11179. Resolution: Duplicate I am resolving this as done. Please reopen if my understanding of

[jira] [Commented] (SOLR-11179) Ability to dump jstack

2021-01-08 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261623#comment-17261623 ] David Eric Pugh commented on SOLR-11179: Looks like this is done! Thanks for the patch

[jira] [Assigned] (SOLR-11179) Ability to dump jstack

2021-01-08 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh reassigned SOLR-11179: -- Assignee: David Eric Pugh > Ability to dump jstack > -- > >

[jira] [Commented] (SOLR-13105) A visual guide to Solr Math Expressions and Streaming Expressions

2021-01-08 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261616#comment-17261616 ] David Eric Pugh commented on SOLR-13105: Thanks for the detailed response [~ctargett], it helps

[GitHub] [lucene-solr] dweiss opened a new pull request #2190: Make :localSettings always available, even if it's a noop on subsequent runs

2021-01-08 Thread GitBox
dweiss opened a new pull request #2190: URL: https://github.com/apache/lucene-solr/pull/2190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (SOLR-13105) A visual guide to Solr Math Expressions and Streaming Expressions

2021-01-08 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261590#comment-17261590 ] Cassandra Targett commented on SOLR-13105: -- I put all the comments together to respond to them.

[GitHub] [lucene-solr] madrob commented on a change in pull request #2187: SOLR-15052 Reducing overseer bottlenecks using per-replica states (8x)

2021-01-08 Thread GitBox
madrob commented on a change in pull request #2187: URL: https://github.com/apache/lucene-solr/pull/2187#discussion_r554164613 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java ## @@ -64,31 +64,8 @@ import org.apache.solr.common.AlreadyClosedException;

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261575#comment-17261575 ] Timothy Potter commented on SOLR-15036: --- Ok thank you for the guidance. Tiered makes sense now (y).

[jira] [Comment Edited] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261568#comment-17261568 ] Joel Bernstein edited comment on SOLR-15036 at 1/8/21, 8:25 PM: Ok, let's

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261568#comment-17261568 ] Joel Bernstein commented on SOLR-15036: --- Ok, let's go with an explicit opt-in for 8.8 if you want

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261555#comment-17261555 ] Timothy Potter commented on SOLR-15036: --- Also, regarding composability ... I think that approach

[GitHub] [lucene-solr] slackhappy commented on pull request #2189: SOLR-14413 fix unit test to use delayed handler

2021-01-08 Thread GitBox
slackhappy commented on pull request #2189: URL: https://github.com/apache/lucene-solr/pull/2189#issuecomment-756956274 thanks for making these changes, certainly an improvement! This is an automated message from the Apache

[GitHub] [lucene-solr] slackhappy commented on a change in pull request #2189: SOLR-14413 fix unit test to use delayed handler

2021-01-08 Thread GitBox
slackhappy commented on a change in pull request #2189: URL: https://github.com/apache/lucene-solr/pull/2189#discussion_r554151852 ## File path: solr/core/src/test/org/apache/solr/CursorPagingTest.java ## @@ -521,6 +522,7 @@ public void testTimeAllowed() throws Exception {

[jira] [Comment Edited] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261550#comment-17261550 ] Timothy Potter edited comment on SOLR-15036 at 1/8/21, 7:36 PM: Thanks

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261550#comment-17261550 ] Timothy Potter commented on SOLR-15036: --- Thanks for looking [~jbernste] I don't see any real risk

[GitHub] [lucene-solr] HoustonPutman opened a new pull request #2191: Add gradle settings for github actions.

2021-01-08 Thread GitBox
HoustonPutman opened a new pull request #2191: URL: https://github.com/apache/lucene-solr/pull/2191 # Description The github precommit action is failing because of OOMs. It should be fixed by setting local settings before running gradle commands.

[jira] [Commented] (SOLR-14413) allow timeAllowed and cursorMark parameters

2021-01-08 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261546#comment-17261546 ] Mike Drob commented on SOLR-14413: -- There's something strange going on with the logging, I'll revert it

[GitHub] [lucene-solr] dweiss merged pull request #2190: Make :localSettings always available, even if it's a noop on subsequent runs

2021-01-08 Thread GitBox
dweiss merged pull request #2190: URL: https://github.com/apache/lucene-solr/pull/2190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Comment Edited] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261539#comment-17261539 ] Joel Bernstein edited comment on SOLR-15036 at 1/8/21, 7:25 PM: One thing

[jira] [Comment Edited] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261539#comment-17261539 ] Joel Bernstein edited comment on SOLR-15036 at 1/8/21, 7:24 PM: One thing

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261539#comment-17261539 ] Joel Bernstein commented on SOLR-15036: --- One thing we could do to remove any risks and move faster

[jira] [Comment Edited] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261532#comment-17261532 ] Joel Bernstein edited comment on SOLR-15036 at 1/8/21, 7:15 PM: A couple

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261532#comment-17261532 ] Joel Bernstein commented on SOLR-15036: --- A couple of thoughts based mainly on the description of

[jira] [Commented] (SOLR-14413) allow timeAllowed and cursorMark parameters

2021-01-08 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261518#comment-17261518 ] Chris M. Hostetter commented on SOLR-14413: --- Hrmmm... I don't think the loggingchange is a good

[jira] [Commented] (SOLR-14413) allow timeAllowed and cursorMark parameters

2021-01-08 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261513#comment-17261513 ] Mike Drob commented on SOLR-14413: -- I put up a PR with your pointers, [~hossman]. Also had to tune down

[GitHub] [lucene-solr] madrob opened a new pull request #2189: SOLR-14413 fix unit test to use delayed handler

2021-01-08 Thread GitBox
madrob opened a new pull request #2189: URL: https://github.com/apache/lucene-solr/pull/2189 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (SOLR-15073) Unsafe cast in SystemInfoHandler

2021-01-08 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261501#comment-17261501 ] Christine Poerschke commented on SOLR-15073: Hello [~nyivan]. Is

[jira] [Commented] (SOLR-14787) Inequality support in Payload Check query parser

2021-01-08 Thread Kevin Watters (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261495#comment-17261495 ] Kevin Watters commented on SOLR-14787: -- I've created a separate ticket / PR for the lucene parts

[jira] [Created] (SOLR-15078) ExpandComponent treats all docs with '0' in a numeric collapse field the same as if null

2021-01-08 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-15078: - Summary: ExpandComponent treats all docs with '0' in a numeric collapse field the same as if null Key: SOLR-15078 URL: https://issues.apache.org/jira/browse/SOLR-15078

[jira] [Commented] (SOLR-14413) allow timeAllowed and cursorMark parameters

2021-01-08 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261473#comment-17261473 ] Chris M. Hostetter commented on SOLR-14413: --- {quote}I don't believe we need to switch the

[jira] [Commented] (SOLR-14413) allow timeAllowed and cursorMark parameters

2021-01-08 Thread John Gallagher (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261464#comment-17261464 ] John Gallagher commented on SOLR-14413: --- Thanks for reporting [~hossman].  I didn't know about the

[jira] [Updated] (SOLR-14413) allow timeAllowed and cursorMark parameters

2021-01-08 Thread John Gallagher (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Gallagher updated SOLR-14413: -- Attachment: SOLR-14413.testfix.patch > allow timeAllowed and cursorMark parameters >

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

2021-01-08 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261439#comment-17261439 ] Houston Putman commented on SOLR-11795: --- I agree that co-existing would be the best course of

[GitHub] [lucene-solr] gerlowskija edited a comment on pull request #2183: SOLR-15070: Remove HashMap usage in SuggestComponent rsp

2021-01-08 Thread GitBox
gerlowskija edited a comment on pull request #2183: URL: https://github.com/apache/lucene-solr/pull/2183#issuecomment-756877504 > If the client side doesn't change, then does that mean this is safe to back port to 8x? Sorry, I think a comment I made above was misleading. This PR as

[jira] [Updated] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter updated SOLR-15036: -- Status: Patch Available (was: Open) > Use plist automatically for executing a facet

[GitHub] [lucene-solr] gerlowskija commented on pull request #2183: SOLR-15070: Remove HashMap usage in SuggestComponent rsp

2021-01-08 Thread GitBox
gerlowskija commented on pull request #2183: URL: https://github.com/apache/lucene-solr/pull/2183#issuecomment-756877504 > If the client side doesn't change, then does that mean this is safe to back port to 8x? Sorry, I think a comment I made above was misleading. This PR as a

[jira] [Commented] (SOLR-15036) Use plist automatically for executing a facet expression against a collection alias backed by multiple collections

2021-01-08 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261434#comment-17261434 ] Timothy Potter commented on SOLR-15036: --- [~jbernste] I think this is ready to go and would

[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2132: SOLR-15036: auto- select / rollup / sort / plist over facet expression when using a collection alias with multiple collec

2021-01-08 Thread GitBox
thelabdude commented on a change in pull request #2132: URL: https://github.com/apache/lucene-solr/pull/2132#discussion_r554056609 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/metrics/MaxMetric.java ## @@ -86,7 +86,7 @@ public void update(Tuple

[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2132: SOLR-15036: auto- select / rollup / sort / plist over facet expression when using a collection alias with multiple collec

2021-01-08 Thread GitBox
thelabdude commented on a change in pull request #2132: URL: https://github.com/apache/lucene-solr/pull/2132#discussion_r554055360 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/FacetStream.java ## @@ -842,10 +881,99 @@ public int getCost() {

[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2132: SOLR-15036: auto- select / rollup / sort / plist over facet expression when using a collection alias with multiple collec

2021-01-08 Thread GitBox
thelabdude commented on a change in pull request #2132: URL: https://github.com/apache/lucene-solr/pull/2132#discussion_r554054810 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/FacetStream.java ## @@ -537,14 +555,29 @@ public void

[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2132: SOLR-15036: auto- select / rollup / sort / plist over facet expression when using a collection alias with multiple collec

2021-01-08 Thread GitBox
thelabdude commented on a change in pull request #2132: URL: https://github.com/apache/lucene-solr/pull/2132#discussion_r554054274 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/FacetStream.java ## @@ -20,15 +20,19 @@ import java.util.ArrayList;

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

2021-01-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261423#comment-17261423 ] David Smiley commented on SOLR-11795: - In the sixth comment on this issue, [~koji] contrasts this

[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2132: SOLR-15036: auto- select / rollup / sort / plist over facet expression when using a collection alias with multiple collec

2021-01-08 Thread GitBox
thelabdude commented on a change in pull request #2132: URL: https://github.com/apache/lucene-solr/pull/2132#discussion_r554052572 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/DrillStream.java ## @@ -252,29 +253,27 @@ public void

[jira] [Commented] (SOLR-14413) allow timeAllowed and cursorMark parameters

2021-01-08 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261393#comment-17261393 ] Mike Drob commented on SOLR-14413: -- Looking. > allow timeAllowed and cursorMark parameters >

[jira] [Commented] (SOLR-13105) A visual guide to Solr Math Expressions and Streaming Expressions

2021-01-08 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261373#comment-17261373 ] Cassandra Targett commented on SOLR-13105: -- I haven't read the rest of the feedback yet, but

[jira] [Updated] (SOLR-15077) Improve performance of the nodes Streaming Expression

2021-01-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15077: -- Description: This ticket will use the new stream processing capability built into the export

[jira] [Updated] (SOLR-15077) Improve performance of the nodes Streaming Expression

2021-01-08 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15077: -- Description: This ticket will use the new stream processing capability built into the export

[jira] [Created] (SOLR-15077) Improve performance of the nodes Streaming Expression

2021-01-08 Thread Joel Bernstein (Jira)
Joel Bernstein created SOLR-15077: - Summary: Improve performance of the nodes Streaming Expression Key: SOLR-15077 URL: https://issues.apache.org/jira/browse/SOLR-15077 Project: Solr Issue

[jira] [Commented] (SOLR-15064) Atomic/partial updates to nested docs should not assume _route_ param is the root ID

2021-01-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261326#comment-17261326 ] Thomas Wöckinger commented on SOLR-15064: - Thx for the hint, i was already thinking about that,

[jira] [Commented] (SOLR-15064) Atomic/partial updates to nested docs should not assume _route_ param is the root ID

2021-01-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261315#comment-17261315 ] David Smiley commented on SOLR-15064: - No.  hash("1!1") != hash("1!1!2") But this trick works :) –

[jira] [Issue Comment Deleted] (SOLR-15064) Atomic/partial updates to nested docs should not assume _route_ param is the root ID

2021-01-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-15064: Comment: was deleted (was: Commit 2417aa085f646f1c5b13ee1bc55d286460dfe826 in lucene-solr's branch

[jira] [Commented] (SOLR-14827) Refactor schema loading to not use XPath

2021-01-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261293#comment-17261293 ] ASF subversion and git services commented on SOLR-14827: Commit

[jira] [Commented] (LUCENE-9641) Support for spatial relationships in LatLonPoint

2021-01-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261288#comment-17261288 ] ASF subversion and git services commented on LUCENE-9641: - Commit

[jira] [Commented] (LUCENE-9641) Support for spatial relationships in LatLonPoint

2021-01-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261286#comment-17261286 ] ASF subversion and git services commented on LUCENE-9641: - Commit

[GitHub] [lucene-solr] iverase merged pull request #2188: [Backport] LUCENE-9641: Support for spatial relationships in LatLonPoint (#2155)

2021-01-08 Thread GitBox
iverase merged pull request #2188: URL: https://github.com/apache/lucene-solr/pull/2188 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Resolved] (LUCENE-9641) Support for spatial relationships in LatLonPoint

2021-01-08 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-9641. -- Fix Version/s: 8.8 Assignee: Ignacio Vera Resolution: Fixed > Support for

[jira] [Commented] (LUCENE-9641) Support for spatial relationships in LatLonPoint

2021-01-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261110#comment-17261110 ] ASF subversion and git services commented on LUCENE-9641: - Commit