noblepaul commented on a change in pull request #2187:
URL: https://github.com/apache/lucene-solr/pull/2187#discussion_r554294274
##
File path:
solr/solrj/src/java/org/apache/solr/common/cloud/PerReplicaStates.java
##
@@ -0,0 +1,310 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261727#comment-17261727
]
Joel Bernstein edited comment on SOLR-15036 at 1/9/21, 2:34 AM:
A little
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261727#comment-17261727
]
Joel Bernstein edited comment on SOLR-15036 at 1/9/21, 2:34 AM:
A little
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261727#comment-17261727
]
Joel Bernstein edited comment on SOLR-15036 at 1/9/21, 2:19 AM:
A little
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261727#comment-17261727
]
Joel Bernstein edited comment on SOLR-15036 at 1/9/21, 2:18 AM:
A little
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261727#comment-17261727
]
Joel Bernstein edited comment on SOLR-15036 at 1/9/21, 2:18 AM:
A little
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261727#comment-17261727
]
Joel Bernstein edited comment on SOLR-15036 at 1/9/21, 2:17 AM:
A little
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261727#comment-17261727
]
Joel Bernstein commented on SOLR-15036:
---
A little more the SolrStream. The SolrStream is meant to
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261708#comment-17261708
]
Joel Bernstein edited comment on SOLR-15036 at 1/9/21, 1:39 AM:
So, basic
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261708#comment-17261708
]
Joel Bernstein edited comment on SOLR-15036 at 1/9/21, 1:39 AM:
So, basic
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261708#comment-17261708
]
Joel Bernstein commented on SOLR-15036:
---
So, basic auth happens automatically under the covers.
tflobbe merged pull request #2174:
URL: https://github.com/apache/lucene-solr/pull/2174
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/SOLR-14999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman resolved SOLR-14999.
---
Fix Version/s: 8.8
Resolution: Fixed
> Add built-in option to advertise Solr with a
[
https://issues.apache.org/jira/browse/SOLR-14999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261686#comment-17261686
]
ASF subversion and git services commented on SOLR-14999:
Commit
[
https://issues.apache.org/jira/browse/SOLR-15025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261672#comment-17261672
]
Mike Drob commented on SOLR-15025:
--
If the passed timeout is null, that should probably be an error. We
[
https://issues.apache.org/jira/browse/SOLR-15025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261668#comment-17261668
]
Tim Dillon commented on SOLR-15025:
---
[~mdrob] I'm a new dev and would be interested in working on this
[
https://issues.apache.org/jira/browse/SOLR-14999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261667#comment-17261667
]
ASF subversion and git services commented on SOLR-14999:
Commit
HoustonPutman merged pull request #2089:
URL: https://github.com/apache/lucene-solr/pull/2089
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
HoustonPutman merged pull request #2191:
URL: https://github.com/apache/lucene-solr/pull/2191
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
HoustonPutman commented on pull request #2191:
URL: https://github.com/apache/lucene-solr/pull/2191#issuecomment-757042563
Not sure why it cause docker tests to fail, but oh well. Works fine for the
SolrJ and Gradle Precommit.
[
https://issues.apache.org/jira/browse/SOLR-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261656#comment-17261656
]
Walter Underwood commented on SOLR-15056:
-
The factory will return null if that MXBean isn't
[
https://issues.apache.org/jira/browse/SOLR-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261634#comment-17261634
]
Mike Drob commented on SOLR-15056:
--
Looking at the code, it should be ok to test for it and attempt to
[
https://issues.apache.org/jira/browse/SOLR-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261628#comment-17261628
]
David Eric Pugh commented on SOLR-15010:
[~janhoy][~cpoerschke] I've pushed up a PR for this, I'd
epugh opened a new pull request #2192:
URL: https://github.com/apache/lucene-solr/pull/2192
Introduce jattach check if jstack is missing. jattach ships in the Solr
docker image instead of jstack.
# Description
With the Solr Docker image you get an alarming
[
https://issues.apache.org/jira/browse/SOLR-11179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Eric Pugh closed SOLR-11179.
--
> Ability to dump jstack
> --
>
> Key: SOLR-11179
>
[
https://issues.apache.org/jira/browse/SOLR-11179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Eric Pugh resolved SOLR-11179.
Resolution: Duplicate
I am resolving this as done. Please reopen if my understanding of
[
https://issues.apache.org/jira/browse/SOLR-11179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261623#comment-17261623
]
David Eric Pugh commented on SOLR-11179:
Looks like this is done! Thanks for the patch
[
https://issues.apache.org/jira/browse/SOLR-11179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Eric Pugh reassigned SOLR-11179:
--
Assignee: David Eric Pugh
> Ability to dump jstack
> --
>
>
[
https://issues.apache.org/jira/browse/SOLR-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261616#comment-17261616
]
David Eric Pugh commented on SOLR-13105:
Thanks for the detailed response [~ctargett], it helps
dweiss opened a new pull request #2190:
URL: https://github.com/apache/lucene-solr/pull/2190
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/SOLR-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261590#comment-17261590
]
Cassandra Targett commented on SOLR-13105:
--
I put all the comments together to respond to them.
madrob commented on a change in pull request #2187:
URL: https://github.com/apache/lucene-solr/pull/2187#discussion_r554164613
##
File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java
##
@@ -64,31 +64,8 @@
import org.apache.solr.common.AlreadyClosedException;
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261575#comment-17261575
]
Timothy Potter commented on SOLR-15036:
---
Ok thank you for the guidance. Tiered makes sense now (y).
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261568#comment-17261568
]
Joel Bernstein edited comment on SOLR-15036 at 1/8/21, 8:25 PM:
Ok, let's
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261568#comment-17261568
]
Joel Bernstein commented on SOLR-15036:
---
Ok, let's go with an explicit opt-in for 8.8 if you want
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261555#comment-17261555
]
Timothy Potter commented on SOLR-15036:
---
Also, regarding composability ... I think that approach
slackhappy commented on pull request #2189:
URL: https://github.com/apache/lucene-solr/pull/2189#issuecomment-756956274
thanks for making these changes, certainly an improvement!
This is an automated message from the Apache
slackhappy commented on a change in pull request #2189:
URL: https://github.com/apache/lucene-solr/pull/2189#discussion_r554151852
##
File path: solr/core/src/test/org/apache/solr/CursorPagingTest.java
##
@@ -521,6 +522,7 @@ public void testTimeAllowed() throws Exception {
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261550#comment-17261550
]
Timothy Potter edited comment on SOLR-15036 at 1/8/21, 7:36 PM:
Thanks
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261550#comment-17261550
]
Timothy Potter commented on SOLR-15036:
---
Thanks for looking [~jbernste]
I don't see any real risk
HoustonPutman opened a new pull request #2191:
URL: https://github.com/apache/lucene-solr/pull/2191
# Description
The github precommit action is failing because of OOMs. It should be fixed
by setting local settings before running gradle commands.
[
https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261546#comment-17261546
]
Mike Drob commented on SOLR-14413:
--
There's something strange going on with the logging, I'll revert it
dweiss merged pull request #2190:
URL: https://github.com/apache/lucene-solr/pull/2190
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261539#comment-17261539
]
Joel Bernstein edited comment on SOLR-15036 at 1/8/21, 7:25 PM:
One thing
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261539#comment-17261539
]
Joel Bernstein edited comment on SOLR-15036 at 1/8/21, 7:24 PM:
One thing
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261539#comment-17261539
]
Joel Bernstein commented on SOLR-15036:
---
One thing we could do to remove any risks and move faster
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261532#comment-17261532
]
Joel Bernstein edited comment on SOLR-15036 at 1/8/21, 7:15 PM:
A couple
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261532#comment-17261532
]
Joel Bernstein commented on SOLR-15036:
---
A couple of thoughts based mainly on the description of
[
https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261518#comment-17261518
]
Chris M. Hostetter commented on SOLR-14413:
---
Hrmmm... I don't think the loggingchange is a good
[
https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261513#comment-17261513
]
Mike Drob commented on SOLR-14413:
--
I put up a PR with your pointers, [~hossman]. Also had to tune down
madrob opened a new pull request #2189:
URL: https://github.com/apache/lucene-solr/pull/2189
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/SOLR-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261501#comment-17261501
]
Christine Poerschke commented on SOLR-15073:
Hello [~nyivan]. Is
[
https://issues.apache.org/jira/browse/SOLR-14787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261495#comment-17261495
]
Kevin Watters commented on SOLR-14787:
--
I've created a separate ticket / PR for the lucene parts
Chris M. Hostetter created SOLR-15078:
-
Summary: ExpandComponent treats all docs with '0' in a numeric
collapse field the same as if null
Key: SOLR-15078
URL: https://issues.apache.org/jira/browse/SOLR-15078
[
https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261473#comment-17261473
]
Chris M. Hostetter commented on SOLR-14413:
---
{quote}I don't believe we need to switch the
[
https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261464#comment-17261464
]
John Gallagher commented on SOLR-14413:
---
Thanks for reporting [~hossman]. I didn't know about the
[
https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Gallagher updated SOLR-14413:
--
Attachment: SOLR-14413.testfix.patch
> allow timeAllowed and cursorMark parameters
>
[
https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261439#comment-17261439
]
Houston Putman commented on SOLR-11795:
---
I agree that co-existing would be the best course of
gerlowskija edited a comment on pull request #2183:
URL: https://github.com/apache/lucene-solr/pull/2183#issuecomment-756877504
> If the client side doesn't change, then does that mean this is safe to
back port to 8x?
Sorry, I think a comment I made above was misleading. This PR as
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Potter updated SOLR-15036:
--
Status: Patch Available (was: Open)
> Use plist automatically for executing a facet
gerlowskija commented on pull request #2183:
URL: https://github.com/apache/lucene-solr/pull/2183#issuecomment-756877504
> If the client side doesn't change, then does that mean this is safe to
back port to 8x?
Sorry, I think a comment I made above was misleading. This PR as a
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261434#comment-17261434
]
Timothy Potter commented on SOLR-15036:
---
[~jbernste] I think this is ready to go and would
thelabdude commented on a change in pull request #2132:
URL: https://github.com/apache/lucene-solr/pull/2132#discussion_r554056609
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/metrics/MaxMetric.java
##
@@ -86,7 +86,7 @@ public void update(Tuple
thelabdude commented on a change in pull request #2132:
URL: https://github.com/apache/lucene-solr/pull/2132#discussion_r554055360
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/FacetStream.java
##
@@ -842,10 +881,99 @@ public int getCost() {
thelabdude commented on a change in pull request #2132:
URL: https://github.com/apache/lucene-solr/pull/2132#discussion_r554054810
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/FacetStream.java
##
@@ -537,14 +555,29 @@ public void
thelabdude commented on a change in pull request #2132:
URL: https://github.com/apache/lucene-solr/pull/2132#discussion_r554054274
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/FacetStream.java
##
@@ -20,15 +20,19 @@
import java.util.ArrayList;
[
https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261423#comment-17261423
]
David Smiley commented on SOLR-11795:
-
In the sixth comment on this issue, [~koji] contrasts this
thelabdude commented on a change in pull request #2132:
URL: https://github.com/apache/lucene-solr/pull/2132#discussion_r554052572
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/DrillStream.java
##
@@ -252,29 +253,27 @@ public void
[
https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261393#comment-17261393
]
Mike Drob commented on SOLR-14413:
--
Looking.
> allow timeAllowed and cursorMark parameters
>
[
https://issues.apache.org/jira/browse/SOLR-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261373#comment-17261373
]
Cassandra Targett commented on SOLR-13105:
--
I haven't read the rest of the feedback yet, but
[
https://issues.apache.org/jira/browse/SOLR-15077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-15077:
--
Description: This ticket will use the new stream processing capability
built into the export
[
https://issues.apache.org/jira/browse/SOLR-15077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-15077:
--
Description: This ticket will use the new stream processing capability
built into the export
Joel Bernstein created SOLR-15077:
-
Summary: Improve performance of the nodes Streaming Expression
Key: SOLR-15077
URL: https://issues.apache.org/jira/browse/SOLR-15077
Project: Solr
Issue
[
https://issues.apache.org/jira/browse/SOLR-15064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261326#comment-17261326
]
Thomas Wöckinger commented on SOLR-15064:
-
Thx for the hint, i was already thinking about that,
[
https://issues.apache.org/jira/browse/SOLR-15064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261315#comment-17261315
]
David Smiley commented on SOLR-15064:
-
No. hash("1!1") != hash("1!1!2")
But this trick works :) –
[
https://issues.apache.org/jira/browse/SOLR-15064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-15064:
Comment: was deleted
(was: Commit 2417aa085f646f1c5b13ee1bc55d286460dfe826 in lucene-solr's branch
[
https://issues.apache.org/jira/browse/SOLR-14827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261293#comment-17261293
]
ASF subversion and git services commented on SOLR-14827:
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261288#comment-17261288
]
ASF subversion and git services commented on LUCENE-9641:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261286#comment-17261286
]
ASF subversion and git services commented on LUCENE-9641:
-
Commit
iverase merged pull request #2188:
URL: https://github.com/apache/lucene-solr/pull/2188
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/LUCENE-9641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-9641.
--
Fix Version/s: 8.8
Assignee: Ignacio Vera
Resolution: Fixed
> Support for
[
https://issues.apache.org/jira/browse/LUCENE-9641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261110#comment-17261110
]
ASF subversion and git services commented on LUCENE-9641:
-
Commit
82 matches
Mail list logo