[jira] [Commented] (LUCENE-9747) Missing package-info.java causes NPE in MissingDoclet.java

2021-02-09 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282163#comment-17282163 ] Robert Muir commented on LUCENE-9747: - whoah, nice work [~epugh] [~dweiss]. thanks for debugging

[GitHub] [lucene-solr] jtibshirani opened a new pull request #2339: LUCENE-9705: Reset internal version in Lucene90FieldInfosFormat.

2021-02-09 Thread GitBox
jtibshirani opened a new pull request #2339: URL: https://github.com/apache/lucene-solr/pull/2339 Since this is a fresh format, we can remove older version logic and reset the internal version to 0. This is an automated

[GitHub] [lucene-solr] jtibshirani opened a new pull request #2338: LUCENE-9756: Extend FieldInfosFormat tests to cover points and vectors

2021-02-09 Thread GitBox
jtibshirani opened a new pull request #2338: URL: https://github.com/apache/lucene-solr/pull/2338 This commit adds coverage to `BaseFieldInfoFormatTestCase ` for points, vectors, and the soft deletes field. This is an

[GitHub] [lucene-solr] jtibshirani commented on pull request #2269: LUCENE-9322: Add TestLucene90FieldInfosFormat

2021-02-09 Thread GitBox
jtibshirani commented on pull request #2269: URL: https://github.com/apache/lucene-solr/pull/2269#issuecomment-776361691 I opened https://issues.apache.org/jira/browse/LUCENE-9756 to add tests for points and vectors. This

[jira] [Created] (LUCENE-9756) Extend FieldInfosFormat tests to cover points and vectors

2021-02-09 Thread Julie Tibshirani (Jira)
Julie Tibshirani created LUCENE-9756: Summary: Extend FieldInfosFormat tests to cover points and vectors Key: LUCENE-9756 URL: https://issues.apache.org/jira/browse/LUCENE-9756 Project: Lucene -

[jira] [Commented] (SOLR-15011) /admin/logging handler should be able to configure logs on all nodes

2021-02-09 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282092#comment-17282092 ] Chris M. Hostetter commented on SOLR-15011: --- BadApple'ing the test just prevents it from being

[jira] [Created] (SOLR-15148) Include a backcompat utility class with a main in solrj that we can use to test older SolrJ against a release candidate

2021-02-09 Thread Timothy Potter (Jira)
Timothy Potter created SOLR-15148: - Summary: Include a backcompat utility class with a main in solrj that we can use to test older SolrJ against a release candidate Key: SOLR-15148 URL:

[GitHub] [lucene-solr] thelabdude commented on pull request #2328: SOLR-15145: System property to control whether base_url is stored in state.json to enable back-compat with older SolrJ versions

2021-02-09 Thread GitBox
thelabdude commented on pull request #2328: URL: https://github.com/apache/lucene-solr/pull/2328#issuecomment-776287188 I ran a back-compat test with a client app built with SolrJ 8.7.0 and a server from this branch and it works as expected.

[jira] [Commented] (SOLR-14561) Validate parameters to CoreAdminAPI

2021-02-09 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282082#comment-17282082 ] Jan Høydahl commented on SOLR-14561: Did you try allowPaths?

[GitHub] [lucene-solr] epugh commented on pull request #2306: SOLR-15121: Move XSLT (tr param) to scripting contrib

2021-02-09 Thread GitBox
epugh commented on pull request #2306: URL: https://github.com/apache/lucene-solr/pull/2306#issuecomment-776276696 Okay, I've done a bunch of tweaking (banging my head?) against the ref guide docs, and they are working, and I think all the tests are passing. I don't like that the

[jira] [Commented] (SOLR-15138) PerReplicaStates does not scale to large collections as well as state.json

2021-02-09 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282042#comment-17282042 ] Mike Drob commented on SOLR-15138: -- For the shards which did not come up, I noticed that not all

[jira] [Commented] (SOLR-15138) PerReplicaStates does not scale to large collections as well as state.json

2021-02-09 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282040#comment-17282040 ] Mike Drob commented on SOLR-15138: -- This patch is an improvement over what we had previously, but I

[jira] [Commented] (LUCENE-9747) Missing package-info.java causes NPE in MissingDoclet.java

2021-02-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282033#comment-17282033 ] ASF subversion and git services commented on LUCENE-9747: - Commit

[jira] [Resolved] (LUCENE-9747) Missing package-info.java causes NPE in MissingDoclet.java

2021-02-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9747. - Fix Version/s: master (9.0) Resolution: Fixed > Missing package-info.java causes NPE in

[jira] [Assigned] (LUCENE-9747) Missing package-info.java causes NPE in MissingDoclet.java

2021-02-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned LUCENE-9747: --- Assignee: Dawid Weiss > Missing package-info.java causes NPE in MissingDoclet.java >

[jira] [Commented] (LUCENE-9747) Missing package-info.java causes NPE in MissingDoclet.java

2021-02-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282032#comment-17282032 ] Dawid Weiss commented on LUCENE-9747: - Thanks for reporting! > Missing package-info.java causes NPE

[GitHub] [lucene-solr] dweiss merged pull request #2337: LUCENE-9747: dodge javadoc reporter NPE bug on Java 11.

2021-02-09 Thread GitBox
dweiss merged pull request #2337: URL: https://github.com/apache/lucene-solr/pull/2337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9747) Missing package-info.java causes NPE in MissingDoclet.java

2021-02-09 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282031#comment-17282031 ] David Eric Pugh commented on LUCENE-9747: - LGTM. > Missing package-info.java causes NPE in

[jira] [Commented] (LUCENE-9747) Missing package-info.java causes NPE in MissingDoclet.java

2021-02-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282029#comment-17282029 ] Dawid Weiss commented on LUCENE-9747: - Filed a slightly smaller PR. Passes for me. > Missing

[GitHub] [lucene-solr] dweiss opened a new pull request #2337: LUCENE-9747: dodge javadoc reporter NPE bug on Java 11.

2021-02-09 Thread GitBox
dweiss opened a new pull request #2337: URL: https://github.com/apache/lucene-solr/pull/2337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (LUCENE-9747) Missing package-info.java causes NPE in MissingDoclet.java

2021-02-09 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282028#comment-17282028 ] David Eric Pugh commented on LUCENE-9747: - :P > Missing package-info.java causes NPE in

[jira] [Commented] (SOLR-15129) Use the Solr TGZ artifact as Docker context

2021-02-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282025#comment-17282025 ] David Smiley commented on SOLR-15129: - See my comment [on PR

[jira] [Commented] (LUCENE-9747) Missing package-info.java causes NPE in MissingDoclet.java

2021-02-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282012#comment-17282012 ] Dawid Weiss commented on LUCENE-9747: - https://bugs.openjdk.java.net/browse/JDK-8224082 > Missing

[jira] [Commented] (LUCENE-9747) Missing package-info.java causes NPE in MissingDoclet.java

2021-02-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282011#comment-17282011 ] Dawid Weiss commented on LUCENE-9747: - Indeed, I can reproduce this with JDK11 too. > Missing

[jira] [Commented] (SOLR-15138) PerReplicaStates does not scale to large collections as well as state.json

2021-02-09 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281996#comment-17281996 ] Mike Drob commented on SOLR-15138: -- Added a couple comments where I agreed with Ilan's review.   More

[GitHub] [lucene-solr] madrob commented on a change in pull request #2318: SOLR-15138: PerReplicaStates does not scale to large collections as well as state.json

2021-02-09 Thread GitBox
madrob commented on a change in pull request #2318: URL: https://github.com/apache/lucene-solr/pull/2318#discussion_r573116634 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/PerReplicaStates.java ## @@ -92,6 +94,17 @@ public PerReplicaStates(String path, int

[GitHub] [lucene-solr-operator] madrob opened a new issue #214: extensions/v1beta1 Ingress is deprecated

2021-02-09 Thread GitBox
madrob opened a new issue #214: URL: https://github.com/apache/lucene-solr-operator/issues/214 After deploying a cluster using this operator, I wanted to get the Ingress, but the one we currently use is deprecated. ```$ k get ing Warning: extensions/v1beta1 Ingress is deprecated

[GitHub] [lucene-solr] anshumg commented on a change in pull request #2328: SOLR-15145: System property to control whether base_url is stored in state.json to enable back-compat with older SolrJ versi

2021-02-09 Thread GitBox
anshumg commented on a change in pull request #2328: URL: https://github.com/apache/lucene-solr/pull/2328#discussion_r573145918 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/ZkNodeProps.java ## @@ -118,14 +120,9 @@ public static ZkNodeProps load(byte[] bytes)

[jira] [Created] (LUCENE-9755) Index Segment without DocValues May Cause Search to Fail

2021-02-09 Thread Thomas Hecker (Jira)
Thomas Hecker created LUCENE-9755: - Summary: Index Segment without DocValues May Cause Search to Fail Key: LUCENE-9755 URL: https://issues.apache.org/jira/browse/LUCENE-9755 Project: Lucene - Core

[jira] [Commented] (LUCENE-9751) Assertion error (int overflow) in ByteSliceReader

2021-02-09 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281874#comment-17281874 ] Michael McCandless commented on LUCENE-9751: Thanks [~dweiss], clearly we have a bug here! 

[jira] [Commented] (SOLR-15133) Document how to eliminate Failed to reserve shared memory warning

2021-02-09 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281872#comment-17281872 ] Mike Drob commented on SOLR-15133: -- I think

[jira] [Commented] (LUCENE-9673) The level of IntBlockPool slice is always 1

2021-02-09 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281862#comment-17281862 ] Michael McCandless commented on LUCENE-9673: I was curious if this impacted indexing

[jira] [Created] (LUCENE-9754) ICU Tokenizer: letter-space-number-letter tokenized inconsistently

2021-02-09 Thread Trey Jones (Jira)
Trey Jones created LUCENE-9754: -- Summary: ICU Tokenizer: letter-space-number-letter tokenized inconsistently Key: LUCENE-9754 URL: https://issues.apache.org/jira/browse/LUCENE-9754 Project: Lucene -

[GitHub] [lucene-solr] jimczi commented on a change in pull request #2256: LUCENE-9507 Custom order for leaves in IndexReader and IndexWriter

2021-02-09 Thread GitBox
jimczi commented on a change in pull request #2256: URL: https://github.com/apache/lucene-solr/pull/2256#discussion_r572984156 ## File path: lucene/core/src/java/org/apache/lucene/index/StandardDirectoryReader.java ## @@ -39,33 +40,47 @@ final IndexWriter writer;

[jira] [Commented] (LUCENE-9747) Missing package-info.java causes NPE in MissingDoclet.java

2021-02-09 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281817#comment-17281817 ] David Eric Pugh commented on LUCENE-9747: - I have Java 11.0.3+7:   ➜ lucene-solr-epugh

[jira] [Commented] (SOLR-15101) Add list-backups and delete-backups APIs

2021-02-09 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281802#comment-17281802 ] Jason Gerlowski commented on SOLR-15101: I've pushed up a PR for this.  I'm hoping to add some

[GitHub] [lucene-solr] gerlowskija opened a new pull request #2336: SOLR-15101: Add list/delete APIs for incremental backups

2021-02-09 Thread GitBox
gerlowskija opened a new pull request #2336: URL: https://github.com/apache/lucene-solr/pull/2336 # Description SOLR-13608 introduced support into Solr for an "incremental" backup file structure, which allows storing multiple backup points for the same collection at a given

[GitHub] [lucene-solr-operator] krishnachalla-hv opened a new issue #213: Solr cloud provided zookeeper cluster in unhealthy state

2021-02-09 Thread GitBox
krishnachalla-hv opened a new issue #213: URL: https://github.com/apache/lucene-solr-operator/issues/213 I have installed **v0.2.8** version of the operator, Sometimes one of the provided zookeeper instance goes into unhealthy state. I have used default values initialize zookeeper

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2335: LUCENE-9753: Hunspell: disallow compounds with parts present in dicti…

2021-02-09 Thread GitBox
donnerpeter opened a new pull request #2335: URL: https://github.com/apache/lucene-solr/pull/2335 …onary, space-separated # Description Don't accept `compoundword` when there's `compound word` in the dictionary # Solution Like Hunspell, handle this

[jira] [Commented] (LUCENE-9406) Make it simpler to track IndexWriter's events

2021-02-09 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281787#comment-17281787 ] Michael McCandless commented on LUCENE-9406: +1 for [~zacharymorn]'s proposed plan! > Make

[jira] [Created] (LUCENE-9753) Hunspell: disallow compounds with parts present in dictionary space-separated

2021-02-09 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9753: Summary: Hunspell: disallow compounds with parts present in dictionary space-separated Key: LUCENE-9753 URL: https://issues.apache.org/jira/browse/LUCENE-9753

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2247: LUCENE-9476 Add getBulkPath API for the Taxonomy index

2021-02-09 Thread GitBox
mikemccand commented on a change in pull request #2247: URL: https://github.com/apache/lucene-solr/pull/2247#discussion_r572845064 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -31,7 +33,7 @@ import

[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #2334: LUCENE-9705: Create Lucene90TermVectorsFormat

2021-02-09 Thread GitBox
muse-dev[bot] commented on a change in pull request #2334: URL: https://github.com/apache/lucene-solr/pull/2334#discussion_r572873185 ## File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/compressing/Lucene50CompressingTermVectorsReader.java ## @@

[jira] [Commented] (LUCENE-9663) Adding compression to terms dict from SortedSet/Sorted DocValues

2021-02-09 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281779#comment-17281779 ] Bruno Roustant commented on LUCENE-9663: I'm ready to merge. I think it could go to 8.9 branch

[GitHub] [lucene-solr-operator] krishnachalla-hv opened a new issue #212: Solr cloud never getes deleted when reclaimPolicy is set to Delete

2021-02-09 Thread GitBox
krishnachalla-hv opened a new issue #212: URL: https://github.com/apache/lucene-solr-operator/issues/212 I facing this issue after upgrading to **v0.2.8**. Earlier I was using **v0.2.6** version of solrcloud things were working fine as expected except the **pvc** deletion that were

[jira] [Commented] (LUCENE-9751) Assertion error (int overflow) in ByteSliceReader

2021-02-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281753#comment-17281753 ] Dawid Weiss commented on LUCENE-9751: - Everything passes with flying colors on lower heap settings

[jira] [Commented] (LUCENE-9751) Assertion error (int overflow) in ByteSliceReader

2021-02-09 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281751#comment-17281751 ] Michael McCandless commented on LUCENE-9751: Hmm I thought we long ago added a best effort

[GitHub] [lucene-solr] iverase opened a new pull request #2334: LUCENE-9705: Create Lucene90TermVectorsFormat

2021-02-09 Thread GitBox
iverase opened a new pull request #2334: URL: https://github.com/apache/lucene-solr/pull/2334 For now this is just a copy of Lucene90TermVectorsFormat. The existing Lucene50TermVectorsFormat was moved to backwards-codecs, along with its utility classes.

[GitHub] [lucene-solr] murblanc commented on pull request #2318: SOLR-15138: PerReplicaStates does not scale to large collections as well as state.json

2021-02-09 Thread GitBox
murblanc commented on pull request #2318: URL: https://github.com/apache/lucene-solr/pull/2318#issuecomment-775852524 > Error is a timeout from `CollectionsHandler` having waited 45 seconds I take that back @noblepaul . I did the test wrong and just did it again and it passes.

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2333: LUCENE-9752: Hunspell Stemmer: reduce parameter count

2021-02-09 Thread GitBox
donnerpeter commented on a change in pull request #2333: URL: https://github.com/apache/lucene-solr/pull/2333#discussion_r572772417 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java ## @@ -698,15 +688,6 @@ private boolean

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2333: LUCENE-9752: Hunspell Stemmer: reduce parameter count

2021-02-09 Thread GitBox
donnerpeter opened a new pull request #2333: URL: https://github.com/apache/lucene-solr/pull/2333 # Description There's too many parameters, some of them avoidable # Solution `doSuffix` is always true, `circumfix` can be calculated at the usage site (and

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2327: LUCENE-9740: scan affix stream once.

2021-02-09 Thread GitBox
donnerpeter commented on a change in pull request #2327: URL: https://github.com/apache/lucene-solr/pull/2327#discussion_r572769064 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -778,31 +791,36 @@ char affixData(int

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2330: LUCENE-9748: Hunspell: suggest inflected dictionary entries similar t…

2021-02-09 Thread GitBox
donnerpeter commented on a change in pull request #2330: URL: https://github.com/apache/lucene-solr/pull/2330#discussion_r572766983 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java ## @@ -33,44 +40,59 @@ */ class

[jira] [Created] (LUCENE-9752) Hunspell Stemmer: reduce parameter count

2021-02-09 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9752: Summary: Hunspell Stemmer: reduce parameter count Key: LUCENE-9752 URL: https://issues.apache.org/jira/browse/LUCENE-9752 Project: Lucene - Core Issue Type:

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2330: LUCENE-9748: Hunspell: suggest inflected dictionary entries similar t…

2021-02-09 Thread GitBox
dweiss commented on a change in pull request #2330: URL: https://github.com/apache/lucene-solr/pull/2330#discussion_r572764206 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java ## @@ -33,44 +40,59 @@ */ class

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2330: LUCENE-9748: Hunspell: suggest inflected dictionary entries similar t…

2021-02-09 Thread GitBox
donnerpeter commented on a change in pull request #2330: URL: https://github.com/apache/lucene-solr/pull/2330#discussion_r572760859 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java ## @@ -33,44 +40,59 @@ */ class

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2330: LUCENE-9748: Hunspell: suggest inflected dictionary entries similar t…

2021-02-09 Thread GitBox
donnerpeter commented on a change in pull request #2330: URL: https://github.com/apache/lucene-solr/pull/2330#discussion_r572760859 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java ## @@ -33,44 +40,59 @@ */ class

[jira] [Commented] (LUCENE-9741) Add optimization for sequential access of stored fields

2021-02-09 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281690#comment-17281690 ] Robert Muir commented on LUCENE-9741: - The getMergeInstance() is already optimized for this case

[jira] [Commented] (LUCENE-9741) Add optimization for sequential access of stored fields

2021-02-09 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281687#comment-17281687 ] Adrien Grand commented on LUCENE-9741: -- To be clear, I'm thinking of only updating the

[jira] [Commented] (LUCENE-9741) Add optimization for sequential access of stored fields

2021-02-09 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281684#comment-17281684 ] Adrien Grand commented on LUCENE-9741: -- I've fallen into the trap of not optimizing merging for

[jira] [Commented] (SOLR-9854) Collect metrics for index merges and index store IO

2021-02-09 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281682#comment-17281682 ] Andrzej Bialecki commented on SOLR-9854: Metrics Counter can only go forward but these integers

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2330: LUCENE-9748: Hunspell: suggest inflected dictionary entries similar t…

2021-02-09 Thread GitBox
dweiss commented on a change in pull request #2330: URL: https://github.com/apache/lucene-solr/pull/2330#discussion_r572744570 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java ## @@ -33,44 +40,59 @@ */ class

[jira] [Created] (SOLR-15147) Hide jdbc credentials in data-config.xml

2021-02-09 Thread Ajay G (Jira)
Ajay G created SOLR-15147: - Summary: Hide jdbc credentials in data-config.xml Key: SOLR-15147 URL: https://issues.apache.org/jira/browse/SOLR-15147 Project: Solr Issue Type: Bug Security

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2327: LUCENE-9740: scan affix stream once.

2021-02-09 Thread GitBox
dweiss commented on a change in pull request #2327: URL: https://github.com/apache/lucene-solr/pull/2327#discussion_r572718487 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -778,31 +791,36 @@ char affixData(int

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2327: LUCENE-9740: scan affix stream once.

2021-02-09 Thread GitBox
dweiss commented on a change in pull request #2327: URL: https://github.com/apache/lucene-solr/pull/2327#discussion_r572718170 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -346,6 +352,7 @@ private void

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2327: LUCENE-9740: scan affix stream once.

2021-02-09 Thread GitBox
dweiss commented on a change in pull request #2327: URL: https://github.com/apache/lucene-solr/pull/2327#discussion_r572717985 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -224,26 +227,37 @@ public Dictionary(

[jira] [Created] (LUCENE-9751) Assertion error (int overflow) in ByteSliceReader

2021-02-09 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9751: --- Summary: Assertion error (int overflow) in ByteSliceReader Key: LUCENE-9751 URL: https://issues.apache.org/jira/browse/LUCENE-9751 Project: Lucene - Core

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2332: LUCENE-9750: Hunspell: improve suggestions for mixed-case misspelled words

2021-02-09 Thread GitBox
donnerpeter opened a new pull request #2332: URL: https://github.com/apache/lucene-solr/pull/2332 # Description Fix a failing Hunspell repo test # Solution Replicate Hunspell's logic around suggestion casing, especially mixed-case ones # Tests

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2327: LUCENE-9740: scan affix stream once.

2021-02-09 Thread GitBox
donnerpeter commented on a change in pull request #2327: URL: https://github.com/apache/lucene-solr/pull/2327#discussion_r572710743 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -346,6 +352,7 @@ private void

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2327: LUCENE-9740: scan affix stream once.

2021-02-09 Thread GitBox
donnerpeter commented on a change in pull request #2327: URL: https://github.com/apache/lucene-solr/pull/2327#discussion_r572707863 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -778,31 +791,36 @@ char affixData(int

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2327: LUCENE-9740: scan affix stream once.

2021-02-09 Thread GitBox
donnerpeter commented on a change in pull request #2327: URL: https://github.com/apache/lucene-solr/pull/2327#discussion_r572706742 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -224,26 +227,37 @@ public Dictionary(

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2327: LUCENE-9740: scan affix stream once.

2021-02-09 Thread GitBox
dweiss commented on a change in pull request #2327: URL: https://github.com/apache/lucene-solr/pull/2327#discussion_r572704827 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -346,6 +352,7 @@ private void

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2327: LUCENE-9740: scan affix stream once.

2021-02-09 Thread GitBox
dweiss commented on a change in pull request #2327: URL: https://github.com/apache/lucene-solr/pull/2327#discussion_r572703555 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -224,26 +227,37 @@ public Dictionary(

[jira] [Created] (LUCENE-9750) Hunspell: improve suggestions for mixed-case misspelled words

2021-02-09 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9750: Summary: Hunspell: improve suggestions for mixed-case misspelled words Key: LUCENE-9750 URL: https://issues.apache.org/jira/browse/LUCENE-9750 Project: Lucene - Core

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2327: LUCENE-9740: scan affix stream once.

2021-02-09 Thread GitBox
dweiss commented on a change in pull request #2327: URL: https://github.com/apache/lucene-solr/pull/2327#discussion_r572702955 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -70,6 +70,9 @@ /** In-memory structure for

[jira] [Resolved] (LUCENE-9740) Avoid buffering and double-scan of flags in *.aff file

2021-02-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9740. - Fix Version/s: master (9.0) Resolution: Fixed > Avoid buffering and double-scan of flags

[jira] [Commented] (LUCENE-9740) Avoid buffering and double-scan of flags in *.aff file

2021-02-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281640#comment-17281640 ] ASF subversion and git services commented on LUCENE-9740: - Commit

[GitHub] [lucene-solr] dweiss merged pull request #2327: LUCENE-9740: scan affix stream once.

2021-02-09 Thread GitBox
dweiss merged pull request #2327: URL: https://github.com/apache/lucene-solr/pull/2327 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2327: LUCENE-9740: scan affix stream once.

2021-02-09 Thread GitBox
dweiss commented on a change in pull request #2327: URL: https://github.com/apache/lucene-solr/pull/2327#discussion_r572701976 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -778,31 +791,36 @@ char affixData(int

[GitHub] [lucene-solr] iverase opened a new pull request #2331: LUCENE-9322: Lucene90VectorWriter can leak open files

2021-02-09 Thread GitBox
iverase opened a new pull request #2331: URL: https://github.com/apache/lucene-solr/pull/2331 While trying to add a Base test class for Vector based on `BaseIndexFileFormatTestCase`, a bug surface on the Lucene90VectorWriter constructor. If there is an exception if the middle, it might

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2330: LUCENE-9748: Hunspell: suggest inflected dictionary entries similar t…

2021-02-09 Thread GitBox
donnerpeter commented on a change in pull request #2330: URL: https://github.com/apache/lucene-solr/pull/2330#discussion_r572696542 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java ## @@ -33,44 +40,59 @@ */ class

[GitHub] [lucene-solr] iverase merged pull request #2269: LUCENE-9322: Add TestLucene90FieldInfosFormat

2021-02-09 Thread GitBox
iverase merged pull request #2269: URL: https://github.com/apache/lucene-solr/pull/2269 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2330: LUCENE-9748: Hunspell: suggest inflected dictionary entries similar t…

2021-02-09 Thread GitBox
donnerpeter commented on a change in pull request #2330: URL: https://github.com/apache/lucene-solr/pull/2330#discussion_r572677980 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java ## @@ -798,8 +798,4 @@ private boolean

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2330: LUCENE-9748: Hunspell: suggest inflected dictionary entries similar t…

2021-02-09 Thread GitBox
donnerpeter commented on a change in pull request #2330: URL: https://github.com/apache/lucene-solr/pull/2330#discussion_r572677318 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java ## @@ -132,14 +155,105 @@ private

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2330: LUCENE-9748: Hunspell: suggest inflected dictionary entries similar t…

2021-02-09 Thread GitBox
donnerpeter commented on a change in pull request #2330: URL: https://github.com/apache/lucene-solr/pull/2330#discussion_r572676998 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java ## @@ -84,33 +106,34 @@ private

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2330: LUCENE-9748: Hunspell: suggest inflected dictionary entries similar t…

2021-02-09 Thread GitBox
donnerpeter commented on a change in pull request #2330: URL: https://github.com/apache/lucene-solr/pull/2330#discussion_r572676594 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java ## @@ -33,44 +40,59 @@ */ class

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2330: LUCENE-9748: Hunspell: suggest inflected dictionary entries similar t…

2021-02-09 Thread GitBox
donnerpeter commented on a change in pull request #2330: URL: https://github.com/apache/lucene-solr/pull/2330#discussion_r572676276 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java ## @@ -33,44 +40,59 @@ */ class

[jira] [Commented] (LUCENE-9705) Move all codec formats to the o.a.l.codecs.Lucene90 package

2021-02-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281617#comment-17281617 ] ASF subversion and git services commented on LUCENE-9705: - Commit

[GitHub] [lucene-solr] iverase merged pull request #2268: LUCENE-9705: Move Lucene50CompoundFormat to Lucene90CompoundFormat

2021-02-09 Thread GitBox
iverase merged pull request #2268: URL: https://github.com/apache/lucene-solr/pull/2268 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2330: LUCENE-9748: Hunspell: suggest inflected dictionary entries similar t…

2021-02-09 Thread GitBox
donnerpeter opened a new pull request #2330: URL: https://github.com/apache/lucene-solr/pull/2330 …o the misspelled word # Description A follow up of the "ngram" suggestion support that adds single prefixes and suffixes to dictionary entries to get better

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2329: LUCENE-9749: Hunspell: apply output conversion (OCONV) to the suggestions

2021-02-09 Thread GitBox
donnerpeter opened a new pull request #2329: URL: https://github.com/apache/lucene-solr/pull/2329 # Description OCONV should be applied not only to stems, but also suggestions # Solution Call the method that applies it :) # Tests `oconv` from

[jira] [Created] (LUCENE-9749) Hunspell: apply output conversion (OCONV) to the suggestions

2021-02-09 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9749: Summary: Hunspell: apply output conversion (OCONV) to the suggestions Key: LUCENE-9749 URL: https://issues.apache.org/jira/browse/LUCENE-9749 Project: Lucene - Core

[jira] [Commented] (LUCENE-9740) Avoid buffering and double-scan of flags in *.aff file

2021-02-09 Thread Peter Gromov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281609#comment-17281609 ] Peter Gromov commented on LUCENE-9740: -- Very nice, thanks! I think this can be merged, and

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2327: LUCENE-9740: scan affix stream once.

2021-02-09 Thread GitBox
donnerpeter commented on a change in pull request #2327: URL: https://github.com/apache/lucene-solr/pull/2327#discussion_r572668532 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -778,31 +791,36 @@ char affixData(int

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2327: LUCENE-9740: scan affix stream once.

2021-02-09 Thread GitBox
donnerpeter commented on a change in pull request #2327: URL: https://github.com/apache/lucene-solr/pull/2327#discussion_r572667748 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -346,6 +352,7 @@ private void

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2327: LUCENE-9740: scan affix stream once.

2021-02-09 Thread GitBox
donnerpeter commented on a change in pull request #2327: URL: https://github.com/apache/lucene-solr/pull/2327#discussion_r572666977 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -224,26 +227,37 @@ public Dictionary(

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2327: LUCENE-9740: scan affix stream once.

2021-02-09 Thread GitBox
donnerpeter commented on a change in pull request #2327: URL: https://github.com/apache/lucene-solr/pull/2327#discussion_r572666204 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -70,6 +70,9 @@ /** In-memory

[jira] [Created] (LUCENE-9748) Hunspell: suggest inflected dictionary entries similar to the misspelled word

2021-02-09 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9748: Summary: Hunspell: suggest inflected dictionary entries similar to the misspelled word Key: LUCENE-9748 URL: https://issues.apache.org/jira/browse/LUCENE-9748

[jira] [Commented] (LUCENE-9747) Missing package-info.java causes NPE in MissingDoclet.java

2021-02-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281602#comment-17281602 ] Dawid Weiss commented on LUCENE-9747: - I get this with openjdk 14.0.1+7: {code} javadoc: error -