zacharymorn commented on pull request #2396:
URL: https://github.com/apache/lucene-solr/pull/2396#issuecomment-781053065
Hi @rmuir, thanks for cc-ing me! For the exception that's being thrown when
the file system does not support direct IO, per java doc of
`ExtendedOpenOption.DIRECT` it
jtibshirani commented on pull request #2245:
URL: https://github.com/apache/lucene-solr/pull/2245#issuecomment-780989835
@mikemccand I opened https://github.com/apache/lucene-solr/pull/2395, it'd
be great to get your feedback. I didn't include a section on adding a new
format, because
[
https://issues.apache.org/jira/browse/LUCENE-9480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286226#comment-17286226
]
Greg Miller commented on LUCENE-9480:
-
As per a discussion with Robert Muir on the dev list, I'm
rmuir commented on pull request #2396:
URL: https://github.com/apache/lucene-solr/pull/2396#issuecomment-780961236
I'm curious if there's a better way to probe this, I'm not happy that the
check here could mask real bugs, but at the same time the test is failing
always for me...
[
https://issues.apache.org/jira/browse/SOLR-14704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gus Heck resolved SOLR-14704.
-
Fix Version/s: 8.9
Resolution: Fixed
> Add download option to solr/cloud-dev/cloud.sh
>
[
https://issues.apache.org/jira/browse/SOLR-14704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286209#comment-17286209
]
ASF subversion and git services commented on SOLR-14704:
Commit
rmuir opened a new pull request #2396:
URL: https://github.com/apache/lucene-solr/pull/2396
TestDirectIODirectory will currently fail if run on an unsupported
filesystem (e.g. tmpfs). Add an "assume" that probes if the filesystem supports
Direct I/O.
Also tweak javadocs to indicate
gus-asf merged pull request #2394:
URL: https://github.com/apache/lucene-solr/pull/2394
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
gautamworah96 commented on a change in pull request #2247:
URL: https://github.com/apache/lucene-solr/pull/2247#discussion_r578042299
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestDirectoryTaxonomyReader.java
##
@@ -569,4 +569,32 @@ public
jtibshirani commented on a change in pull request #2395:
URL: https://github.com/apache/lucene-solr/pull/2395#discussion_r578036823
##
File path: lucene/backward-codecs/README.md
##
@@ -0,0 +1,45 @@
+# Index backwards compatibility
+
+This README describes the approach to
jtibshirani commented on pull request #2395:
URL: https://github.com/apache/lucene-solr/pull/2395#issuecomment-780942757
I'm not sure this is the right place to add developer docs... let me know if
a wiki page would be more appropriate!
jtibshirani opened a new pull request #2395:
URL: https://github.com/apache/lucene-solr/pull/2395
This commit adds simple guidelines on how to make a change to a file format:
* Document how the 'copy-on-write' approach works with backwards-codecs
* Clarify that we prefer to copy the
gus-asf opened a new pull request #2394:
URL: https://github.com/apache/lucene-solr/pull/2394
also ensure lucene libs exist
(cherry picked from commit 65da5ed32c940529b27a518deb8ffd1e61aa2e96)
(backport)
This is
mikemccand commented on a change in pull request #2247:
URL: https://github.com/apache/lucene-solr/pull/2247#discussion_r578019284
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java
##
@@ -353,12 +349,137 @@ public
[
https://issues.apache.org/jira/browse/LUCENE-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman resolved LUCENE-9780.
Fix Version/s: master (9.0)
Assignee: Houston Putman
Resolution: Fixed
>
HoustonPutman merged pull request #220:
URL: https://github.com/apache/lucene-solr-operator/pull/220
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mikemccand commented on a change in pull request #2247:
URL: https://github.com/apache/lucene-solr/pull/2247#discussion_r578017904
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java
##
@@ -353,12 +349,137 @@ public
HoustonPutman merged pull request #217:
URL: https://github.com/apache/lucene-solr-operator/pull/217
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
HoustonPutman closed issue #214:
URL: https://github.com/apache/lucene-solr-operator/issues/214
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/LUCENE-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286191#comment-17286191
]
ASF subversion and git services commented on LUCENE-9780:
-
Commit
HoustonPutman merged pull request #2382:
URL: https://github.com/apache/lucene-solr/pull/2382
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gus-asf opened a new pull request #2393:
URL: https://github.com/apache/lucene-solr/pull/2393
Make cloud.sh work with gradle on master
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/SOLR-13034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286188#comment-17286188
]
David Smiley commented on SOLR-13034:
-
[~moshebla] are you sure the issue was with {{toSolrDoc}} and
Gus Heck created SOLR-15160:
---
Summary: Update cloud-dev/cloud.sh to work with gradle
Key: SOLR-15160
URL: https://issues.apache.org/jira/browse/SOLR-15160
Project: Solr
Issue Type: Improvement
thelabdude commented on a change in pull request #221:
URL:
https://github.com/apache/lucene-solr-operator/pull/221#discussion_r57778
##
File path: controllers/util/solr_util.go
##
@@ -1158,3 +1195,170 @@ func createZkConnectionEnvVars(solrCloud
*solr.SolrCloud,
thelabdude commented on a change in pull request #221:
URL:
https://github.com/apache/lucene-solr-operator/pull/221#discussion_r577998973
##
File path: controllers/util/solr_util.go
##
@@ -971,10 +991,26 @@ func generateZKInteractionInitContainer(solrCloud
*solr.SolrCloud,
thelabdude opened a new pull request #221:
URL: https://github.com/apache/lucene-solr-operator/pull/221
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/LUCENE-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286161#comment-17286161
]
Julie Tibshirani commented on LUCENE-9705:
--
[~ivera] I opened PRs for the following formats:
jtibshirani opened a new pull request #2392:
URL: https://github.com/apache/lucene-solr/pull/2392
For now these are just copies of Lucene80DocValuesFormat and
Lucene80NormsFormat. The existing formats were moved to backwards-codecs.
[
https://issues.apache.org/jira/browse/LUCENE-9659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286129#comment-17286129
]
ASF subversion and git services commented on LUCENE-9659:
-
Commit
[
https://issues.apache.org/jira/browse/SOLR-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Eric Pugh updated SOLR-8138:
--
Fix Version/s: 8.9
master (9.0)
> Simple UI for issuing SQL queries
>
epugh closed pull request #180:
URL: https://github.com/apache/lucene-solr/pull/180
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
epugh commented on pull request #180:
URL: https://github.com/apache/lucene-solr/pull/180#issuecomment-780800501
I am closing this in favour of the updated branch!
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/SOLR-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286108#comment-17286108
]
David Eric Pugh commented on SOLR-8138:
---
Okay, 5+ years, but this JIRA is potentially ready to be
epugh commented on pull request #2381:
URL: https://github.com/apache/lucene-solr/pull/2381#issuecomment-780799691
I think I'm done with this PR! I'd love a review and then I'll commit it.
I could see backporting it to 8.x as well.
[
https://issues.apache.org/jira/browse/SOLR-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286106#comment-17286106
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-15154:
--
OK, I've spent much more
[
https://issues.apache.org/jira/browse/LUCENE-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286091#comment-17286091
]
Michael Sokolov commented on LUCENE-9781:
-
Nice catch! I wonder if this moves the needle
[
https://issues.apache.org/jira/browse/SOLR-14341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286080#comment-17286080
]
Nazerke Seidan edited comment on SOLR-14341 at 2/17/21, 6:52 PM:
-
Created
[
https://issues.apache.org/jira/browse/SOLR-14341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286080#comment-17286080
]
Nazerke Seidan edited comment on SOLR-14341 at 2/17/21, 6:51 PM:
-
Created
[
https://issues.apache.org/jira/browse/SOLR-14341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286080#comment-17286080
]
Nazerke Seidan commented on SOLR-14341:
---
Created a PR
gus-asf commented on pull request #2185:
URL: https://github.com/apache/lucene-solr/pull/2185#issuecomment-780758842
That's a change *sigh*Looks like a c error while trying to satisfy
spotless based on my local history
iverase commented on pull request #2185:
URL: https://github.com/apache/lucene-solr/pull/2185#issuecomment-780748800
Unfortunately precommit only checks style, it does not run the tests.
This is an automated message from the
gus-asf commented on pull request #2185:
URL: https://github.com/apache/lucene-solr/pull/2185#issuecomment-780743941
That's odd I ran precommit... and so did github.
This is an automated message from the Apache Git Service.
HoustonPutman opened a new pull request #220:
URL: https://github.com/apache/lucene-solr-operator/pull/220
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
NazerkeBS opened a new pull request #2391:
URL: https://github.com/apache/lucene-solr/pull/2391
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Please provide a short description of the
HoustonPutman merged pull request #216:
URL: https://github.com/apache/lucene-solr-operator/pull/216
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/SOLR-15132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-15132:
--
Description:
The *nodes* Streaming Expression performs a breadth first graph traversal. This
[
https://issues.apache.org/jira/browse/SOLR-15132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-15132:
--
Description:
The *nodes* Streaming Expression performs a breadth first graph traversal. This
iverase commented on pull request #2185:
URL: https://github.com/apache/lucene-solr/pull/2185#issuecomment-780653993
I think this commit has broken some tests:
```
gradlew test --tests TestPayloadCheckQuery.testInequalityPayloadChecks
-Dtests.seed=892AF6C5F1C8E77D
janhoy merged pull request #44:
URL: https://github.com/apache/lucene-site/pull/44
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
muse-dev[bot] commented on a change in pull request #2390:
URL: https://github.com/apache/lucene-solr/pull/2390#discussion_r577720307
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java
##
@@ -0,0 +1,592 @@
+/*
+ * Licensed to
janhoy opened a new pull request #44:
URL: https://github.com/apache/lucene-site/pull/44
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
janhoy commented on pull request #42:
URL: https://github.com/apache/lucene-site/pull/42#issuecomment-780643532
> @janhoy I noticed we use `pip3` in the readme, but `pip` in the script. At
least for me, `pip` doesn't work, so I upgraded. However, not sure this is a
good change for
janhoy commented on pull request #41:
URL: https://github.com/apache/lucene-site/pull/41#issuecomment-780641522
No prob, the changes will end up on
https://lucene.staged.apache.org/solr/community.html#mailing-lists-irc first,
so it is easy to check if it worked before merging to
janhoy merged pull request #41:
URL: https://github.com/apache/lucene-site/pull/41
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
janhoy merged pull request #43:
URL: https://github.com/apache/lucene-site/pull/43
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
murblanc commented on pull request #2390:
URL: https://github.com/apache/lucene-solr/pull/2390#issuecomment-780629746
I have done my best to preserve the order of code originating in
`OverseerCollectionMessageHandler` as it moved to `CollectionHandlingUtils` and
`CollApiCmds` to make an
murblanc commented on pull request #2390:
URL: https://github.com/apache/lucene-solr/pull/2390#issuecomment-780625973
@madrob @chatman @gerlowskija @sigram @noblepaul - if you want to have a
look. You've all recently touched parts of the code and/or are familiar with it.
murblanc opened a new pull request #2390:
URL: https://github.com/apache/lucene-solr/pull/2390
This refactoring is inserting a layer of abstraction
(`CollectionCommandContext`) between Collection API commands and the
`OverseerCollectionMessageHandler`, to enable future changes where
[
https://issues.apache.org/jira/browse/LUCENE-9762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285866#comment-17285866
]
Nicolás Lichtmaier commented on LUCENE-9762:
I hope this can be merged sooner than 8.9
[
https://issues.apache.org/jira/browse/SOLR-14787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285855#comment-17285855
]
ASF subversion and git services commented on SOLR-14787:
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285856#comment-17285856
]
ASF subversion and git services commented on LUCENE-9659:
-
Commit
gus-asf merged pull request #2185:
URL: https://github.com/apache/lucene-solr/pull/2185
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/SOLR-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285847#comment-17285847
]
David Eric Pugh commented on SOLR-8138:
---
The icon I picked turns out not to be free. I'm strugglign
murblanc commented on a change in pull request #2380:
URL: https://github.com/apache/lucene-solr/pull/2380#discussion_r577649171
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/RestoreCmd.java
##
@@ -67,6 +49,26 @@
import org.slf4j.Logger;
import
donnerpeter opened a new pull request #2389:
URL: https://github.com/apache/lucene-solr/pull/2389
# Description
Like Hunspell/C++ does
# Solution
Set the default value accordingly
# Tests
`keyDefault` added (based on German dictionary)
#
Peter Gromov created LUCENE-9784:
Summary: Hunspell suggestions: use US keyboard in absence of KEY
option
Key: LUCENE-9784
URL: https://issues.apache.org/jira/browse/LUCENE-9784
Project: Lucene -
donnerpeter opened a new pull request #2387:
URL: https://github.com/apache/lucene-solr/pull/2387
# Description
Suggest replacing English "ina" with "in a"
# Solution
Fix off-by-one error
# Tests
`sug` expanded
# Checklist
Please
donnerpeter opened a new pull request #2388:
URL: https://github.com/apache/lucene-solr/pull/2388
# Description
MAXNGRAMSUGS has a default value of 4 (undocumented and not easy to find in
source)
# Solution
Hardcode this 4
# Tests
Peter Gromov created LUCENE-9783:
Summary: Hunspell: don't suggest more than 4 ngram corrections by
default
Key: LUCENE-9783
URL: https://issues.apache.org/jira/browse/LUCENE-9783
Project: Lucene -
Peter Gromov created LUCENE-9782:
Summary: Hunspell suggestions: split by space (but not dash) also
before last char
Key: LUCENE-9782
URL: https://issues.apache.org/jira/browse/LUCENE-9782
Project:
[
https://issues.apache.org/jira/browse/LUCENE-9782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Gromov updated LUCENE-9782:
-
Description: Suggest replacing English "ina" with "in a"
> Hunspell suggestions: split by space
[
https://issues.apache.org/jira/browse/SOLR-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285822#comment-17285822
]
ASF subversion and git services commented on SOLR-15101:
Commit
jward-bw commented on pull request #216:
URL:
https://github.com/apache/lucene-solr-operator/pull/216#issuecomment-780515319
> As for the tests, here is some help:
Thanks so much for the pointers Houston, let me know if I've missed anything.
[
https://issues.apache.org/jira/browse/LUCENE-9777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-9777.
--
Resolution: Fixed
Running ant is actually correct. The script executes ant using the source
[
https://issues.apache.org/jira/browse/LUCENE-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285796#comment-17285796
]
ASF subversion and git services commented on LUCENE-9781:
-
Commit
[
https://issues.apache.org/jira/browse/SOLR-15038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant resolved SOLR-15038.
---
Fix Version/s: 8.9
Resolution: Fixed
Thanks [~kaessmann]
> Add
[
https://issues.apache.org/jira/browse/SOLR-15038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285769#comment-17285769
]
ASF subversion and git services commented on SOLR-15038:
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9781.
-
Fix Version/s: master (9.0)
Resolution: Fixed
Thanks! It'd be good to backport this to
[
https://issues.apache.org/jira/browse/LUCENE-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285767#comment-17285767
]
ASF subversion and git services commented on LUCENE-9781:
-
Commit
dweiss merged pull request #2386:
URL: https://github.com/apache/lucene-solr/pull/2386
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
bruno-roustant commented on a change in pull request #2134:
URL: https://github.com/apache/lucene-solr/pull/2134#discussion_r577477601
##
File path:
solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java
##
@@ -509,7 +509,9 @@ private void
[
https://issues.apache.org/jira/browse/SOLR-15038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285753#comment-17285753
]
ASF subversion and git services commented on SOLR-15038:
Commit
bruno-roustant closed pull request #2134:
URL: https://github.com/apache/lucene-solr/pull/2134
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
donnerpeter opened a new pull request #2386:
URL: https://github.com/apache/lucene-solr/pull/2386
# Description
It's a hot spot, called a lot during FST arc reading
# Solution
Go to ArrayList only when it's necessary. This speeds up
Peter Gromov created LUCENE-9781:
Summary: Speed up BytesStore reader setPosition
Key: LUCENE-9781
URL: https://issues.apache.org/jira/browse/LUCENE-9781
Project: Lucene - Core
Issue Type:
[
https://issues.apache.org/jira/browse/SOLR-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285717#comment-17285717
]
Andras Salamon commented on SOLR-13985:
---
It seems to me, after the revert a new version has been
dweiss commented on a change in pull request #2382:
URL: https://github.com/apache/lucene-solr/pull/2382#discussion_r577409452
##
File path: gradle/validation/jar-checks.gradle
##
@@ -333,9 +333,14 @@ configure([project(":solr"), project(":lucene"),]) {
}
doFirst {
[
https://issues.apache.org/jira/browse/LUCENE-9778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9778.
-
Fix Version/s: master (9.0)
Resolution: Fixed
> Hunspell: speed up input conversion
>
[
https://issues.apache.org/jira/browse/LUCENE-9778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285703#comment-17285703
]
ASF subversion and git services commented on LUCENE-9778:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9779.
-
Fix Version/s: master (9.0)
Resolution: Fixed
> Hunspell: add an API to interrupt long
[
https://issues.apache.org/jira/browse/LUCENE-9779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285702#comment-17285702
]
ASF subversion and git services commented on LUCENE-9779:
-
Commit
dweiss merged pull request #2376:
URL: https://github.com/apache/lucene-solr/pull/2376
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dweiss merged pull request #2378:
URL: https://github.com/apache/lucene-solr/pull/2378
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dweiss commented on pull request #2378:
URL: https://github.com/apache/lucene-solr/pull/2378#issuecomment-780381762
Sorry - I wrote it off the top of my head. It should be
Thread.currentThread().isInterrupted() which checks for the interrupted flag on
the current thread. It doesn't throw
95 matches
Mail list logo
