zacharymorn commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r602651563
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -388,6 +434,42 @@ private void processFacetFields(
}
}
+
[
https://issues.apache.org/jira/browse/LUCENE-9883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach Chen updated LUCENE-9883:
--
Description: This is a spin-off issue from discussion in
[https://github.com/apache/lucene/pull/25].
[
https://issues.apache.org/jira/browse/LUCENE-9883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach Chen updated LUCENE-9883:
--
Summary: Turn on ecj missingEnumCaseDespiteDefault setting (was: Enforce
Zach Chen created LUCENE-9883:
-
Summary: Enforce missingEnumCaseDespiteDefault with ecj static
analysis configuration
Key: LUCENE-9883
URL: https://issues.apache.org/jira/browse/LUCENE-9883
Project:
[
https://issues.apache.org/jira/browse/LUCENE-9883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zach Chen updated LUCENE-9883:
--
Description: This is a spin-off issue from discussion in
https://github.com/apache/lucene/pull/25. In
[
https://issues.apache.org/jira/browse/LUCENE-9881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309810#comment-17309810
]
ASF subversion and git services commented on LUCENE-9881:
-
Commit
uschindler merged pull request #46:
URL: https://github.com/apache/lucene/pull/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
uschindler commented on pull request #46:
URL: https://github.com/apache/lucene/pull/46#issuecomment-808589763
I pushed a change to replace the properties directly in the sync task. I
also added correct inputs. It is now also possible to change the default error
mode to "error" using a
[
https://issues.apache.org/jira/browse/LUCENE-9877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-9877:
Status: Patch Available (was: Open)
> Explore increasing the allowable exceptions in PForUtil
>
[
https://issues.apache.org/jira/browse/LUCENE-9877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-9877:
Status: Open (was: Patch Available)
> Explore increasing the allowable exceptions in PForUtil
>
gsmiller opened a new pull request #48:
URL: https://github.com/apache/lucene/pull/48
# Description
This change allows PForUtil to encode up to 7 exceptions per encoded block
(instead of the 3 allowed today) in order to reduce index size.
# Solution
I
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309761#comment-17309761
]
Alexander L edited comment on LUCENE-9867 at 3/26/21, 9:58 PM:
---
Thank you
[
https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309761#comment-17309761
]
Alexander L commented on LUCENE-9867:
-
Thank you for the feedback, everyone! Here are some answers
rmuir commented on pull request #46:
URL: https://github.com/apache/lucene/pull/46#issuecomment-808537778
> As said before use explicit utf-8 encoding when reading/writing file.
> Explicit properties not needed.
please, just push commits with grooviness. otherwise i can do it
[
https://issues.apache.org/jira/browse/LUCENE-9877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309752#comment-17309752
]
Greg Miller commented on LUCENE-9877:
-
If anyone wants to have a closer look at my methodology (and
[
https://issues.apache.org/jira/browse/LUCENE-9877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-9877:
Comment: was deleted
(was: NOTE: I updated the description just now. I realized when I originally
[
https://issues.apache.org/jira/browse/LUCENE-9877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309746#comment-17309746
]
Greg Miller commented on LUCENE-9877:
-
Out of curiosity, I compared using zero exceptions (so
uschindler commented on a change in pull request #46:
URL: https://github.com/apache/lucene/pull/46#discussion_r602597775
##
File path: gradle/ide/eclipse.gradle
##
@@ -78,6 +78,8 @@ configure(rootProject) {
from rootProject.file("${resources}/dot.settings")
rmuir commented on a change in pull request #46:
URL: https://github.com/apache/lucene/pull/46#discussion_r602586288
##
File path: gradle/ide/eclipse.gradle
##
@@ -78,6 +78,8 @@ configure(rootProject) {
from rootProject.file("${resources}/dot.settings")
into
dweiss commented on a change in pull request #46:
URL: https://github.com/apache/lucene/pull/46#discussion_r602577677
##
File path: gradle/ide/eclipse.gradle
##
@@ -78,6 +78,8 @@ configure(rootProject) {
from rootProject.file("${resources}/dot.settings")
into
[
https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309717#comment-17309717
]
Dawid Weiss commented on LUCENE-9879:
-
I committed this in as it was, [~uschindler]. If this ever
dweiss merged pull request #45:
URL: https://github.com/apache/lucene/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
dweiss commented on pull request #40:
URL: https://github.com/apache/lucene/pull/40#issuecomment-808497181
I didn't mean to convince you to use it. :) I just mentioned it's not really
that scary.
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/LUCENE-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309713#comment-17309713
]
Dawid Weiss commented on LUCENE-9868:
-
> cache things (especially downloads) better.
Possible, but
[
https://issues.apache.org/jira/browse/LUCENE-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9868:
Attachment: quietExec.patch
> Verify checksums on generated files
>
[
https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304171#comment-17304171
]
Greg Miller edited comment on LUCENE-9850 at 3/26/21, 7:22 PM:
---
It may
magibney commented on pull request #15:
URL: https://github.com/apache/lucene/pull/15#issuecomment-808398015
FYI, this is requiring one last burst of persistence! Everything's coming
together, but not quite ready yet ... just checking in to let you know that my
silence doesn't indicate
[
https://issues.apache.org/jira/browse/LUCENE-9835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved LUCENE-9835.
-
Resolution: Fixed
Script is run with help from INFRA. Log attached.
Just 'main' and one active
[
https://issues.apache.org/jira/browse/LUCENE-9835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated LUCENE-9835:
Attachment: lucene-branches.log
> Prune git branches in lucene.git repo
>
[
https://issues.apache.org/jira/browse/LUCENE-9835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309507#comment-17309507
]
Jan Høydahl commented on LUCENE-9835:
-
It's simply been a busy week for me. Need to coordinate live
rmuir opened a new pull request #47:
URL: https://github.com/apache/lucene/pull/47
Import the spotless settings into eclipse formatter so that it is a better
match, hopefully less hassles.
If i reformat the entire codebase with lucene, it produces 25MB diff as
opposed to a 33MB diff
Robert Muir created LUCENE-9882:
---
Summary: better synchronize eclipse formatter with spotless
Key: LUCENE-9882
URL: https://issues.apache.org/jira/browse/LUCENE-9882
Project: Lucene - Core
jnystad commented on pull request #41:
URL: https://github.com/apache/lucene/pull/41#issuecomment-808276711
I was probably just unlucky. Fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308723#comment-17308723
]
Greg Miller edited comment on LUCENE-9850 at 3/26/21, 2:33 PM:
---
Also,
iverase commented on pull request #41:
URL: https://github.com/apache/lucene/pull/41#issuecomment-808259794
I don't think there is much. I normally add the following environmental
variable the na was to repeat a test : `-Dtests.iters=50`. I run on your test
and half of the test failed.
jnystad commented on pull request #41:
URL: https://github.com/apache/lucene/pull/41#issuecomment-808249781
Will do. Could you please instruct how to control which test is run? I find
the "randomness" to be a bit odd for a test suite. I ran several times without
fail.
--
This is an
iverase commented on pull request #41:
URL: https://github.com/apache/lucene/pull/41#issuecomment-808240522
Thanks, I run the test and it seems to fail for the (LatLon)Circle. I added
a comment with a possible fix. Could you add as well an entry in CHANGES.txt?It
can be added to the
[
https://issues.apache.org/jira/browse/LUCENE-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309443#comment-17309443
]
ASF subversion and git services commented on LUCENE-9507:
-
Commit
rmuir commented on a change in pull request #46:
URL: https://github.com/apache/lucene/pull/46#discussion_r602314063
##
File path: gradle/validation/ecj-lint/ecj.javadocs.prefs
##
@@ -90,26 +96,30 @@
mayya-sharipova merged pull request #32:
URL: https://github.com/apache/lucene/pull/32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
rmuir commented on a change in pull request #46:
URL: https://github.com/apache/lucene/pull/46#discussion_r602313452
##
File path: gradle/validation/ecj-lint/ecj.javadocs.prefs
##
@@ -72,7 +77,7 @@
org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore
iverase commented on a change in pull request #41:
URL: https://github.com/apache/lucene/pull/41#discussion_r602312995
##
File path: lucene/core/src/test/org/apache/lucene/geo/TestCircle2D.java
##
@@ -179,4 +179,28 @@ public void testRandomTriangles() {
}
}
}
+
rmuir opened a new pull request #46:
URL: https://github.com/apache/lucene/pull/46
Remove duplicate compiler configuration. Anything that will fail the linter
shows up in as a warning in Eclipse, nothing else.
See the JIRA issue for a longer explanation:
Robert Muir created LUCENE-9881:
---
Summary: synchronize ECJ linter with eclipse IDE
Key: LUCENE-9881
URL: https://issues.apache.org/jira/browse/LUCENE-9881
Project: Lucene - Core
Issue Type:
[
https://issues.apache.org/jira/browse/LUCENE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309391#comment-17309391
]
Robert Muir commented on LUCENE-9880:
-
I don't know if it helps, but if you pass "-verbose" to ecj
rmuir commented on pull request #45:
URL: https://github.com/apache/lucene/pull/45#issuecomment-808134759
+1, why not try it out? If it becomes annoying in our nightly builds (e.g.
many failures or something), we can revisit and put it somewhere else. But I
think it'd be great to get this
rmuir commented on pull request #40:
URL: https://github.com/apache/lucene/pull/40#issuecomment-808116776
@dweiss as i mentioned, I personally choose not to use it: yes I have tried
it, yes I really hate it. Especially rebase -i is really dangerous and bad to
me. I think this just depends
[
https://issues.apache.org/jira/browse/LUCENE-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309334#comment-17309334
]
Robert Muir commented on LUCENE-9868:
-
Yeah, probably a few other things we want to do to make this
rmuir commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r602160575
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -388,6 +434,42 @@ private void processFacetFields(
}
}
+ private
[
https://issues.apache.org/jira/browse/LUCENE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309319#comment-17309319
]
Dawid Weiss commented on LUCENE-9880:
-
Run them separately for the time being: gradlew clean &&
[
https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309312#comment-17309312
]
Robert Muir commented on LUCENE-9879:
-
{quote}
Thanks Robert: this explains why it got so slow over
[
https://issues.apache.org/jira/browse/LUCENE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309308#comment-17309308
]
Robert Muir commented on LUCENE-9880:
-
I hit this sometimes too.
> Task ordering can be incorrect
[
https://issues.apache.org/jira/browse/LUCENE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9880:
Summary: Task ordering can be incorrect for gradlew clean [...] (was:
Investigate build order
[
https://issues.apache.org/jira/browse/LUCENE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309303#comment-17309303
]
Dawid Weiss commented on LUCENE-9880:
-
Something is wrong with task ordering here for:
{code}
[
https://issues.apache.org/jira/browse/LUCENE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9880:
Attachment: output.log
> Investigate build order task weirdness
>
Dawid Weiss created LUCENE-9880:
---
Summary: Investigate build order task weirdness
Key: LUCENE-9880
URL: https://issues.apache.org/jira/browse/LUCENE-9880
Project: Lucene - Core
Issue Type: Bug
dweiss commented on pull request #45:
URL: https://github.com/apache/lucene/pull/45#issuecomment-808039637
Let's give others some time to express their opinion and I'll commit it in.
If we decide a separate option is good then I'll add it, no prob.
--
This is an automated message from
[
https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309264#comment-17309264
]
Uwe Schindler commented on LUCENE-9879:
---
Yes. I think that's easiest to do without reconfigure
[
https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309259#comment-17309259
]
Dawid Weiss commented on LUCENE-9879:
-
We can add a separate flag too, of course
[
https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309256#comment-17309256
]
Uwe Schindler commented on LUCENE-9879:
---
Option 3 seems fine, but maybe with a separate flag.
[
https://issues.apache.org/jira/browse/LUCENE-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309245#comment-17309245
]
Dawid Weiss commented on LUCENE-9868:
-
bq. I think hashing could be extremely difficult to debug, if
[
https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309239#comment-17309239
]
Dawid Weiss commented on LUCENE-9879:
-
Left a PR implementing option (3).
> errorprone cause large
dweiss opened a new pull request #45:
URL: https://github.com/apache/lucene/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[
https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309237#comment-17309237
]
Dawid Weiss commented on LUCENE-9879:
-
Oh... so that's why it's slow!
I see three options:
1)
dweiss commented on pull request #40:
URL: https://github.com/apache/lucene/pull/40#issuecomment-807975052
I use rebase all the time on work-in-progress branches. It's really not that
scary. rebase -i is particularly useful to do bulk commit edits - it's like
batch cherry picking.
--
65 matches
Mail list logo
