[jira] [Resolved] (LUCENE-9870) Circle2D intersectsLine bug mostly causes no matches along indexed lines and outside polygon edges

2021-03-29 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-9870. -- Fix Version/s: 8.8.2 Assignee: Ignacio Vera Resolution: Fixed > Circle2D inter

[jira] [Commented] (LUCENE-9870) Circle2D intersectsLine bug mostly causes no matches along indexed lines and outside polygon edges

2021-03-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311154#comment-17311154 ] ASF subversion and git services commented on LUCENE-9870: - Commi

[jira] [Commented] (LUCENE-9870) Circle2D intersectsLine bug mostly causes no matches along indexed lines and outside polygon edges

2021-03-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311157#comment-17311157 ] ASF subversion and git services commented on LUCENE-9870: - Commi

[GitHub] [lucene-solr] zacharymorn commented on pull request #2471: LUCENE-9385: (Backporting) Add FacetsConfig option to control which drill-down terms are indexed for a FacetLabel

2021-03-29 Thread GitBox
zacharymorn commented on pull request #2471: URL: https://github.com/apache/lucene-solr/pull/2471#issuecomment-809872761 HI @mikemccand , thanks for approving and merging the changes! I researched around cross-repo cherry-picking and found that git seems to support it to some extend, but m

[jira] [Commented] (LUCENE-9890) Retire @lucene.experimental tag and enforce @since tag for public classes

2021-03-29 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311056#comment-17311056 ] Greg Miller commented on LUCENE-9890: - [~tomoko] I wonder if a slightly different cl

[jira] [Commented] (LUCENE-9877) Explore increasing the allowable exceptions in PForUtil

2021-03-29 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311030#comment-17311030 ] Greg Miller commented on LUCENE-9877: - This is the first time I've attempted a backp

[GitHub] [lucene-solr] gsmiller opened a new pull request #2474: LUCENE-9877: Allow up to 7 exceptions in PForUtil (instead of 3).

2021-03-29 Thread GitBox
gsmiller opened a new pull request #2474: URL: https://github.com/apache/lucene-solr/pull/2474 Backport of https://github.com/apache/lucene/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (LUCENE-9880) Task ordering can be incorrect for gradlew clean [...]

2021-03-29 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310951#comment-17310951 ] Dawid Weiss commented on LUCENE-9880: - Yeah, I know what the problem is. It's not tr

[jira] [Commented] (LUCENE-9877) Explore increasing the allowable exceptions in PForUtil

2021-03-29 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310944#comment-17310944 ] Greg Miller commented on LUCENE-9877: - Thanks [~mikemccand], [~jpountz]! I updated t

[GitHub] [lucene] gsmiller commented on pull request #48: LUCENE-9877: Allow up to 7 exceptions in PForUtil (instead of 3)

2021-03-29 Thread GitBox
gsmiller commented on pull request #48: URL: https://github.com/apache/lucene/pull/48#issuecomment-809630728 Thanks @jpountz. I updated CHANGES.txt just now. As for updating 8.x, I'm a bit naive on how to go about suggesting that change. The change is backwards-compatible so this should be

[jira] [Updated] (LUCENE-9893) Document or fix CodecUtil's codec requirements/limitations

2021-03-29 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated LUCENE-9893: Summary: Document or fix CodecUtil's codec requirements/limitations (was: Document or fix

[jira] [Created] (LUCENE-9893) Document or fix CodecUtil limitations

2021-03-29 Thread Jason Gerlowski (Jira)
Jason Gerlowski created LUCENE-9893: --- Summary: Document or fix CodecUtil limitations Key: LUCENE-9893 URL: https://issues.apache.org/jira/browse/LUCENE-9893 Project: Lucene - Core Issue Typ

[GitHub] [lucene-solr] mayya-sharipova opened a new pull request #2473: LUCENE-9507 Custom order for leaves

2021-03-29 Thread GitBox
mayya-sharipova opened a new pull request #2473: URL: https://github.com/apache/lucene-solr/pull/2473 Custom order for leaves in IndexReader and IndexWriter 1.Add an option to supply a custom leaf sorter for IndexWriter. A DirectoryReader opened from this IndexWriter will have its

[jira] [Commented] (LUCENE-9385) Skip indexing facet drill down terms

2021-03-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310892#comment-17310892 ] ASF subversion and git services commented on LUCENE-9385: - Commi

[jira] [Resolved] (LUCENE-9385) Skip indexing facet drill down terms

2021-03-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-9385. Fix Version/s: 8.9 main (9.0) Resolution: Fixed Thanks [

[GitHub] [lucene-solr] mikemccand merged pull request #2471: LUCENE-9385: (Backporting) Add FacetsConfig option to control which drill-down terms are indexed for a FacetLabel

2021-03-29 Thread GitBox
mikemccand merged pull request #2471: URL: https://github.com/apache/lucene-solr/pull/2471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [lucene-solr] mikemccand commented on pull request #2471: LUCENE-9385: (Backporting) Add FacetsConfig option to control which drill-down terms are indexed for a FacetLabel

2021-03-29 Thread GitBox
mikemccand commented on pull request #2471: URL: https://github.com/apache/lucene-solr/pull/2471#issuecomment-809607098 Thanks @zacharymorn! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [lucene] jtibshirani commented on a change in pull request #30: LUCENE-9705: Create Lucene90SegmentInfoFormat

2021-03-29 Thread GitBox
jtibshirani commented on a change in pull request #30: URL: https://github.com/apache/lucene/pull/30#discussion_r603511444 ## File path: lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene86/TestLucene86SegmentInfoFormat.java ## @@ -0,0 +1,36 @@ +/* + * Li

[jira] [Commented] (LUCENE-9888) Re-instate CheckIndex's attempts to confirm index sort is consistent across all segments

2021-03-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310854#comment-17310854 ] ASF subversion and git services commented on LUCENE-9888: - Commi

[jira] [Resolved] (LUCENE-9888) Re-instate CheckIndex's attempts to confirm index sort is consistent across all segments

2021-03-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-9888. Fix Version/s: 8.9 main (9.0) Resolution: Fixed Thanks [

[jira] [Commented] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

2021-03-29 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310834#comment-17310834 ] Mike Drob commented on LUCENE-9836: --- [~uschindler] - do we need this back ported to 8.

[GitHub] [lucene] mikemccand commented on a change in pull request #25: LUCENE-9385: Add option to skip indexing facet drill down terms

2021-03-29 Thread GitBox
mikemccand commented on a change in pull request #25: URL: https://github.com/apache/lucene/pull/25#discussion_r603483275 ## File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java ## @@ -168,14 +203,34 @@ public synchronized void setIndexFieldName(String di

[GitHub] [lucene-solr] madrob commented on a change in pull request #2472: SOLR-15217: Use shardsWhitelist in ReplicationHandler.

2021-03-29 Thread GitBox
madrob commented on a change in pull request #2472: URL: https://github.com/apache/lucene-solr/pull/2472#discussion_r603457994 ## File path: solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java ## @@ -302,6 +305,26 @@ public void doTestHandlerPathUnchanged()

[GitHub] [lucene-solr] mikemccand commented on pull request #2471: LUCENE-9385: (Backporting) Add FacetsConfig option to control which drill-down terms are indexed for a FacetLabel

2021-03-29 Thread GitBox
mikemccand commented on pull request #2471: URL: https://github.com/apache/lucene-solr/pull/2471#issuecomment-809541919 Also, were there any conflicts you had to resolve manually? Or it was smooth sailing? -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [lucene-solr] mikemccand commented on pull request #2471: LUCENE-9385: (Backporting) Add FacetsConfig option to control which drill-down terms are indexed for a FacetLabel

2021-03-29 Thread GitBox
mikemccand commented on pull request #2471: URL: https://github.com/apache/lucene-solr/pull/2471#issuecomment-809541741 Aha, thank you @zacharymorn! I'll have a look. Out of curiosity: were you able to use git somehow to cherry-pick across the repositories/branches? Or did you diff

[GitHub] [lucene] mikemccand commented on a change in pull request #25: LUCENE-9385: Add option to skip indexing facet drill down terms

2021-03-29 Thread GitBox
mikemccand commented on a change in pull request #25: URL: https://github.com/apache/lucene/pull/25#discussion_r603456522 ## File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java ## @@ -168,14 +203,34 @@ public synchronized void setIndexFieldName(String di

[jira] [Commented] (LUCENE-9888) Re-instate CheckIndex's attempts to confirm index sort is consistent across all segments

2021-03-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310768#comment-17310768 ] Michael McCandless commented on LUCENE-9888: +1 > Re-instate CheckIndex's a

[jira] [Commented] (LUCENE-9888) Re-instate CheckIndex's attempts to confirm index sort is consistent across all segments

2021-03-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310770#comment-17310770 ] ASF subversion and git services commented on LUCENE-9888: - Commi

[GitHub] [lucene] mikemccand merged pull request #49: LUCENE-9888: re-enable CheckIndex verification that indexSort is the same across all segments

2021-03-29 Thread GitBox
mikemccand merged pull request #49: URL: https://github.com/apache/lucene/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[jira] [Commented] (LUCENE-9855) Reconsider codec name VectorFormat

2021-03-29 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310749#comment-17310749 ] Adrien Grand commented on LUCENE-9855: -- I like NeighborsFormat, which is the only o

[jira] [Updated] (LUCENE-9722) Aborted merge can leak readers if the output is empty

2021-03-29 Thread Nhat Nguyen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-9722: Fix Version/s: 8.8.2 > Aborted merge can leak readers if the output is empty > ---

[jira] [Commented] (LUCENE-7306) Use radix sort for points too

2021-03-29 Thread hu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310562#comment-17310562 ] hu commented on LUCENE-7306: [~jpountz] Thanks > Use radix sort for points too > --

[jira] [Comment Edited] (LUCENE-7306) Use radix sort for points too

2021-03-29 Thread hu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310548#comment-17310548 ] hu edited comment on LUCENE-7306 at 3/29/21, 10:49 AM: --- [~jpountz]

[jira] [Updated] (LUCENE-9887) error param use in RadixSelector

2021-03-29 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-9887: - Fix Version/s: 8.9 Resolution: Fixed Status: Resolved (was: Patch Available)

[jira] [Commented] (LUCENE-7306) Use radix sort for points too

2021-03-29 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310555#comment-17310555 ] Adrien Grand commented on LUCENE-7306: -- Data may be stored across multiple buffers,

[jira] [Commented] (LUCENE-9887) error param use in RadixSelector

2021-03-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310552#comment-17310552 ] ASF subversion and git services commented on LUCENE-9887: - Commi

[jira] [Commented] (LUCENE-9887) error param use in RadixSelector

2021-03-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310550#comment-17310550 ] ASF subversion and git services commented on LUCENE-9887: - Commi

[jira] [Commented] (LUCENE-7306) Use radix sort for points too

2021-03-29 Thread hu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310548#comment-17310548 ] hu commented on LUCENE-7306: [~jpountz] thanks, I think the cache cannot be used well when t

[jira] [Updated] (LUCENE-7306) Use radix sort for points too

2021-03-29 Thread hu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hu updated LUCENE-7306: --- Attachment: image-2021-03-29-18-10-32-296.png > Use radix sort for points too > - > >

[jira] [Commented] (LUCENE-7306) Use radix sort for points too

2021-03-29 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310538#comment-17310538 ] Adrien Grand commented on LUCENE-7306: -- [~hu] I don't remember exactly, but I think

[GitHub] [lucene-solr] atris commented on a change in pull request #2472: SOLR-15217: Use shardsWhitelist in ReplicationHandler.

2021-03-29 Thread GitBox
atris commented on a change in pull request #2472: URL: https://github.com/apache/lucene-solr/pull/2472#discussion_r603153830 ## File path: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java ## @@ -271,7 +273,33 @@ public IndexFetcher(@SuppressWarnings({"rawtypes"})fi

[GitHub] [lucene] jpountz opened a new pull request #50: Add an example to the CacheHelper docs.

2021-03-29 Thread GitBox
jpountz opened a new pull request #50: URL: https://github.com/apache/lucene/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [lucene-solr] bruno-roustant opened a new pull request #2472: SOLR-15217: Use shardsWhitelist in ReplicationHandler.

2021-03-29 Thread GitBox
bruno-roustant opened a new pull request #2472: URL: https://github.com/apache/lucene-solr/pull/2472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi

[jira] [Commented] (LUCENE-9890) Retire @lucene.experimental tag and enforce @since tag for public classes

2021-03-29 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310532#comment-17310532 ] Tomoko Uchida commented on LUCENE-9890: --- Thank you [~dweiss] for your support. I

[jira] [Comment Edited] (LUCENE-7306) Use radix sort for points too

2021-03-29 Thread hu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310502#comment-17310502 ] hu edited comment on LUCENE-7306 at 3/29/21, 9:28 AM: -- I have a que

[jira] [Comment Edited] (LUCENE-7306) Use radix sort for points too

2021-03-29 Thread hu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310502#comment-17310502 ] hu edited comment on LUCENE-7306 at 3/29/21, 9:28 AM: -- I have a que

[jira] [Updated] (LUCENE-9887) error param use in RadixSelector

2021-03-29 Thread liupanfeng (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liupanfeng updated LUCENE-9887: --- Attachment: LUCENE-9887.patch Status: Patch Available (was: Patch Available) fix this probl

[jira] [Updated] (LUCENE-9887) error param use in RadixSelector

2021-03-29 Thread liupanfeng (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liupanfeng updated LUCENE-9887: --- Status: Patch Available (was: Open) > error param use in RadixSelector > --

[jira] [Updated] (LUCENE-9887) error param use in RadixSelector

2021-03-29 Thread liupanfeng (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liupanfeng updated LUCENE-9887: --- Attachment: LUCENE-9887.patch > error param use in RadixSelector >

[jira] [Commented] (LUCENE-7306) Use radix sort for points too

2021-03-29 Thread hu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310502#comment-17310502 ] hu commented on LUCENE-7306: I have a question,why  MSBRadixSorter class LEVEL_THRESHOLD is

[jira] [Commented] (LUCENE-9870) Circle2D intersectsLine bug mostly causes no matches along indexed lines and outside polygon edges

2021-03-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310494#comment-17310494 ] ASF subversion and git services commented on LUCENE-9870: - Commi

[GitHub] [lucene] iverase commented on pull request #41: LUCENE-9870: Fix Circle2D intersectsLine t-value (distance) range clamp

2021-03-29 Thread GitBox
iverase commented on pull request #41: URL: https://github.com/apache/lucene/pull/41#issuecomment-809191582 thanks @jnystad -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [lucene] iverase merged pull request #41: LUCENE-9870: Fix Circle2D intersectsLine t-value (distance) range clamp

2021-03-29 Thread GitBox
iverase merged pull request #41: URL: https://github.com/apache/lucene/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please cont

[jira] [Updated] (LUCENE-9887) error param use in RadixSelector

2021-03-29 Thread liupanfeng (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liupanfeng updated LUCENE-9887: --- Status: Open (was: Patch Available) > error param use in RadixSelector > --

[jira] [Updated] (LUCENE-9887) error param use in RadixSelector

2021-03-29 Thread liupanfeng (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liupanfeng updated LUCENE-9887: --- Status: Patch Available (was: Open) > error param use in RadixSelector > --

[jira] [Commented] (LUCENE-9887) error param use in RadixSelector

2021-03-29 Thread liupanfeng (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310477#comment-17310477 ] liupanfeng commented on LUCENE-9887: OK. I will do it.  > error param use in RadixS

[jira] [Commented] (LUCENE-9887) error param use in RadixSelector

2021-03-29 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310462#comment-17310462 ] Adrien Grand commented on LUCENE-9887: -- I don't think we need to benchmark this. Ca