[
https://issues.apache.org/jira/browse/LUCENE-9335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316042#comment-17316042
]
Zach Chen commented on LUCENE-9335:
---
Just curious, I see code in
[https://github.com/
rmuir opened a new pull request #70:
URL: https://github.com/apache/lucene/pull/70
unusedExceptionParameter is a very useful check, as it detects if you catch
an exception and do nothing with it at all (swallowed).
As a library, its important to preserve exceptions (e.g. chain the ro
Robert Muir created LUCENE-9911:
---
Summary: enable ecjLint unusedExceptionParameter
Key: LUCENE-9911
URL: https://issues.apache.org/jira/browse/LUCENE-9911
Project: Lucene - Core
Issue Type: Tas
[
https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315897#comment-17315897
]
Tomoko Uchida commented on LUCENE-9855:
---
I didn't use the word "strategy" with any
[
https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida reassigned LUCENE-9855:
-
Assignee: (was: Tomoko Uchida)
> Reconsider names for ANN related format and APIs
>
[
https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-9855:
--
Summary: Reconsider names for ANN related format and APIs (was: Reconsider
codec VectorFormat
[
https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315895#comment-17315895
]
Greg Miller commented on LUCENE-9850:
-
Thanks! I've just submitted a PR for this wor
gsmiller opened a new pull request #69:
URL: https://github.com/apache/lucene/pull/69
# Description
Switch over to PFOR encoding for doc IDs (instead of FOR) to achieve better
index compression.
# Solution
Details are in the Jira issue, but I explored the index size vs.
[
https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-9855:
--
Summary: Reconsider codec VectorFormat and ANN related API names (was:
Reconsider codec name
[
https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-9855:
--
Summary: Reconsider codec name VectorFormat and ANN related APIs (was:
Reconsider codec name
rmuir commented on a change in pull request #68:
URL: https://github.com/apache/lucene/pull/68#discussion_r608213508
##
File path: gradle/java/javac.gradle
##
@@ -33,27 +33,51 @@ allprojects {
options.compilerArgs += [
"-Xlint:-deprecation",
"-Xlint:-se
rmuir opened a new pull request #68:
URL: https://github.com/apache/lucene/pull/68
This enables quite a few javac warnings from java11+ that weren't
enabled for some reason. None of them fail, so lock them in.
Additionally some newer checks are only recognized for newer JDK
vers
Robert Muir created LUCENE-9910:
---
Summary: maximize javac lint
Key: LUCENE-9910
URL: https://issues.apache.org/jira/browse/LUCENE-9910
Project: Lucene - Core
Issue Type: Task
Report
[
https://issues.apache.org/jira/browse/LUCENE-9904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315830#comment-17315830
]
Dawid Weiss commented on LUCENE-9904:
-
That hardcoded list of tld suffixes in testEx
[
https://issues.apache.org/jira/browse/LUCENE-9904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315814#comment-17315814
]
Dawid Weiss commented on LUCENE-9904:
-
This one entails regeneration of top-level do
[
https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315813#comment-17315813
]
Robert Muir commented on LUCENE-9855:
-
{quote}
For postings and doc values, we make
[
https://issues.apache.org/jira/browse/LUCENE-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani updated LUCENE-9905:
-
Affects Version/s: main (9.0)
> Revise approach to specifying NN algorithm
> ---
[
https://issues.apache.org/jira/browse/LUCENE-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani updated LUCENE-9905:
-
Priority: Blocker (was: Major)
> Revise approach to specifying NN algorithm
> -
[
https://issues.apache.org/jira/browse/LUCENE-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani updated LUCENE-9908:
-
Affects Version/s: main (9.0)
> Move VectorValues#search to VectorReader and LeafReader
Dawid Weiss created LUCENE-9909:
---
Summary: Some jflex regeneration tasks should also check the
checksums of %include-d resources
Key: LUCENE-9909
URL: https://issues.apache.org/jira/browse/LUCENE-9909
P
dweiss opened a new pull request #67:
URL: https://github.com/apache/lucene/pull/67
This does contain the regenerated tld file... which should entail
regeneration of the jflex parser monster. I'll follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the m
gautamworah96 commented on a change in pull request #62:
URL: https://github.com/apache/lucene/pull/62#discussion_r608103838
##
File path: lucene/CHANGES.txt
##
@@ -287,7 +287,10 @@ Other
API Changes
-
-(No changes)
+
+* LUCENE-9902: Change the getValue
[
https://issues.apache.org/jira/browse/LUCENE-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315780#comment-17315780
]
ASF subversion and git services commented on LUCENE-9902:
-
Commi
mikemccand merged pull request #62:
URL: https://github.com/apache/lucene/pull/62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
mikemccand commented on a change in pull request #62:
URL: https://github.com/apache/lucene/pull/62#discussion_r608099720
##
File path: lucene/CHANGES.txt
##
@@ -287,7 +287,10 @@ Other
API Changes
-
-(No changes)
+
+* LUCENE-9902: Change the getValue met
[
https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315773#comment-17315773
]
Michael McCandless commented on LUCENE-9850:
{quote}I might except the oppos
[
https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315763#comment-17315763
]
ASF subversion and git services commented on LUCENE-9827:
-
Commi
rmuir merged pull request #28:
URL: https://github.com/apache/lucene/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contac
[
https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315700#comment-17315700
]
Greg Miller commented on LUCENE-9850:
-
Thanks [~jpountz]. I'll cleanup my code a bit
mayya-sharipova commented on a change in pull request #11:
URL: https://github.com/apache/lucene/pull/11#discussion_r607913700
##
File path:
lucene/core/src/test/org/apache/lucene/document/TestPerFieldConsistency.java
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Softwar
mayya-sharipova commented on a change in pull request #11:
URL: https://github.com/apache/lucene/pull/11#discussion_r607913534
##
File path:
lucene/core/src/test/org/apache/lucene/document/TestPerFieldConsistency.java
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Softwar
mayya-sharipova commented on a change in pull request #11:
URL: https://github.com/apache/lucene/pull/11#discussion_r607913125
##
File path: lucene/MIGRATE.md
##
@@ -358,11 +358,21 @@ Rather, an IllegalArgumentException shall be thrown. This
is introduced for bett
defence and
jpountz merged pull request #50:
URL: https://github.com/apache/lucene/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please cont
jpountz commented on pull request #50:
URL: https://github.com/apache/lucene/pull/50#issuecomment-814164029
Thanks for looking. If I had to actually build such a cache, I'd probably
cache per-segment instead, but that would have made the example more complex
while the goal is more to show
[
https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315606#comment-17315606
]
Adrien Grand commented on LUCENE-9850:
--
bq. it seems like the index size reduction
jpountz commented on a change in pull request #64:
URL: https://github.com/apache/lucene/pull/64#discussion_r607865192
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java
##
@@ -374,8 +371,8 @@ private Ser
[
https://issues.apache.org/jira/browse/LUCENE-9888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315503#comment-17315503
]
Adrien Grand edited comment on LUCENE-9888 at 4/6/21, 1:01 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315519#comment-17315519
]
Adrien Grand commented on LUCENE-9906:
--
This is due to LUCENE-9888, I left a commen
[
https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315504#comment-17315504
]
Tomoko Uchida commented on LUCENE-9855:
---
I opened two PRs just to get the picture
[
https://issues.apache.org/jira/browse/LUCENE-9888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315503#comment-17315503
]
Adrien Grand commented on LUCENE-9888:
--
There are some test failures due to this ch
nitirajrathore commented on a change in pull request #55:
URL: https://github.com/apache/lucene/pull/55#discussion_r607813173
##
File path: lucene/test-framework/src/java/org/apache/lucene/util/FullKnn.java
##
@@ -0,0 +1,156 @@
+package org.apache.lucene.util;
+
+import org.apa
nitirajrathore commented on a change in pull request #55:
URL: https://github.com/apache/lucene/pull/55#discussion_r607812871
##
File path: lucene/test-framework/src/java/org/apache/lucene/util/FullKnn.java
##
@@ -0,0 +1,156 @@
+package org.apache.lucene.util;
+
+import org.apa
Adrien Grand created LUCENE-9908:
Summary: Move VectorValues#search to VectorReader and LeafReader
Key: LUCENE-9908
URL: https://issues.apache.org/jira/browse/LUCENE-9908
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315486#comment-17315486
]
Adrien Grand commented on LUCENE-9855:
--
bq. NeighborsFormat also doesn't feel preci
mocobeta opened a new pull request #66:
URL: https://github.com/apache/lucene/pull/66
https://issues.apache.org/jira/browse/LUCENE-9855
This renames two interfaces and its subclasses.
- o.a.l.c.VectorFormat to HnswVectorsFormat
- o.a.l.i.VectorValues to NumericVectors
mocobeta opened a new pull request #65:
URL: https://github.com/apache/lucene/pull/65
See https://issues.apache.org/jira/browse/LUCENE-9855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
iverase opened a new pull request #64:
URL: https://github.com/apache/lucene/pull/64
This PR removes the dependency on PackedInts to the StoredFieldsFormat in
favour of directReader / DirectWriter.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
Ignacio Vera created LUCENE-9907:
Summary: Remove dependency on PackedInts in all current codecs
Key: LUCENE-9907
URL: https://issues.apache.org/jira/browse/LUCENE-9907
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315359#comment-17315359
]
Adrien Grand commented on LUCENE-9905:
--
+1
> Revise approach to specifying NN alg
jpountz commented on pull request #11:
URL: https://github.com/apache/lucene/pull/11#issuecomment-813948862
> I'm also curious if we plan to enforce value consistency in a follow-up?
It would be great if we could enforce value consistency too. It feels more
challenging because `Index
[
https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315328#comment-17315328
]
Tomoko Uchida edited comment on LUCENE-9855 at 4/6/21, 8:01 AM:
--
[
https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315328#comment-17315328
]
Tomoko Uchida commented on LUCENE-9855:
---
I set the Fix version of the issue to 9.0
52 matches
Mail list logo
