[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-07 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r628697141 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -488,8 +503,35 @@ public Status checkIndex() throws IOException { *

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-07 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r628696357 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -731,40 +747,188 @@ public Status checkIndex(List onlySegments) throws

[GitHub] [lucene] jpountz commented on a change in pull request #91: LUCENE-9932: Performance improvement for BKD index building

2021-05-07 Thread GitBox
jpountz commented on a change in pull request #91: URL: https://github.com/apache/lucene/pull/91#discussion_r628551730 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/MutablePointsReaderUtils.java ## @@ -35,63 +37,60 @@ MutablePointsReaderUtils() {} -

[GitHub] [lucene] jpountz commented on pull request #101: LUCENE-9335: [Discussion Only] Add BMM scorer and use it for pure disjunction term query

2021-05-07 Thread GitBox
jpountz commented on pull request #101: URL: https://github.com/apache/lucene/pull/101#issuecomment-834791219 > The last two are optimization techniques not mentioned in the paper I think? To be honest I didn't read the paper recently so it's possible I diverged a bit from it.

[GitHub] [lucene] gsmiller commented on pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-07 Thread GitBox
gsmiller commented on pull request #127: URL: https://github.com/apache/lucene/pull/127#issuecomment-834786325 @rmuir just posted a new revision that optimizes non-overlapping range cases with its own implementation. It's a pretty big change from the previous version, but I'm curious to

[GitHub] [lucene] mocobeta commented on pull request #130: Reorganize TermVectorsFormat format description (javadocs).

2021-05-07 Thread GitBox
mocobeta commented on pull request #130: URL: https://github.com/apache/lucene/pull/130#issuecomment-834649989 I think few people care about the format documentation, but at least it will not hurt anything (...and might be helpful for advanced users). I'll keep open it for a while for

[GitHub] [lucene] mocobeta opened a new pull request #130: Reorganize TermVectorsFormat format description (javadocs).

2021-05-07 Thread GitBox
mocobeta opened a new pull request #130: URL: https://github.com/apache/lucene/pull/130 (Maybe) trivial documentation change. Current format description of [TermVectorsFormat](https://lucene.apache.org/core/8_8_2/core/org/apache/lucene/codecs/lucene50/Lucene50TermVectorsFormat.html) is a

[GitHub] [lucene] gautamworah96 commented on pull request #108: LUCENE-9897 Change dependency checking mechanism to use gradle checksum verification

2021-05-07 Thread GitBox
gautamworah96 commented on pull request #108: URL: https://github.com/apache/lucene/pull/108#issuecomment-834622966 Some closing notes: We found the current gradle checksum verification functionality unsuitable for our use case. The current functionality records all dependencies

[GitHub] [lucene] gsmiller commented on pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-07 Thread GitBox
gsmiller commented on pull request #127: URL: https://github.com/apache/lucene/pull/127#issuecomment-834352411 (In the meantime, I just pushed a small revision that does a more efficient binary search for multi-valued cases by keeping track of the last seen elementary interval, taking

[GitHub] [lucene] gsmiller commented on pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-07 Thread GitBox
gsmiller commented on pull request #127: URL: https://github.com/apache/lucene/pull/127#issuecomment-834346001 Oh yeah, good point @rmuir! I actually wonder if a separate implementation of the segment-tree counter (`LongRangeCounter`) would make sense for this typical case. The entire

[GitHub] [lucene] rmuir commented on pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-07 Thread GitBox
rmuir commented on pull request #127: URL: https://github.com/apache/lucene/pull/127#issuecomment-834312458 in an overlapping case, we can't do the optimization. my suggestion was for a (i think typical?) case where ranges are non-overlapping (facets i see such as price ranges). in that

[GitHub] [lucene] rmuir commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-07 Thread GitBox
rmuir commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r628122895 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -488,8 +503,35 @@ public Status checkIndex() throws IOException { *

[GitHub] [lucene] dweiss commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-07 Thread GitBox
dweiss commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r628015890 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -731,40 +747,188 @@ public Status checkIndex(List onlySegments) throws

[GitHub] [lucene] zacharymorn commented on a change in pull request #101: LUCENE-9335: [Discussion Only] Add BMM scorer and use it for pure disjunction term query

2021-05-07 Thread GitBox
zacharymorn commented on a change in pull request #101: URL: https://github.com/apache/lucene/pull/101#discussion_r627978058 ## File path: lucene/core/src/java/org/apache/lucene/search/BlockMaxMaxscoreScorer.java ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene] zacharymorn commented on a change in pull request #101: LUCENE-9335: [Discussion Only] Add BMM scorer and use it for pure disjunction term query

2021-05-07 Thread GitBox
zacharymorn commented on a change in pull request #101: URL: https://github.com/apache/lucene/pull/101#discussion_r627975325 ## File path: lucene/core/src/java/org/apache/lucene/search/BlockMaxMaxscoreScorer.java ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene] zacharymorn commented on pull request #101: LUCENE-9335: [Discussion Only] Add BMM scorer and use it for pure disjunction term query

2021-05-07 Thread GitBox
zacharymorn commented on pull request #101: URL: https://github.com/apache/lucene/pull/101#issuecomment-834114823 > I played with your branch in order to try to speed things up a bit and I'm getting a bit closer to our current WAND implementation:

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-07 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r627960571 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -605,6 +610,15 @@ public Status checkIndex(List onlySegments) throws

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-07 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r627960267 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -810,6 +976,8 @@ public Status checkIndex(List onlySegments) throws

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-07 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r627960267 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -810,6 +976,8 @@ public Status checkIndex(List onlySegments) throws

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-07 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r627959173 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -731,40 +747,188 @@ public Status checkIndex(List onlySegments) throws