[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Ori D (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353939#comment-17353939 ] Ori D commented on LUCENE-9981: --- Hi Guys, Looks great! My only concern now is that the w

[jira] [Commented] (LUCENE-9687) Hunspell support improvements

2021-05-29 Thread Peter Gromov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353926#comment-17353926 ] Peter Gromov commented on LUCENE-9687: -- [~rcmuir] Thank you so much! > Hunspell su

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353910#comment-17353910 ] Robert Muir commented on LUCENE-9981: - Another tweak: its great that we give a compi

[GitHub] [lucene] sqshq commented on a change in pull request #149: LUCENE-9971: Inconsistent SSDVFF and Taxonomy facet behavior in case of unseen dimension

2021-05-29 Thread GitBox
sqshq commented on a change in pull request #149: URL: https://github.com/apache/lucene/pull/149#discussion_r641998363 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java ## @@ -110,17 +109,10 @@ public boolean siblingsLoaded() { retur

[jira] [Comment Edited] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353908#comment-17353908 ] Robert Muir edited comment on LUCENE-9981 at 5/30/21, 12:10 AM: --

[jira] [Updated] (LUCENE-9971) Inconsistent SSDVFF and Taxonomy facet behavior in case of unseen dimension

2021-05-29 Thread Alexander L (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander L updated LUCENE-9971: Description: Unlike other org.apache.lucene.facet.Facet interface implementations,  SortedSetDocVa

[jira] [Updated] (LUCENE-9971) Inconsistent SSDVFF and Taxonomy facet behavior in case of unseen dimension

2021-05-29 Thread Alexander L (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander L updated LUCENE-9971: Summary: Inconsistent SSDVFF and Taxonomy facet behavior in case of unseen dimension (was: Sorted

[jira] [Comment Edited] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353908#comment-17353908 ] Robert Muir edited comment on LUCENE-9981 at 5/30/21, 12:01 AM: --

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353908#comment-17353908 ] Robert Muir commented on LUCENE-9981: - cc: [~dweiss] in case you have thoughts. Quic

[jira] [Commented] (LUCENE-9687) Hunspell support improvements

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353907#comment-17353907 ] Robert Muir commented on LUCENE-9687: - I think we should be good now. The only other

[jira] [Commented] (LUCENE-9867) CorruptIndexException after failed segment merge caused by No space left on device

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353906#comment-17353906 ] Robert Muir commented on LUCENE-9867: - Sorry for the dyslexic commit > CorruptIndex

[jira] [Commented] (LUCENE-9867) CorruptIndexException after failed segment merge caused by No space left on device

2021-05-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353905#comment-17353905 ] ASF subversion and git services commented on LUCENE-9867: - Commi

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353861#comment-17353861 ] Robert Muir commented on LUCENE-9981: - I updated the patch, changes: * Add simple un

[jira] [Updated] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9981: Attachment: LUCENE-9981.patch > CompiledAutomaton.getCommonSuffix can be extraordinarily slow, eve

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353852#comment-17353852 ] Robert Muir commented on LUCENE-9981: - Patch looks great! I really like how it is cl

[jira] [Updated] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-9981: --- Attachment: LUCENE-9981.patch Status: Open (was: Open) Initial patch mergin

[jira] [Commented] (LUCENE-9687) Hunspell support improvements

2021-05-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353848#comment-17353848 ] ASF subversion and git services commented on LUCENE-9687: - Commi

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353840#comment-17353840 ] Michael McCandless commented on LUCENE-9981: Patch looks great – I'll make s

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353831#comment-17353831 ] Michael McCandless commented on LUCENE-9981: {quote}[~mikemccand] can you lo

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353830#comment-17353830 ] Robert Muir commented on LUCENE-9981: - I attached LUCENE-9981_nfa_prefix.patch, whic

[jira] [Updated] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9981: Attachment: LUCENE-9981_nfaprefix.patch > CompiledAutomaton.getCommonSuffix can be extraordinarily

[jira] [Commented] (LUCENE-9687) Hunspell support improvements

2021-05-29 Thread Peter Gromov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353819#comment-17353819 ] Peter Gromov commented on LUCENE-9687: -- [~mikemccand] Oops, sorry, I thought I've r

[jira] [Updated] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-9981: --- Attachment: LUCENE-9981.patch Status: Open (was: Open) Here is a starter pa

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353816#comment-17353816 ] Michael McCandless commented on LUCENE-9981: Also, I opened this fun spinoff

[jira] [Created] (LUCENE-9983) Stop sorting determinize powersets unnecessarily

2021-05-29 Thread Michael McCandless (Jira)
Michael McCandless created LUCENE-9983: -- Summary: Stop sorting determinize powersets unnecessarily Key: LUCENE-9983 URL: https://issues.apache.org/jira/browse/LUCENE-9983 Project: Lucene - Core

[jira] [Commented] (LUCENE-9687) Hunspell support improvements

2021-05-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353786#comment-17353786 ] Michael McCandless commented on LUCENE-9687: Hmm 8.x build looks [a bit ang

[jira] [Created] (LUCENE-9982) ../../gradlew help should be just as helpful as ./gradlew help?

2021-05-29 Thread Michael McCandless (Jira)
Michael McCandless created LUCENE-9982: -- Summary: ../../gradlew help should be just as helpful as ./gradlew help? Key: LUCENE-9982 URL: https://issues.apache.org/jira/browse/LUCENE-9982 Project:

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353777#comment-17353777 ] Michael McCandless commented on LUCENE-9981: I think we should do two separa

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2021-05-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353770#comment-17353770 ] David Smiley commented on LUCENE-9379: -- Rob, please tone down your language. Don't

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353769#comment-17353769 ] Michael McCandless commented on LUCENE-9981: One curious observation is that

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353767#comment-17353767 ] Michael McCandless commented on LUCENE-9981: Here's the same automaton, reve

[jira] [Updated] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-9981: --- Attachment: three-repeats-reverse-det.png > CompiledAutomaton.getCommonSuffix can be

[jira] [Comment Edited] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353765#comment-17353765 ] Michael McCandless edited comment on LUCENE-9981 at 5/29/21, 2:19 PM:

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353765#comment-17353765 ] Michael McCandless commented on LUCENE-9981: What a delightful {{RegExp}}! T

[jira] [Updated] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-9981: --- Attachment: three-repeats.png > CompiledAutomaton.getCommonSuffix can be extraordina

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353762#comment-17353762 ] Robert Muir commented on LUCENE-9981: - Nope, but exposing very slow queries (via DSL

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Ori D (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353750#comment-17353750 ] Ori D commented on LUCENE-9981: --- [~rcmuir], I'm not saying a timeout must be added as a s

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353742#comment-17353742 ] Robert Muir commented on LUCENE-9981: - Hi [~oridool]. This issue isn't a security is

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Ori D (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353741#comment-17353741 ] Ori D commented on LUCENE-9981: --- Hi [~rcmuir], Thanks for handling this (y) Just wanted

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353696#comment-17353696 ] Robert Muir commented on LUCENE-9379: - Your argument is even more uneducated, the "i

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2021-05-29 Thread Martin Huber (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353685#comment-17353685 ] Martin Huber commented on LUCENE-9379: -- [~rcmuir] thanks for the useful links.  Bu