[jira] [Commented] (LUCENE-9983) Stop sorting determinize powersets unnecessarily

2021-05-30 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354237#comment-17354237 ] Haoyu Zhai commented on LUCENE-9983: Oh I realized we're still gonna iterate on thos

[jira] [Commented] (LUCENE-9983) Stop sorting determinize powersets unnecessarily

2021-05-30 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354225#comment-17354225 ] Haoyu Zhai commented on LUCENE-9983: Hi Mike, So if I understand correctly what we

[GitHub] [lucene] zacharymorn commented on pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index check across segments

2021-05-30 Thread GitBox
zacharymorn commented on pull request #128: URL: https://github.com/apache/lucene/pull/128#issuecomment-851169333 Some test results with corrupted index (`_gx_Lucene90_0.dvd`): ### Full check ``` > Task :lucene:core:CheckIndex.main() NOTE: testing will be more thorough if

[GitHub] [lucene-site] gsmiller closed pull request #59: Add Greg Miller to whoweare page

2021-05-30 Thread GitBox
gsmiller closed pull request #59: URL: https://github.com/apache/lucene-site/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [lucene-site] gsmiller opened a new pull request #59: Add Greg Miller to whoweare page

2021-05-30 Thread GitBox
gsmiller opened a new pull request #59: URL: https://github.com/apache/lucene-site/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (LUCENE-9946) Support multi-value fields in range facet counting

2021-05-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354184#comment-17354184 ] ASF subversion and git services commented on LUCENE-9946: - Commi

[GitHub] [lucene] gsmiller merged pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-30 Thread GitBox
gsmiller merged pull request #127: URL: https://github.com/apache/lucene/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [lucene-site] gsmiller merged pull request #58: Add Greg Miller to committer list

2021-05-30 Thread GitBox
gsmiller merged pull request #58: URL: https://github.com/apache/lucene-site/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [lucene-site] gsmiller commented on pull request #58: Add Greg Miller to committer list

2021-05-30 Thread GitBox
gsmiller commented on pull request #58: URL: https://github.com/apache/lucene-site/pull/58#issuecomment-851128062 @zacharymorn ah, that's what I needed. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] zacharymorn commented on pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index parts check within each segment

2021-05-30 Thread GitBox
zacharymorn commented on pull request #128: URL: https://github.com/apache/lucene/pull/128#issuecomment-851080738 Latest ok output from 12 threads (my machine actually only has 6 physical cores though) : ``` 4:39:26 PM: Executing task 'CheckIndex.main()'... > Task :buildSr

[GitHub] [lucene-site] zacharymorn commented on pull request #58: Add Greg Miller to committer list

2021-05-30 Thread GitBox
zacharymorn commented on pull request #58: URL: https://github.com/apache/lucene-site/pull/58#issuecomment-851074580 Oh have you performed this setup? :D https://github.com/apache/lucene-site/pull/56#issuecomment-823772980 -- This is an automated message from the Apache Git Service. To r

[GitHub] [lucene-site] gsmiller commented on pull request #58: Add Greg Miller to committer list

2021-05-30 Thread GitBox
gsmiller commented on pull request #58: URL: https://github.com/apache/lucene-site/pull/58#issuecomment-851066900 Thanks @zacharymorn. It looks like my write permissions aren’t there yet so I’ll get that sorted out and merge this. -- This is an automated message from the Apache Git Serv

[GitHub] [lucene] sqshq commented on a change in pull request #149: LUCENE-9971: Inconsistent SSDVFF and Taxonomy facet behavior in case of unseen dimension

2021-05-30 Thread GitBox
sqshq commented on a change in pull request #149: URL: https://github.com/apache/lucene/pull/149#discussion_r642119150 ## File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java ## @@ -157,6 +157,11 @@ public DimConfig getDimConfig(String dimName) { retu

[GitHub] [lucene] zhaih commented on a change in pull request #157: LUCENE-9963 Fix issue with FlattenGraphFilter throwing exceptions from holes

2021-05-30 Thread GitBox
zhaih commented on a change in pull request #157: URL: https://github.com/apache/lucene/pull/157#discussion_r642116290 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/core/FlattenGraphFilter.java ## @@ -362,6 +378,40 @@ public boolean incrementToken()

[GitHub] [lucene] zhaih commented on a change in pull request #157: LUCENE-9963 Fix issue with FlattenGraphFilter throwing exceptions from holes

2021-05-30 Thread GitBox
zhaih commented on a change in pull request #157: URL: https://github.com/apache/lucene/pull/157#discussion_r642115585 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/core/FlattenGraphFilter.java ## @@ -240,7 +252,13 @@ private boolean releaseBufferedT

[GitHub] [lucene] zhaih commented on a change in pull request #157: LUCENE-9963 Fix issue with FlattenGraphFilter throwing exceptions from holes

2021-05-30 Thread GitBox
zhaih commented on a change in pull request #157: URL: https://github.com/apache/lucene/pull/157#discussion_r642115419 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/core/FlattenGraphFilter.java ## @@ -193,14 +194,25 @@ private boolean releaseBuffered

[GitHub] [lucene] zacharymorn commented on pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index parts check within each segment

2021-05-30 Thread GitBox
zacharymorn commented on pull request #128: URL: https://github.com/apache/lucene/pull/128#issuecomment-851030385 Oh one more thing. As the log output was buffered during parallel execution and printed later in sequential fashion to maintain order, to help out those who might be eager to s

[GitHub] [lucene] zacharymorn commented on pull request #128: LUCENE-9662: CheckIndex should be concurrent - parallelizing index parts check within each segment

2021-05-30 Thread GitBox
zacharymorn commented on pull request #128: URL: https://github.com/apache/lucene/pull/128#issuecomment-851028668 I've gone ahead and reverted the changes to parallelize within segment, and then added the code that used many of the same ideas to parallelize across segments - with 11 thread

[GitHub] [lucene] gsmiller commented on a change in pull request #149: LUCENE-9971: Inconsistent SSDVFF and Taxonomy facet behavior in case of unseen dimension

2021-05-30 Thread GitBox
gsmiller commented on a change in pull request #149: URL: https://github.com/apache/lucene/pull/149#discussion_r642091782 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java ## @@ -16,15 +16,17 @@ */ package org.apache.lucene.facet.taxon

[jira] [Updated] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-30 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-9981: --- Attachment: LUCENE-9981.patch Status: Open (was: Open) Another iteration! 

[GitHub] [lucene-site] gsmiller opened a new pull request #58: Add Greg Miller to committer list

2021-05-30 Thread GitBox
gsmiller opened a new pull request #58: URL: https://github.com/apache/lucene-site/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-30 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354008#comment-17354008 ] Michael McCandless commented on LUCENE-9981: {quote}Even with no API break,

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353994#comment-17353994 ] Robert Muir commented on LUCENE-9981: - Even with no API break, I don't want these ch

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-30 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353993#comment-17353993 ] Michael McCandless commented on LUCENE-9981: {quote}So if the user has {{new

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353972#comment-17353972 ] Robert Muir commented on LUCENE-9981: - It is probably enough bits? I originally like

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-30 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353970#comment-17353970 ] Michael McCandless commented on LUCENE-9981: {quote}We can add a simple note

[jira] [Commented] (LUCENE-9823) SynonymQuery rewrite can change field boost calculation

2021-05-30 Thread Naoto Minami (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353967#comment-17353967 ] Naoto Minami commented on LUCENE-9823: -- +1 I created a PR to fix this. Thanks. >

[GitHub] [lucene] chlorochrule opened a new pull request #160: LUCENE-9823: Fix not to rewrite boosted single term SynonymQuery

2021-05-30 Thread GitBox
chlorochrule opened a new pull request #160: URL: https://github.com/apache/lucene/pull/160 # Description > When rewriting a SynonymQuery with a single term, we create a BoostQuery wrapping a TermQuery. However, > it now multiplies the final TermQuery sco

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-30 Thread Ori D (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353964#comment-17353964 ] Ori D commented on LUCENE-9981: --- [~rcmuir], We don't expose the entire elasticsearch DSL

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353956#comment-17353956 ] Robert Muir commented on LUCENE-9981: - There's no reason to rush fixes/backports for