dsmiley commented on a change in pull request #180:
URL: https://github.com/apache/lucene/pull/180#discussion_r661978375
##
File path: lucene/core/src/java/org/apache/lucene/index/BaseCompositeReader.java
##
@@ -112,10 +112,29 @@ protected BaseCompositeReader(R[] subReaders,
C
dsmiley commented on pull request #180:
URL: https://github.com/apache/lucene/pull/180#issuecomment-871922823
I agree that replacing `Fields` for a similar class `TermVectors` should be
its own issue.
I love your naming proposals: TermVectorsReader and TermVectorsReaderBase!
Renamin
[
https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372323#comment-17372323
]
Tomoko Uchida commented on LUCENE-9855:
---
Thanks [~rcmuir] and [~jpountz].
I think
[
https://issues.apache.org/jira/browse/LUCENE-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372309#comment-17372309
]
weizijun commented on LUCENE-10014:
---
hi，[~jpountz] ** , can you help to review this i
[
https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372278#comment-17372278
]
Robert Muir commented on LUCENE-8638:
-
What are these {{lucene-deprecations.txt}} fi
[
https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372213#comment-17372213
]
Mike Drob commented on LUCENE-8638:
---
What would be helpful here to move forward? Do yo
gsmiller commented on a change in pull request #191:
URL: https://github.com/apache/lucene/pull/191#discussion_r661709723
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/TestLongValueFacetCounts.java
##
@@ -556,23 +544,37 @@ public void testRandomMultiValued() thro
gautamworah96 commented on a change in pull request #191:
URL: https://github.com/apache/lucene/pull/191#discussion_r661699546
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/TestLongValueFacetCounts.java
##
@@ -556,23 +544,37 @@ public void testRandomMultiValued()
gsmiller commented on a change in pull request #191:
URL: https://github.com/apache/lucene/pull/191#discussion_r661692139
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/TestLongValueFacetCounts.java
##
@@ -556,23 +544,37 @@ public void testRandomMultiValued() thro
gsmiller commented on pull request #191:
URL: https://github.com/apache/lucene/pull/191#issuecomment-871606648
@mikemccand I'm curious about your suggestion to squash these duplicates at
indexing time. Are we certain there aren't any valid use-cases for indexing
duplicate longs into the sa
[
https://issues.apache.org/jira/browse/LUCENE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372057#comment-17372057
]
Robert Muir commented on LUCENE-10016:
--
[~sokolov] let's not make these assumption
[
https://issues.apache.org/jira/browse/LUCENE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372056#comment-17372056
]
Michael Sokolov commented on LUCENE-10016:
--
Hmm I think we expect that any app
[
https://issues.apache.org/jira/browse/LUCENE-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372053#comment-17372053
]
Michael Sokolov commented on LUCENE-10015:
--
I'm fine with removing NONE but I
[
https://issues.apache.org/jira/browse/LUCENE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-10016:
-
Fix Version/s: 9.0
> VectorReader.search needs rethought, o.a.l.search integration?
> -
Robert Muir created LUCENE-10016:
Summary: VectorReader.search needs rethought, o.a.l.search
integration?
Key: LUCENE-10016
URL: https://issues.apache.org/jira/browse/LUCENE-10016
Project: Lucene - Co
[
https://issues.apache.org/jira/browse/LUCENE-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-10015:
-
Fix Version/s: 9.0
> Remove VectorValues.SimilarityFunction, remove NONE
>
[
https://issues.apache.org/jira/browse/LUCENE-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372019#comment-17372019
]
Adrien Grand commented on LUCENE-10015:
---
+1 I was hoping we could remove NONE as
[
https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372011#comment-17372011
]
Adrien Grand commented on LUCENE-9855:
--
[~tomoko] +1 on a name that makes it explic
Robert Muir created LUCENE-10015:
Summary: Remove VectorValues.SimilarityFunction, remove NONE
Key: LUCENE-10015
URL: https://issues.apache.org/jira/browse/LUCENE-10015
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372001#comment-17372001
]
Robert Muir commented on LUCENE-9855:
-
I really do think this is correctly a blocker
[
https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371983#comment-17371983
]
Tomoko Uchida commented on LUCENE-9855:
---
Are we still hanging on here...
I'd like
glawson0 commented on pull request #157:
URL: https://github.com/apache/lucene/pull/157#issuecomment-871334072
Simplified `AutomatonToTokenStream` and added license comment.
I beasted the random tests a few hundred times and found 2 issues.
1)When completely separated edges get con
zacharymorn commented on a change in pull request #180:
URL: https://github.com/apache/lucene/pull/180#discussion_r661242673
##
File path: lucene/core/src/java/org/apache/lucene/index/BaseCompositeReader.java
##
@@ -112,10 +112,29 @@ protected BaseCompositeReader(R[] subReaders
zacharymorn commented on pull request #180:
URL: https://github.com/apache/lucene/pull/180#issuecomment-871155896
> > If I understanding the above correctly, eventually we would like to also
have TermVectors to be similar to Fields, and act like the abstraction API for
term vectors index d
24 matches
Mail list logo
